[GitHub] daisy-ycguo closed pull request #390: improve documentation of configurations choices

2018-12-13 Thread GitBox
daisy-ycguo closed pull request #390: improve documentation of configurations choices URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/390 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] motin opened a new issue #184: Do not clean dangling volumes that are not created by incubator-openwhisk-devtools without warning on make destroy

2018-12-13 Thread GitBox
motin opened a new issue #184: Do not clean dangling volumes that are not created by incubator-openwhisk-devtools without warning on make destroy URL: https://github.com/apache/incubator-openwhisk-devtools/issues/184 Took this repo out for a spin. make quick-start, tested some things, make

[GitHub] davidbreitgand commented on issue #394: Integrating wskdeploy into wsk CLI

2018-12-13 Thread GitBox
davidbreitgand commented on issue #394: Integrating wskdeploy into wsk CLI URL: https://github.com/apache/incubator-openwhisk-cli/pull/394#issuecomment-446952218 Very nice! This is an automated message from the Apache Git

[GitHub] chetanmeh closed pull request #47: add php 7.3 to travis publish

2018-12-13 Thread GitBox
chetanmeh closed pull request #47: add php 7.3 to travis publish URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/47 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] 2rob opened a new pull request #395: Update to the most recent version of gradle

2018-12-13 Thread GitBox
2rob opened a new pull request #395: Update to the most recent version of gradle URL: https://github.com/apache/incubator-openwhisk-cli/pull/395 gradle builds fail with: "Could not determine java version from '11.0.1'." unless its using an updated version of gradle. was successful with

[GitHub] jthomas closed pull request #5: Update test artifact to use Newtonsoft.Json 12

2018-12-13 Thread GitBox
jthomas closed pull request #5: Update test artifact to use Newtonsoft.Json 12 URL: https://github.com/apache/incubator-openwhisk-runtime-dotnet/pull/5 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] houshengbo opened a new issue #4175: Unable to ping running invoker service on another machine

2018-12-13 Thread GitBox
houshengbo opened a new issue #4175: Unable to ping running invoker service on another machine URL: https://github.com/apache/incubator-openwhisk/issues/4175 I am trying to run all the openwhisk services on one VM(VM1), and an additional invoker service on another VM(VM2) with the IP

[GitHub] dgrove-oss commented on issue #382: Improve configuration of invoker.containerFactory.nameservers

2018-12-13 Thread GitBox
dgrove-oss commented on issue #382: Improve configuration of invoker.containerFactory.nameservers URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/382#issuecomment-447131597 #392 adds some necessary plumbing for configuring dns-search and dns-opt.

[GitHub] rabbah commented on issue #4175: Unable to ping running invoker service on another machine

2018-12-13 Thread GitBox
rabbah commented on issue #4175: Unable to ping running invoker service on another machine URL: https://github.com/apache/incubator-openwhisk/issues/4175#issuecomment-447127271 Can you share the invoke2 logs  This is an

[GitHub] rabbah edited a comment on issue #4175: Unable to ping running invoker service on another machine

2018-12-13 Thread GitBox
rabbah edited a comment on issue #4175: Unable to ping running invoker service on another machine URL: https://github.com/apache/incubator-openwhisk/issues/4175#issuecomment-447127271 Can you share the invoker2 logs  This

[GitHub] rabbah commented on issue #4129: Adding YARNContainerFactory. This allows OpenWhisk to run actions on Apache Hadoop clusters.

2018-12-13 Thread GitBox
rabbah commented on issue #4129: Adding YARNContainerFactory. This allows OpenWhisk to run actions on Apache Hadoop clusters. URL: https://github.com/apache/incubator-openwhisk/pull/4129#issuecomment-447102346 Nice! Thanks for improving the PR. I will go through the changes and restart

[GitHub] csantanapr commented on issue #4177: Add dotnet 2.2 runtime support to default deployments

2018-12-13 Thread GitBox
csantanapr commented on issue #4177: Add dotnet 2.2 runtime support to default deployments URL: https://github.com/apache/incubator-openwhisk/issues/4177#issuecomment-447139810 @shawnallen85 is going to be working on this

[GitHub] rabbah commented on issue #4177: Add dotnet 2.2 runtime support to default deployments

2018-12-13 Thread GitBox
rabbah commented on issue #4177: Add dotnet 2.2 runtime support to default deployments URL: https://github.com/apache/incubator-openwhisk/issues/4177#issuecomment-447154076 @ddragosd do you think we should auto generate the JSON in the makefile so we avoid modifying the downstream repo

[GitHub] dgrove-oss commented on issue #4176: additional container factory dns configuration

2018-12-13 Thread GitBox
dgrove-oss commented on issue #4176: additional container factory dns configuration URL: https://github.com/apache/incubator-openwhisk/pull/4176#issuecomment-447130839 See https://github.com/apache/incubator-openwhisk-deploy-kube/pull/392 for how this would be used.

[GitHub] dgrove-oss opened a new pull request #4176: additional container factory dns configuration

2018-12-13 Thread GitBox
dgrove-oss opened a new pull request #4176: additional container factory dns configuration URL: https://github.com/apache/incubator-openwhisk/pull/4176 Allow configuration of the --dns-search and --dns-opt (--dns-option) arguments to the docker run command of the DockerContainerFactory.

[GitHub] rabbah commented on a change in pull request #4172: .NET Core 2.2 Runtime

2018-12-13 Thread GitBox
rabbah commented on a change in pull request #4172: .NET Core 2.2 Runtime URL: https://github.com/apache/incubator-openwhisk/pull/4172#discussion_r241569501 ## File path: ansible/files/runtimes.json ## @@ -240,6 +240,23 @@ } ] }, +"dotnet":

[GitHub] shawnallen85 opened a new pull request #393: Update runtimes.json

2018-12-13 Thread GitBox
shawnallen85 opened a new pull request #393: Update runtimes.json URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/393 Updated runtimes.json to address item 3 on https://github.com/apache/incubator-openwhisk/issues/4177

[GitHub] csantanapr commented on a change in pull request #4172: .NET Core 2.2 Runtime

2018-12-13 Thread GitBox
csantanapr commented on a change in pull request #4172: .NET Core 2.2 Runtime URL: https://github.com/apache/incubator-openwhisk/pull/4172#discussion_r241580126 ## File path: ansible/files/runtimes.json ## @@ -240,6 +240,23 @@ } ] }, +

[GitHub] shawnallen85 opened a new pull request #1019: Updated for OpenWhisk issue 4177

2018-12-13 Thread GitBox
shawnallen85 opened a new pull request #1019: Updated for OpenWhisk issue 4177 URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/1019 Updated items to meet requirements of https://github.com/apache/incubator-openwhisk/issues/4177

[GitHub] csantanapr commented on a change in pull request #4172: .NET Core 2.2 Runtime

2018-12-13 Thread GitBox
csantanapr commented on a change in pull request #4172: .NET Core 2.2 Runtime URL: https://github.com/apache/incubator-openwhisk/pull/4172#discussion_r241544328 ## File path: ansible/files/runtimes.json ## @@ -240,6 +240,23 @@ } ] }, +

[GitHub] rabbah commented on a change in pull request #4172: .NET Core 2.2 Runtime

2018-12-13 Thread GitBox
rabbah commented on a change in pull request #4172: .NET Core 2.2 Runtime URL: https://github.com/apache/incubator-openwhisk/pull/4172#discussion_r241569501 ## File path: ansible/files/runtimes.json ## @@ -240,6 +240,23 @@ } ] }, +"dotnet":

[GitHub] csantanapr commented on issue #4174: Add PHP 7.3 runtime support to default deployments

2018-12-13 Thread GitBox
csantanapr commented on issue #4174: Add PHP 7.3 runtime support to default deployments URL: https://github.com/apache/incubator-openwhisk/issues/4174#issuecomment-447139411 @akrabat will be working on this This is an

[GitHub] csantanapr opened a new issue #4177: Add dotnet 2.2 runtime support to default deployments

2018-12-13 Thread GitBox
csantanapr opened a new issue #4177: Add dotnet 2.2 runtime support to default deployments URL: https://github.com/apache/incubator-openwhisk/issues/4177 Title: Add `dotnet:2.2` runtime support to default deployments ### 1. Add `dotnet:2.2` to core ansible/vagrant deploy - Add

[GitHub] rabbah commented on issue #4177: Add dotnet 2.2 runtime support to default deployments

2018-12-13 Thread GitBox
rabbah commented on issue #4177: Add dotnet 2.2 runtime support to default deployments URL: https://github.com/apache/incubator-openwhisk/issues/4177#issuecomment-447153168 @csantanapr why does wskdeploy needs the manifest - this is a bug I'm raised before. wskdeploy should read the

[GitHub] rabbah commented on issue #1018: Find out how to package runtimes.json into wskdeploy binary

2018-12-13 Thread GitBox
rabbah commented on issue #1018: Find out how to package runtimes.json into wskdeploy binary URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1018#issuecomment-447153418 This should not exist in wskdeploy - the tool should IMO read it from the API host.

[GitHub] shawnallen85 opened a new pull request #356: Updated documentation for .NET Core 2.2 runtime, Swift typo fix.

2018-12-13 Thread GitBox
shawnallen85 opened a new pull request #356: Updated documentation for .NET Core 2.2 runtime, Swift typo fix. URL: https://github.com/apache/incubator-openwhisk-website/pull/356 Addresses final item in https://github.com/apache/incubator-openwhisk/issues/4177

[GitHub] SamHjelmfelt commented on issue #4129: Adding YARNContainerFactory. This allows OpenWhisk to run actions on Apache Hadoop clusters.

2018-12-13 Thread GitBox
SamHjelmfelt commented on issue #4129: Adding YARNContainerFactory. This allows OpenWhisk to run actions on Apache Hadoop clusters. URL: https://github.com/apache/incubator-openwhisk/pull/4129#issuecomment-447100832 @rabbah Thanks for the feedback. I refactored the solution to use an

[GitHub] rabbah edited a comment on issue #4175: Unable to ping running invoker service on another machine

2018-12-13 Thread GitBox
rabbah edited a comment on issue #4175: Unable to ping running invoker service on another machine URL: https://github.com/apache/incubator-openwhisk/issues/4175#issuecomment-447127271 Can you share the invoker logs from vm2 

[GitHub] rabbah commented on a change in pull request #4172: .NET Core 2.2 Runtime

2018-12-13 Thread GitBox
rabbah commented on a change in pull request #4172: .NET Core 2.2 Runtime URL: https://github.com/apache/incubator-openwhisk/pull/4172#discussion_r241571760 ## File path: ansible/files/runtimes.json ## @@ -240,6 +240,23 @@ } ] }, +"dotnet":

[GitHub] dgrove-oss commented on issue #392: DockerContainerFactory DNS configuration

2018-12-13 Thread GitBox
dgrove-oss commented on issue #392: DockerContainerFactory DNS configuration URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/392#issuecomment-447131207 Can be merged independently, but not actually useful until https://github.com/apache/incubator-openwhisk/pull/4176 is

[GitHub] dgrove-oss opened a new pull request #392: DockerContainerFactory DNS configuration

2018-12-13 Thread GitBox
dgrove-oss opened a new pull request #392: DockerContainerFactory DNS configuration URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/392 Plumbing to support passing the dns-search and dns-opt (dns-option) command line arguments to docker run. Depends on enabling

[GitHub] codecov-io commented on issue #4176: additional container factory dns configuration

2018-12-13 Thread GitBox
codecov-io commented on issue #4176: additional container factory dns configuration URL: https://github.com/apache/incubator-openwhisk/pull/4176#issuecomment-447197571 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4176?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4129: Adding YARNContainerFactory. This allows OpenWhisk to run actions on Apache Hadoop clusters.

2018-12-13 Thread GitBox
codecov-io commented on issue #4129: Adding YARNContainerFactory. This allows OpenWhisk to run actions on Apache Hadoop clusters. URL: https://github.com/apache/incubator-openwhisk/pull/4129#issuecomment-447209493 #

[GitHub] csantanapr commented on issue #4177: Add dotnet 2.2 runtime support to default deployments

2018-12-13 Thread GitBox
csantanapr commented on issue #4177: Add dotnet 2.2 runtime support to default deployments URL: https://github.com/apache/incubator-openwhisk/issues/4177#issuecomment-447231115 I agree in general @rabbah we should re-use the runtimes.json and/or the api host and avoid duplication.

[GitHub] dgrove-oss commented on a change in pull request #393: Update runtimes.json

2018-12-13 Thread GitBox
dgrove-oss commented on a change in pull request #393: Update runtimes.json URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/393#discussion_r241621413 ## File path: helm/openwhisk/runtimes.json ## @@ -199,6 +199,23 @@ "tag":

[GitHub] chetanmeh commented on a change in pull request #4176: additional container factory dns configuration

2018-12-13 Thread GitBox
chetanmeh commented on a change in pull request #4176: additional container factory dns configuration URL: https://github.com/apache/incubator-openwhisk/pull/4176#discussion_r241638425 ## File path: core/invoker/src/main/resources/application.conf ## @@ -69,6 +69,8 @@

[GitHub] rabbah commented on issue #4172: .NET Core 2.2 Runtime

2018-12-13 Thread GitBox
rabbah commented on issue #4172: .NET Core 2.2 Runtime URL: https://github.com/apache/incubator-openwhisk/pull/4172#issuecomment-447212585 @shawnallen85 you need one more change: ```git diff --git a/tests/src/test/scala/system/basic/WskUnicodeTests.scala

[GitHub] chetanmeh opened a new pull request #396: Update the pollSince time based on latest activation start time

2018-12-13 Thread GitBox
chetanmeh opened a new pull request #396: Update the pollSince time based on latest activation start time URL: https://github.com/apache/incubator-openwhisk-cli/pull/396 Change the `pollSince` time for each loop by basing it on the latest `Start` time seen in activation result See

[GitHub] chetanmeh commented on a change in pull request #4176: additional container factory dns configuration

2018-12-13 Thread GitBox
chetanmeh commented on a change in pull request #4176: additional container factory dns configuration URL: https://github.com/apache/incubator-openwhisk/pull/4176#discussion_r241638236 ## File path:

[GitHub] codecov-io commented on issue #4172: .NET Core 2.2 Runtime

2018-12-13 Thread GitBox
codecov-io commented on issue #4172: .NET Core 2.2 Runtime URL: https://github.com/apache/incubator-openwhisk/pull/4172#issuecomment-447238247 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4172?src=pr=h1) Report > Merging

[GitHub] csantanapr commented on a change in pull request #4172: .NET Core 2.2 Runtime

2018-12-13 Thread GitBox
csantanapr commented on a change in pull request #4172: .NET Core 2.2 Runtime URL: https://github.com/apache/incubator-openwhisk/pull/4172#discussion_r241543725 ## File path: ansible/files/runtimes.json ## @@ -240,6 +240,23 @@ } ] }, +

[GitHub] shawnallen85 opened a new pull request #185: Update docker-whisk-controller.env

2018-12-13 Thread GitBox
shawnallen85 opened a new pull request #185: Update docker-whisk-controller.env URL: https://github.com/apache/incubator-openwhisk-devtools/pull/185 Addressing item 2 on https://github.com/apache/incubator-openwhisk/issues/4177

[GitHub] rabbah edited a comment on issue #4177: Add dotnet 2.2 runtime support to default deployments

2018-12-13 Thread GitBox
rabbah edited a comment on issue #4177: Add dotnet 2.2 runtime support to default deployments URL: https://github.com/apache/incubator-openwhisk/issues/4177#issuecomment-447153168 @csantanapr @pritidesai @mrutkows why does wskdeploy needs the manifest? this is a bug I may have raised

[GitHub] chetanmeh commented on issue #4157: Make query limits configurable

2018-12-13 Thread GitBox
chetanmeh commented on issue #4157: Make query limits configurable URL: https://github.com/apache/incubator-openwhisk/pull/4157#issuecomment-447211056 Opened apache/incubator-openwhisk-cli#390 to fix the wsk poll logic to change `since` time which should also help db as it only has to

[GitHub] chetanmeh commented on issue #396: Update the pollSince time based on latest activation start time

2018-12-13 Thread GitBox
chetanmeh commented on issue #396: Update the pollSince time based on latest activation start time URL: https://github.com/apache/incubator-openwhisk-cli/pull/396#issuecomment-447214884 @csantanapr @rabbah @dubee Please review

[GitHub] daisy-ycguo closed pull request #393: Update runtimes.json

2018-12-13 Thread GitBox
daisy-ycguo closed pull request #393: Update runtimes.json URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/393 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a