[jira] [Commented] (ORC-394) [C++] Add addUserMetadata() function to C++ writer

2018-08-12 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/ORC-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577569#comment-16577569
 ] 

ASF GitHub Bot commented on ORC-394:


Github user asfgit closed the pull request at:

https://github.com/apache/orc/pull/300


> [C++] Add addUserMetadata() function to C++ writer
> --
>
> Key: ORC-394
> URL: https://issues.apache.org/jira/browse/ORC-394
> Project: ORC
>  Issue Type: New Feature
>Reporter: Zherui Cao
>Priority: Major
>
> addUserMetadata() already exist on java side
> I think implementing it on c++ side would be useful
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ORC-394) [C++] Add addUserMetadata() function to C++ writer

2018-08-10 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/ORC-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576572#comment-16576572
 ] 

ASF GitHub Bot commented on ORC-394:


Github user xndai commented on the issue:

https://github.com/apache/orc/pull/300
  
Looks good. Thanks for adding this.


> [C++] Add addUserMetadata() function to C++ writer
> --
>
> Key: ORC-394
> URL: https://issues.apache.org/jira/browse/ORC-394
> Project: ORC
>  Issue Type: New Feature
>Reporter: Zherui Cao
>Priority: Major
>
> addUserMetadata() already exist on java side
> I think implementing it on c++ side would be useful
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ORC-394) [C++] Add addUserMetadata() function to C++ writer

2018-08-10 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/ORC-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576106#comment-16576106
 ] 

ASF GitHub Bot commented on ORC-394:


Github user majetideepak commented on a diff in the pull request:

https://github.com/apache/orc/pull/300#discussion_r209222998
  
--- Diff: c++/test/TestWriter.cc ---
@@ -1170,5 +1170,52 @@ namespace orc {
 }
   }
 
+  TEST_P(WriterTest, writeUserMetadata) {
--- End diff --

can you add the user metadata check to an existing test?


> [C++] Add addUserMetadata() function to C++ writer
> --
>
> Key: ORC-394
> URL: https://issues.apache.org/jira/browse/ORC-394
> Project: ORC
>  Issue Type: New Feature
>Reporter: Zherui Cao
>Priority: Major
>
> addUserMetadata() already exist on java side
> I think implementing it on c++ side would be useful
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ORC-394) [C++] Add addUserMetadata() function to C++ writer

2018-08-09 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/ORC-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575737#comment-16575737
 ] 

ASF GitHub Bot commented on ORC-394:


GitHub user czxrrr opened a pull request:

https://github.com/apache/orc/pull/300

[ORC-394][C++] Add addUserMetadata() function to C++ write



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/czxrrr/orc ORC-394

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/orc/pull/300.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #300


commit a0e34f9e8091ff5e9af24b470e971023f08fe60a
Author: zherui cao 
Date:   2018-08-10T03:54:25Z

addusermetadata




> [C++] Add addUserMetadata() function to C++ writer
> --
>
> Key: ORC-394
> URL: https://issues.apache.org/jira/browse/ORC-394
> Project: ORC
>  Issue Type: New Feature
>Reporter: Zherui Cao
>Priority: Major
>
> addUserMetadata() already exist on java side
> I think implementing it on c++ side would be useful
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)