[GitHub] [phoenix] gjacoby126 commented on pull request #801: PHOENIX-5951 - Index rebuild output logging for past-max-lookback row…

2020-06-26 Thread GitBox
gjacoby126 commented on pull request #801: URL: https://github.com/apache/phoenix/pull/801#issuecomment-649997131 I see that verifyType is set in the superclass constructor, if the Scan has the right attribute, as you say. But without manually setting it in the IndexRebuildRegionScanner,

[GitHub] [phoenix] gjacoby126 edited a comment on pull request #801: PHOENIX-5951 - Index rebuild output logging for past-max-lookback row…

2020-06-26 Thread GitBox
gjacoby126 edited a comment on pull request #801: URL: https://github.com/apache/phoenix/pull/801#issuecomment-649997131 I see that verifyType is set in the superclass constructor, if the Scan has the right attribute, as you say. But without manually setting it in the

[jira] [Commented] (PHOENIX-5779) SplitSystemCatalogIT tests fail with Multiple Regions error

2020-06-26 Thread Richard Antal (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146275#comment-17146275 ] Richard Antal commented on PHOENIX-5779: I have added some extra logging and found out the old

[jira] [Commented] (PHOENIX-5975) Index rebuild/verification page size should be configurable from IndexTool

2020-06-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146786#comment-17146786 ] Hadoop QA commented on PHOENIX-5975: {color:red}-1 overall{color}. Here are the results of testing

[GitHub] [phoenix] swaroopak commented on a change in pull request #801: PHOENIX-5951 - Index rebuild output logging for past-max-lookback row…

2020-06-26 Thread GitBox
swaroopak commented on a change in pull request #801: URL: https://github.com/apache/phoenix/pull/801#discussion_r446469639 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java ## @@ -96,6 +102,11 @@ private static

[GitHub] [phoenix] gjacoby126 commented on pull request #801: PHOENIX-5951 - Index rebuild output logging for past-max-lookback row…

2020-06-26 Thread GitBox
gjacoby126 commented on pull request #801: URL: https://github.com/apache/phoenix/pull/801#issuecomment-650461976 OK, @swaroopak , fixed the test bug I mentioned to you and the real bug that revealed. It also now uses Configuration to verify.

[jira] [Commented] (PHOENIX-5975) Index rebuild/verification page size should be configurable from IndexTool

2020-06-26 Thread Abhishek Singh Chouhan (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146726#comment-17146726 ] Abhishek Singh Chouhan commented on PHOENIX-5975: - [~kadir] [~priyankporwal] [~gjacoby]

[GitHub] [phoenix] kadirozde closed pull request #808: PHOENIX-5969 Read repair reduces the number of rows returned for LIMI…

2020-06-26 Thread GitBox
kadirozde closed pull request #808: URL: https://github.com/apache/phoenix/pull/808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (PHOENIX-5951) IndexTool output logging for past-max-lookback rows should be configurable

2020-06-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146774#comment-17146774 ] Hadoop QA commented on PHOENIX-5951: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-5898) Phoenix function CURRENT_TIME() returns wrong result when view indexes are used.

2020-06-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146777#comment-17146777 ] Hudson commented on PHOENIX-5898: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3996

[GitHub] [phoenix] jpisaac commented on a change in pull request #799: PHOENIX-5933 Rename VIEW_TTL property to be PHOENIX_TTL

2020-06-26 Thread GitBox
jpisaac commented on a change in pull request #799: URL: https://github.com/apache/phoenix/pull/799#discussion_r446291104 ## File path: phoenix-core/src/main/java/org/apache/phoenix/util/ViewUtil.java ## @@ -635,11 +639,52 @@ public static void

[GitHub] [phoenix] jpisaac commented on a change in pull request #799: PHOENIX-5933 Rename VIEW_TTL property to be PHOENIX_TTL

2020-06-26 Thread GitBox
jpisaac commented on a change in pull request #799: URL: https://github.com/apache/phoenix/pull/799#discussion_r446291773 ## File path: phoenix-protocol/src/main/PTable.proto ## @@ -106,9 +106,9 @@ message PTable { optional int32 viewIndexIdType = 39 [default = 5];

[GitHub] [phoenix] jpisaac commented on a change in pull request #799: PHOENIX-5933 Rename VIEW_TTL property to be PHOENIX_TTL

2020-06-26 Thread GitBox
jpisaac commented on a change in pull request #799: URL: https://github.com/apache/phoenix/pull/799#discussion_r446292426 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java ## @@ -19,63 +19,7 @@ import static

[GitHub] [phoenix] gjacoby126 commented on pull request #801: PHOENIX-5951 - Index rebuild output logging for past-max-lookback row…

2020-06-26 Thread GitBox
gjacoby126 commented on pull request #801: URL: https://github.com/apache/phoenix/pull/801#issuecomment-650284537 @kadirozde - figured out the problem. A previous rebase on this feature branch had re-introduced a private verifyType in IndexRebuildRegionScanner and that was masking the

[jira] [Commented] (PHOENIX-5951) IndexTool output logging for past-max-lookback rows should be configurable

2020-06-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146619#comment-17146619 ] Hadoop QA commented on PHOENIX-5951: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-5935) Select with non primary keys and PHOENIX_ROW_TIMESTAMP() in where clause fails

2020-06-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146622#comment-17146622 ] Hadoop QA commented on PHOENIX-5935: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-5779) SplitSystemCatalogIT tests fail with Multiple Regions error

2020-06-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146504#comment-17146504 ] Hadoop QA commented on PHOENIX-5779: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-5935) Select with non primary keys and PHOENIX_ROW_TIMESTAMP() in where clause fails

2020-06-26 Thread Geoffrey Jacoby (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146646#comment-17146646 ] Geoffrey Jacoby commented on PHOENIX-5935: -- The one test failure appears to be a minicluster

[GitHub] [phoenix] jpisaac commented on a change in pull request #799: PHOENIX-5933 Rename VIEW_TTL property to be PHOENIX_TTL

2020-06-26 Thread GitBox
jpisaac commented on a change in pull request #799: URL: https://github.com/apache/phoenix/pull/799#discussion_r446289834 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/generated/PTableProtos.java ## @@ -3725,35 +3725,35 @@ public Builder

[jira] [Commented] (PHOENIX-5974) RequestId Tracing feature for Phoenix Query

2020-06-26 Thread Lokesh Khurana (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146308#comment-17146308 ] Lokesh Khurana commented on PHOENIX-5974: - [~mihir6692], [~rvaleti] can you please assign this

[GitHub] [phoenix] pranshu1200 opened a new pull request #810: PHOENIX-5974 RequestId Tracing feature for Phoenix Query

2020-06-26 Thread GitBox
pranshu1200 opened a new pull request #810: URL: https://github.com/apache/phoenix/pull/810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above