[jira] [Commented] (PHOENIX-7246) Crash Due to Unhandled JDBC Type Code 0 for NULL Values

2024-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822794#comment-17822794 ] ASF GitHub Bot commented on PHOENIX-7246: - stoty commented on code in PR #148: URL:

Re: [PR] PHOENIX-7246: Add support for mapping JDBC type code 0 to protobuf NULL type [phoenix-queryserver]

2024-03-02 Thread via GitHub
stoty commented on code in PR #148: URL: https://github.com/apache/phoenix-queryserver/pull/148#discussion_r1509934616 ## python-phoenixdb/phoenixdb/types.py: ## @@ -222,9 +225,9 @@ def __cmp__(self, other): (2011, common_pb2.STRING), # NCLOB (2009,

[jira] [Commented] (PHOENIX-7246) Crash Due to Unhandled JDBC Type Code 0 for NULL Values

2024-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822788#comment-17822788 ] ASF GitHub Bot commented on PHOENIX-7246: - stoty commented on code in PR #148: URL:

Re: [PR] PHOENIX-7246: Add support for mapping JDBC type code 0 to protobuf NULL type [phoenix-queryserver]

2024-03-02 Thread via GitHub
stoty commented on code in PR #148: URL: https://github.com/apache/phoenix-queryserver/pull/148#discussion_r1509923536 ## python-phoenixdb/phoenixdb/types.py: ## @@ -222,9 +225,9 @@ def __cmp__(self, other): (2011, common_pb2.STRING), # NCLOB (2009,

[jira] [Commented] (PHOENIX-7246) Crash Due to Unhandled JDBC Type Code 0 for NULL Values

2024-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822798#comment-17822798 ] ASF GitHub Bot commented on PHOENIX-7246: - stoty closed pull request #148: PHOENIX-7246: Add

[jira] [Commented] (PHOENIX-7246) Crash Due to Unhandled JDBC Type Code 0 for NULL Values

2024-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822799#comment-17822799 ] ASF GitHub Bot commented on PHOENIX-7246: - stoty commented on PR #148: URL:

Re: [PR] PHOENIX-7246: Add support for mapping JDBC type code 0 to protobuf NULL type [phoenix-queryserver]

2024-03-02 Thread via GitHub
stoty closed pull request #148: PHOENIX-7246: Add support for mapping JDBC type code 0 to protobuf NULL type URL: https://github.com/apache/phoenix-queryserver/pull/148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] PHOENIX-7246: Add support for mapping JDBC type code 0 to protobuf NULL type [phoenix-queryserver]

2024-03-02 Thread via GitHub
stoty commented on PR #148: URL: https://github.com/apache/phoenix-queryserver/pull/148#issuecomment-1974755622 Committed with minor cleanups. Thanks a lot for the patch: Some nits for the future: - We do not use colon after the JIRA ID in the commit message - The commit

[jira] [Commented] (PHOENIX-7006) Configure maxLookbackAge at table level

2024-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822856#comment-17822856 ] ASF GitHub Bot commented on PHOENIX-7006: - virajjasani commented on code in PR #1751: URL:

Re: [PR] PHOENIX-7006: Configure maxLookbackAge at table level [phoenix]

2024-03-02 Thread via GitHub
virajjasani commented on code in PR #1751: URL: https://github.com/apache/phoenix/pull/1751#discussion_r1509896530 ## phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java: ## @@ -527,6 +535,28 @@ public static boolean

Re: [PR] PHOENIX-7015 Implementing CDCGlobalIndexRegionScanner [phoenix]

2024-03-02 Thread via GitHub
virajjasani commented on PR #1813: URL: https://github.com/apache/phoenix/pull/1813#issuecomment-1974909405 testCreate is failing: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1813/15/testReport/junit/org.apache.phoenix.end2end/CDCDefinitionIT/

[jira] [Commented] (PHOENIX-7015) Extend UncoveredGlobalIndexRegionScanner for CDC region scanner usecase

2024-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822866#comment-17822866 ] ASF GitHub Bot commented on PHOENIX-7015: - virajjasani commented on PR #1813: URL: