[jira] [Commented] (PHOENIX-5593) Remove null checks for JoinCompiler

2019-12-04 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/PHOENIX-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988019#comment-16988019
 ] 

Hudson commented on PHOENIX-5593:
-

FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3167 (See 
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/3167/])
PHOENIX-5593 : Remove redundant null check in JoinCompiler (chinmayskulkarni: 
rev 08ed7027da64d47b8ed4ed43ac47d94983d14d41)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java


> Remove null checks for JoinCompiler
> ---
>
> Key: PHOENIX-5593
> URL: https://issues.apache.org/jira/browse/PHOENIX-5593
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.15.0, 5.1.0, 4.14.4
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5593.master.000.patch, 
> PHOENIX-5593.master.001.patch
>
>
> JoinCompiler.getCommonType() has redundant null checks for PDataType that can 
> be removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (PHOENIX-5593) Remove null checks for JoinCompiler

2019-12-03 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/PHOENIX-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986762#comment-16986762
 ] 

Hudson commented on PHOENIX-5593:
-

SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #613 (See 
[https://builds.apache.org/job/Phoenix-4.x-HBase-1.3/613/])
PHOENIX-5593 : Remove redundant null check in JoinCompiler (chinmayskulkarni: 
rev bf4b007466aaf70abc1b4e265b0e4d121820795f)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java


> Remove null checks for JoinCompiler
> ---
>
> Key: PHOENIX-5593
> URL: https://issues.apache.org/jira/browse/PHOENIX-5593
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.15.0, 5.1.0, 4.14.4
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5593.master.000.patch, 
> PHOENIX-5593.master.001.patch
>
>
> JoinCompiler.getCommonType() has redundant null checks for PDataType that can 
> be removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (PHOENIX-5593) Remove null checks for JoinCompiler

2019-12-03 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/PHOENIX-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986746#comment-16986746
 ] 

Hudson commented on PHOENIX-5593:
-

SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBase-1.4 #327 (See 
[https://builds.apache.org/job/Phoenix-4.x-HBase-1.4/327/])
PHOENIX-5593 : Remove redundant null check in JoinCompiler (chinmayskulkarni: 
rev 3b82bebf277b39e680bd59aa7a42b4b80cabe1a8)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java


> Remove null checks for JoinCompiler
> ---
>
> Key: PHOENIX-5593
> URL: https://issues.apache.org/jira/browse/PHOENIX-5593
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.15.0, 5.1.0, 4.14.4
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5593.master.000.patch, 
> PHOENIX-5593.master.001.patch
>
>
> JoinCompiler.getCommonType() has redundant null checks for PDataType that can 
> be removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (PHOENIX-5593) Remove null checks for JoinCompiler

2019-12-03 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/PHOENIX-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986726#comment-16986726
 ] 

Hudson commented on PHOENIX-5593:
-

SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBase-1.5 #210 (See 
[https://builds.apache.org/job/Phoenix-4.x-HBase-1.5/210/])
PHOENIX-5593 : Remove redundant null check in JoinCompiler (chinmayskulkarni: 
rev 2bf821fc9e002d44816afc819e2379935f16c588)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java


> Remove null checks for JoinCompiler
> ---
>
> Key: PHOENIX-5593
> URL: https://issues.apache.org/jira/browse/PHOENIX-5593
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.15.0, 5.1.0, 4.14.4
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5593.master.000.patch, 
> PHOENIX-5593.master.001.patch
>
>
> JoinCompiler.getCommonType() has redundant null checks for PDataType that can 
> be removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (PHOENIX-5593) Remove null checks for JoinCompiler

2019-12-02 Thread Chinmay Kulkarni (Jira) 


[ 
https://issues.apache.org/jira/browse/PHOENIX-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986665#comment-16986665
 ] 

Chinmay Kulkarni commented on PHOENIX-5593:
---

Thanks [~vjasani]. Committed to master and 4.x branches.

> Remove null checks for JoinCompiler
> ---
>
> Key: PHOENIX-5593
> URL: https://issues.apache.org/jira/browse/PHOENIX-5593
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.15.0, 5.1.0, 4.14.4
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5593.master.000.patch, 
> PHOENIX-5593.master.001.patch
>
>
> JoinCompiler.getCommonType() has redundant null checks for PDataType that can 
> be removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (PHOENIX-5593) Remove null checks for JoinCompiler

2019-12-02 Thread Viraj Jasani (Jira) 


[ 
https://issues.apache.org/jira/browse/PHOENIX-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986604#comment-16986604
 ] 

Viraj Jasani commented on PHOENIX-5593:
---

[~ckulkarni] We have new QA results, please take a look as per your convenience.

Thanks

> Remove null checks for JoinCompiler
> ---
>
> Key: PHOENIX-5593
> URL: https://issues.apache.org/jira/browse/PHOENIX-5593
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.15.0, 5.1.0, 4.14.4
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5593.master.000.patch, 
> PHOENIX-5593.master.001.patch
>
>
> JoinCompiler.getCommonType() has redundant null checks for PDataType that can 
> be removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (PHOENIX-5593) Remove null checks for JoinCompiler

2019-11-28 Thread Viraj Jasani (Jira) 


[ 
https://issues.apache.org/jira/browse/PHOENIX-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984340#comment-16984340
 ] 

Viraj Jasani commented on PHOENIX-5593:
---

Now QA results look good

> Remove null checks for JoinCompiler
> ---
>
> Key: PHOENIX-5593
> URL: https://issues.apache.org/jira/browse/PHOENIX-5593
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.15.0, 5.1.0, 4.14.4
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5593.master.000.patch, 
> PHOENIX-5593.master.001.patch
>
>
> JoinCompiler.getCommonType() has redundant null checks for PDataType that can 
> be removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (PHOENIX-5593) Remove null checks for JoinCompiler

2019-11-28 Thread Hadoop QA (Jira) 


[ 
https://issues.apache.org/jira/browse/PHOENIX-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984318#comment-16984318
 ] 

Hadoop QA commented on PHOENIX-5593:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12987042/PHOENIX-5593.master.001.patch
  against master branch at commit 7e298b3b4b51e5ebfcd46cf0c9724fcf36cbd9fd.
  ATTACHMENT ID: 12987042

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3166//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3166//console

This message is automatically generated.

> Remove null checks for JoinCompiler
> ---
>
> Key: PHOENIX-5593
> URL: https://issues.apache.org/jira/browse/PHOENIX-5593
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.15.0, 5.1.0, 4.14.4
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5593.master.000.patch, 
> PHOENIX-5593.master.001.patch
>
>
> JoinCompiler.getCommonType() has redundant null checks for PDataType that can 
> be removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (PHOENIX-5593) Remove null checks for JoinCompiler

2019-11-27 Thread Chinmay Kulkarni (Jira) 


[ 
https://issues.apache.org/jira/browse/PHOENIX-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983867#comment-16983867
 ] 

Chinmay Kulkarni commented on PHOENIX-5593:
---

[~vjasani] patch looks good and one of the test failures looks like an NPE 
(though it doesn't look related to your changes). Just to be sure, can you 
attach another patch (same content, different name, perhaps 
) to get another QA run?


> Remove null checks for JoinCompiler
> ---
>
> Key: PHOENIX-5593
> URL: https://issues.apache.org/jira/browse/PHOENIX-5593
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.15.0, 5.1.0, 4.14.4
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5593.master.000.patch
>
>
> JoinCompiler.getCommonType() has redundant null checks for PDataType that can 
> be removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (PHOENIX-5593) Remove null checks for JoinCompiler

2019-11-26 Thread Viraj Jasani (Jira) 


[ 
https://issues.apache.org/jira/browse/PHOENIX-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983167#comment-16983167
 ] 

Viraj Jasani commented on PHOENIX-5593:
---

Please review [~ckulkarni]

> Remove null checks for JoinCompiler
> ---
>
> Key: PHOENIX-5593
> URL: https://issues.apache.org/jira/browse/PHOENIX-5593
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.15.0, 5.1.0, 4.14.4
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5593.master.000.patch
>
>
> JoinCompiler.getCommonType() has redundant null checks for PDataType that can 
> be removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (PHOENIX-5593) Remove null checks for JoinCompiler

2019-11-26 Thread Hadoop QA (Jira) 


[ 
https://issues.apache.org/jira/browse/PHOENIX-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982935#comment-16982935
 ] 

Hadoop QA commented on PHOENIX-5593:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12986835/PHOENIX-5593.master.000.patch
  against master branch at commit cdabf29aa7440c4a8b8c85b81542121ffcb7baac.
  ATTACHMENT ID: 12986835

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ParameterizedIndexUpgradeToolIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3156//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3156//console

This message is automatically generated.

> Remove null checks for JoinCompiler
> ---
>
> Key: PHOENIX-5593
> URL: https://issues.apache.org/jira/browse/PHOENIX-5593
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 5.1.0, 4.14.4
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 4.15.0, 5.1.0, 4.14.4
>
> Attachments: PHOENIX-5593.master.000.patch
>
>
> JoinCompiler.getCommonType() has redundant null checks for PDataType that can 
> be removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)