[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824269#comment-17824269 ] ASF GitHub Bot commented on PHOENIX-7130: - stoty commented on PR #1773: URL: https://github.com/apache/phoenix/pull/1773#issuecomment-1982506030 merged manually. Note that 5.2 still does not have this. > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824268#comment-17824268 ] ASF GitHub Bot commented on PHOENIX-7130: - stoty closed pull request #1773: PHOENIX-7130 Support skipping of shade sources jar creation URL: https://github.com/apache/phoenix/pull/1773 > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821957#comment-17821957 ] ASF GitHub Bot commented on PHOENIX-7130: - chrajeshbabu merged PR #1745: URL: https://github.com/apache/phoenix/pull/1745 > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821956#comment-17821956 ] ASF GitHub Bot commented on PHOENIX-7130: - chrajeshbabu commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1970510225 Since build failures are not related this. Merging > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821764#comment-17821764 ] ASF GitHub Bot commented on PHOENIX-7130: - NihalJain commented on PR #1837: URL: https://github.com/apache/phoenix/pull/1837#issuecomment-1969405263 This is a backport of https://github.com/apache/phoenix/pull/1745 > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821763#comment-17821763 ] ASF GitHub Bot commented on PHOENIX-7130: - NihalJain opened a new pull request, #1837: URL: https://github.com/apache/phoenix/pull/1837 (no comment) > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821759#comment-17821759 ] ASF GitHub Bot commented on PHOENIX-7130: - NihalJain commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1969390922 Rebased code and updated all new instances of createSourcesJar in code. Could you please review and merge this.? CC: @gjacoby126 @stoty @virajjasani > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821754#comment-17821754 ] ASF GitHub Bot commented on PHOENIX-7130: - NihalJain commented on PR #1773: URL: https://github.com/apache/phoenix/pull/1773#issuecomment-1969380052 Rebased code and verified no new instances of createSourcesJar in code. Could you please merge this.? CC: @gjacoby126 @stoty > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807586#comment-17807586 ] ASF GitHub Bot commented on PHOENIX-7130: - virajjasani commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1895161776 pom changes are fine so far, but yeah any other big changes or feature changes that have potential to cause any additional issues (more than what is known with #1736 and make it worse) are potential blockers e.g. JSON support, which is technically ready for merge (though still in final review phase) but i would like to block it. > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807584#comment-17807584 ] ASF GitHub Bot commented on PHOENIX-7130: - stoty commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1895152920 Also, I'm going to merge the phoenix-server shading refactor soon (another pom only change), It would probably be a good idea to add this change there as well. > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807583#comment-17807583 ] ASF GitHub Bot commented on PHOENIX-7130: - virajjasani commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1895151463 I think it's fine to merge this since it adds the option to skip the shaded jar creation. > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807582#comment-17807582 ] ASF GitHub Bot commented on PHOENIX-7130: - stoty commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1895149696 This is a pom only change, and #1736 doesn't touch the poms, so I wouldn't expect them to confict in any way. > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807482#comment-17807482 ] ASF GitHub Bot commented on PHOENIX-7130: - gjacoby126 commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1894644362 (Note that we're waiting on #1736 before merging since it's a blocker.) > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802273#comment-17802273 ] ASF GitHub Bot commented on PHOENIX-7130: - stoty commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1875727262 Ouch. That's extremley slow. Is it on a spinning rust HDD ? Or some slow NAS ? > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802201#comment-17802201 ] ASF GitHub Bot commented on PHOENIX-7130: - NihalJain commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1875472586 > I have tested this now, but the shading time difference is seems to be minimal. On my machine it takes ~3:20 with the shaded sources, and ~3:05 without them. In our internal jenkins, which is based on branch-5.1, the difference is substantial. Maybe because we download all jars for every build and also possibly our local artifactory + VPN is not as fast, so downloading the source jars take almost 33% of build time. Without `-PskipShadeSources -Dmaven.source.skip=true` ``` . . [INFO] Phoenix Client . SUCCESS [22:40 min] [INFO] Phoenix Client Embedded SUCCESS [08:56 min] [INFO] Phoenix Server JAR . SUCCESS [01:54 min] [INFO] Phoenix Assembly ... SUCCESS [ 38.548 s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 36:06 min [INFO] Finished at: 2024-01-03T10:55:52Z [INFO] ``` Vs With `-PskipShadeSources -Dmaven.source.skip=true` ``` . . [INFO] Phoenix Client . SUCCESS [09:37 min] [INFO] Phoenix Client Embedded SUCCESS [08:14 min] [INFO] Phoenix Server JAR . SUCCESS [01:49 min] [INFO] Phoenix Assembly ... SUCCESS [ 38.593 s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 24:08 min [INFO] Finished at: 2024-01-03T11:29:24Z [INFO] ``` > Also I have just merged phoenix-client-lite, you may want to update the patch to add same change there. Sure let me rebase and make appropriate changes, if any > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801705#comment-17801705 ] ASF GitHub Bot commented on PHOENIX-7130: - stoty commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1873770999 I have tested this now, but the shading time difference is seems to be minimal. On my machine it takes ~3:20 with the shaded sources, and ~3:05 without them. I don't have a problem with committing this, but I wander what kind of improvement do you see with the patch, @NihalJain ? Also I have just merged phoenix-client-lite, you may want to update the patch to add same change there. > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799802#comment-17799802 ] ASF GitHub Bot commented on PHOENIX-7130: - NihalJain commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1867582477 Please donot push this to 5.1, have raised another PR for 5.1 as code is a bit different. > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799801#comment-17799801 ] ASF GitHub Bot commented on PHOENIX-7130: - NihalJain commented on PR #1773: URL: https://github.com/apache/phoenix/pull/1773#issuecomment-1867581510 This is a backport of https://github.com/apache/phoenix/pull/1745 > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799800#comment-17799800 ] ASF GitHub Bot commented on PHOENIX-7130: - NihalJain opened a new pull request, #1773: URL: https://github.com/apache/phoenix/pull/1773 (no comment) > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
