Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

2024-03-08 Thread via GitHub
virajjasani merged PR #1851: URL: https://github.com/apache/phoenix/pull/1851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

2024-03-08 Thread via GitHub
sanjeet006py commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1517922771 ## phoenix-core-client/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java: ## @@ -247,6 +248,10 @@ private List

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

2024-03-08 Thread via GitHub
tkhurana commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1517620543 ## phoenix-core-client/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java: ## @@ -247,6 +248,10 @@ private List

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

2024-03-08 Thread via GitHub
sanjeet006py commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1517610019 ## phoenix-core-client/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java: ## @@ -247,6 +248,10 @@ private List

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

2024-03-08 Thread via GitHub
sanjeet006py commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1517610019 ## phoenix-core-client/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java: ## @@ -247,6 +248,10 @@ private List

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

2024-03-08 Thread via GitHub
sanjeet006py commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1517610019 ## phoenix-core-client/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java: ## @@ -247,6 +248,10 @@ private List

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

2024-03-08 Thread via GitHub
sanjeet006py commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1517470937 ## phoenix-core-client/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java: ## @@ -247,6 +248,10 @@ private List

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

2024-03-08 Thread via GitHub
tkhurana commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1517442429 ## phoenix-core-client/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java: ## @@ -247,6 +248,10 @@ private List

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

2024-03-08 Thread via GitHub
sanjeet006py commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1517375166 ## phoenix-core/src/it/java/org/apache/phoenix/end2end/RowValueConstructorOffsetIT.java: ## @@ -1221,4 +1222,29 @@ public void rvcOffsetTrailingNullKeyTest()

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

2024-03-07 Thread via GitHub
sanjeet006py commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1517343363 ## phoenix-core-client/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java: ## @@ -247,6 +248,10 @@ private List

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

2024-03-07 Thread via GitHub
sanjeet006py commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1517343103 ## phoenix-core-client/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java: ## @@ -247,6 +248,10 @@ private List

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

2024-03-07 Thread via GitHub
virajjasani commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1517163722 ## phoenix-core-client/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java: ## @@ -247,6 +248,10 @@ private List

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

2024-03-07 Thread via GitHub
tkhurana commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1516937729 ## phoenix-core-client/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java: ## @@ -247,6 +248,10 @@ private List

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

2024-03-07 Thread via GitHub
kadirozde commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1516869330 ## phoenix-core/src/it/java/org/apache/phoenix/end2end/RowValueConstructorOffsetIT.java: ## @@ -1221,4 +1222,29 @@ public void rvcOffsetTrailingNullKeyTest() throws

Re: [PR] PHOENIX-7258: Query Optimizer should pick Index hint even for point lookup queries [phoenix]

2024-03-07 Thread via GitHub
virajjasani commented on code in PR #1851: URL: https://github.com/apache/phoenix/pull/1851#discussion_r1516856703 ## phoenix-core/src/it/java/org/apache/phoenix/end2end/TenantSpecificTablesDDLIT.java: ## @@ -616,6 +621,52 @@ public void testTableMetadataScan() throws Exception