[jira] [Commented] (RATIS-840) Memory leak of LogAppender

2020-04-23 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091159#comment-17091159 ] Tsz-wo Sze commented on RATIS-840: -- [~yjxxtd], the test failures seem related. Could you take a look? >

[jira] [Comment Edited] (RATIS-878) Infinite restart of LogAppender

2020-04-23 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/RATIS-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091103#comment-17091103 ] runzhiwang edited comment on RATIS-878 at 4/24/20, 2:24 AM: [~ljain]

[jira] [Comment Edited] (RATIS-878) Infinite restart of LogAppender

2020-04-23 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/RATIS-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091103#comment-17091103 ] runzhiwang edited comment on RATIS-878 at 4/24/20, 2:24 AM: [~ljain]

[jira] [Comment Edited] (RATIS-878) Infinite restart of LogAppender

2020-04-23 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/RATIS-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091103#comment-17091103 ] runzhiwang edited comment on RATIS-878 at 4/24/20, 2:28 AM: [~ljain]

[jira] [Commented] (RATIS-878) Infinite restart of LogAppender

2020-04-23 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/RATIS-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091103#comment-17091103 ] runzhiwang commented on RATIS-878: -- [~ljain][~szetszwo][~shashikant] Hi, there are 2 ideas to

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

2020-04-23 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091195#comment-17091195 ] runzhiwang commented on RATIS-840: -- [~szetszwo] Sure, I will take a look. > Memory leak of LogAppender >

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

2020-04-23 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090457#comment-17090457 ] runzhiwang commented on RATIS-840: -- [~szetszwo] Hi, I have updated the patch. Could you help review it

[jira] [Commented] (RATIS-876) Introduce max timeout in RequestTypeDependentRetryPolicy

2020-04-23 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090512#comment-17090512 ] Hadoop QA commented on RATIS-876: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Comment Edited] (RATIS-840) Memory leak of LogAppender

2020-04-23 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090361#comment-17090361 ] runzhiwang edited comment on RATIS-840 at 4/23/20, 10:02 AM: - [~szetszwo]

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

2020-04-23 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090498#comment-17090498 ] Hadoop QA commented on RATIS-840: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Created] (RATIS-879) Fix TestRaftAsyncWithGrpc#testNoRetryWaitOnNotLeaderException

2020-04-23 Thread Shashikant Banerjee (Jira)
Shashikant Banerjee created RATIS-879: - Summary: Fix TestRaftAsyncWithGrpc#testNoRetryWaitOnNotLeaderException Key: RATIS-879 URL: https://issues.apache.org/jira/browse/RATIS-879 Project: Ratis

[jira] [Updated] (RATIS-841) Remove unnecessary exception checks in OrderedAsync#sendRequest

2020-04-23 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lokesh Jain updated RATIS-841: -- Attachment: RATIS-841.003.patch > Remove unnecessary exception checks in OrderedAsync#sendRequest >

[jira] [Commented] (RATIS-841) Remove unnecessary exception checks in OrderedAsync#sendRequest

2020-04-23 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090572#comment-17090572 ] Lokesh Jain commented on RATIS-841: --- Uploaded rebased v3 patch. > Remove unnecessary exception checks

[jira] [Updated] (RATIS-840) Memory leak of LogAppender

2020-04-23 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] runzhiwang updated RATIS-840: - Attachment: RATIS-840.003.patch > Memory leak of LogAppender > -- > >

[jira] [Commented] (RATIS-876) Introduce max timeout in RequestTypeDependentRetryPolicy

2020-04-23 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090462#comment-17090462 ] Lokesh Jain commented on RATIS-876: --- v2 patch fixes UT failures. > Introduce max timeout in

[jira] [Updated] (RATIS-876) Introduce max timeout in RequestTypeDependentRetryPolicy

2020-04-23 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lokesh Jain updated RATIS-876: -- Attachment: RATIS-876.002.patch > Introduce max timeout in RequestTypeDependentRetryPolicy >

[jira] [Updated] (RATIS-865) Fix TestRaftWithGrpc#testStateMachineMetrics

2020-04-23 Thread Shashikant Banerjee (Jira)
[ https://issues.apache.org/jira/browse/RATIS-865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashikant Banerjee updated RATIS-865: -- Description: The failure was observed here:

[jira] [Commented] (RATIS-841) Remove unnecessary exception checks in OrderedAsync#sendRequest

2020-04-23 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090573#comment-17090573 ] Lokesh Jain commented on RATIS-841: --- [~szetszwo] Thanks for the review! I have committed the patch to

[jira] [Commented] (RATIS-844) RaftClient should connect to the new leader when the old leader is partitioned from the cluster

2020-04-23 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090559#comment-17090559 ] Lokesh Jain commented on RATIS-844: --- [~burcukozkan] Thanks for updating the patch! The changes look good

[jira] [Created] (RATIS-878) Infinite restart of LogAppender

2020-04-23 Thread runzhiwang (Jira)
runzhiwang created RATIS-878: Summary: Infinite restart of LogAppender Key: RATIS-878 URL: https://issues.apache.org/jira/browse/RATIS-878 Project: Ratis Issue Type: Bug Reporter:

[jira] [Updated] (RATIS-801) Ratis snapshot should consider stateMachine#appliedIndex for triggering snapshot

2020-04-23 Thread Shashikant Banerjee (Jira)
[ https://issues.apache.org/jira/browse/RATIS-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashikant Banerjee updated RATIS-801: -- Description: Currently, while triggering snapshot, snapshotUpdater#appliedIndex is

[jira] [Resolved] (RATIS-877) StateMachineUpdater#takeSnapshot should check stateMachine lastAppliedIndex

2020-04-23 Thread Shashikant Banerjee (Jira)
[ https://issues.apache.org/jira/browse/RATIS-877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashikant Banerjee resolved RATIS-877. --- Fix Version/s: 0.6.0 Resolution: Duplicate > StateMachineUpdater#takeSnapshot

[jira] [Commented] (RATIS-841) Remove unnecessary exception checks in OrderedAsync#sendRequest

2020-04-23 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090362#comment-17090362 ] Lokesh Jain commented on RATIS-841: --- In 

[jira] [Commented] (RATIS-841) Remove unnecessary exception checks in OrderedAsync#sendRequest

2020-04-23 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090351#comment-17090351 ] Tsz-wo Sze commented on RATIS-841: -- Why skilling client.handleLeaderException? In

[jira] [Commented] (RATIS-841) Remove unnecessary exception checks in OrderedAsync#sendRequest

2020-04-23 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090380#comment-17090380 ] Tsz-wo Sze commented on RATIS-841: -- I see. Thanks! +1 the 002 patch looks good. > Remove unnecessary

[jira] [Commented] (RATIS-840) Memory leak of LogAppender

2020-04-23 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090361#comment-17090361 ] runzhiwang commented on RATIS-840: -- [~szetszwo] Sounds good. I will open another JIRA and fix the

[jira] [Commented] (RATIS-801) Ratis snapshot should consider stateMachine#appliedIndex for triggering snapshot

2020-04-23 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090371#comment-17090371 ] Lokesh Jain commented on RATIS-801: --- {code:java} private void takeSnapshot() { ... final long

[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-23 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090324#comment-17090324 ] Lokesh Jain commented on RATIS-850: --- [~hanishakoneru] Thanks for updating the patch! The changes look

[jira] [Updated] (RATIS-878) Infinite restart of LogAppender

2020-04-23 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/RATIS-878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] runzhiwang updated RATIS-878: - Description: The details please refer it here

[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-23 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090343#comment-17090343 ] Lokesh Jain commented on RATIS-850: --- [~hanishakoneru] Thanks for the contribution! [~msingh] Thanks for

[jira] [Comment Edited] (RATIS-840) Memory leak of LogAppender

2020-04-23 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090357#comment-17090357 ] Tsz-wo Sze edited comment on RATIS-840 at 4/23/20, 7:45 AM: [~yjxxtd], in this

[jira] [Updated] (RATIS-840) Use new FollowerInfo in votesList when create new GrpcLogAppender

2020-04-23 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] runzhiwang updated RATIS-840: - Summary: Use new FollowerInfo in votesList when create new GrpcLogAppender (was: Memory leak of

[jira] [Updated] (RATIS-840) Memory leak of LogAppender

2020-04-23 Thread runzhiwang (Jira)
[ https://issues.apache.org/jira/browse/RATIS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] runzhiwang updated RATIS-840: - Summary: Memory leak of LogAppender (was: Use new FollowerInfo in votesList when create new

[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-23 Thread Hanisha Koneru (Jira)
[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090785#comment-17090785 ] Hanisha Koneru commented on RATIS-850: -- Thank you [~ljain] and [~msingh] for the reviews and