[jira] [Commented] (SCB-792) More abundant metrics information
[
https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577835#comment-16577835
]
ASF GitHub Bot commented on SCB-792:
asifdxtreme closed pull request #413: SCB-792 More abundant metrics information
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/413
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/pkg/buffer/pool.go b/pkg/buffer/pool.go
new file mode 100644
index ..66d7ecde
--- /dev/null
+++ b/pkg/buffer/pool.go
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package buffer
+
+import (
+ "bytes"
+ "sync"
+)
+
+type Pool struct {
+ pool sync.Pool
+}
+
+func (p *Pool) Get() *bytes.Buffer {
+ return p.pool.Get().(*bytes.Buffer)
+}
+
+func (p *Pool) Put(buf *bytes.Buffer) {
+ buf.Reset()
+ p.pool.Put(buf)
+}
+
+func NewPool(s int) *Pool {
+ return {
+ pool: sync.Pool{
+ New: func() interface{} {
+ b := bytes.NewBuffer(make([]byte, s))
+ b.Reset()
+ return b
+ },
+ },
+ }
+}
diff --git a/pkg/buffer/pool_test.go b/pkg/buffer/pool_test.go
new file mode 100644
index ..959b2597
--- /dev/null
+++ b/pkg/buffer/pool_test.go
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package buffer
+
+import (
+ "strings"
+ "testing"
+)
+
+func TestNewPool(t *testing.T) {
+ p := NewPool(10)
+ b := p.Get()
+ if b == nil {
+ t.Fatalf("TestNewPool falied")
+ }
+ b.WriteString("a")
+ if b.String() != "a" {
+ t.Fatalf("TestNewPool falied")
+ }
+ p.Put(b)
+ b = p.Get()
+ if b == nil || b.Len() != 0 {
+ t.Fatalf("TestNewPool falied")
+ }
+}
+
+func BenchmarkNewPool(b *testing.B) {
+ p := NewPool(4 * 10)
+ s := strings.Repeat("a", 4*1024)
+ b.ResetTimer()
+ b.RunParallel(func(pb *testing.PB) {
+ for pb.Next() {
+ buf := p.Get()
+ buf.WriteString(s)
+ _ = buf.String()
+ p.Put(buf)
+ }
+ })
+ b.ReportAllocs()
+ // 200 872 ns/op4098 B/op 1
allocs/op
+}
diff --git a/pkg/rest/route.go b/pkg/rest/route.go
index 7e2088c2..084fe44b 100644
--- a/pkg/rest/route.go
+++ b/pkg/rest/route.go
@@ -71,7 +71,7 @@ func (this *ROAServerHandler) addRoute(route *Route) (err
error) {
this.handlers[method] = append(this.handlers[method],
{
util.FormatFuncName(util.FuncName(route.Func)), route.Path,
http.HandlerFunc(route.Func)})
- util.Logger().Infof("register route %s(%s).", route.Path, method)
+ util.Logger().Infof("register route %s(%s)", route.Path, method)
return nil
}
diff --git a/pkg/util/concurrent_map.go b/pkg/util/concurrent_map.go
index fce2c3ce..6c6a484a 100644
--- a/pkg/util/concurrent_map.go
+++ b/pkg/util/concurrent_map.go
@@ -1,19 +1,20 @@
-/*
-
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577188#comment-16577188 ] ASF GitHub Bot commented on SCB-792: coveralls commented on issue #413: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/413#issuecomment-412277748 [](https://coveralls.io/builds/18439298) Coverage increased (+0.2%) to 76.544% when pulling **07f9e03277b652c94e44db7f6d42dfc0af2f62e4 on little-cui:master** into **e5a485e3e04ab9ecf152f52bccfd64c12914951d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[
https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573143#comment-16573143
]
ASF GitHub Bot commented on SCB-792:
asifdxtreme closed pull request #412: SCB-792 More abundant metrics information
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/412
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/integration/integrationtest_suite_test.go
b/integration/integrationtest_suite_test.go
index adad6665..ae25b96d 100644
--- a/integration/integrationtest_suite_test.go
+++ b/integration/integrationtest_suite_test.go
@@ -21,15 +21,10 @@ import (
"github.com/onsi/ginkgo/reporters"
. "github.com/onsi/gomega"
"net/http"
+ "os"
"testing"
)
-func TestIntegration(t *testing.T) {
- RegisterFailHandler(Fail)
- junitReporter := reporters.NewJUnitReporter("model.junit.xml")
- RunSpecsWithDefaultAndCustomReporters(t, "Integration Test for SC",
[]Reporter{junitReporter})
-}
-
var scclient *http.Client
var insecurityConnection = {}
@@ -39,3 +34,16 @@ var SCURL = "http://127.0.0.1:30100;
var _ = BeforeSuite(func() {
scclient = insecurityConnection
})
+
+func init() {
+ addr, ok := os.LookupEnv("CSE_REGISTRY_ADDRESS")
+ if ok {
+ SCURL = addr
+ }
+}
+
+func TestIntegration(t *testing.T) {
+ RegisterFailHandler(Fail)
+ junitReporter := reporters.NewJUnitReporter("model.junit.xml")
+ RunSpecsWithDefaultAndCustomReporters(t, "Integration Test for SC",
[]Reporter{junitReporter})
+}
diff --git a/server/metric/calculator.go b/server/metric/calculator.go
index 8b163c6d..99fac216 100644
--- a/server/metric/calculator.go
+++ b/server/metric/calculator.go
@@ -18,17 +18,14 @@ package metric
import (
dto "github.com/prometheus/client_model/go"
- "strings"
)
var (
- calculators = make(map[string]Calculator)
- DefaultCalculator = {}
+ DefaultCalculator Calculator = {}
)
type Calculator interface {
Calc(mf *dto.MetricFamily) float64
- ReShape()
}
type CommonCalculator struct {
@@ -52,9 +49,6 @@ func (c *CommonCalculator) Calc(mf *dto.MetricFamily) float64
{
}
}
-func (c *CommonCalculator) ReShape() {
-}
-
func metricCounterOf(m []*dto.Metric) float64 {
var sum float64 = 0
for _, d := range m {
@@ -80,19 +74,10 @@ func metricSummaryOf(m []*dto.Metric) float64 {
return sum / float64(count)
}
-func RegisterCalculator(family string, c Calculator) {
- calculators[family] = c
+func RegisterCalculator(c Calculator) {
+ DefaultCalculator = c
}
func Calculate(mf *dto.MetricFamily) float64 {
- if c, ok := calculators[strings.TrimPrefix(mf.GetName(),
familyNamePrefix)]; ok {
- return c.Calc(mf)
- }
return DefaultCalculator.Calc(mf)
}
-
-func ReShape() {
- for _, c := range calculators {
- c.ReShape()
- }
-}
diff --git a/server/metric/calculator_test.go b/server/metric/calculator_test.go
new file mode 100644
index ..50bc42b3
--- /dev/null
+++ b/server/metric/calculator_test.go
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package metric
+
+import (
+ dto "github.com/prometheus/client_model/go"
+ "testing"
+)
+
+func TestCommonCalculator_Calc(t *testing.T) {
+ c := {}
+
+ mf := {}
+ mt := dto.MetricType_UNTYPED
+ v := float64(0)
+ n := uint64(0)
+
+ if c.Calc(mf) != 0 {
+ t.Fatalf("TestCommonCalculator_Calc failed")
+ }
+
+ mf = {Type: , Metric: []*dto.Metric{{}}}
+ if c.Calc(mf) != 0 {
+ t.Fatalf("TestCommonCalculator_Calc failed")
+ }
+
+ mt = dto.MetricType_GAUGE
+ v = 1
+ mf = {Type: , Metric: []*dto.Metric{
+ {Gauge: {Value: }}, {Gauge: {Value:
+ if
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572658#comment-16572658 ] ASF GitHub Bot commented on SCB-792: coveralls edited a comment on issue #412: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/412#issuecomment-411100776 [](https://coveralls.io/builds/1830) Coverage decreased (-0.02%) to 76.219% when pulling **f6f81f3e90fa5a0becf873f1f7dc4d8bc13d2243 on little-cui:metric** into **2e14f09b03c052503a978350616da8e60832848d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572655#comment-16572655 ] ASF GitHub Bot commented on SCB-792: codecov-io edited a comment on issue #412: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/412#issuecomment-411278340 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=h1) Report > Merging [#412](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/2e14f09b03c052503a978350616da8e60832848d?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `83.33%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=tree) ```diff @@Coverage Diff @@ ## master #412 +/- ## == - Coverage 73.02% 73.01% -0.02% == Files 118 123 +5 Lines9746 9864 +118 == + Hits 7117 7202 +85 - Misses 2154 2183 +29 - Partials 475 479 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/metric/calculator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-c2VydmVyL21ldHJpYy9jYWxjdWxhdG9yLmdv) | `87.5% <0%> (ø)` | | | [server/metric/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-c2VydmVyL21ldHJpYy9jb21tb24uZ28=) | `88% <100%> (ø)` | | | [server/metric/gatherer.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-c2VydmVyL21ldHJpYy9nYXRoZXJlci5nbw==) | `65.71% <66.66%> (ø)` | | | [server/metric/reporter.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-c2VydmVyL21ldHJpYy9yZXBvcnRlci5nbw==) | `85.71% <85.71%> (ø)` | | | [server/plugin/infra/registry/etcd/etcd.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL2V0Y2QuZ28=) | `86.06% <0%> (-0.2%)` | :arrow_down: | | [server/metric/metrics.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-c2VydmVyL21ldHJpYy9tZXRyaWNzLmdv) | `31.57% <0%> (ø)` | | | ... and [1 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=footer). Last update [2e14f09...f6f81f3](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572652#comment-16572652 ] ASF GitHub Bot commented on SCB-792: coveralls edited a comment on issue #412: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/412#issuecomment-411100776 [](https://coveralls.io/builds/18377741) Coverage decreased (-0.02%) to 76.221% when pulling **f6f81f3e90fa5a0becf873f1f7dc4d8bc13d2243 on little-cui:metric** into **2e14f09b03c052503a978350616da8e60832848d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572651#comment-16572651 ] ASF GitHub Bot commented on SCB-792: codecov-io edited a comment on issue #412: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/412#issuecomment-411278340 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=h1) Report > Merging [#412](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/2e14f09b03c052503a978350616da8e60832848d?src=pr=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `82.6%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=tree) ```diff @@Coverage Diff @@ ## master #412 +/- ## == - Coverage 73.02% 72.98% -0.04% == Files 118 123 +5 Lines9746 9863 +117 == + Hits 7117 7199 +82 - Misses 2154 2185 +31 - Partials 475 479 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/metric/calculator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-c2VydmVyL21ldHJpYy9jYWxjdWxhdG9yLmdv) | `87.5% <0%> (ø)` | | | [server/metric/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-c2VydmVyL21ldHJpYy9jb21tb24uZ28=) | `88% <100%> (ø)` | | | [server/metric/gatherer.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-c2VydmVyL21ldHJpYy9nYXRoZXJlci5nbw==) | `65.71% <66.66%> (ø)` | | | [server/metric/reporter.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-c2VydmVyL21ldHJpYy9yZXBvcnRlci5nbw==) | `83.33% <83.33%> (ø)` | | | [server/admin/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-c2VydmVyL2FkbWluL3NlcnZpY2UuZ28=) | `85.18% <0%> (-3.71%)` | :arrow_down: | | [pkg/util/log.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-cGtnL3V0aWwvbG9nLmdv) | `72.95% <0%> (-0.82%)` | :arrow_down: | | [server/plugin/infra/registry/etcd/etcd.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL2V0Y2QuZ28=) | `86.06% <0%> (-0.2%)` | :arrow_down: | | ... and [3 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=footer). Last update [2e14f09...f6f81f3](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572643#comment-16572643 ] ASF GitHub Bot commented on SCB-792: codecov-io commented on issue #412: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/412#issuecomment-411278340 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=h1) Report > Merging [#412](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/2e14f09b03c052503a978350616da8e60832848d?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `82.6%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=tree) ```diff @@Coverage Diff @@ ## master #412 +/- ## == - Coverage 73.02% 73.01% -0.02% == Files 118 123 +5 Lines9746 9863 +117 == + Hits 7117 7201 +84 - Misses 2154 2183 +29 - Partials 475 479 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/metric/calculator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-c2VydmVyL21ldHJpYy9jYWxjdWxhdG9yLmdv) | `87.5% <0%> (ø)` | | | [server/metric/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-c2VydmVyL21ldHJpYy9jb21tb24uZ28=) | `88% <100%> (ø)` | | | [server/metric/gatherer.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-c2VydmVyL21ldHJpYy9nYXRoZXJlci5nbw==) | `65.71% <66.66%> (ø)` | | | [server/metric/reporter.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-c2VydmVyL21ldHJpYy9yZXBvcnRlci5nbw==) | `83.33% <83.33%> (ø)` | | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.58% <0%> (-0.95%)` | :arrow_down: | | [server/plugin/infra/registry/etcd/etcd.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL2V0Y2QuZ28=) | `86.06% <0%> (-0.2%)` | :arrow_down: | | [server/metric/metrics.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree#diff-c2VydmVyL21ldHJpYy9tZXRyaWNzLmdv) | `31.57% <0%> (ø)` | | | ... and [3 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=footer). Last update [2e14f09...f6f81f3](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/412?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572644#comment-16572644 ] ASF GitHub Bot commented on SCB-792: coveralls edited a comment on issue #412: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/412#issuecomment-411100776 [](https://coveralls.io/builds/18377700) Coverage increased (+0.03%) to 76.276% when pulling **588311b110468ef5ea38d90c1fd07348e874ec24 on little-cui:metric** into **2e14f09b03c052503a978350616da8e60832848d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571850#comment-16571850 ] ASF GitHub Bot commented on SCB-792: coveralls commented on issue #412: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/412#issuecomment-411100776 [](https://coveralls.io/builds/18366266) Coverage decreased (-0.2%) to 76.019% when pulling **6a74ca7edf427523f4d170d859bfd90a1bed143c on little-cui:metric** into **2e14f09b03c052503a978350616da8e60832848d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571622#comment-16571622 ] ASF GitHub Bot commented on SCB-792: little-cui opened a new pull request #412: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/412 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[
https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566348#comment-16566348
]
ASF GitHub Bot commented on SCB-792:
asifdxtreme closed pull request #407: SCB-792 More abundant metrics information
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/docs/README.md b/docs/README.md
index 481d3f8e..5a9f8aa1 100644
--- a/docs/README.md
+++ b/docs/README.md
@@ -6,7 +6,7 @@
- [Api
Documentation](https://rawcdn.githack.com/ServiceComb/service-center/master/docs/api-docs.html)
- [Contribution Guide](/docs/contribution.md)
+- [Plug-in Extension](/server/plugin/README.md)
[Docker Image Guide](/scripts/docker)
@@ -14,4 +14,14 @@
- [Making Front-end Image](/scripts/docker/build-frontend-image)
- [Deploy Service-Center in Cluster](/docs/sc-cluster.md)
+ Deploy Service-Center
+
+- [Cluster Deployment](/docs/sc-cluster.md)
+
+- [Deploy with TLS](/docs/security-tls.md)
+
+ Monitoring Service-Center
+
+- [Integrate with Grafana](/docs/integration-grafana.md)
+
+ [Contribution Guide](/docs/contribution.md)
\ No newline at end of file
diff --git a/docs/integration-grafana.PNG b/docs/integration-grafana.PNG
new file mode 100644
index ..e8e96090
Binary files /dev/null and b/docs/integration-grafana.PNG differ
diff --git a/docs/integration-grafana.md b/docs/integration-grafana.md
new file mode 100644
index ..1909fd85
--- /dev/null
+++ b/docs/integration-grafana.md
@@ -0,0 +1,9 @@
+# Integrate with Grafana
+
+As Service-Center uses Prometheus lib to report metrics.
+Then it is easy to integrate with Grafana.
+Here is a [template](/integration/health-metrics-grafana.json) file can be
imported in Grafana.
+
+After the import, you can get the view like blow.
+
+
\ No newline at end of file
diff --git a/docs/security_tls.md b/docs/security-tls.md
similarity index 100%
rename from docs/security_tls.md
rename to docs/security-tls.md
diff --git a/glide.yaml b/glide.yaml
index 2a8830a0..fce282ba 100644
--- a/glide.yaml
+++ b/glide.yaml
@@ -3,9 +3,9 @@ import:
- package: github.com/Knetic/govaluate
version: 91facc4ae520fef82c9aee6b6ae720d9ae789131
repo: https://github.com/Knetic/govaluate
-- package: github.com/ServiceComb/paas-lager
- version: 378a833fc008d8343083dc73e77db142afccf377
- repo: https://github.com/ServiceComb/paas-lager
+- package: github.com/go-chassis/paas-lager
+ version: master
+ repo: https://github.com/go-chassis/paas-lager
subpackages:
- third_party/forked/cloudfoundry/lager
- package: github.com/Shopify/sarama
diff --git a/integration/health-metrics-grafana.json
b/integration/health-metrics-grafana.json
index fdc80d25..7b435ba3 100644
--- a/integration/health-metrics-grafana.json
+++ b/integration/health-metrics-grafana.json
@@ -109,7 +109,7 @@
},
"gridPos": {
"h": 3,
-"w": 2,
+"w": 4,
"x": 0,
"y": 0
},
@@ -171,88 +171,6 @@
],
"valueName": "current"
},
-{
- "cacheTimeout": null,
- "colorBackground": false,
- "colorValue": false,
- "colors": [
-"#299c46",
-"rgba(237, 129, 40, 0.89)",
-"#d44a3a"
- ],
- "datasource": "${DS_LOCAL}",
- "format": "none",
- "gauge": {
-"maxValue": 100,
-"minValue": 0,
-"show": false,
-"thresholdLabels": false,
-"thresholdMarkers": true
- },
- "gridPos": {
-"h": 3,
-"w": 2,
-"x": 2,
-"y": 0
- },
- "id": 19,
- "interval": null,
- "links": [],
- "mappingType": 1,
- "mappingTypes": [
-{
- "name": "value to text",
- "value": 1
-},
-{
- "name": "range to text",
- "value": 2
-}
- ],
- "maxDataPoints": 100,
- "minSpan": 4,
- "nullPointMode": "connected",
- "nullText": null,
- "postfix": "",
- "postfixFontSize": "50%",
- "prefix": "",
- "prefixFontSize": "50%",
- "rangeMaps": [
-{
- "from": "null",
- "text": "N/A",
- "to": "null"
-}
- ],
- "sparkline": {
-"fillColor": "rgba(31, 118, 189, 0.18)",
-"full": true,
-"lineColor": "rgb(31, 120, 193)",
-"show": false
- },
- "tableColumn": "",
- "targets": [
-{
- "expr":
"max(service_center_db_backend_total{job=\"service-center\"})",
- "format": "time_series",
- "instant": false,
- "intervalFactor":
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565482#comment-16565482 ] ASF GitHub Bot commented on SCB-792: coveralls edited a comment on issue #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#issuecomment-409155842 [](https://coveralls.io/builds/18272330) Coverage decreased (-0.1%) to 76.246% when pulling **0c50f9ca21cdc8db58b613641386d053db2e03cf on little-cui:metrics** into **7bf5c582204d6237f3c3fe61d5d6f59986796a23 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565447#comment-16565447 ] ASF GitHub Bot commented on SCB-792: codecov-io edited a comment on issue #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#issuecomment-409155366 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=h1) Report > Merging [#407](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/7bf5c582204d6237f3c3fe61d5d6f59986796a23?src=pr=desc) will **decrease** coverage by `0.05%`. > The diff coverage is `51.11%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=tree) ```diff @@Coverage Diff @@ ## master #407 +/- ## == - Coverage 73.06% 73.01% -0.06% == Files 118 118 Lines9747 9746 -1 == - Hits 7122 7116 -6 - Misses 2153 2156 +3 - Partials 472 474 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.33% <ø> (ø)` | :arrow_up: | | [server/plugin/infra/tls/buildin/tls.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90bHMvYnVpbGRpbi90bHMuZ28=) | `82.08% <0%> (ø)` | :arrow_up: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `53.21% <0%> (ø)` | :arrow_up: | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.72% <0%> (ø)` | :arrow_up: | | [server/service/util/dependency\_query.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5X3F1ZXJ5Lmdv) | `51.9% <0%> (ø)` | :arrow_up: | | [server/core/backend/cacher\_kv.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9jYWNoZXJfa3YuZ28=) | `66.77% <0%> (ø)` | :arrow_up: | | [server/service/validate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdmFsaWRhdGUuZ28=) | `84.48% <0%> (ø)` | :arrow_up: | | [...ver/plugin/infra/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90cmFjaW5nL2J1aWxkaW4vZmlsZV9jb2xsZWN0b3IuZ28=) | `52.42% <0%> (ø)` | :arrow_up: | | [server/plugin/infra/tracing/buildin/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90cmFjaW5nL2J1aWxkaW4vY29tbW9uLmdv) | `50% <0%> (ø)` | :arrow_up: | | [server/core/backend/lease.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9sZWFzZS5nbw==) | `84.21% <0%> (ø)` | :arrow_up: | | ... and [20 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=footer). Last update [7bf5c58...0c50f9c](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565416#comment-16565416 ] ASF GitHub Bot commented on SCB-792: codecov-io edited a comment on issue #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#issuecomment-409155366 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=h1) Report > Merging [#407](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/7bf5c582204d6237f3c3fe61d5d6f59986796a23?src=pr=desc) will **decrease** coverage by `0.07%`. > The diff coverage is `51.11%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=tree) ```diff @@Coverage Diff @@ ## master #407 +/- ## == - Coverage 73.06% 72.99% -0.08% == Files 118 118 Lines9747 9746 -1 == - Hits 7122 7114 -8 - Misses 2153 2156 +3 - Partials 472 476 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.33% <ø> (ø)` | :arrow_up: | | [server/service/util/dependency\_query.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5X3F1ZXJ5Lmdv) | `51.9% <0%> (ø)` | :arrow_up: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `53.21% <0%> (ø)` | :arrow_up: | | [server/service/validate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdmFsaWRhdGUuZ28=) | `84.48% <0%> (ø)` | :arrow_up: | | [...ver/plugin/infra/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90cmFjaW5nL2J1aWxkaW4vZmlsZV9jb2xsZWN0b3IuZ28=) | `52.42% <0%> (ø)` | :arrow_up: | | [server/core/backend/cacher\_kv.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9jYWNoZXJfa3YuZ28=) | `66.77% <0%> (ø)` | :arrow_up: | | [server/plugin/infra/tls/buildin/tls.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90bHMvYnVpbGRpbi90bHMuZ28=) | `82.08% <0%> (ø)` | :arrow_up: | | [server/core/backend/lease.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9sZWFzZS5nbw==) | `84.21% <0%> (ø)` | :arrow_up: | | [server/plugin/infra/tracing/buildin/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90cmFjaW5nL2J1aWxkaW4vY29tbW9uLmdv) | `50% <0%> (ø)` | :arrow_up: | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.72% <0%> (ø)` | :arrow_up: | | ... and [19 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=footer). Last update [7bf5c58...0c50f9c](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565412#comment-16565412 ] ASF GitHub Bot commented on SCB-792: coveralls edited a comment on issue #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#issuecomment-409155842 [](https://coveralls.io/builds/18271632) Coverage decreased (-0.1%) to 76.283% when pulling **580b8846bd0e34712a0d22aec17e2d9eb19cd3dd on little-cui:metrics** into **7bf5c582204d6237f3c3fe61d5d6f59986796a23 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565383#comment-16565383 ] ASF GitHub Bot commented on SCB-792: little-cui commented on a change in pull request #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#discussion_r206894331 ## File path: integration/health-metrics-grafana.json ## @@ -31,6 +31,12 @@ "name": "Grafana", Review comment: DONE This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565345#comment-16565345 ] ASF GitHub Bot commented on SCB-792: little-cui commented on a change in pull request #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#discussion_r206884555 ## File path: server/metric/common.go ## @@ -16,17 +16,44 @@ */ package metric -import "time" +import ( + "github.com/astaxie/beego" + "net" + "sync" + "time" +) const ( - defaultMetricsSize = 100 - collectInterval= 5 * time.Second + collectInterval = 5 * time.Second Review comment: i think there are no necessary to make it configurable, because the gather just used internal for some special situations, like calculate the QPS and adjust whether to raise an overload alarm. the interval is not the report metrics period. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565148#comment-16565148 ] ASF GitHub Bot commented on SCB-792: asifdxtreme commented on a change in pull request #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#discussion_r206841318 ## File path: server/metric/common.go ## @@ -16,17 +16,44 @@ */ package metric -import "time" +import ( + "github.com/astaxie/beego" + "net" + "sync" + "time" +) const ( - defaultMetricsSize = 100 - collectInterval= 5 * time.Second + collectInterval = 5 * time.Second Review comment: Suggestion : Can we make this interval time configurable? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565147#comment-16565147 ] ASF GitHub Bot commented on SCB-792: asifdxtreme commented on a change in pull request #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#discussion_r206841975 ## File path: integration/health-metrics-grafana.json ## @@ -31,6 +31,12 @@ "name": "Grafana", Review comment: Suggestion : If possible can we add the Dashboard Snapshot image of the Grafana, currently we do not have any dashboard snapshot of this json dashbord. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563366#comment-16563366 ] ASF GitHub Bot commented on SCB-792: coveralls commented on issue #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#issuecomment-409155842 [](https://coveralls.io/builds/18244676) Coverage decreased (-0.08%) to 74.455% when pulling **f788e2391a50924a7fb76b4f331e26fe0770d90f on little-cui:metrics** into **7157610d608704aa885ec278f053ae91e283fa85 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563359#comment-16563359 ] ASF GitHub Bot commented on SCB-792: codecov-io commented on issue #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#issuecomment-409155366 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=h1) Report > Merging [#407](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/7157610d608704aa885ec278f053ae91e283fa85?src=pr=desc) will **decrease** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=tree) ```diff @@Coverage Diff @@ ## master #407 +/- ## == - Coverage 71.71% 71.57% -0.15% == Files 39 39 Lines4137 4137 == - Hits 2967 2961 -6 - Misses 1003 1011 +8 + Partials 167 165 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv) | `27.9% <0%> (-9.31%)` | :arrow_down: | | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `68.94% <0%> (+0.62%)` | :arrow_up: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `80.98% <0%> (+0.7%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=footer). Last update [7157610...f788e23](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563345#comment-16563345 ] ASF GitHub Bot commented on SCB-792: little-cui opened a new pull request #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
