[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697636#comment-16697636 ] ASF GitHub Bot commented on SCB-993: asifdxtreme closed pull request #498: SCB-993 Add the requirement of scctl URL: https://github.com/apache/servicecomb-service-center/pull/498 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/frontend/Readme.md b/frontend/Readme.md index 79c86ac7..9bb56b56 100644 --- a/frontend/Readme.md +++ b/frontend/Readme.md @@ -5,7 +5,8 @@ Service-Center UI also offers a unique feature of testing the Schemas of their M ### QuickStart Guide -Easiest way to get started with Service-Center UI is to download the release from [here](https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/) and then untar/unzip it based on your OS and run start-frontend.sh/start-frontend.bat. +Easiest way to get started with Service-Center UI is to download the release from +[`here`](http://servicecomb.apache.org/release/) and then untar/unzip it based on your OS and run start-frontend.sh/start-frontend.bat. This will bring up the Service-Center UI on [http://127.0.0.1:30103](http://127.0.0.1:30103). Windows(apache-servicecomb-service-center-XXX-windows-amd64.zip): diff --git a/scctl/README.md b/scctl/README.md index 5b5cfca9..b9431f08 100644 --- a/scctl/README.md +++ b/scctl/README.md @@ -1,13 +1,13 @@ ## scctl -`scctl` enables user to view the list of MicroServices registered in SC. +`scctl` enables user to view the list of MicroServices registered in service center(version 1.1.0+). You can view all the commands from [here](/scctl/pkg/plugin/README.md) ### QuickStart Guide # Install Easiest way to get started with `scctl` is to download the release -from [here](https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/) +from [`here`](http://servicecomb.apache.org/release/) and then untar/unzip it based on your OS. # Check the version diff --git a/scctl/pkg/plugin/README.md b/scctl/pkg/plugin/README.md index e244676e..d72dc5ba 100644 --- a/scctl/pkg/plugin/README.md +++ b/scctl/pkg/plugin/README.md @@ -1,7 +1,7 @@ scctl -`scctl` is a command line client for service center. +`scctl` is a command line client for service center(version 1.1.0+). ## Global options This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697569#comment-16697569 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #498: SCB-993 Add the requirement of scctl URL: https://github.com/apache/servicecomb-service-center/pull/498#issuecomment-441254509 [](https://coveralls.io/builds/20266621) Coverage decreased (-0.02%) to 61.646% when pulling **91e6b597baa948b5f1ea09a0a35f35fd7d2c5125 on little-cui:docs** into **49428294a99f2a475203a7ceb04ce8d5754feb77 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697568#comment-16697568 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #498: SCB-993 Add the requirement of scctl URL: https://github.com/apache/servicecomb-service-center/pull/498#issuecomment-441254296 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=h1) Report > Merging [#498](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/49428294a99f2a475203a7ceb04ce8d5754feb77?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=tree) ```diff @@Coverage Diff @@ ## master #498 +/- ## == - Coverage 59.25% 59.23% -0.03% == Files 166 166 Lines 1388013880 == - Hits 8225 8222 -3 Misses 5072 5072 - Partials 583 586 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/498/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `72.72% <0%> (-9.1%)` | :arrow_down: | | [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/498/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.4% <0%> (-0.56%)` | :arrow_down: | | [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/498/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=footer). Last update [4942829...91e6b59](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697203#comment-16697203 ] ASF GitHub Bot commented on SCB-993: coveralls commented on issue #498: SCB-993 Add the requirement of scctl URL: https://github.com/apache/servicecomb-service-center/pull/498#issuecomment-441254509 [](https://coveralls.io/builds/20260744) Coverage decreased (-0.04%) to 61.625% when pulling **e7675bc2feb4fc54d4b9e1f19f3459047c3d1b13 on little-cui:docs** into **49428294a99f2a475203a7ceb04ce8d5754feb77 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697202#comment-16697202 ] ASF GitHub Bot commented on SCB-993: codecov-io commented on issue #498: SCB-993 Add the requirement of scctl URL: https://github.com/apache/servicecomb-service-center/pull/498#issuecomment-441254296 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=h1) Report > Merging [#498](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/49428294a99f2a475203a7ceb04ce8d5754feb77?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=tree) ```diff @@Coverage Diff @@ ## master #498 +/- ## == + Coverage 59.25% 59.27% +0.01% == Files 166 166 Lines 1388013880 == + Hits 8225 8227 +2 Misses 5072 5072 + Partials 583 581 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/498/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.4% <0%> (-0.56%)` | :arrow_down: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/498/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `34.28% <0%> (+0.57%)` | :arrow_up: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/498/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [...erver/plugin/pkg/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/498/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2ZpbGVfY29sbGVjdG9yLmdv) | `64.07% <0%> (+0.97%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=footer). Last update [4942829...e7675bc](https://codecov.io/gh/apache/servicecomb-service-center/pull/498?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697172#comment-16697172 ] ASF GitHub Bot commented on SCB-993: little-cui opened a new pull request #498: SCB-993 Add the requirement of scctl URL: https://github.com/apache/servicecomb-service-center/pull/498 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697174#comment-16697174 ] ASF GitHub Bot commented on SCB-993: little-cui commented on issue #498: SCB-993 Add the requirement of scctl URL: https://github.com/apache/servicecomb-service-center/pull/498#issuecomment-441249300 #497 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[
https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694761#comment-16694761
]
ASF GitHub Bot commented on SCB-993:
little-cui closed pull request #493: SCB-993 search sc cluster when key
mismatch with aggregator cache
URL: https://github.com/apache/servicecomb-service-center/pull/493
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/pkg/cache/cache_test.go b/pkg/cache/cache_test.go
index 331666ea..bfd337ef 100644
--- a/pkg/cache/cache_test.go
+++ b/pkg/cache/cache_test.go
@@ -26,12 +26,12 @@ import (
type level1 struct {
}
-func (l *level1) Name(ctx context.Context) string {
+func (l *level1) Name(ctx context.Context, _ *Node) string {
return ctx.Value("key1").(string)
}
func (l *level1) Init(ctx context.Context, parent *Node) (node *Node, err
error) {
- p := l.Name(ctx)
+ p := l.Name(ctx, parent)
if p == "err" {
return nil, fmt.Errorf("wrong logic")
}
@@ -51,7 +51,7 @@ type level2 struct {
changed string
}
-func (l *level2) Name(ctx context.Context) string {
+func (l *level2) Name(ctx context.Context, _ *Node) string {
return ctx.Value("key2").(string)
}
@@ -60,7 +60,7 @@ func (l *level2) Init(ctx context.Context, parent *Node)
(node *Node, err error)
return
}
- p := l.Name(ctx)
+ p := l.Name(ctx, parent)
if p == "err" {
return nil, fmt.Errorf("wrong logic")
}
diff --git a/pkg/cache/filter.go b/pkg/cache/filter.go
index 51c64481..9652fcf9 100644
--- a/pkg/cache/filter.go
+++ b/pkg/cache/filter.go
@@ -19,6 +19,6 @@ package cache
import "golang.org/x/net/context"
type Filter interface {
- Name(ctx context.Context) string
+ Name(ctx context.Context, parent *Node) string
Init(ctx context.Context, parent *Node) (*Node, error)
}
diff --git a/pkg/cache/tree.go b/pkg/cache/tree.go
index 9c89df08..d9adcf57 100644
--- a/pkg/cache/tree.go
+++ b/pkg/cache/tree.go
@@ -77,7 +77,7 @@ func (t *Tree) Remove(ctx context.Context) {
return
}
- t.roots.Delete(t.filters[0].Name(ctx))
+ t.roots.Delete(t.filters[0].Name(ctx, nil))
}
func (t *Tree) getOrCreateRoot(ctx context.Context) (node *Node, err error) {
@@ -86,7 +86,7 @@ func (t *Tree) getOrCreateRoot(ctx context.Context) (node
*Node, err error) {
}
filter := t.filters[0]
- name := filter.Name(ctx)
+ name := filter.Name(ctx, nil)
item, err := t.roots.Fetch(name, t.Config.TTL(), func() (interface{},
error) {
node, err := t.getOrCreateNode(ctx, 0, nil)
if err != nil {
@@ -108,7 +108,7 @@ func (t *Tree) getOrCreateRoot(ctx context.Context) (node
*Node, err error) {
func (t *Tree) getOrCreateNode(ctx context.Context, idx int, parent *Node)
(node *Node, err error) {
filter := t.filters[idx]
- name := t.nodeFullName(filter.Name(ctx), parent)
+ name := t.nodeFullName(filter.Name(ctx, parent), parent)
if parent == nil {
// new a temp node
diff --git a/pkg/client/sc/apis.go b/pkg/client/sc/apis.go
index e0103af1..3fb8f1a5 100644
--- a/pkg/client/sc/apis.go
+++ b/pkg/client/sc/apis.go
@@ -25,17 +25,22 @@ import (
scerr "github.com/apache/servicecomb-service-center/server/error"
"github.com/apache/servicecomb-service-center/server/plugin/pkg/registry"
"github.com/apache/servicecomb-service-center/version"
+ "golang.org/x/net/context"
"io/ioutil"
"net/http"
)
const (
- apiVersionURL = "/version"
- apiDumpURL = "/v4/default/admin/dump"
- apiClustersURL = "/v4/default/admin/clusters"
- apiHealthURL = "/v4/default/registry/health"
- apiSchemasURL = "/v4/%s/registry/microservices/%s/schemas"
- apiSchemaURL = "/v4/%s/registry/microservices/%s/schemas/%s"
+ apiVersionURL = "/version"
+ apiDumpURL = "/v4/default/admin/dump"
+ apiClustersURL = "/v4/default/admin/clusters"
+ apiHealthURL= "/v4/default/registry/health"
+ apiSchemasURL = "/v4/%s/registry/microservices/%s/schemas"
+ apiSchemaURL= "/v4/%s/registry/microservices/%s/schemas/%s"
+ apiInstancesURL = "/v4/%s/registry/microservices/%s/instances"
+ apiInstanceURL = "/v4/%s/registry/microservices/%s/instances/%s"
+
+ QueryGlobal = "global"
)
func (c *SCClient) toError(body []byte) *scerr.Error {
@@ -47,8 +52,18 @@ func (c *SCClient) toError(body []byte) *scerr.Error {
return message
}
-func (c *SCClient) GetScVersion() (*version.VersionSet, *scerr.Error) {
-
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694581#comment-16694581 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767176 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=h1) Report > Merging [#493](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de?src=pr=desc) will **decrease** coverage by `0.49%`. > The diff coverage is `25.44%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) ```diff @@Coverage Diff@@ ## master #493 +/- ## = - Coverage 59.74% 59.25% -0.5% = Files 165 166 +1 Lines 1379613880 +84 = - Hits 8243 8224 -19 - Misses 4973 5072 +99 - Partials 580 584 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/event/instance\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvaW5zdGFuY2VfZXZlbnRfaGFuZGxlci5nbw==) | `7.54% <0%> (-0.3%)` | :arrow_down: | | [pkg/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-cGtnL3V0aWwvdXRpbC5nbw==) | `62.02% <0%> (-4.2%)` | :arrow_down: | | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (-35%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | :arrow_up: | | [server/service/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC91dGlsLmdv) | `80% <0%> (-10%)` | :arrow_down: | | [server/service/event/dependency\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvZGVwZW5kZW5jeV9ldmVudF9oYW5kbGVyLmdv) | `15.17% <0%> (-0.14%)` | :arrow_down: | | [scctl/pkg/plugin/diagnose/diagnose.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9kaWFnbm9zZS5nbw==) | `64.77% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [server/service/event/rule\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvcnVsZV9ldmVudF9oYW5kbGVyLmdv) | `8.33% <0%> (-0.37%)` | :arrow_down: | | [server/service/event/tag\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvdGFnX2V2ZW50X2hhbmRsZXIuZ28=) | `7.14% <0%> (-0.27%)` | :arrow_down: | | ... and [16 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=footer). Last update [0a0b1fd...bcee692](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694582#comment-16694582 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20221615) Coverage decreased (-0.4%) to 61.748% when pulling **bcee69265855e72151bb3c27ea91e0974f689b12 on little-cui:bug** into **0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694361#comment-16694361 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20218501) Coverage decreased (-0.4%) to 61.759% when pulling **84e1d2b3c98141d89c8ac4cec058eeff69ccb6b6 on little-cui:bug** into **0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694360#comment-16694360 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767176 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=h1) Report > Merging [#493](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de?src=pr=desc) will **decrease** coverage by `0.52%`. > The diff coverage is `25.44%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) ```diff @@Coverage Diff @@ ## master #493 +/- ## == - Coverage 59.74% 59.22% -0.53% == Files 165 166 +1 Lines 1379613880 +84 == - Hits 8243 8220 -23 - Misses 4973 5079 +106 - Partials 580 581 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/event/instance\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvaW5zdGFuY2VfZXZlbnRfaGFuZGxlci5nbw==) | `7.54% <0%> (-0.3%)` | :arrow_down: | | [pkg/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-cGtnL3V0aWwvdXRpbC5nbw==) | `62.02% <0%> (-4.2%)` | :arrow_down: | | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (-35%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | :arrow_up: | | [server/service/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC91dGlsLmdv) | `80% <0%> (-10%)` | :arrow_down: | | [server/service/event/dependency\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvZGVwZW5kZW5jeV9ldmVudF9oYW5kbGVyLmdv) | `15.17% <0%> (-0.14%)` | :arrow_down: | | [scctl/pkg/plugin/diagnose/diagnose.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9kaWFnbm9zZS5nbw==) | `64.77% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [server/service/event/rule\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvcnVsZV9ldmVudF9oYW5kbGVyLmdv) | `8.33% <0%> (-0.37%)` | :arrow_down: | | [server/service/event/tag\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvdGFnX2V2ZW50X2hhbmRsZXIuZ28=) | `7.14% <0%> (-0.27%)` | :arrow_down: | | ... and [12 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=footer). Last update [0a0b1fd...84e1d2b](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694306#comment-16694306 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767176 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=h1) Report > Merging [#493](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de?src=pr=desc) will **decrease** coverage by `0.46%`. > The diff coverage is `25.52%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) ```diff @@Coverage Diff @@ ## master #493 +/- ## == - Coverage 59.74% 59.28% -0.47% == Files 165 166 +1 Lines 1379613879 +83 == - Hits 8243 8228 -15 - Misses 4973 5071 +98 Partials 580 580 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/event/instance\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvaW5zdGFuY2VfZXZlbnRfaGFuZGxlci5nbw==) | `7.54% <0%> (-0.3%)` | :arrow_down: | | [pkg/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-cGtnL3V0aWwvdXRpbC5nbw==) | `62.02% <0%> (-4.2%)` | :arrow_down: | | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (-35%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | :arrow_up: | | [server/service/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC91dGlsLmdv) | `80% <0%> (-10%)` | :arrow_down: | | [server/service/event/dependency\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvZGVwZW5kZW5jeV9ldmVudF9oYW5kbGVyLmdv) | `15.17% <0%> (-0.14%)` | :arrow_down: | | [scctl/pkg/plugin/diagnose/diagnose.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9kaWFnbm9zZS5nbw==) | `64.77% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [server/service/event/rule\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvcnVsZV9ldmVudF9oYW5kbGVyLmdv) | `8.33% <0%> (-0.37%)` | :arrow_down: | | [server/service/event/tag\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvdGFnX2V2ZW50X2hhbmRsZXIuZ28=) | `7.14% <0%> (-0.27%)` | :arrow_down: | | ... and [14 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=footer). Last update [0a0b1fd...b1888ba](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694305#comment-16694305 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767176 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=h1) Report > Merging [#493](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de?src=pr=desc) will **decrease** coverage by `0.46%`. > The diff coverage is `25.52%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) ```diff @@Coverage Diff @@ ## master #493 +/- ## == - Coverage 59.74% 59.28% -0.47% == Files 165 166 +1 Lines 1379613879 +83 == - Hits 8243 8228 -15 - Misses 4973 5071 +98 Partials 580 580 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/event/instance\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvaW5zdGFuY2VfZXZlbnRfaGFuZGxlci5nbw==) | `7.54% <0%> (-0.3%)` | :arrow_down: | | [pkg/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-cGtnL3V0aWwvdXRpbC5nbw==) | `62.02% <0%> (-4.2%)` | :arrow_down: | | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (-35%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | :arrow_up: | | [server/service/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC91dGlsLmdv) | `80% <0%> (-10%)` | :arrow_down: | | [server/service/event/dependency\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvZGVwZW5kZW5jeV9ldmVudF9oYW5kbGVyLmdv) | `15.17% <0%> (-0.14%)` | :arrow_down: | | [scctl/pkg/plugin/diagnose/diagnose.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9kaWFnbm9zZS5nbw==) | `64.77% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [server/service/event/rule\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvcnVsZV9ldmVudF9oYW5kbGVyLmdv) | `8.33% <0%> (-0.37%)` | :arrow_down: | | [server/service/event/tag\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvdGFnX2V2ZW50X2hhbmRsZXIuZ28=) | `7.14% <0%> (-0.27%)` | :arrow_down: | | ... and [14 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=footer). Last update [0a0b1fd...b1888ba](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694304#comment-16694304 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20217748) Coverage decreased (-0.6%) to 61.565% when pulling **b1888ba4d66c3aba5af8db27f25d7a24a64a58b6 on little-cui:bug** into **0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694303#comment-16694303 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20217736) Coverage decreased (-0.4%) to 61.797% when pulling **b1888ba4d66c3aba5af8db27f25d7a24a64a58b6 on little-cui:bug** into **0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694095#comment-16694095 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20215170) Coverage decreased (-0.4%) to 61.723% when pulling **848dc76627a5e558fabfdff024e986715dc7f74f on little-cui:bug** into **0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694093#comment-16694093 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767176 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=h1) Report > Merging [#493](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de?src=pr=desc) will **decrease** coverage by `0.43%`. > The diff coverage is `27.07%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) ```diff @@Coverage Diff @@ ## master #493 +/- ## == - Coverage 59.74% 59.31% -0.44% == Files 165 166 +1 Lines 1379613867 +71 == - Hits 8243 8225 -18 - Misses 4973 5059 +86 - Partials 580 583 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) | Coverage Δ | | |---|---|---| | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (-35%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | :arrow_up: | | [scctl/pkg/plugin/diagnose/diagnose.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9kaWFnbm9zZS5nbw==) | `64.77% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `8% <10.2%> (-6.29%)` | :arrow_down: | | [server/plugin/pkg/discovery/etcd/indexer\_etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9ldGNkLmdv) | `100% <100%> (ø)` | :arrow_up: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `46.98% <100%> (-1.56%)` | :arrow_down: | | [pkg/cache/tree.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-cGtnL2NhY2hlL3RyZWUuZ28=) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlci5nbw==) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/etcd/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9jYWNoZS5nbw==) | `88.23% <100%> (-1.77%)` | :arrow_down: | | ... and [8 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=footer). Last update [0a0b1fd...848dc76](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To
[jira] [Commented] (SCB-993) Bug fixes
[
https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693933#comment-16693933
]
ASF GitHub Bot commented on SCB-993:
little-cui commented on a change in pull request #493: WIP: SCB-993 search sc
cluster when key mismatch with aggregator cache
URL:
https://github.com/apache/servicecomb-service-center/pull/493#discussion_r235216627
##
File path: server/plugin/pkg/discovery/aggregate/indexer.go
##
@@ -42,15 +43,24 @@ func (i *AdaptorsIndexer) Search(ctx context.Context, opts
...registry.PluginOpO
if _, ok := exists[key]; !ok {
Review comment:
Add cache searching here
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Bug fixes
> -
>
> Key: SCB-993
> URL: https://issues.apache.org/jira/browse/SCB-993
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[
https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693929#comment-16693929
]
ASF GitHub Bot commented on SCB-993:
little-cui commented on a change in pull request #493: WIP: SCB-993 search sc
cluster when key mismatch with aggregator cache
URL:
https://github.com/apache/servicecomb-service-center/pull/493#discussion_r235215710
##
File path: server/service/notification/websocket.go
##
@@ -181,7 +181,9 @@ func (wh *WebSocket) HandleWatchWebSocketJob(o
interface{}) {
message = util.StringToBytesWithNoCopy(fmt.Sprintf("watcher
catch an err: %s", err.Error()))
case time.Time:
domainProject := util.ParseDomainProject(wh.ctx)
- if !serviceUtil.ServiceExist(wh.ctx, domainProject,
wh.watcher.Group()) {
+ if !serviceUtil.ServiceExist(
+ context.WithValue(wh.ctx, serviceUtil.CTX_REGISTRYONLY,
"1"),
+ domainProject, wh.watcher.Group()) {
Review comment:
error logic, we don’t only require consumer registered locally
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Bug fixes
> -
>
> Key: SCB-993
> URL: https://issues.apache.org/jira/browse/SCB-993
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693511#comment-16693511 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20205928) Coverage decreased (-0.5%) to 61.653% when pulling **ea8bf4acbd7a6ad2df2c045c3bc825797b44fde8 on little-cui:bug** into **0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693509#comment-16693509 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767176 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=h1) Report > Merging [#493](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de?src=pr=desc) will **decrease** coverage by `0.42%`. > The diff coverage is `27.76%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) ```diff @@Coverage Diff @@ ## master #493 +/- ## == - Coverage 59.74% 59.31% -0.43% == Files 165 166 +1 Lines 1379613869 +73 == - Hits 8243 8227 -16 - Misses 4973 5059 +86 - Partials 580 583 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) | Coverage Δ | | |---|---|---| | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (-35%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | :arrow_up: | | [scctl/pkg/plugin/diagnose/diagnose.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9kaWFnbm9zZS5nbw==) | `64.77% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `8% <10.2%> (-6.29%)` | :arrow_down: | | [server/plugin/pkg/discovery/etcd/indexer\_etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9ldGNkLmdv) | `100% <100%> (ø)` | :arrow_up: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `46.98% <100%> (-1.56%)` | :arrow_down: | | [pkg/cache/tree.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-cGtnL2NhY2hlL3RyZWUuZ28=) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlci5nbw==) | `100% <100%> (ø)` | :arrow_up: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.07% <100%> (-0.44%)` | :arrow_down: | | ... and [9 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=footer). Last update [0a0b1fd...ea8bf4a](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message,
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693323#comment-16693323 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20202735) Coverage decreased (-0.5%) to 61.686% when pulling **8199895e5b31bdc18e27eff6e3f55cb359e2a773 on little-cui:bug** into **0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693318#comment-16693318 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767176 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=h1) Report > Merging [#493](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de?src=pr=desc) will **decrease** coverage by `0.44%`. > The diff coverage is `27.24%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) ```diff @@Coverage Diff@@ ## master#493 +/- ## = - Coverage 59.74% 59.3% -0.45% = Files 165 166 +1 Lines 13796 13865 +69 = - Hits 82438222 -21 - Misses 49735057 +84 - Partials 580 586 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) | Coverage Δ | | |---|---|---| | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (-35%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | :arrow_up: | | [scctl/pkg/plugin/diagnose/diagnose.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9kaWFnbm9zZS5nbw==) | `64.77% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `8% <10.2%> (-6.29%)` | :arrow_down: | | [server/plugin/pkg/discovery/etcd/indexer\_etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9ldGNkLmdv) | `100% <100%> (ø)` | :arrow_up: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `46.98% <100%> (-1.56%)` | :arrow_down: | | [pkg/cache/tree.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-cGtnL2NhY2hlL3RyZWUuZ28=) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlci5nbw==) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/etcd/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9jYWNoZS5nbw==) | `88.23% <100%> (-1.77%)` | :arrow_down: | | ... and [9 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=footer). Last update [0a0b1fd...8199895](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692538#comment-16692538 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #493: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767176 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=h1) Report > Merging [#493](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/5cec4bafcfe1f111de44efd47e2aff22843921ff?src=pr=desc) will **decrease** coverage by `0.4%`. > The diff coverage is `27%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) ```diff @@Coverage Diff @@ ## master #493 +/- ## == - Coverage 59.72% 59.31% -0.41% == Files 165 166 +1 Lines 1379613865 +69 == - Hits 8239 8224 -15 - Misses 4973 5057 +84 Partials 584 584 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) | Coverage Δ | | |---|---|---| | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (-35%)` | :arrow_down: | | [scctl/pkg/plugin/diagnose/diagnose.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9kaWFnbm9zZS5nbw==) | `64.77% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `8% <10.2%> (-6.29%)` | :arrow_down: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `46.98% <100%> (-1.56%)` | :arrow_down: | | [pkg/cache/tree.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-cGtnL2NhY2hlL3RyZWUuZ28=) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlci5nbw==) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/etcd/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9jYWNoZS5nbw==) | `88.23% <100%> (-1.77%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/syncer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvc3luY2VyLmdv) | `42.74% <42.74%> (ø)` | | | ... and [4 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=footer). Last update [5cec4ba...8ec7aba](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692537#comment-16692537 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #493: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20193166) Coverage decreased (-0.5%) to 61.674% when pulling **8ec7ababd1be86d6d675e9da908c5eab814dda5c on little-cui:bug** into **5cec4bafcfe1f111de44efd47e2aff22843921ff on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691889#comment-16691889 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20182133) Coverage decreased (-0.3%) to 61.841% when pulling **16d080b0f2d912226cc24dde179f889d8a5a0595 on little-cui:bug** into **5cec4bafcfe1f111de44efd47e2aff22843921ff on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691888#comment-16691888 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767176 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=h1) Report > Merging [#493](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/5cec4bafcfe1f111de44efd47e2aff22843921ff?src=pr=desc) will **decrease** coverage by `0.39%`. > The diff coverage is `27%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) ```diff @@Coverage Diff@@ ## master #493 +/- ## = - Coverage 59.72% 59.32% -0.4% = Files 165 166 +1 Lines 1379613865 +69 = - Hits 8239 8226 -13 - Misses 4973 5057 +84 + Partials 584 582 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) | Coverage Δ | | |---|---|---| | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (-35%)` | :arrow_down: | | [scctl/pkg/plugin/diagnose/diagnose.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9kaWFnbm9zZS5nbw==) | `64.77% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `8% <10.2%> (-6.29%)` | :arrow_down: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `46.98% <100%> (-1.56%)` | :arrow_down: | | [pkg/cache/tree.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-cGtnL2NhY2hlL3RyZWUuZ28=) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlci5nbw==) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/etcd/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9jYWNoZS5nbw==) | `88.23% <100%> (-1.77%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/syncer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvc3luY2VyLmdv) | `42.74% <42.74%> (ø)` | | | ... and [6 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=footer). Last update [5cec4ba...16d080b](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691239#comment-16691239 ] ASF GitHub Bot commented on SCB-993: codecov-io commented on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767176 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=h1) Report > Merging [#493](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/413eacb2ec3a0b24344f439afaf4737822e06c2e?src=pr=desc) will **decrease** coverage by `0.36%`. > The diff coverage is `24.63%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) ```diff @@Coverage Diff @@ ## master #493 +/- ## == - Coverage 59.72% 59.36% -0.37% == Files 165 166 +1 Lines 1379613873 +77 == - Hits 8240 8236 -4 - Misses 4973 5052 +79 - Partials 583 585 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) | Coverage Δ | | |---|---|---| | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (-35%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | :arrow_up: | | [scctl/pkg/plugin/diagnose/diagnose.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9kaWFnbm9zZS5nbw==) | `64.77% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/etcd/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9jYWNoZS5nbw==) | `88.23% <100%> (-1.77%)` | :arrow_down: | | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `8.33% <11.9%> (-5.96%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/syncer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvc3luY2VyLmdv) | `42.74% <42.74%> (ø)` | | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.58% <0%> (-0.95%)` | :arrow_down: | | [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.4% <0%> (-0.56%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.6% <0%> (-0.34%)` | :arrow_down: | | ... and [2 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=footer). Last update [413eacb...80b990b](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691240#comment-16691240 ] ASF GitHub Bot commented on SCB-993: coveralls commented on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20172540) Coverage decreased (-0.4%) to 61.698% when pulling **80b990b2e348f90d324484079bbeb5994a50debe on little-cui:bug** into **413eacb2ec3a0b24344f439afaf4737822e06c2e on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691224#comment-16691224 ] ASF GitHub Bot commented on SCB-993: little-cui opened a new pull request #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689186#comment-16689186 ] ASF GitHub Bot commented on SCB-993: little-cui closed pull request #492: SCB-993 Update the document of docker-compose URL: https://github.com/apache/servicecomb-service-center/pull/492 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/examples/infrastructures/docker/docker-compose.yml b/examples/infrastructures/docker/docker-compose.yml index 964837ef..bab0ac45 100644 --- a/examples/infrastructures/docker/docker-compose.yml +++ b/examples/infrastructures/docker/docker-compose.yml @@ -20,25 +20,23 @@ services: volumes: - grafana_data:/var/lib/grafana - etcd: -image: 'quay.io/coreos/etcd:latest' -# restart: always -environment: - ETCD_ADVERTISE_CLIENT_URLS: http://etcd:2379 - ETCD_LISTEN_CLIENT_URLS: http://0.0.0.0:2379 - ETCD_INITIAL_ADVERTISE_PEER_URLS: http://etcd:2380 - ETCD_LISTEN_PEER_URLS: http://0.0.0.0:2380 - ETCD_INITIAL_CLUSTER: default=http://etcd:2380 + #etcd: + # image: 'quay.io/coreos/etcd:latest' + # # restart: always + # environment: + #ETCD_ADVERTISE_CLIENT_URLS: http://etcd:2379 + #ETCD_LISTEN_CLIENT_URLS: http://0.0.0.0:2379 + #ETCD_INITIAL_ADVERTISE_PEER_URLS: http://etcd:2380 + #ETCD_LISTEN_PEER_URLS: http://0.0.0.0:2380 + #ETCD_INITIAL_CLUSTER: default=http://etcd:2380 service-center: -depends_on: - - etcd image: 'servicecomb/service-center:latest' # restart: always ports: - "30100:30100" -environment: - BACKEND_ADDRESS: etcd:2379 + # environment: + #BACKEND_ADDRESS: etcd:2379 scfrontend: depends_on: diff --git a/scripts/docker/README.md b/scripts/docker/README.md index d98d529d..f8f7023b 100644 --- a/scripts/docker/README.md +++ b/scripts/docker/README.md @@ -4,6 +4,10 @@ For Making docker images for Service-Center you can refer to this [doc](/scripts For Making the Front-end images you can refer to this [doc](/scripts/docker/build-frontend-image) -After Making the images, you can run the following command at the PROJECT_ROOT to startup all +After Making the images, you can run the following command at the `PROJECT_ROOT` to startup all -docker-compose up \ No newline at end of file +```bash +# the directory of docker-compose.yml file +cd examples/infrastructures/docker +docker-compose up +``` \ No newline at end of file This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689158#comment-16689158 ] ASF GitHub Bot commented on SCB-993: coveralls commented on issue #492: SCB-993 Update the document of docker-compose URL: https://github.com/apache/servicecomb-service-center/pull/492#issuecomment-439317638 [](https://coveralls.io/builds/20140242) Coverage decreased (-0.0008%) to 62.255% when pulling **2792fc887c0ac8ddf0fa0dff1f66bef3670ad40c on little-cui:master** into **b3a10ee821c609180d1282b19ae9b9e38d2c9a7b on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689157#comment-16689157 ] ASF GitHub Bot commented on SCB-993: codecov-io commented on issue #492: SCB-993 Update the document of docker-compose URL: https://github.com/apache/servicecomb-service-center/pull/492#issuecomment-439317517 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/492?src=pr=h1) Report > Merging [#492](https://codecov.io/gh/apache/servicecomb-service-center/pull/492?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/b3a10ee821c609180d1282b19ae9b9e38d2c9a7b?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/492?src=pr=tree) ```diff @@Coverage Diff @@ ## master #492 +/- ## == - Coverage 59.74% 59.72% -0.03% == Files 165 165 Lines 1379613796 == - Hits 8242 8239 -3 Misses 4973 4973 - Partials 581 584 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/492?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/492/diff?src=pr=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.58% <0%> (-0.95%)` | :arrow_down: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/492/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `83.87% <0%> (-0.65%)` | :arrow_down: | | [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/492/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.4% <0%> (-0.56%)` | :arrow_down: | | [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/492/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `86.17% <0%> (-0.19%)` | :arrow_down: | | [pkg/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/492/diff?src=pr=tree#diff-cGtnL3V0aWwvdXRpbC5nbw==) | `67.56% <0%> (+1.35%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/492?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/492?src=pr=footer). Last update [b3a10ee...2792fc8](https://codecov.io/gh/apache/servicecomb-service-center/pull/492?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689140#comment-16689140 ] ASF GitHub Bot commented on SCB-993: little-cui opened a new pull request #492: SCB-993 Update the document of docker-compose URL: https://github.com/apache/servicecomb-service-center/pull/492 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[
https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686646#comment-16686646
]
ASF GitHub Bot commented on SCB-993:
little-cui closed pull request #487: SCB-993 Fixed the error of microservice
registration in multi-dc
URL: https://github.com/apache/servicecomb-service-center/pull/487
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/server/admin/admin_suite_test.go b/server/admin/admin_suite_test.go
index 8053859a..9c11b874 100644
--- a/server/admin/admin_suite_test.go
+++ b/server/admin/admin_suite_test.go
@@ -20,6 +20,7 @@ import _
"github.com/apache/servicecomb-service-center/server/init"
import _ "github.com/apache/servicecomb-service-center/server/bootstrap"
import (
"github.com/apache/servicecomb-service-center/pkg/util"
+ serviceUtil
"github.com/apache/servicecomb-service-center/server/service/util"
"github.com/astaxie/beego"
. "github.com/onsi/ginkgo"
"github.com/onsi/ginkgo/reporters"
@@ -45,5 +46,5 @@ var _ = BeforeSuite(func() {
func getContext() context.Context {
return util.SetContext(
util.SetDomainProject(context.Background(), "default",
"default"),
- "noCache", "1")
+ serviceUtil.CTX_NOCACHE, "1")
}
diff --git a/server/core/microservice.go b/server/core/microservice.go
index 25765a1a..9331e2c1 100644
--- a/server/core/microservice.go
+++ b/server/core/microservice.go
@@ -45,7 +45,8 @@ const (
REGISTRY_DEFAULT_LEASE_RENEWALINTERVAL int32 = 30
REGISTRY_DEFAULT_LEASE_RETRYTIMES int32 = 3
- IS_SC_SELF = "sc_self"
+ CTX_SC_SELF = "_sc_self"
+ CTX_SC_REGISTRY = "_registryOnly"
)
func init() {
@@ -85,9 +86,10 @@ func prepareSelfRegistration() {
}
func AddDefaultContextValue(ctx context.Context) context.Context {
- return util.SetContext(
- util.SetDomainProject(ctx, REGISTRY_DOMAIN, REGISTRY_PROJECT),
- IS_SC_SELF, true)
+ return util.SetContext(util.SetContext(util.SetDomainProject(ctx,
+ REGISTRY_DOMAIN, REGISTRY_PROJECT),
+ CTX_SC_SELF, true),
+ CTX_SC_REGISTRY, "1")
}
func IsDefaultDomainProject(domainProject string) bool {
@@ -116,7 +118,7 @@ func IsShared(key *pb.MicroServiceKey) bool {
}
func IsSCInstance(ctx context.Context) bool {
- b, _ := ctx.Value(IS_SC_SELF).(bool)
+ b, _ := ctx.Value(CTX_SC_SELF).(bool)
return b
}
diff --git a/server/govern/govern_suite_test.go
b/server/govern/govern_suite_test.go
index 2b20ef0d..0954f22f 100644
--- a/server/govern/govern_suite_test.go
+++ b/server/govern/govern_suite_test.go
@@ -25,6 +25,7 @@ import (
pb "github.com/apache/servicecomb-service-center/server/core/proto"
"github.com/apache/servicecomb-service-center/server/govern"
"github.com/apache/servicecomb-service-center/server/service"
+ serviceUtil
"github.com/apache/servicecomb-service-center/server/service/util"
"github.com/astaxie/beego"
. "github.com/onsi/ginkgo"
"github.com/onsi/ginkgo/reporters"
@@ -54,5 +55,5 @@ var _ = BeforeSuite(func() {
func getContext() context.Context {
return util.SetContext(
util.SetDomainProject(context.Background(), "default",
"default"),
- "noCache", "1")
+ serviceUtil.CTX_NOCACHE, "1")
}
diff --git a/server/handler/cache/cache.go b/server/handler/cache/cache.go
index 7bda9d4f..4bb6fd5d 100644
--- a/server/handler/cache/cache.go
+++ b/server/handler/cache/cache.go
@@ -32,6 +32,10 @@ func (l *CacheResponse) Handle(i *chain.Invocation) {
r := i.Context().Value(rest.CTX_REQUEST).(*http.Request)
query := r.URL.Query()
+ if r.Method != http.MethodGet {
+ i.WithContext(serviceUtil.CTX_REGISTRYONLY, "1")
+ }
+
noCache := query.Get(serviceUtil.CTX_NOCACHE) == "1"
if noCache {
i.WithContext(serviceUtil.CTX_NOCACHE, "1")
diff --git a/server/plugin/pkg/discovery/aggregate/adaptor.go
b/server/plugin/pkg/discovery/aggregate/adaptor.go
index 6efb2c5c..e56e7c38 100644
--- a/server/plugin/pkg/discovery/aggregate/adaptor.go
+++ b/server/plugin/pkg/discovery/aggregate/adaptor.go
@@ -26,6 +26,7 @@ import (
// Aggregator is a discovery service adaptor implement of one registry cluster
type Aggregator struct {
discovery.Indexer
+ Type discovery.Type
Adaptors []discovery.Adaptor
}
@@ -81,21 +82,16 @@ func getLogConflictFunc(t discovery.Type) func(origin,
conflict *discovery.KeyVa
}
func NewAggregator(t discovery.Type, cfg *discovery.Config) *Aggregator {
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686254#comment-16686254 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #487: SCB-993 Fixed the error of microservice registration in multi-dc URL: https://github.com/apache/servicecomb-service-center/pull/487#issuecomment-438181672 [](https://coveralls.io/builds/20095238) Coverage decreased (-0.7%) to 62.127% when pulling **7bf51f96f28e4f2e5f8eba61faf942423149cea5 on little-cui:master** into **09040b90d0dc3c87f976caec1e0b6d2c5b1d86db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686250#comment-16686250 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #487: SCB-993 Fixed the error of microservice registration in multi-dc URL: https://github.com/apache/servicecomb-service-center/pull/487#issuecomment-438181426 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=h1) Report > Merging [#487](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/09040b90d0dc3c87f976caec1e0b6d2c5b1d86db?src=pr=desc) will **decrease** coverage by `0.64%`. > The diff coverage is `25%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=tree) ```diff @@Coverage Diff @@ ## master #487 +/- ## == - Coverage 60.32% 59.68% -0.65% == Files 159 165 +6 Lines 1353413796 +262 == + Hits 8165 8234 +69 - Misses 4787 4980 +193 Partials 582 582 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC91dGlsLmdv) | `80% <0%> (-20%)` | :arrow_down: | | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `14.28% <0%> (ø)` | | | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `35% <100%> (ø)` | | | [server/core/microservice.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvbWljcm9zZXJ2aWNlLmdv) | `70.27% <20%> (-0.97%)` | :arrow_down: | | [server/service/notification/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2xpc3R3YXRjaGVyLmdv) | `69.01% <0%> (-9.86%)` | :arrow_down: | | [server/plugin/pkg/discovery/servicecenter/repo.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvcmVwby5nbw==) | `33.33% <0%> (ø)` | | | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | | | [...erver/plugin/pkg/discovery/servicecenter/common.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY29tbW9uLmdv) | `100% <0%> (ø)` | | | ... and [5 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=footer). Last update [09040b9...7bf51f9](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL:
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685422#comment-16685422 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #487: SCB-993 Fixed the error of microservice registration in multi-dc URL: https://github.com/apache/servicecomb-service-center/pull/487#issuecomment-438181672 [](https://coveralls.io/builds/20079398) Coverage decreased (-0.08%) to 62.783% when pulling **dfffe333979ddb794c36dab21c675cd4048b430f on little-cui:master** into **c3f06f1b40f8e3cb2f4fa60bcdf02e447e3aba40 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684884#comment-16684884 ] ASF GitHub Bot commented on SCB-993: coveralls commented on issue #487: WIP SCB-993 Fixed the error of microservice registration in multi-dc URL: https://github.com/apache/servicecomb-service-center/pull/487#issuecomment-438181672 [](https://coveralls.io/builds/20071064) Coverage decreased (-0.2%) to 62.684% when pulling **be0335d0a7afbe72a1fe6bb24ffc164ea4a787d5 on little-cui:master** into **c3f06f1b40f8e3cb2f4fa60bcdf02e447e3aba40 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684882#comment-16684882 ] ASF GitHub Bot commented on SCB-993: codecov-io commented on issue #487: WIP SCB-993 Fixed the error of microservice registration in multi-dc URL: https://github.com/apache/servicecomb-service-center/pull/487#issuecomment-438181426 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=h1) Report > Merging [#487](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/c3f06f1b40f8e3cb2f4fa60bcdf02e447e3aba40?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `14.28%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=tree) ```diff @@Coverage Diff @@ ## master #487 +/- ## == - Coverage 60.35% 60.35% -0.01% == Files 159 159 Lines 1353413537 +3 == + Hits 8169 8170 +1 - Misses 4787 4789 +2 Partials 578 578 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC91dGlsLmdv) | `80% <0%> (-20%)` | :arrow_down: | | [server/core/microservice.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvbWljcm9zZXJ2aWNlLmdv) | `70.27% <20%> (-0.97%)` | :arrow_down: | | [server/service/instance.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `67.61% <0%> (-0.2%)` | :arrow_down: | | [server/broker/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.78% <0%> (-0.16%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.93% <0%> (+0.33%)` | :arrow_up: | | [scctl/pkg/plugin/diagnose/compare\_holder.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9jb21wYXJlX2hvbGRlci5nbw==) | `96.15% <0%> (+1.28%)` | :arrow_up: | | [server/service/util/tag\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/487/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `65.38% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=footer). Last update [c3f06f1...be0335d](https://codecov.io/gh/apache/servicecomb-service-center/pull/487?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684850#comment-16684850 ] ASF GitHub Bot commented on SCB-993: little-cui opened a new pull request #487: SCB-993 Fixed the error of microservice registration in multi-dc URL: https://github.com/apache/servicecomb-service-center/pull/487 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684831#comment-16684831 ] ASF GitHub Bot commented on SCB-993: asifdxtreme closed pull request #486: SCB-993 Update the design document URL: https://github.com/apache/servicecomb-service-center/pull/486 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/aggregator-design.PNG b/docs/aggregator-design.PNG index 5f67d1ab..06b4bf72 100644 Binary files a/docs/aggregator-design.PNG and b/docs/aggregator-design.PNG differ diff --git a/docs/design.md b/docs/design.md index 12c73f69..9268fa76 100644 --- a/docs/design.md +++ b/docs/design.md @@ -1,10 +1,18 @@ ## Service-Center Design Service-Center(SC) is a service registry that allows services to register their instance information and to discover providers of a given service. -SC uses etcd to store all the information of micro-service and its instances. Below is the diagram stating the working principles and flow of SC. +Generally, SC uses etcd to store all the information of micro-service and its instances. + + + +Below is the diagram stating the working principles and flow of SC. On StartUp -Here we assume that micro-services are written using [java-chassis](https://github.com/ServiceComb/java-chassis) sdk. So when micro-service boots up then java-chassis sdk does the following list of tasks. +Here describes a standard client registration process. +We assume that micro-services are written using +[java-chassis](https://github.com/ServiceComb/java-chassis) sdk or +[go-chassis](https://github.com/go-chassis/go-chassis) sdk. +So when micro-service boots up then java-chassis sdk does the following list of tasks. 1. On startup provider registers the micro-service to SC if not registered earlier and also register its instance information like its Ip and Port on which instance is running. 2. SC stores the provider information in etcd. @@ -23,4 +31,4 @@ Provider instance regularly sends heartbeat signal every 30 seconds to SC, if SC Consumer watches the information of provider instances from SC and if there is any change then the cache is updated. When Consumer needs to communicate to Provider then consumer reads endpoints of the provider instances from cache and do loadbalancing to communicate to Provider. -Note: This document is in beta stage, feel free to contribute to this document. +Note: Feel free to contribute to this document. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684837#comment-16684837 ] ASF GitHub Bot commented on SCB-993: coveralls commented on issue #486: SCB-993 Update the design document URL: https://github.com/apache/servicecomb-service-center/pull/486#issuecomment-438171719 [](https://coveralls.io/builds/20070694) Coverage decreased (-0.03%) to 62.735% when pulling **032b28dd5a41adf56ec98286480a83dfc411eec9 on little-cui:docs** into **b6e54063a7c1cfdd89453bbdcf08d57f06c6a9f7 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684818#comment-16684818 ] ASF GitHub Bot commented on SCB-993: little-cui opened a new pull request #486: SCB-993 Update the design document URL: https://github.com/apache/servicecomb-service-center/pull/486 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[
https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680690#comment-16680690
]
ASF GitHub Bot commented on SCB-993:
little-cui closed pull request #481: SCB-993 print warning log when aggregate
conflict
URL: https://github.com/apache/servicecomb-service-center/pull/481
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/pkg/client/sc/client.go b/pkg/client/sc/client.go
index 38ab11bd..18ee9db2 100644
--- a/pkg/client/sc/client.go
+++ b/pkg/client/sc/client.go
@@ -24,18 +24,18 @@ func NewSCClient(cfg Config) (*SCClient, error) {
if err != nil {
return nil, err
}
- return {LBClient: client, Token: cfg.Token}, nil
+ return {LBClient: client, Cfg: cfg}, nil
}
type SCClient struct {
*LBClient
- Token string
+ Cfg Config
}
func (c *SCClient) CommonHeaders() http.Header {
var headers = make(http.Header)
- if len(c.Token) > 0 {
- headers.Set("X-Auth-Token", c.Token)
+ if len(c.Cfg.Token) > 0 {
+ headers.Set("X-Auth-Token", c.Cfg.Token)
}
return headers
}
diff --git a/pkg/client/sc/config.go b/pkg/client/sc/config.go
index f78845b2..9cbc0c60 100644
--- a/pkg/client/sc/config.go
+++ b/pkg/client/sc/config.go
@@ -22,8 +22,11 @@ import (
"time"
)
+const defaultRequestTimeout = 10 * time.Second
+
type Config struct {
rest.URLClientOption
+ Name string
Endpoints []string
// TODO Expandable header not only token header
Token string
@@ -38,7 +41,7 @@ func (cfg *Config) Merge() rest.URLClientOption {
}
cfg.SSLEnabled = ssl
if cfg.RequestTimeout == 0 {
- cfg.RequestTimeout = 10 * time.Second
+ cfg.RequestTimeout = defaultRequestTimeout
}
return cfg.URLClientOption
}
diff --git a/server/admin/model/dump.go b/server/admin/model/dump.go
index 461be7ec..6165c53b 100644
--- a/server/admin/model/dump.go
+++ b/server/admin/model/dump.go
@@ -161,9 +161,10 @@ type Cache struct {
}
type KV struct {
- Key string `json:"key"`
- Rev int64 `json:"rev"`
- Value interface{} `json:"-"`
+ Key string `json:"key"`
+ Rev int64 `json:"rev"`
+ Value interface{} `json:"-"`
+ ClusterName string `json:"cluster"`
}
type Microservice struct {
diff --git a/server/admin/service.go b/server/admin/service.go
index 6255f382..90c6d9e3 100644
--- a/server/admin/service.go
+++ b/server/admin/service.go
@@ -95,13 +95,13 @@ func (service *AdminService) dumpAll(ctx context.Context,
cache *model.Cache) {
}
func setValue(e discovery.Adaptor, setter model.Setter) {
- exists := make(map[string]struct{})
e.Cache().ForEach(func(k string, kv *discovery.KeyValue) (next bool) {
- if _, ok := exists[k]; ok {
- return true
- }
- exists[k] = struct{}{}
- setter.SetValue({Key: k, Rev: kv.ModRevision, Value:
kv.Value})
+ setter.SetValue({
+ Key: k,
+ Rev: kv.ModRevision,
+ Value: kv.Value,
+ ClusterName: kv.ClusterName,
+ })
return true
})
}
diff --git a/server/core/key_convertor.go b/server/core/key_convertor.go
index 296b727f..d0730986 100644
--- a/server/core/key_convertor.go
+++ b/server/core/key_convertor.go
@@ -108,6 +108,10 @@ func GetInfoFromSvcIndexKV(key []byte) *pb.MicroServiceKey
{
}
}
+func GetInfoFromSvcAliasKV(key []byte) *pb.MicroServiceKey {
+ return GetInfoFromSvcIndexKV(key)
+}
+
func GetInfoFromSchemaSummaryKV(key []byte) (domainProject, serviceId,
schemaId string) {
keys := KvToResponse(key)
l := len(keys)
diff --git a/server/plugin/pkg/discovery/aggregate/adaptor.go
b/server/plugin/pkg/discovery/aggregate/adaptor.go
index cb669806..d48e7d5b 100644
--- a/server/plugin/pkg/discovery/aggregate/adaptor.go
+++ b/server/plugin/pkg/discovery/aggregate/adaptor.go
@@ -16,69 +16,86 @@
package aggregate
import (
- "github.com/apache/incubator-servicecomb-service-center/pkg/util"
+ "github.com/apache/incubator-servicecomb-service-center/pkg/log"
+ "github.com/apache/incubator-servicecomb-service-center/server/core"
+
"github.com/apache/incubator-servicecomb-service-center/server/core/backend"
mgr
"github.com/apache/incubator-servicecomb-service-center/server/plugin"
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679524#comment-16679524 ] ASF GitHub Bot commented on SCB-993: codecov-io commented on issue #481: SCB-993 print warning log when aggregate conflict URL: https://github.com/apache/incubator-servicecomb-service-center/pull/481#issuecomment-436938114 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=h1) Report > Merging [#481](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/ea31a1a3c9fdbd242817157f61e4aad15bfa5f0f?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=tree) ```diff @@Coverage Diff @@ ## master #481 +/- ## == - Coverage 60.32% 60.31% -0.01% == Files 159 159 Lines 1352913534 +5 == + Hits 8161 8163 +2 - Misses 4789 4790 +1 - Partials 579 581 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/plugin/pkg/discovery/indexer\_cache.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2luZGV4ZXJfY2FjaGUuZ28=) | `100% <ø> (ø)` | :arrow_up: | | [server/core/key\_convertor.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL2NvcmUva2V5X2NvbnZlcnRvci5nbw==) | `91.81% <0%> (-1.71%)` | :arrow_down: | | [server/service/event/service\_event\_handler.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvc2VydmljZV9ldmVudF9oYW5kbGVyLmdv) | `12.5% <0%> (ø)` | :arrow_up: | | [server/admin/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL2FkbWluL3NlcnZpY2UuZ28=) | `66.66% <0%> (-5.08%)` | :arrow_down: | | [server/plugin/pkg/discovery/types.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3R5cGVzLmdv) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/etcd/cacher\_kv.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvY2FjaGVyX2t2Lmdv) | `67.48% <100%> (ø)` | :arrow_up: | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `67.61% <100%> (-0.07%)` | :arrow_down: | | [pkg/etcdsync/mutex.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-cGtnL2V0Y2RzeW5jL211dGV4Lmdv) | `61.29% <0%> (-5.38%)` | :arrow_down: | | [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.58% <0%> (-0.95%)` | :arrow_down: | | ... and [3 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=footer). Last update [ea31a1a...3cb34ae](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment.
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679527#comment-16679527 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #481: SCB-993 print warning log when aggregate conflict URL: https://github.com/apache/incubator-servicecomb-service-center/pull/481#issuecomment-436660133 [](https://coveralls.io/builds/19980045) Coverage decreased (-0.1%) to 62.651% when pulling **3cb34aed9abde03b42107e0ac773998e22c2dd42 on little-cui:bug** into **ea31a1a3c9fdbd242817157f61e4aad15bfa5f0f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679825#comment-16679825 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #481: SCB-993 print warning log when aggregate conflict URL: https://github.com/apache/incubator-servicecomb-service-center/pull/481#issuecomment-436938114 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=h1) Report > Merging [#481](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/ea31a1a3c9fdbd242817157f61e4aad15bfa5f0f?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=tree) ```diff @@Coverage Diff @@ ## master #481 +/- ## == + Coverage 60.32% 60.35% +0.02% == Files 159 159 Lines 1352913534 +5 == + Hits 8161 8168 +7 + Misses 4789 4787 -2 Partials 579 579 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/plugin/pkg/discovery/indexer\_cache.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2luZGV4ZXJfY2FjaGUuZ28=) | `100% <ø> (ø)` | :arrow_up: | | [server/core/key\_convertor.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL2NvcmUva2V5X2NvbnZlcnRvci5nbw==) | `91.81% <0%> (-1.71%)` | :arrow_down: | | [server/service/event/service\_event\_handler.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvc2VydmljZV9ldmVudF9oYW5kbGVyLmdv) | `12.5% <0%> (ø)` | :arrow_up: | | [server/admin/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL2FkbWluL3NlcnZpY2UuZ28=) | `66.66% <0%> (-5.08%)` | :arrow_down: | | [server/plugin/pkg/discovery/types.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3R5cGVzLmdv) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/etcd/cacher\_kv.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvY2FjaGVyX2t2Lmdv) | `67.48% <100%> (ø)` | :arrow_up: | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `67.61% <100%> (-0.07%)` | :arrow_down: | | [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: | | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.95% <0%> (+0.55%)` | :arrow_up: | | [server/service/notification/listwatcher.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2xpc3R3YXRjaGVyLmdv) | `78.87% <0%> (+9.85%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=footer). Last update [ea31a1a...f7762e2](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at:
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679826#comment-16679826 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #481: SCB-993 print warning log when aggregate conflict URL: https://github.com/apache/incubator-servicecomb-service-center/pull/481#issuecomment-436660133 [](https://coveralls.io/builds/19984563) Coverage decreased (-0.1%) to 62.653% when pulling **f7762e23c1f01962b2885943febff253bb252335 on little-cui:bug** into **ea31a1a3c9fdbd242817157f61e4aad15bfa5f0f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679794#comment-16679794 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #481: SCB-993 print warning log when aggregate conflict URL: https://github.com/apache/incubator-servicecomb-service-center/pull/481#issuecomment-436660133 [](https://coveralls.io/builds/19984076) Coverage decreased (-0.09%) to 62.675% when pulling **fd5414aa791970fb6ab415f31c7c2008233608b1 on little-cui:bug** into **ea31a1a3c9fdbd242817157f61e4aad15bfa5f0f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679793#comment-16679793 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #481: SCB-993 print warning log when aggregate conflict URL: https://github.com/apache/incubator-servicecomb-service-center/pull/481#issuecomment-436938114 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=h1) Report > Merging [#481](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/ea31a1a3c9fdbd242817157f61e4aad15bfa5f0f?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=tree) ```diff @@Coverage Diff @@ ## master #481 +/- ## == + Coverage 60.32% 60.35% +0.02% == Files 159 159 Lines 1352913534 +5 == + Hits 8161 8168 +7 + Misses 4789 4787 -2 Partials 579 579 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/plugin/pkg/discovery/indexer\_cache.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2luZGV4ZXJfY2FjaGUuZ28=) | `100% <ø> (ø)` | :arrow_up: | | [server/core/key\_convertor.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL2NvcmUva2V5X2NvbnZlcnRvci5nbw==) | `91.81% <0%> (-1.71%)` | :arrow_down: | | [server/service/event/service\_event\_handler.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvc2VydmljZV9ldmVudF9oYW5kbGVyLmdv) | `12.5% <0%> (ø)` | :arrow_up: | | [server/admin/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL2FkbWluL3NlcnZpY2UuZ28=) | `66.66% <0%> (-5.08%)` | :arrow_down: | | [server/plugin/pkg/discovery/types.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3R5cGVzLmdv) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/etcd/cacher\_kv.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvY2FjaGVyX2t2Lmdv) | `67.48% <100%> (ø)` | :arrow_up: | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `67.61% <100%> (-0.07%)` | :arrow_down: | | [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `72.72% <0%> (-9.1%)` | :arrow_down: | | [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.58% <0%> (-0.95%)` | :arrow_down: | | ... and [4 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=footer). Last update [ea31a1a...fd5414a](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678380#comment-16678380 ] ASF GitHub Bot commented on SCB-993: coveralls commented on issue #481: SCB-993 print warning log when aggregate conflict URL: https://github.com/apache/incubator-servicecomb-service-center/pull/481#issuecomment-436660133 [](https://coveralls.io/builds/19961735) Coverage decreased (-0.06%) to 62.708% when pulling **b5689678aa8c1d01b59e1332de643754d3065ee9 on little-cui:bug** into **ea31a1a3c9fdbd242817157f61e4aad15bfa5f0f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678337#comment-16678337 ] ASF GitHub Bot commented on SCB-993: little-cui opened a new pull request #481: SCB-993 print warning log when aggregate conflict URL: https://github.com/apache/incubator-servicecomb-service-center/pull/481 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672791#comment-16672791 ] ASF GitHub Bot commented on SCB-993: coveralls commented on issue #480: SCB-993 Can not test Schema if instance port greater than 4 digits URL: https://github.com/apache/incubator-servicecomb-service-center/pull/480#issuecomment-435312371 [](https://coveralls.io/builds/19870573) Coverage decreased (-0.09%) to 62.646% when pulling **8dd472ee911057e4ef2269b45f683a098f92fc15 on little-cui:ui** into **2a7fa4d8913919463a9899ac78b53037e48b7f64 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[
https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672773#comment-16672773
]
ASF GitHub Bot commented on SCB-993:
asifdxtreme closed pull request #480: SCB-993 Can not test Schema if instance
port greater than 4 digits
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/480
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/frontend/app/scripts/modules/serviceCenter/controllers/schemaCtrl.js
b/frontend/app/scripts/modules/serviceCenter/controllers/schemaCtrl.js
index ab24663a..cd21f130 100644
--- a/frontend/app/scripts/modules/serviceCenter/controllers/schemaCtrl.js
+++ b/frontend/app/scripts/modules/serviceCenter/controllers/schemaCtrl.js
@@ -261,14 +261,8 @@ angular.module('serviceCenter.sc')
httpService.apiRequest(url, method, null, headers,
"nopopup").then(function(response) {
$(".loader").hide();
if (response && response.data &&
response.data.schema) {
-if ($scope.selectedAddress.indexOf("rest")
!= -1) {
-var rest =
$scope.selectedAddress.split(':');
-var ip = rest[1].substring(2,
rest[1].length) + ":" + rest[2].substring(0, 4);
-}
-if
($scope.selectedAddress.indexOf("highway") != -1) {
-var highway =
$scope.selectedAddress.split(':');
-var ip = highway[1].substring(2,
highway[1].length) + ":" + highway[2].substring(0, 4);
-}
+var arr =
/^(?:\w+:\/\/)?([^\/?#]+)(.*)$/.exec($scope.selectedAddress);
+var ip = arr[1];
var schema = response.data.schema;
schema = schema.replace(/\\\s/g, "");
var json = YAML.parse(schema);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Bug fixes
> -
>
> Key: SCB-993
> URL: https://issues.apache.org/jira/browse/SCB-993
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672763#comment-16672763 ] ASF GitHub Bot commented on SCB-993: little-cui opened a new pull request #480: SCB-993 Can not test Schema if instance port greater than 4 digits URL: https://github.com/apache/incubator-servicecomb-service-center/pull/480 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668366#comment-16668366 ] ASF GitHub Bot commented on SCB-993: coveralls commented on issue #477: SCB-993 Optimize log prints URL: https://github.com/apache/incubator-servicecomb-service-center/pull/477#issuecomment-434217827 [](https://coveralls.io/builds/19799001) Coverage decreased (-0.1%) to 62.735% when pulling **b6a072837d1fb5ee0e4b7267036a58e65c932c9e on little-cui:logs** into **f67d612893a03e5ea9e206c625491bb7f02c58a7 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668359#comment-16668359 ] ASF GitHub Bot commented on SCB-993: codecov-io commented on issue #477: SCB-993 Optimize log prints URL: https://github.com/apache/incubator-servicecomb-service-center/pull/477#issuecomment-434217125 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/477?src=pr=h1) Report > Merging [#477](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/477?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/f67d612893a03e5ea9e206c625491bb7f02c58a7?src=pr=desc) will **decrease** coverage by `0.14%`. > The diff coverage is `48.86%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/477?src=pr=tree) ```diff @@Coverage Diff @@ ## master #477 +/- ## == - Coverage 60.39% 60.24% -0.15% == Files 156 156 Lines 1337913484 +105 == + Hits 8080 8124 +44 - Misses 4722 4779 +57 - Partials 577 581 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/477?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/event/instance\_event\_handler.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/477/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvaW5zdGFuY2VfZXZlbnRfaGFuZGxlci5nbw==) | `8.16% <0%> (ø)` | :arrow_up: | | [server/govern/controller\_v4.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/477/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9jb250cm9sbGVyX3Y0Lmdv) | `72.61% <0%> (-0.88%)` | :arrow_down: | | [server/service/util/tag\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/477/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `61.53% <0%> (ø)` | :arrow_up: | | [server/core/proto/services.pb.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/477/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvcHJvdG8vc2VydmljZXMucGIuZ28=) | `4.51% <0%> (-0.01%)` | :arrow_down: | | [server/metric/gatherer.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/477/diff?src=pr=tree#diff-c2VydmVyL21ldHJpYy9nYXRoZXJlci5nbw==) | `66.66% <0%> (ø)` | :arrow_up: | | [server/service/event/rule\_event\_handler.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/477/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvcnVsZV9ldmVudF9oYW5kbGVyLmdv) | `8.88% <0%> (ø)` | :arrow_up: | | [server/service/event/dependency\_event\_handler.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/477/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvZGVwZW5kZW5jeV9ldmVudF9oYW5kbGVyLmdv) | `15.31% <0%> (ø)` | :arrow_up: | | [server/core/backend/registry.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/477/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9yZWdpc3RyeS5nbw==) | `15.03% <0%> (-0.23%)` | :arrow_down: | | [server/service/event/tag\_event\_handler.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/477/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvdGFnX2V2ZW50X2hhbmRsZXIuZ28=) | `7.69% <0%> (ø)` | :arrow_up: | | [server/service/event/service\_event\_handler.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/477/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvc2VydmljZV9ldmVudF9oYW5kbGVyLmdv) | `12.12% <0%> (ø)` | :arrow_up: | | ... and [26 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/477/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/477?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/477?src=pr=footer). Last update [f67d612...b6a0728](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/477?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668328#comment-16668328 ] ASF GitHub Bot commented on SCB-993: little-cui opened a new pull request #477: SCB-993 Optimize log prints URL: https://github.com/apache/incubator-servicecomb-service-center/pull/477 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[
https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668006#comment-16668006
]
ASF GitHub Bot commented on SCB-993:
little-cui closed pull request #474: SCB-993 span_test.go:151: Fatalf call has
arguments but no formatting directives
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/474
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/server/plugin/pkg/tracing/buildin/span_test.go
b/server/plugin/pkg/tracing/buildin/span_test.go
index c44ba2a2..fcf86679 100644
--- a/server/plugin/pkg/tracing/buildin/span_test.go
+++ b/server/plugin/pkg/tracing/buildin/span_test.go
@@ -148,19 +148,19 @@ func TestFromZipkinSpan(t *testing.T) {
span := {}
err := json.Unmarshal(sample, )
if err != nil {
- t.Fatalf("TestFromZipkinSpan Unmarshal", err)
+ t.Fatalf("TestFromZipkinSpan Unmarshal, %v", err)
}
s := FromZipkinSpan(span)
b, err := json.Marshal(s)
if err != nil {
- t.Fatalf("TestFromZipkinSpan Marshal", err)
+ t.Fatalf("TestFromZipkinSpan Marshal, %v", err)
}
fmt.Println(string(b))
s = FromZipkinSpan({})
b, err = json.Marshal(s)
if err != nil {
- t.Fatalf("TestFromZipkinSpan Marshal", err)
+ t.Fatalf("TestFromZipkinSpan Marshal, %v", err)
}
fmt.Println(string(b))
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Bug fixes
> -
>
> Key: SCB-993
> URL: https://issues.apache.org/jira/browse/SCB-993
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668005#comment-16668005 ] ASF GitHub Bot commented on SCB-993: little-cui closed pull request #475: SCB-993 Add sc binary to .gitignore URL: https://github.com/apache/incubator-servicecomb-service-center/pull/475 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.gitignore b/.gitignore index c4d8a42d..01b32abb 100644 --- a/.gitignore +++ b/.gitignore @@ -27,3 +27,4 @@ tmp/ glide.lock incubator-servicecomb-service-center go.sum +service-center This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668004#comment-16668004 ] ASF GitHub Bot commented on SCB-993: codecov-io commented on issue #475: SCB-993 Add sc binary to .gitignore URL: https://github.com/apache/incubator-servicecomb-service-center/pull/475#issuecomment-434145979 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475?src=pr=h1) Report > Merging [#475](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/5a68edee4c4095367145fbe9484b369d30064c9e?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475?src=pr=tree) ```diff @@Coverage Diff @@ ## master #475 +/- ## == - Coverage 60.38% 60.37% -0.01% == Files 156 156 Lines 1337913379 == - Hits 8079 8078 -1 Misses 4722 4722 - Partials 578 579 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `83.87% <0%> (-0.65%)` | :arrow_down: | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.09% <0%> (-0.2%)` | :arrow_down: | | [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `86.3% <0%> (-0.19%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `73.66% <0%> (+0.33%)` | :arrow_up: | | [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `81.81% <0%> (+9.09%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475?src=pr=footer). Last update [5a68ede...a85e300](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668003#comment-16668003 ] ASF GitHub Bot commented on SCB-993: coveralls commented on issue #475: SCB-993 Add sc binary to .gitignore URL: https://github.com/apache/incubator-servicecomb-service-center/pull/475#issuecomment-434145954 [](https://coveralls.io/builds/19795120) Coverage decreased (-0.01%) to 62.829% when pulling **a85e300d1823cbcfdf52593261ce05127d2089d7 on xcaspar:master** into **5a68edee4c4095367145fbe9484b369d30064c9e on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667983#comment-16667983 ] ASF GitHub Bot commented on SCB-993: coveralls commented on issue #474: SCB-993 span_test.go:151: Fatalf call has arguments but no formatting directives URL: https://github.com/apache/incubator-servicecomb-service-center/pull/474#issuecomment-434138966 [](https://coveralls.io/builds/19794791) Coverage increased (+0.09%) to 62.927% when pulling **88e2bf7ffc384188519576775cb0aeec938fd1b7 on little-cui:bug** into **5a68edee4c4095367145fbe9484b369d30064c9e on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667982#comment-16667982 ] ASF GitHub Bot commented on SCB-993: codecov-io commented on issue #474: SCB-993 span_test.go:151: Fatalf call has arguments but no formatting directives URL: https://github.com/apache/incubator-servicecomb-service-center/pull/474#issuecomment-434138922 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474?src=pr=h1) Report > Merging [#474](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/5a68edee4c4095367145fbe9484b369d30064c9e?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474?src=pr=tree) ```diff @@Coverage Diff@@ ## master#474 +/- ## = + Coverage 60.38% 60.4% +0.02% = Files 156 156 Lines 13379 13379 = + Hits 80798082 +3 Misses 47224722 + Partials 578 575 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.09% <0%> (-0.2%)` | :arrow_down: | | [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `86.3% <0%> (-0.19%)` | :arrow_down: | | [server/broker/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.94% <0%> (+0.15%)` | :arrow_up: | | [server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `73.66% <0%> (+0.33%)` | :arrow_up: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474/diff?src=pr=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `74.52% <0%> (+0.94%)` | :arrow_up: | | [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474/diff?src=pr=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `84.37% <0%> (+3.12%)` | :arrow_up: | | [server/service/util/tag\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `65.38% <0%> (+3.84%)` | :arrow_up: | | [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `81.81% <0%> (+9.09%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474?src=pr=footer). Last update [5a68ede...88e2bf7](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667962#comment-16667962 ] ASF GitHub Bot commented on SCB-993: little-cui opened a new pull request #474: SCB-993 span_test.go:151: Fatalf call has arguments but no formatting directives URL: https://github.com/apache/incubator-servicecomb-service-center/pull/474 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667963#comment-16667963 ] ASF GitHub Bot commented on SCB-993: little-cui commented on issue #474: SCB-993 span_test.go:151: Fatalf call has arguments but no formatting directives URL: https://github.com/apache/incubator-servicecomb-service-center/pull/474#issuecomment-434135332 #472 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
