[GitHub] [struts] sepe81 commented on a diff in pull request #657: WW-5279 Improve readability of XmlConfigurationProvider class

2023-01-31 Thread via GitHub
sepe81 commented on code in PR #657: URL: https://github.com/apache/struts/pull/657#discussion_r1091847537 ## core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java: ## @@ -164,13 +174,10 @@ public boolean equals(Object o) { if (this

[GitHub] [struts] sepe81 commented on a diff in pull request #657: WW-5279 Improve readability of XmlConfigurationProvider class

2023-01-30 Thread via GitHub
sepe81 commented on code in PR #657: URL: https://github.com/apache/struts/pull/657#discussion_r1090851725 ## core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java: ## @@ -439,28 +445,16 @@ protected void addAction(Element actionElement,