[jira] [Commented] (WW-4412) Context started without being closed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106680#comment-15106680
 ] 

ASF GitHub Bot commented on WW-4412:


Github user lukaszlenart commented on a diff in the pull request:

https://github.com/apache/struts/pull/79#discussion_r50108754
  
--- Diff: 
plugins/tiles/src/main/java/org/apache/struts2/views/tiles/TilesResult.java ---
@@ -110,7 +110,9 @@ public void doExecute(String location, ActionInvocation 
invocation) throws Excep
 HttpServletResponse httpResponse = 
ServletActionContext.getResponse();
 
 Request request = new ServletRequest(applicationContext, 
httpRequest, httpResponse);
-
+
+container.startContext(request);
 container.render(location, request);
+container.endContext(request);
--- End diff --

This isn't needed, `container.render` starts and ends context.


> Context started without being closed
> 
>
> Key: WW-4412
> URL: https://issues.apache.org/jira/browse/WW-4412
> Project: Struts 2
>  Issue Type: Bug
>  Components: Plugin - Tiles
>Affects Versions: 2.3.16.3
>Reporter: Hazem Taji
> Fix For: 2.5
>
> Attachments: tiles-test.zip
>
>
> In the TilesResult class, in doExecute, a context is started but not ended. 
> This causes the context stack later to have extra irrelevant contexts.
> The problem prevents the use of  tags where actions have tile 
> results and results in the tile attributes being unrecognized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4412) Context started without being closed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106663#comment-15106663
 ] 

ASF GitHub Bot commented on WW-4412:


GitHub user victorsosa opened a pull request:

https://github.com/apache/struts/pull/79

WW-4412  Context started without being closed

Patch for WW-4412

Context started without being closed

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/victorsosa/struts patch

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/struts/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #79


commit 6bc2afbc5d39902c26afa957533872a0e2dd38e3
Author: Lukasz Lenart 
Date:   2016-01-18T14:55:59Z

WW-4412
Context started without being closed

Now it is started and closed

commit c167d6c855f9f3f5863d8fa20ab45aa28cb77486
Author: victor sosa 
Date:   2016-01-19T12:25:29Z

Merge pull request #1 from apache/master

update pull

commit af42137b539cadca21413c7a438e258a844b3dbb
Author: victor sosa 
Date:   2016-01-19T12:30:07Z

Merge pull request #2 from victorsosa/master

update pull




> Context started without being closed
> 
>
> Key: WW-4412
> URL: https://issues.apache.org/jira/browse/WW-4412
> Project: Struts 2
>  Issue Type: Bug
>  Components: Plugin - Tiles
>Affects Versions: 2.3.16.3
>Reporter: Hazem Taji
> Fix For: 2.5
>
> Attachments: tiles-test.zip
>
>
> In the TilesResult class, in doExecute, a context is started but not ended. 
> This causes the context stack later to have extra irrelevant contexts.
> The problem prevents the use of  tags where actions have tile 
> results and results in the tile attributes being unrecognized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4412) Context started without being closed

[victorsosa (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106807#comment-15106807
 ] 

victorsosa commented on WW-4412:


the context should start and end
+ container.startContext(request);
container.render(location, request);
+ container.endContext(request);



> Context started without being closed
> 
>
> Key: WW-4412
> URL: https://issues.apache.org/jira/browse/WW-4412
> Project: Struts 2
>  Issue Type: Bug
>  Components: Plugin - Tiles
>Affects Versions: 2.3.16.3
>Reporter: Hazem Taji
> Fix For: 2.5
>
> Attachments: tiles-test.zip
>
>
> In the TilesResult class, in doExecute, a context is started but not ended. 
> This causes the context stack later to have extra irrelevant contexts.
> The problem prevents the use of  tags where actions have tile 
> results and results in the tile attributes being unrecognized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4412) Context started without being closed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106838#comment-15106838
 ] 

ASF GitHub Bot commented on WW-4412:


Github user lukaszlenart commented on the pull request:

https://github.com/apache/struts/pull/79#issuecomment-172878561
  
Thanks!


> Context started without being closed
> 
>
> Key: WW-4412
> URL: https://issues.apache.org/jira/browse/WW-4412
> Project: Struts 2
>  Issue Type: Bug
>  Components: Plugin - Tiles
>Affects Versions: 2.3.16.3
>Reporter: Hazem Taji
> Fix For: 2.5
>
> Attachments: tiles-test.zip
>
>
> In the TilesResult class, in doExecute, a context is started but not ended. 
> This causes the context stack later to have extra irrelevant contexts.
> The problem prevents the use of  tags where actions have tile 
> results and results in the tile attributes being unrecognized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4412) Context started without being closed

[Lukasz Lenart (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106818#comment-15106818
 ] 

Lukasz Lenart commented on WW-4412:
---

It's already done in {{render}}
https://github.com/apache/tiles/blob/TILES_3_0_X/tiles-core/src/main/java/org/apache/tiles/impl/BasicTilesContainer.java#L230-L242

> Context started without being closed
> 
>
> Key: WW-4412
> URL: https://issues.apache.org/jira/browse/WW-4412
> Project: Struts 2
>  Issue Type: Bug
>  Components: Plugin - Tiles
>Affects Versions: 2.3.16.3
>Reporter: Hazem Taji
> Fix For: 2.5
>
> Attachments: tiles-test.zip
>
>
> In the TilesResult class, in doExecute, a context is started but not ended. 
> This causes the context stack later to have extra irrelevant contexts.
> The problem prevents the use of  tags where actions have tile 
> results and results in the tile attributes being unrecognized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4412) Context started without being closed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106828#comment-15106828
 ] 

ASF GitHub Bot commented on WW-4412:


Github user victorsosa commented on a diff in the pull request:

https://github.com/apache/struts/pull/79#discussion_r50120845
  
--- Diff: 
plugins/tiles/src/main/java/org/apache/struts2/views/tiles/TilesResult.java ---
@@ -110,7 +110,9 @@ public void doExecute(String location, ActionInvocation 
invocation) throws Excep
 HttpServletResponse httpResponse = 
ServletActionContext.getResponse();
 
 Request request = new ServletRequest(applicationContext, 
httpRequest, httpResponse);
-
+
+container.startContext(request);
 container.render(location, request);
+container.endContext(request);
--- End diff --

OK, i will close the PR then :+1: 


> Context started without being closed
> 
>
> Key: WW-4412
> URL: https://issues.apache.org/jira/browse/WW-4412
> Project: Struts 2
>  Issue Type: Bug
>  Components: Plugin - Tiles
>Affects Versions: 2.3.16.3
>Reporter: Hazem Taji
> Fix For: 2.5
>
> Attachments: tiles-test.zip
>
>
> In the TilesResult class, in doExecute, a context is started but not ended. 
> This causes the context stack later to have extra irrelevant contexts.
> The problem prevents the use of  tags where actions have tile 
> results and results in the tile attributes being unrecognized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4412) Context started without being closed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106829#comment-15106829
 ] 

ASF GitHub Bot commented on WW-4412:


Github user victorsosa closed the pull request at:

https://github.com/apache/struts/pull/79


> Context started without being closed
> 
>
> Key: WW-4412
> URL: https://issues.apache.org/jira/browse/WW-4412
> Project: Struts 2
>  Issue Type: Bug
>  Components: Plugin - Tiles
>Affects Versions: 2.3.16.3
>Reporter: Hazem Taji
> Fix For: 2.5
>
> Attachments: tiles-test.zip
>
>
> In the TilesResult class, in doExecute, a context is started but not ended. 
> This causes the context stack later to have extra irrelevant contexts.
> The problem prevents the use of  tags where actions have tile 
> results and results in the tile attributes being unrecognized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4412) Context started without being closed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105948#comment-15105948
 ] 

ASF GitHub Bot commented on WW-4412:


GitHub user victorsosa opened a pull request:

https://github.com/apache/struts/pull/76

WW-4412  Context started without being closed

WW-4412

Context started without being closed

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/victorsosa/struts patch

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/struts/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #76


commit 073bb9dd587844c1f44c97ba53b8419c83f2583a
Author: victor sosa 
Date:   2016-01-16T18:45:39Z

Merge pull request #3 from apache/master

update

commit 8f1557a5b13fe9f9b4cbc8961a8bf66b3db89e76
Author: Victor Sosa 
Date:   2016-01-18T15:34:36Z

WW-4412

Context started without being closed

Now the context is closed after been used.

commit cd931f8ed8e73a9dd242ec05fe6dfcaf45012273
Author: victor sosa 
Date:   2016-01-18T23:19:45Z

Update JakartaMultiPartRequest.java

Fix conflict




> Context started without being closed
> 
>
> Key: WW-4412
> URL: https://issues.apache.org/jira/browse/WW-4412
> Project: Struts 2
>  Issue Type: Bug
>  Components: Plugin - Tiles
>Affects Versions: 2.3.16.3
>Reporter: Hazem Taji
> Fix For: 2.3.x
>
> Attachments: tiles-test.zip
>
>
> In the TilesResult class, in doExecute, a context is started but not ended. 
> This causes the context stack later to have extra irrelevant contexts.
> The problem prevents the use of  tags where actions have tile 
> results and results in the tile attributes being unrecognized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4412) Context started without being closed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105954#comment-15105954
 ] 

ASF GitHub Bot commented on WW-4412:


Github user victorsosa closed the pull request at:

https://github.com/apache/struts/pull/76


> Context started without being closed
> 
>
> Key: WW-4412
> URL: https://issues.apache.org/jira/browse/WW-4412
> Project: Struts 2
>  Issue Type: Bug
>  Components: Plugin - Tiles
>Affects Versions: 2.3.16.3
>Reporter: Hazem Taji
> Fix For: 2.3.x
>
> Attachments: tiles-test.zip
>
>
> In the TilesResult class, in doExecute, a context is started but not ended. 
> This causes the context stack later to have extra irrelevant contexts.
> The problem prevents the use of  tags where actions have tile 
> results and results in the tile attributes being unrecognized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4412) Context started without being closed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105953#comment-15105953
 ] 

ASF GitHub Bot commented on WW-4412:


Github user victorsosa commented on the pull request:

https://github.com/apache/struts/pull/76#issuecomment-172679977
  
Closed this pull request is right; I will send another one


> Context started without being closed
> 
>
> Key: WW-4412
> URL: https://issues.apache.org/jira/browse/WW-4412
> Project: Struts 2
>  Issue Type: Bug
>  Components: Plugin - Tiles
>Affects Versions: 2.3.16.3
>Reporter: Hazem Taji
> Fix For: 2.3.x
>
> Attachments: tiles-test.zip
>
>
> In the TilesResult class, in doExecute, a context is started but not ended. 
> This causes the context stack later to have extra irrelevant contexts.
> The problem prevents the use of  tags where actions have tile 
> results and results in the tile attributes being unrecognized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4412) Context started without being closed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105961#comment-15105961
 ] 

ASF GitHub Bot commented on WW-4412:


Github user victorsosa closed the pull request at:

https://github.com/apache/struts/pull/77


> Context started without being closed
> 
>
> Key: WW-4412
> URL: https://issues.apache.org/jira/browse/WW-4412
> Project: Struts 2
>  Issue Type: Bug
>  Components: Plugin - Tiles
>Affects Versions: 2.3.16.3
>Reporter: Hazem Taji
> Fix For: 2.3.x
>
> Attachments: tiles-test.zip
>
>
> In the TilesResult class, in doExecute, a context is started but not ended. 
> This causes the context stack later to have extra irrelevant contexts.
> The problem prevents the use of  tags where actions have tile 
> results and results in the tile attributes being unrecognized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4412) Context started without being closed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105959#comment-15105959
 ] 

ASF GitHub Bot commented on WW-4412:


GitHub user victorsosa opened a pull request:

https://github.com/apache/struts/pull/77

WW-4412  Context started without being closed

Patch   WW-4412

Context started without being closed

Now the context is closed after been used.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/victorsosa/struts patch

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/struts/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #77


commit 073bb9dd587844c1f44c97ba53b8419c83f2583a
Author: victor sosa 
Date:   2016-01-16T18:45:39Z

Merge pull request #3 from apache/master

update

commit 8f1557a5b13fe9f9b4cbc8961a8bf66b3db89e76
Author: Victor Sosa 
Date:   2016-01-18T15:34:36Z

WW-4412

Context started without being closed

Now the context is closed after been used.

commit a154184b9059e6e81e63af4820c0fefc0374c2bd
Author: Victor Sosa 
Date:   2016-01-18T15:34:36Z

WW-4412

Context started without being closed

Now the context is closed after been used.

commit cd931f8ed8e73a9dd242ec05fe6dfcaf45012273
Author: victor sosa 
Date:   2016-01-18T23:19:45Z

Update JakartaMultiPartRequest.java

Fix conflict

commit f562147d028156f7f51adab247e1b450a20962d8
Author: Victor Sosa 
Date:   2016-01-18T23:14:48Z

Merge branch 'patch' of g...@github.com:victorsosa/struts.git into patch

commit 39a334c87a1b4429060eaf0227ba79677931d25f
Author: Victor Sosa 
Date:   2016-01-18T23:29:28Z

Merge branch 'patch' of g...@github.com:victorsosa/struts.git into patch




> Context started without being closed
> 
>
> Key: WW-4412
> URL: https://issues.apache.org/jira/browse/WW-4412
> Project: Struts 2
>  Issue Type: Bug
>  Components: Plugin - Tiles
>Affects Versions: 2.3.16.3
>Reporter: Hazem Taji
> Fix For: 2.3.x
>
> Attachments: tiles-test.zip
>
>
> In the TilesResult class, in doExecute, a context is started but not ended. 
> This causes the context stack later to have extra irrelevant contexts.
> The problem prevents the use of  tags where actions have tile 
> results and results in the tile attributes being unrecognized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4412) Context started without being closed

[Hazem Taji (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14169202#comment-14169202
 ] 

Hazem Taji commented on WW-4412:


The s:action tag in BaseLayout.jsp causes the tiles to add 2 elements to the 
context stack, only popping one after it finishes. When trying to load the 
footer attribute, it will complain as it will not find the correct definition 
made in the resources/tiles/tiles-index.xml file.

My analysis is that in TilesResult class the context is started, but is not 
closed after rendering. If closed, the example works correctly.

 Context started without being closed
 

 Key: WW-4412
 URL: https://issues.apache.org/jira/browse/WW-4412
 Project: Struts 2
  Issue Type: Bug
  Components: Plugin - Tiles
Affects Versions: 2.3.16.3
Reporter: Hazem Taji
 Fix For: 2.3.x

 Attachments: tiles-test.zip


 In the TilesResult class, in doExecute, a context is started but not ended. 
 This causes the context stack later to have extra irrelevant contexts.
 The problem prevents the use of s:action tags where actions have tile 
 results and results in the tile attributes being unrecognized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WW-4412) Context started without being closed

[Lukasz Lenart (JIRA)]

[ 
https://issues.apache.org/jira/browse/WW-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14165062#comment-14165062
 ] 

Lukasz Lenart commented on WW-4412:
---

Can you post more info? Stacktrace? Example app or config?

 Context started without being closed
 

 Key: WW-4412
 URL: https://issues.apache.org/jira/browse/WW-4412
 Project: Struts 2
  Issue Type: Bug
  Components: Plugin - Tiles
Affects Versions: 2.3.16.3
Reporter: Hazem Taji
 Fix For: 2.3.x


 In the TilesResult class, in doExecute, a context is started but not ended. 
 This causes the context stack later to have extra irrelevant contexts.
 The problem prevents the use of s:action tags where actions have tile 
 results and results in the tile attributes being unrecognized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)