[GitHub] [trafficcontrol] rawlinp commented on issue #3789: Rewrite /divisions/name/{{name}} to Go

rawlinp commented on issue #3789: Rewrite /divisions/name/{{name}} to Go URL: https://github.com/apache/trafficcontrol/issues/3789#issuecomment-531297979 @ocket for `DELETE`? This is an automated message from the Apache

[GitHub] [trafficcontrol] rawlinp commented on issue #3812: Rewrite /regions/{{region}}/phys_locations to Go

rawlinp commented on issue #3812: Rewrite /regions/{{region}}/phys_locations to Go URL: https://github.com/apache/trafficcontrol/issues/3812#issuecomment-531304704 +1 on deprecation This is an automated message from the

[GitHub] [trafficcontrol] rawlinp commented on issue #3813: Rewrite /profiles/name/{{name}}/copy/{{fromName}} to Go

rawlinp commented on issue #3813: Rewrite /profiles/name/{{name}}/copy/{{fromName}} to Go URL: https://github.com/apache/trafficcontrol/issues/3813#issuecomment-531306309 I believe TP uses this endpoint for cloning profiles. I think ops probably uses this one quite a bit, so I'm unsure

[GitHub] [trafficcontrol] rawlinp commented on issue #3816: Rewrite /parameters/{{id}}/profiles

rawlinp commented on issue #3816: Rewrite /parameters/{{id}}/profiles URL: https://github.com/apache/trafficcontrol/issues/3816#issuecomment-531306515 +1 on deprecation if query param works This is an automated message from

[GitHub] [trafficcontrol] rawlinp commented on issue #3817: Rewrite /parameters/{{id}}/unassigned_profiles to Go

rawlinp commented on issue #3817: Rewrite /parameters/{{id}}/unassigned_profiles to Go URL: https://github.com/apache/trafficcontrol/issues/3817#issuecomment-531306657 agree, +1 on deprecation This is an automated message

[GitHub] [trafficcontrol] rawlinp commented on issue #3831: Rewrite /servercheck/aadata to Go

rawlinp commented on issue #3831: Rewrite /servercheck/aadata to Go URL: https://github.com/apache/trafficcontrol/issues/3831#issuecomment-531312940 +1 on deprecation This is an automated message from the Apache Git Service.

[GitHub] [trafficcontrol] rawlinp commented on issue #3833: Rewrite /stats_summary/create to Go

rawlinp commented on issue #3833: Rewrite /stats_summary/create to Go URL: https://github.com/apache/trafficcontrol/issues/3833#issuecomment-531313449 +1 to the deprecation/rewrite idea This is an automated message from the

[GitHub] [trafficcontrol] rawlinp commented on issue #3837: Rewrite /deliveryservice_user/{{DSID}}/{{userID}} to Go

rawlinp commented on issue #3837: Rewrite /deliveryservice_user/{{DSID}}/{{userID}} to Go URL: https://github.com/apache/trafficcontrol/issues/3837#issuecomment-531314247 +1 on deprecation This is an automated message from

[GitHub] [trafficcontrol] rawlinp commented on issue #3834: Rewrite /types/trimmed to Go

rawlinp commented on issue #3834: Rewrite /types/trimmed to Go URL: https://github.com/apache/trafficcontrol/issues/3834#issuecomment-531315305 +1 on deprecation. Specialized endpoints that only return subsets of data from other endpoints are an API smell IMO.

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3912: Rewrote /dbdump to Go

ocket commented on a change in pull request #3912: Rewrote /dbdump to Go URL: https://github.com/apache/trafficcontrol/pull/3912#discussion_r324307200 ## File path: traffic_ops/traffic_ops_golang/dbdump/dbdump.go ## @@ -0,0 +1,99 @@ +package dbdump + +/* + * Licensed

[GitHub] [trafficcontrol] rawlinp commented on issue #3818: Rewrite /divisions/{{division}}/regions to Go

rawlinp commented on issue #3818: Rewrite /divisions/{{division}}/regions to Go URL: https://github.com/apache/trafficcontrol/issues/3818#issuecomment-531306794 +1 on deprecation as long as the query param works This is an

[GitHub] [trafficcontrol] rawlinp commented on issue #3839: Rewrite /user/current/update to Go

rawlinp commented on issue #3839: Rewrite /user/current/update to Go URL: https://github.com/apache/trafficcontrol/issues/3839#issuecomment-531314658 +1 on deprecation as long as `PUT /user/current` already does the same thing

[GitHub] [trafficcontrol] rawlinp commented on issue #3845: Rewrite /to_extensions/{{id}}/delete to Go

rawlinp commented on issue #3845: Rewrite /to_extensions/{{id}}/delete to Go URL: https://github.com/apache/trafficcontrol/issues/3845#issuecomment-531315602 +1 to not rewriting as-is This is an automated message from the

[GitHub] [trafficcontrol] rawlinp commented on issue #3848: Rewrite /cachegroup_fallbacks to Go

rawlinp commented on issue #3848: Rewrite /cachegroup_fallbacks to Go URL: https://github.com/apache/trafficcontrol/issues/3848#issuecomment-531315846 +1, definitely shouldn't be rewritten. Go cachegroups API supersedes this.

Build failed in Jenkins: trafficcontrol-master-build #1481

See Changes: [rawlin_peters] Correcting some unnecessary diffs with master (#3920) -- [...truncated 3.34 MB...] traffic_portal_build_1 | | | +--

[GitHub] [trafficcontrol] rawlinp commented on issue #3836: Rewrite /deliveryservice_user to Go

rawlinp commented on issue #3836: Rewrite /deliveryservice_user to Go URL: https://github.com/apache/trafficcontrol/issues/3836#issuecomment-531313842 +1 on deprecation. If it even does have an affect anywhere, the code should be fixed to where tenant is used over delivery service users.

[GitHub] [trafficcontrol] ocket8888 commented on issue #3789: Rewrite /divisions/name/{{name}} to Go

ocket commented on issue #3789: Rewrite /divisions/name/{{name}} to Go URL: https://github.com/apache/trafficcontrol/issues/3789#issuecomment-531337996 Oh, not for DELETE. But it could easily be added. This is an

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3920: Fix fragile unit test in NetworkNodeUnitTest

rawlinp commented on a change in pull request #3920: Fix fragile unit test in NetworkNodeUnitTest URL: https://github.com/apache/trafficcontrol/pull/3920#discussion_r324262394 ## File path:

[GitHub] [trafficcontrol] rawlinp merged pull request #3920: Fix fragile unit test in NetworkNodeUnitTest

rawlinp merged pull request #3920: Fix fragile unit test in NetworkNodeUnitTest URL: https://github.com/apache/trafficcontrol/pull/3920 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [trafficcontrol] asf-ci commented on issue #3913: Issue 3910 - Fixes issue where targets with RGB enabled cannot be steered

asf-ci commented on issue #3913: Issue 3910 - Fixes issue where targets with RGB enabled cannot be steered URL: https://github.com/apache/trafficcontrol/pull/3913#issuecomment-531377170 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] rawlinp merged pull request #3913: Issue 3910 - Fixes issue where targets with RGB enabled cannot be steered

rawlinp merged pull request #3913: Issue 3910 - Fixes issue where targets with RGB enabled cannot be steered URL: https://github.com/apache/trafficcontrol/pull/3913 This is an automated message from the Apache Git Service.

[GitHub] [trafficcontrol] rawlinp closed issue #3910: Traffic Router does not allow RGB to be enabled on Client steering DSs

rawlinp closed issue #3910: Traffic Router does not allow RGB to be enabled on Client steering DSs URL: https://github.com/apache/trafficcontrol/issues/3910 This is an automated message from the Apache Git Service. To

[GitHub] [trafficcontrol] dneuman64 commented on issue #3913: Issue 3910 - Fixes issue where targets with RGB enabled cannot be steered

dneuman64 commented on issue #3913: Issue 3910 - Fixes issue where targets with RGB enabled cannot be steered URL: https://github.com/apache/trafficcontrol/pull/3913#issuecomment-531357879 OK, this is ready for review again. I have tested the code changes in a staging environment and

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3912: Rewrote /dbdump to Go

ocket commented on a change in pull request #3912: Rewrote /dbdump to Go URL: https://github.com/apache/trafficcontrol/pull/3912#discussion_r324334369 ## File path: traffic_ops/traffic_ops_golang/dbdump/dbdump.go ## @@ -0,0 +1,99 @@ +package dbdump + +/* + * Licensed

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3913: Issue 3910 - Fixes issue where targets with RGB enabled cannot be steered

rawlinp commented on a change in pull request #3913: Issue 3910 - Fixes issue where targets with RGB enabled cannot be steered URL: https://github.com/apache/trafficcontrol/pull/3913#discussion_r324337586 ## File path: CHANGELOG.md ## @@ -42,6 +42,7 @@ The format is based

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3913: Issue 3910 - Fixes issue where targets with RGB enabled cannot be steered

rawlinp commented on a change in pull request #3913: Issue 3910 - Fixes issue where targets with RGB enabled cannot be steered URL: https://github.com/apache/trafficcontrol/pull/3913#discussion_r324338304 ## File path:

[GitHub] [trafficcontrol] asf-ci commented on issue #3912: Rewrote /dbdump to Go

asf-ci commented on issue #3912: Rewrote /dbdump to Go URL: https://github.com/apache/trafficcontrol/pull/3912#issuecomment-531364510 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4247/ Test PASSed.

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles

ocket commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles URL: https://github.com/apache/trafficcontrol/pull/3919#discussion_r324344589 ## File path:

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles

ocket commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles URL: https://github.com/apache/trafficcontrol/pull/3919#discussion_r324350138 ## File path:

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles

ocket commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles URL: https://github.com/apache/trafficcontrol/pull/3919#discussion_r324354887 ## File path:

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles

ocket commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles URL: https://github.com/apache/trafficcontrol/pull/3919#discussion_r324336843 ## File path: docs/source/admin/quick_howto/profile_compare_mgmt.rst ##

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles

ocket commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles URL: https://github.com/apache/trafficcontrol/pull/3919#discussion_r324340932 ## File path: traffic_portal/app/src/common/modules/table/_table.scss ##

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles

ocket commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles URL: https://github.com/apache/trafficcontrol/pull/3919#discussion_r324336100 ## File path: docs/source/admin/quick_howto/profile_compare_mgmt.rst ##

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles

ocket commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles URL: https://github.com/apache/trafficcontrol/pull/3919#discussion_r324340026 ## File path: docs/source/admin/quick_howto/profile_compare_mgmt.rst ##

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles

ocket commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles URL: https://github.com/apache/trafficcontrol/pull/3919#discussion_r324358651 ## File path: traffic_portal/app/src/styles/main.scss ## @@ -183,6

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles

ocket commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles URL: https://github.com/apache/trafficcontrol/pull/3919#discussion_r324353425 ## File path:

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles

ocket commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles URL: https://github.com/apache/trafficcontrol/pull/3919#discussion_r324337368 ## File path: docs/source/admin/quick_howto/profile_compare_mgmt.rst ##

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles

ocket commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles URL: https://github.com/apache/trafficcontrol/pull/3919#discussion_r324355570 ## File path:

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles

ocket commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles URL: https://github.com/apache/trafficcontrol/pull/3919#discussion_r324356739 ## File path:

[GitHub] [trafficcontrol] mhoppa opened a new pull request #3921: Rewrite profiles/{id}/export to golang

mhoppa opened a new pull request #3921: Rewrite profiles/{id}/export to golang URL: https://github.com/apache/trafficcontrol/pull/3921 ## What does this PR (Pull Request) do? This PR rewrites the /cachegroups/{id}/unassigned_parameters endpoint to Go - [x] This PR fixes #3814

[GitHub] [trafficcontrol] asf-ci commented on issue #3912: Rewrote /dbdump to Go

asf-ci commented on issue #3912: Rewrote /dbdump to Go URL: https://github.com/apache/trafficcontrol/pull/3912#issuecomment-531367106 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4249/ Test PASSed.

[GitHub] [trafficcontrol] dneuman64 commented on a change in pull request #3913: Issue 3910 - Fixes issue where targets with RGB enabled cannot be steered

dneuman64 commented on a change in pull request #3913: Issue 3910 - Fixes issue where targets with RGB enabled cannot be steered URL: https://github.com/apache/trafficcontrol/pull/3913#discussion_r324343537 ## File path: CHANGELOG.md ## @@ -42,6 +42,7 @@ The format is

[GitHub] [trafficcontrol] dneuman64 commented on a change in pull request #3913: Issue 3910 - Fixes issue where targets with RGB enabled cannot be steered

dneuman64 commented on a change in pull request #3913: Issue 3910 - Fixes issue where targets with RGB enabled cannot be steered URL: https://github.com/apache/trafficcontrol/pull/3913#discussion_r324343567 ## File path:

Jenkins build is back to normal : trafficcontrol-master-build #1482

See

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles

mitchell852 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles URL: https://github.com/apache/trafficcontrol/pull/3919#discussion_r324371564 ## File path:

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles

mitchell852 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles URL: https://github.com/apache/trafficcontrol/pull/3919#discussion_r324371764 ## File path:

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3921: Rewrite profiles/{id}/export to golang

ocket commented on a change in pull request #3921: Rewrite profiles/{id}/export to golang URL: https://github.com/apache/trafficcontrol/pull/3921#discussion_r324377956 ## File path: traffic_ops/traffic_ops_golang/profile/profile_export.go ## @@ -0,0 +1,144 @@ +package

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3921: Rewrite profiles/{id}/export to golang

mhoppa commented on a change in pull request #3921: Rewrite profiles/{id}/export to golang URL: https://github.com/apache/trafficcontrol/pull/3921#discussion_r324379372 ## File path: traffic_ops/traffic_ops_golang/profile/profile_export.go ## @@ -0,0 +1,144 @@ +package

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #3923: Moved DNSSEC documentation into the existing qht guide

ocket opened a new pull request #3923: Moved DNSSEC documentation into the existing qht guide URL: https://github.com/apache/trafficcontrol/pull/3923 ## What does this PR (Pull Request) do? - [x] This PR is not related to any Issue Moved the old Traffic Ops UI's documentation

[GitHub] [trafficcontrol] asf-ci commented on issue #3921: Rewrite profiles/{id}/export to golang

asf-ci commented on issue #3921: Rewrite profiles/{id}/export to golang URL: https://github.com/apache/trafficcontrol/pull/3921#issuecomment-531390937 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4251/

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles

mitchell852 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles URL: https://github.com/apache/trafficcontrol/pull/3919#discussion_r324372027 ## File path: traffic_portal/app/src/styles/main.scss ## @@ -183,6

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #3922: Removed the TO UI menu docs, and documented equivalent TP functionality

ocket opened a new pull request #3922: Removed the TO UI menu docs, and documented equivalent TP functionality URL: https://github.com/apache/trafficcontrol/pull/3922 ## What does this PR (Pull Request) do? - [x] This PR is not related to any Issue Removed the "Traffic

[GitHub] [trafficcontrol] asf-ci commented on issue #3922: Removed the TO UI menu docs, and documented equivalent TP functionality

asf-ci commented on issue #3922: Removed the TO UI menu docs, and documented equivalent TP functionality URL: https://github.com/apache/trafficcontrol/pull/3922#issuecomment-531398631 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3921: Rewrite profiles/{id}/export to golang

ocket commented on a change in pull request #3921: Rewrite profiles/{id}/export to golang URL: https://github.com/apache/trafficcontrol/pull/3921#discussion_r324383013 ## File path: traffic_ops/traffic_ops_golang/profile/profile_export.go ## @@ -0,0 +1,144 @@ +package

[GitHub] [trafficcontrol] asf-ci commented on issue #3923: Moved DNSSEC documentation into the existing qht guide

asf-ci commented on issue #3923: Moved DNSSEC documentation into the existing qht guide URL: https://github.com/apache/trafficcontrol/pull/3923#issuecomment-531408160 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] asf-ci commented on issue #3691: Some best-practices updates to the kickstart script

asf-ci commented on issue #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#issuecomment-531409543 Refer to this link for build results (access rights to CI server needed):