[GitHub] [trafficcontrol] mitchell852 commented on issue #3977: TP: Adds Server Capabilities UI

2019-10-11 Thread GitBox
mitchell852 commented on issue #3977: TP: Adds Server Capabilities UI URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541109856 > I'd like to remove allowing dot, if no one objects. I'm good with that. Is this a good UI error message? `Must be alphanumeric

[GitHub] [trafficcontrol] asf-ci commented on issue #3954: Added deprecation notices for /user/current/update

2019-10-11 Thread GitBox
asf-ci commented on issue #3954: Added deprecation notices for /user/current/update URL: https://github.com/apache/trafficcontrol/pull/3954#issuecomment-541127422 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] lbathina opened a new issue #3986: Unable to add new user - shows passwords don't match even when they match

2019-10-11 Thread GitBox
lbathina opened a new issue #3986: Unable to add new user - shows passwords don't match even when they match URL: https://github.com/apache/trafficcontrol/issues/3986 ## I'm submitting a ... - [X] bug report - [ ] new feature / enhancement request - [ ]

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3870: Rewrite /capabilities to Go

2019-10-11 Thread GitBox
ocket commented on a change in pull request #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r334095773 ## File path: traffic_ops/traffic_ops_golang/capabilities/capabilities.go ## @@ -0,0 +1,305 @@ +package

[GitHub] [trafficcontrol] asf-ci commented on issue #3977: TP: Adds Server Capabilities UI

2019-10-11 Thread GitBox
asf-ci commented on issue #3977: TP: Adds Server Capabilities UI URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541167072 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4461/

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3972: Add Server Capabilities blueprint

2019-10-11 Thread GitBox
mitchell852 commented on a change in pull request #3972: Add Server Capabilities blueprint URL: https://github.com/apache/trafficcontrol/pull/3972#discussion_r334118568 ## File path: blueprints/server-capabilitites.md ## @@ -0,0 +1,164 @@ + +# Server Capabilities + +##

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang

2019-10-11 Thread GitBox
mhoppa commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang URL: https://github.com/apache/trafficcontrol/pull/3967#discussion_r334133185 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @@ -445,7 +445,7 @@

[GitHub] [trafficcontrol] ocket8888 commented on issue #3870: Rewrite /capabilities to Go

2019-10-11 Thread GitBox
ocket commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-541228488 retest this please This is an automated message from the Apache Git Service.

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang

2019-10-11 Thread GitBox
ocket commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang URL: https://github.com/apache/trafficcontrol/pull/3967#discussion_r334138885 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @@ -445,7 +445,7 @@

[GitHub] [trafficcontrol] asf-ci commented on issue #3977: TP: Adds Server Capabilities UI

2019-10-11 Thread GitBox
asf-ci commented on issue #3977: TP: Adds Server Capabilities UI URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541192541 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4463/

Build failed in Jenkins: trafficcontrol-PR #4463

2019-10-11 Thread Apache Jenkins Server
See Changes: [mitchell852] prevents dots in server capability name -- GitHub pull request #3977 of commit 97e7c817e010ed739959fc341b55619a27ed3675, no merge conflicts.

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang

2019-10-11 Thread GitBox
ocket commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang URL: https://github.com/apache/trafficcontrol/pull/3967#discussion_r334145362 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @@ -445,7 +445,7 @@

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3870: Rewrite /capabilities to Go

2019-10-11 Thread GitBox
ocket commented on a change in pull request #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r334149509 ## File path: traffic_ops/traffic_ops_golang/capabilities/capabilities.go ## @@ -0,0 +1,305 @@ +package

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3972: Add Server Capabilities blueprint

2019-10-11 Thread GitBox
mitchell852 commented on a change in pull request #3972: Add Server Capabilities blueprint URL: https://github.com/apache/trafficcontrol/pull/3972#discussion_r334119233 ## File path: blueprints/server-capabilitites.md ## @@ -0,0 +1,164 @@ + +# Server Capabilities + +##

Build failed in Jenkins: trafficcontrol-PR #4462

2019-10-11 Thread Apache Jenkins Server
See Changes: -- GitHub pull request #3870 of commit 4a5be16e2f96379a3d97ce52329da67e142a56b5, no merge conflicts. Running as SYSTEM Setting status of

[GitHub] [trafficcontrol] asf-ci commented on issue #3870: Rewrite /capabilities to Go

2019-10-11 Thread GitBox
asf-ci commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-541179969 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4462/

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang

2019-10-11 Thread GitBox
mhoppa commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang URL: https://github.com/apache/trafficcontrol/pull/3967#discussion_r334139892 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @@ -445,7 +445,7 @@

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang

2019-10-11 Thread GitBox
mhoppa commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang URL: https://github.com/apache/trafficcontrol/pull/3967#discussion_r334139892 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @@ -445,7 +445,7 @@

[GitHub] [trafficcontrol] zrhoffman opened a new pull request #3988: WIP Remove Traffic Ops Golang legacy tc.ApiErrorType

2019-10-11 Thread GitBox
zrhoffman opened a new pull request #3988: WIP Remove Traffic Ops Golang legacy tc.ApiErrorType URL: https://github.com/apache/trafficcontrol/pull/3988 ## What does this PR (Pull Request) do? - [x] This PR fixes #3349 ## Which Traffic Control components are

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3972: Add Server Capabilities blueprint

2019-10-11 Thread GitBox
mitchell852 commented on a change in pull request #3972: Add Server Capabilities blueprint URL: https://github.com/apache/trafficcontrol/pull/3972#discussion_r334118568 ## File path: blueprints/server-capabilitites.md ## @@ -0,0 +1,164 @@ + +# Server Capabilities + +##

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3966: Add server capabilities API

2019-10-11 Thread GitBox
mitchell852 edited a comment on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-541195588 > 5. When a post with no body is made. the following error is provided. > > ``` > "alerts": [ > { >

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang

2019-10-11 Thread GitBox
mhoppa commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang URL: https://github.com/apache/trafficcontrol/pull/3967#discussion_r334155561 ## File path: traffic_ops/traffic_ops_golang/federations/ds.go ## @@ -123,11 +131,93 @@

[GitHub] [trafficcontrol] lbathina commented on issue #3977: TP: Adds Server Capabilities UI

2019-10-11 Thread GitBox
lbathina commented on issue #3977: TP: Adds Server Capabilities UI URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541208904 > > Also there should be a check on only special characters - system should not accept only special characters. > > define special

[GitHub] [trafficcontrol] lbathina edited a comment on issue #3977: TP: Adds Server Capabilities UI

2019-10-11 Thread GitBox
lbathina edited a comment on issue #3977: TP: Adds Server Capabilities UI URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541208904 > > Also there should be a check on only special characters - system should not accept only special characters. > > define special

[GitHub] [trafficcontrol] lbathina edited a comment on issue #3977: TP: Adds Server Capabilities UI

2019-10-11 Thread GitBox
lbathina edited a comment on issue #3977: TP: Adds Server Capabilities UI URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541208904 > > Also there should be a check on only special characters - system should not accept only special characters. > > define special

[GitHub] [trafficcontrol] asf-ci commented on issue #3870: Rewrite /capabilities to Go

2019-10-11 Thread GitBox
asf-ci commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-541210512 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4464/

Build failed in Jenkins: trafficcontrol-PR #4464

2019-10-11 Thread Apache Jenkins Server
See Changes: [ocket] Rewrite profile import to Go (#3930) [ocket] On cachestats get if all TMs fail to return data return failure (#3926) [ocket] Remove atstccfg unused code (#3960) [ocket]

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3972: Add Server Capabilities blueprint

2019-10-11 Thread GitBox
mitchell852 commented on a change in pull request #3972: Add Server Capabilities blueprint URL: https://github.com/apache/trafficcontrol/pull/3972#discussion_r334117890 ## File path: blueprints/server-capabilitites.md ## @@ -0,0 +1,164 @@ + +# Server Capabilities + +##

[GitHub] [trafficcontrol] ocket8888 merged pull request #3985: Remove commented out PATCH /jobs code, api_capability, and docs

2019-10-11 Thread GitBox
ocket merged pull request #3985: Remove commented out PATCH /jobs code, api_capability, and docs URL: https://github.com/apache/trafficcontrol/pull/3985 This is an automated message from the Apache Git Service. To

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1570

2019-10-11 Thread Apache Jenkins Server
See Changes: [ocket] Remove commented out PATCH /jobs code, api_capability, and docs (#3985) -- Started by an SCM change Started by an SCM change

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang

2019-10-11 Thread GitBox
ocket commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang URL: https://github.com/apache/trafficcontrol/pull/3967#discussion_r334146811 ## File path: traffic_ops/traffic_ops_golang/federations/ds.go ## @@ -123,11 +131,93

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang

2019-10-11 Thread GitBox
ocket commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang URL: https://github.com/apache/trafficcontrol/pull/3967#discussion_r334146455 ## File path: traffic_ops/traffic_ops_golang/federations/ds.go ## @@ -123,11 +131,93

[GitHub] [trafficcontrol] rawlinp opened a new pull request #3987: Add extension user config to CIAB TO API tests

2019-10-11 Thread GitBox
rawlinp opened a new pull request #3987: Add extension user config to CIAB TO API tests URL: https://github.com/apache/trafficcontrol/pull/3987 ## What does this PR (Pull Request) do? The extension user config was recently added to the TO API tests and needs to be added

[GitHub] [trafficcontrol] ocket8888 commented on issue #3901: Fixed runtime panic when creating roles, added docs

2019-10-11 Thread GitBox
ocket commented on issue #3901: Fixed runtime panic when creating roles, added docs URL: https://github.com/apache/trafficcontrol/pull/3901#issuecomment-541205261 retest this please This is an automated message from the

[GitHub] [trafficcontrol] lbathina commented on issue #3977: TP: Adds Server Capabilities UI

2019-10-11 Thread GitBox
lbathina commented on issue #3977: TP: Adds Server Capabilities UI URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541209743 > > I'd like to remove allowing dot, if no one objects. > > I'm good with that. Is this a good UI error message? > > `Must be

[GitHub] [trafficcontrol] asf-ci commented on issue #3870: Rewrite /capabilities to Go

2019-10-11 Thread GitBox
asf-ci commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-541227233 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4465/

Build failed in Jenkins: trafficcontrol-PR #4465

2019-10-11 Thread Apache Jenkins Server
See Changes: [ocket] fix compilation error [ocket] Switch URL building to use proper net/url encoding -- GitHub pull request #3870 of commit

[GitHub] [trafficcontrol] asf-ci commented on issue #3988: WIP Remove Traffic Ops Golang legacy tc.ApiErrorType

2019-10-11 Thread GitBox
asf-ci commented on issue #3988: WIP Remove Traffic Ops Golang legacy tc.ApiErrorType URL: https://github.com/apache/trafficcontrol/pull/3988#issuecomment-541237431 Can one of the admins verify this patch? This is an

Build failed in Jenkins: trafficcontrol-PR #4466

2019-10-11 Thread Apache Jenkins Server
See Changes: -- GitHub pull request #3977 of commit 576dc0b61a243a93270a977f942ea95f951c78df, has merge conflicts. Running as SYSTEM Setting status of

[GitHub] [trafficcontrol] mitchell852 commented on issue #3966: Add server capabilities API

2019-10-11 Thread GitBox
mitchell852 commented on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-541107333 > Trimming whitespace should be fine. It should be documented, but the extra safety seems like a good thing to me. agree

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3966: Add server capabilities API

2019-10-11 Thread GitBox
mitchell852 edited a comment on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-541107445 > Unknown parameters should be ignored. unknown query params that is. agree.

[GitHub] [trafficcontrol] mitchell852 commented on issue #3966: Add server capabilities API

2019-10-11 Thread GitBox
mitchell852 commented on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-541107445 > Unknown parameters should be ignored. agree This is an automated

[GitHub] [trafficcontrol] mitchell852 commented on issue #3977: TP: Adds Server Capabilities UI

2019-10-11 Thread GitBox
mitchell852 commented on issue #3977: TP: Adds Server Capabilities UI URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541110531 > Also there should be a check on only special characters - system should not accept only special characters. define special

Build failed in Jenkins: trafficcontrol-PR #4455

2019-10-11 Thread Apache Jenkins Server
See Changes: [rawlin_peters] Add server_capability goose migration [rawlin_peters] Add server_capabilities API endpoints [rawlin_peters] Add server capabilities methods to TO-Go client [rawlin_peters] Add TO

[GitHub] [trafficcontrol] asf-ci commented on issue #3966: Add server capabilities API

2019-10-11 Thread GitBox
asf-ci commented on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-541134208 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4455/

[GitHub] [trafficcontrol] rob05c edited a comment on issue #3982: Add Traffic Monitor gbps calculated stat.

2019-10-11 Thread GitBox
rob05c edited a comment on issue #3982: Add Traffic Monitor gbps calculated stat. URL: https://github.com/apache/trafficcontrol/pull/3982#issuecomment-541090806 Thanks! This is great, this small change is a big help to CDN operators! Would you mind adding a `CHANGELOG.md` entry?

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1569

2019-10-11 Thread Apache Jenkins Server
See Changes: [ocket] Fix broken api tests (#3983) -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables.

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3966: Add server capabilities API

2019-10-11 Thread GitBox
mitchell852 edited a comment on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-541107445 > Unknown parameters should be ignored. unknown query params that is. agree. plus this is how our api has always behaved.

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3977: TP: Adds Server Capabilities UI

2019-10-11 Thread GitBox
mitchell852 edited a comment on issue #3977: TP: Adds Server Capabilities UI URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541109856 > I'd like to remove allowing dot, if no one objects. I'm good with that. Is this a good UI error message? `Must be

[GitHub] [trafficcontrol] ocket8888 commented on issue #3982: Add Traffic Monitor gbps calculated stat.

2019-10-11 Thread GitBox
ocket commented on issue #3982: Add Traffic Monitor gbps calculated stat. URL: https://github.com/apache/trafficcontrol/pull/3982#issuecomment-541127065 With this change, what happens if there are conflicting maxKBPS and maxGBPS Parameters?

[GitHub] [trafficcontrol] asf-ci commented on issue #3966: Add server capabilities API

2019-10-11 Thread GitBox
asf-ci commented on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-541137404 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4458/

Build failed in Jenkins: trafficcontrol-PR #4458

2019-10-11 Thread Apache Jenkins Server
See Changes: [rawlin_peters] Add server_capability goose migration [rawlin_peters] Add server_capabilities API endpoints [rawlin_peters] Add server capabilities methods to TO-Go client [rawlin_peters] Add TO

[GitHub] [trafficcontrol] asf-ci commented on issue #3983: Fix broken api tests

2019-10-11 Thread GitBox
asf-ci commented on issue #3983: Fix broken api tests URL: https://github.com/apache/trafficcontrol/pull/3983#issuecomment-541137126 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4457/

Build failed in Jenkins: trafficcontrol-PR #4457

2019-10-11 Thread Apache Jenkins Server
See Changes: [Michael_Hoppal] Fix broken api tests -- GitHub pull request #3983 of commit 230609efbf239cc8bf7e38521d773b9888d3bd41, no merge conflicts. Running as

Build failed in Jenkins: trafficcontrol-PR #4459

2019-10-11 Thread Apache Jenkins Server
See Changes: [ocket] Rewrite profile import to Go (#3930) [ocket] On cachestats get if all TMs fail to return data return failure (#3926) [ocket] Remove atstccfg unused code (#3960) [ocket]

[GitHub] [trafficcontrol] asf-ci commented on issue #3983: Fix broken api tests

2019-10-11 Thread GitBox
asf-ci commented on issue #3983: Fix broken api tests URL: https://github.com/apache/trafficcontrol/pull/3983#issuecomment-541141465 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4459/

[GitHub] [trafficcontrol] rawlinp opened a new pull request #3985: Remove commented out PATCH /jobs code, api_capability, and docs

2019-10-11 Thread GitBox
rawlinp opened a new pull request #3985: Remove commented out PATCH /jobs code, api_capability, and docs URL: https://github.com/apache/trafficcontrol/pull/3985 ## What does this PR (Pull Request) do? The PATCH method was not included and should not be referenced by

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3870: Rewrite /capabilities to Go

2019-10-11 Thread GitBox
ocket commented on a change in pull request #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r334100766 ## File path: lib/go-tc/capabilities.go ## @@ -0,0 +1,38 @@ +package tc + +/* + * Licensed to the Apache

[GitHub] [trafficcontrol] mitchell852 commented on issue #3977: TP: Adds Server Capabilities UI

2019-10-11 Thread GitBox
mitchell852 commented on issue #3977: TP: Adds Server Capabilities UI URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541108652 > leading and trailing spaces are ignore and doesn't throw errors. i think that's fine. the api strips them out.

[GitHub] [trafficcontrol] rob05c commented on issue #3982: Add Traffic Monitor gbps calculated stat.

2019-10-11 Thread GitBox
rob05c commented on issue #3982: Add Traffic Monitor gbps calculated stat. URL: https://github.com/apache/trafficcontrol/pull/3982#issuecomment-541128257 You mean as threshold? You can apply any number of thresholds to the Monitor. Whatever is lowest will make it Unavailable first.

[GitHub] [trafficcontrol] mhoppa opened a new pull request #3983: Fix broken api tests

2019-10-11 Thread GitBox
mhoppa opened a new pull request #3983: Fix broken api tests URL: https://github.com/apache/trafficcontrol/pull/3983 ## What does this PR (Pull Request) do? - [x] This PR fixes is not related to any Issue ## Which Traffic Control components are affected by this

[GitHub] [trafficcontrol] ocket8888 merged pull request #3983: Fix broken api tests

2019-10-11 Thread GitBox
ocket merged pull request #3983: Fix broken api tests URL: https://github.com/apache/trafficcontrol/pull/3983 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [trafficcontrol] asf-ci commented on issue #3985: Remove commented out PATCH /jobs code, api_capability, and docs

2019-10-11 Thread GitBox
asf-ci commented on issue #3985: Remove commented out PATCH /jobs code, api_capability, and docs URL: https://github.com/apache/trafficcontrol/pull/3985#issuecomment-541152432 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] rawlinp commented on issue #3966: Add server capabilities API

2019-10-11 Thread GitBox
rawlinp commented on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-541113266 > 1. ``` > "alerts": [ > { > "text": "no server capability with that id found", > "level": "error"

[GitHub] [trafficcontrol] vincentalfred commented on a change in pull request #3982: Add Traffic Monitor gbps calculated stat.

2019-10-11 Thread GitBox
vincentalfred commented on a change in pull request #3982: Add Traffic Monitor gbps calculated stat. URL: https://github.com/apache/trafficcontrol/pull/3982#discussion_r334056340 ## File path: traffic_monitor/cache/cache.go ## @@ -154,6 +154,9 @@ func ComputedStats()

[GitHub] [trafficcontrol] ocket8888 commented on issue #2456: Add TO Go delete deliveryservice_user

2019-10-11 Thread GitBox
ocket commented on issue #2456: Add TO Go delete deliveryservice_user URL: https://github.com/apache/trafficcontrol/pull/2456#issuecomment-541123572 we shouldn't rewrite this using query instead of path parameters - that breaks the API contract.

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs

2019-10-11 Thread GitBox
ocket commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs URL: https://github.com/apache/trafficcontrol/pull/3901#discussion_r334072039 ## File path: traffic_ops/traffic_ops_golang/role/roles.go ## @@ -177,12 +179,16 @@

[GitHub] [trafficcontrol] vincentalfred commented on issue #3982: Add Traffic Monitor gbps calculated stat.

2019-10-11 Thread GitBox
vincentalfred commented on issue #3982: Add Traffic Monitor gbps calculated stat. URL: https://github.com/apache/trafficcontrol/pull/3982#issuecomment-541118094 I'm relatively new to Go and open source. I'll update the changelog and try to create a unit test for it. Thanks for the

[GitHub] [trafficcontrol] asf-ci commented on issue #3972: Add Server Capabilities blueprint

2019-10-11 Thread GitBox
asf-ci commented on issue #3972: Add Server Capabilities blueprint URL: https://github.com/apache/trafficcontrol/pull/3972#issuecomment-541118026 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4453/

Build failed in Jenkins: trafficcontrol-PR #4456

2019-10-11 Thread Apache Jenkins Server
See Changes: [ocket] Rewrite profile import to Go (#3930) [ocket] On cachestats get if all TMs fail to return data return failure (#3926) [ocket] Remove atstccfg unused code (#3960) [ocket]

[GitHub] [trafficcontrol] asf-ci commented on issue #3901: Fixed runtime panic when creating roles, added docs

2019-10-11 Thread GitBox
asf-ci commented on issue #3901: Fixed runtime panic when creating roles, added docs URL: https://github.com/apache/trafficcontrol/pull/3901#issuecomment-541136621 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs

2019-10-11 Thread GitBox
mhoppa commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs URL: https://github.com/apache/trafficcontrol/pull/3901#discussion_r334076999 ## File path: traffic_ops/traffic_ops_golang/role/roles.go ## @@ -177,12 +179,16 @@ func

Build failed in Jenkins: trafficcontrol-master-build #1527

2019-10-11 Thread Apache Jenkins Server
See Changes: [ocket] Fix broken api tests (#3983) -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment variables. Building

[GitHub] [trafficcontrol] ocket8888 commented on issue #3870: Rewrite /capabilities to Go

2019-10-11 Thread GitBox
ocket commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-541257724 retest this please This is an automated message from the Apache Git Service. To

[GitHub] [trafficcontrol] asf-ci commented on issue #3977: TP: Adds Server Capabilities UI

2019-10-11 Thread GitBox
asf-ci commented on issue #3977: TP: Adds Server Capabilities UI URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541263780 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4472/

Build failed in Jenkins: trafficcontrol-PR #4472

2019-10-11 Thread Apache Jenkins Server
See Changes: [rawlin_peters] Add server_capability goose migration [rawlin_peters] Add server_capabilities API endpoints [rawlin_peters] Add server capabilities methods to TO-Go client [rawlin_peters] Add TO

[GitHub] [trafficcontrol] asf-ci commented on issue #3758: Rewrote deliveryservice_stats to Go

2019-10-11 Thread GitBox
asf-ci commented on issue #3758: Rewrote deliveryservice_stats to Go URL: https://github.com/apache/trafficcontrol/pull/3758#issuecomment-541278486 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4479/

Build failed in Jenkins: trafficcontrol-PR #4479

2019-10-11 Thread Apache Jenkins Server
See Changes: [ocket] Remove commented out PATCH /jobs code, api_capability, and docs (#3985) [ocket] Rewrote deliveryservice_stats to Go [ocket] Fixed api.CreateInfluxClient always attempting to

[GitHub] [trafficcontrol] asf-ci commented on issue #3977: TP: Adds Server Capabilities UI

2019-10-11 Thread GitBox
asf-ci commented on issue #3977: TP: Adds Server Capabilities UI URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541262383 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4471/

Build failed in Jenkins: trafficcontrol-PR #4471

2019-10-11 Thread Apache Jenkins Server
See Changes: -- GitHub pull request #3977 of commit 6468a23a75ade33ca2c1da967f5be943c49dca95, has merge conflicts. Running as SYSTEM Setting status of

[GitHub] [trafficcontrol] asf-ci commented on issue #3766: Cachegroup fallbacks deprecation

2019-10-11 Thread GitBox
asf-ci commented on issue #3766: Cachegroup fallbacks deprecation URL: https://github.com/apache/trafficcontrol/pull/3766#issuecomment-541278384 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4477/

Build failed in Jenkins: trafficcontrol-PR #4477

2019-10-11 Thread Apache Jenkins Server
See Changes: [ocket] Remove commented out PATCH /jobs code, api_capability, and docs (#3985) [ocket] Added deprecation notice for cachegroup_fallbacks [ocket] fixed missing documentation for

Build failed in Jenkins: trafficcontrol-PR #4478

2019-10-11 Thread Apache Jenkins Server
See Changes: [ocket] Rewrote capabilities endpoints to GO [ocket] Fixed incorrect parameter contraint [ocket] Added godoc [ocket] Added support in the Go Client for capabilities [ocket]

[GitHub] [trafficcontrol] asf-ci commented on issue #3870: Rewrite /capabilities to Go

2019-10-11 Thread GitBox
asf-ci commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-541278437 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4478/

[GitHub] [trafficcontrol] asf-ci commented on issue #3870: Rewrite /capabilities to Go

2019-10-11 Thread GitBox
asf-ci commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-541250927 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4467/

Jenkins build is back to normal : trafficcontrol-PR #4467

2019-10-11 Thread Apache Jenkins Server
See

Build failed in Jenkins: trafficcontrol-PR #4469

2019-10-11 Thread Apache Jenkins Server
See Changes: [ocket] Rewrote capabilities endpoints to GO [ocket] Fixed incorrect parameter contraint [ocket] Added godoc [ocket] Added support in the Go Client for capabilities [ocket]

[GitHub] [trafficcontrol] ocket8888 commented on issue #3766: Cachegroup fallbacks deprecation

2019-10-11 Thread GitBox
ocket commented on issue #3766: Cachegroup fallbacks deprecation URL: https://github.com/apache/trafficcontrol/pull/3766#issuecomment-541257332 > _The cachegroup_fallbacks endpoints should have a deprecation message added to its response_ done.

[GitHub] [trafficcontrol] asf-ci commented on issue #3870: Rewrite /capabilities to Go

2019-10-11 Thread GitBox
asf-ci commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-541257304 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4469/

[GitHub] [trafficcontrol] asf-ci commented on issue #3967: Rewrite DELETE federation delivery service to golang

2019-10-11 Thread GitBox
asf-ci commented on issue #3967: Rewrite DELETE federation delivery service to golang URL: https://github.com/apache/trafficcontrol/pull/3967#issuecomment-541266091 Refer to this link for build results (access rights to CI server needed):

Jenkins build is back to normal : trafficcontrol-PR #4473

2019-10-11 Thread Apache Jenkins Server
See

[GitHub] [trafficcontrol] asf-ci commented on issue #3901: Fixed runtime panic when creating roles, added docs

2019-10-11 Thread GitBox
asf-ci commented on issue #3901: Fixed runtime panic when creating roles, added docs URL: https://github.com/apache/trafficcontrol/pull/3901#issuecomment-541268568 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] ocket8888 merged pull request #3967: Rewrite DELETE federation delivery service to golang

2019-10-11 Thread GitBox
ocket merged pull request #3967: Rewrite DELETE federation delivery service to golang URL: https://github.com/apache/trafficcontrol/pull/3967 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [trafficcontrol] ocket8888 closed issue #3794: Rewrite /federations/{{id}}/deliveryservices/{{DSID}} to Go

2019-10-11 Thread GitBox
ocket closed issue #3794: Rewrite /federations/{{id}}/deliveryservices/{{DSID}} to Go URL: https://github.com/apache/trafficcontrol/issues/3794 This is an automated message from the Apache Git Service. To respond to the

Build failed in Jenkins: trafficcontrol-PR #4470

2019-10-11 Thread Apache Jenkins Server
See Changes: [Michael_Hoppal] Rewrite DELETE federation delivery service to golang [Michael_Hoppal] Fix test case [Michael_Hoppal] Dont change path as part of rewrite [Michael_Hoppal] Minor fix

Jenkins build is back to normal : trafficcontrol-master-build #1529

2019-10-11 Thread Apache Jenkins Server
See

[GitHub] [trafficcontrol] asf-ci commented on issue #3870: Rewrite /capabilities to Go

2019-10-11 Thread GitBox
asf-ci commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-541278280 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4476/

Build failed in Jenkins: trafficcontrol-PR #4476

2019-10-11 Thread Apache Jenkins Server
See Changes: [ocket] Fix broken api tests (#3983) [ocket] Rewrote capabilities endpoints to GO [ocket] Fixed incorrect parameter contraint [ocket] Added godoc [ocket] Added support in

Build failed in Jenkins: trafficcontrol-PR #4468

2019-10-11 Thread Apache Jenkins Server
See Changes: [Michael_Hoppal] Rewrite DELETE federation delivery service to golang [Michael_Hoppal] Fix test case [Michael_Hoppal] Dont change path as part of rewrite

Jenkins build is back to normal : trafficcontrol-traffic_ops-test #1571

2019-10-11 Thread Apache Jenkins Server
See

  1   2   >