[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r340118459 ## File path:

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r340118606 ## File path:

[GitHub] [trafficcontrol] lbathina opened a new issue #4038: TP, TO: server capabilities are allowed to be assigned to any servers which are not mid or edge

lbathina opened a new issue #4038: TP, TO: server capabilities are allowed to be assigned to any servers which are not mid or edge URL: https://github.com/apache/trafficcontrol/issues/4038 ## I'm submitting a ... - [X] bug report - [ ] new feature /

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r340143304 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4037: Docs/influx fix

mhoppa commented on a change in pull request #4037: Docs/influx fix URL: https://github.com/apache/trafficcontrol/pull/4037#discussion_r340099493 ## File path: docs/source/admin/traffic_ops.rst ## @@ -0,0 +1,706 @@ +.. +.. +.. Licensed under the Apache License, Version 2.0

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4037: Docs/influx fix

mhoppa commented on a change in pull request #4037: Docs/influx fix URL: https://github.com/apache/trafficcontrol/pull/4037#discussion_r340090954 ## File path: docs/source/admin/traffic_ops.rst ## @@ -0,0 +1,706 @@ +.. +.. +.. Licensed under the Apache License, Version 2.0

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4037: Docs/influx fix

ocket commented on a change in pull request #4037: Docs/influx fix URL: https://github.com/apache/trafficcontrol/pull/4037#discussion_r340130735 ## File path: docs/source/admin/traffic_ops.rst ## @@ -0,0 +1,706 @@ +.. +.. +.. Licensed under the Apache License, Version

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4037: Docs/influx fix

ocket commented on a change in pull request #4037: Docs/influx fix URL: https://github.com/apache/trafficcontrol/pull/4037#discussion_r340136332 ## File path: docs/source/admin/traffic_ops.rst ## @@ -0,0 +1,706 @@ +.. +.. +.. Licensed under the Apache License, Version

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r340105300 ## File path: docs/source/admin/traffic_router.rst ## @@ -681,8

Jenkins build is back to normal : trafficcontrol-traffic_ops-test #1611

See

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

rawlinp commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r340242557 ## File path: traffic_ops/app/conf/cdn.conf ## @@ -1,7 +1,7 @@ { "hypnotoad" : {

[GitHub] [trafficcontrol] ocket8888 closed issue #3847: Rewrite /cache_stats to Go

ocket closed issue #3847: Rewrite /cache_stats to Go URL: https://github.com/apache/trafficcontrol/issues/3847 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [trafficcontrol] ocket8888 merged pull request #4029: Rewrite cache_stats to Golang

ocket merged pull request #4029: Rewrite cache_stats to Golang URL: https://github.com/apache/trafficcontrol/pull/4029 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [trafficcontrol] asf-ci commented on issue #4015: Rewrite /federations to Go - POST/PUT/DELETE

asf-ci commented on issue #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#issuecomment-547565073 Refer to this link for build results (access rights to CI server needed):

Jenkins build is back to normal : trafficcontrol-PR #4664

See

Jenkins build is back to normal : trafficcontrol-master-build #1568

See

[GitHub] [trafficcontrol] rawlinp closed issue #3790: Rewrite /federations to Go

rawlinp closed issue #3790: Rewrite /federations to Go URL: https://github.com/apache/trafficcontrol/issues/3790 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [trafficcontrol] rawlinp merged pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

rawlinp merged pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015 This is an automated message from the Apache Git Service. To respond to the message,

Build failed in Jenkins: trafficcontrol-PR #4663

See Changes: [ocket] Moved some images, unset executable bit and shebang on non-executable [ocket] Fixed some documentation warnings generated from Python files [ocket] Added kickstart setup QHT

[GitHub] [trafficcontrol] asf-ci commented on issue #4037: Docs/influx fix

asf-ci commented on issue #4037: Docs/influx fix URL: https://github.com/apache/trafficcontrol/pull/4037#issuecomment-547550071 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4663/

[GitHub] [trafficcontrol] lbathina edited a comment on issue #4033: To: INternal server error when server capability associated with Server/ds is deleted

lbathina edited a comment on issue #4033: To: INternal server error when server capability associated with Server/ds is deleted URL: https://github.com/apache/trafficcontrol/issues/4033#issuecomment-547551139 same issue appears while deleting a server capability associated to a delivery

[GitHub] [trafficcontrol] lbathina commented on issue #4033: To: INternal server error when server capability associated with Server/ds is deleted

lbathina commented on issue #4033: To: INternal server error when server capability associated with Server/ds is deleted URL: https://github.com/apache/trafficcontrol/issues/4033#issuecomment-547551139 same applies to deleting a server capability associated to a delivery service

[GitHub] [trafficcontrol] rawlinp merged pull request #4037: Docs/influx fix

rawlinp merged pull request #4037: Docs/influx fix URL: https://github.com/apache/trafficcontrol/pull/4037 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

ocket commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r340247925 ## File path: traffic_ops/app/conf/cdn.conf ## @@ -1,7 +1,7 @@ { "hypnotoad" : {

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4030: Rewrite PUT /api/1.1/servers/:id/status to Go

ocket commented on a change in pull request #4030: Rewrite PUT /api/1.1/servers/:id/status to Go URL: https://github.com/apache/trafficcontrol/pull/4030#discussion_r340265485 ## File path: traffic_ops/testing/api/v14/serverupdatestatus_test.go ## @@ -0,0 +1,149 @@

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4030: Rewrite PUT /api/1.1/servers/:id/status to Go

ocket commented on a change in pull request #4030: Rewrite PUT /api/1.1/servers/:id/status to Go URL: https://github.com/apache/trafficcontrol/pull/4030#discussion_r340269064 ## File path: traffic_ops/traffic_ops_golang/server/put_status.go ## @@ -0,0 +1,137 @@

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4030: Rewrite PUT /api/1.1/servers/:id/status to Go

rawlinp commented on a change in pull request #4030: Rewrite PUT /api/1.1/servers/:id/status to Go URL: https://github.com/apache/trafficcontrol/pull/4030#discussion_r340284109 ## File path: traffic_ops/traffic_ops_golang/server/put_status.go ## @@ -0,0 +1,137 @@ +package

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

ocket commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r340233091 ## File path: docs/source/api/federations.rst ## @@ -150,82 +173,122 @@ Request Structure

Build failed in Jenkins: trafficcontrol-PR #4665

See Changes: -- GitHub pull request #4015 of commit 879c4ed196152934e88452f2d1e9c04e6db092ea, no merge conflicts. Running as SYSTEM Setting status of

[GitHub] [trafficcontrol] asf-ci commented on issue #4015: Rewrite /federations to Go - POST/PUT/DELETE

asf-ci commented on issue #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#issuecomment-547569594 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1614

See Changes: [rawlin_peters] Rewrite /federations to Go - POST/PUT/DELETE (#4015) -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node

[GitHub] [trafficcontrol] rob05c commented on issue #4038: TP, TO: server capabilities are allowed to be assigned to any servers which are not mid or edge

rob05c commented on issue #4038: TP, TO: server capabilities are allowed to be assigned to any servers which are not mid or edge URL: https://github.com/apache/trafficcontrol/issues/4038#issuecomment-547493652 Eh, you're right. Postgres check constraints can't reference other tables (the

[GitHub] [trafficcontrol] rob05c edited a comment on issue #4038: TP, TO: server capabilities are allowed to be assigned to any servers which are not mid or edge

rob05c edited a comment on issue #4038: TP, TO: server capabilities are allowed to be assigned to any servers which are not mid or edge URL: https://github.com/apache/trafficcontrol/issues/4038#issuecomment-547493652 Eh, you're right. Postgres check constraints can't reference other tables

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

rawlinp commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r340187114 ## File path: traffic_ops/traffic_ops_golang/federations/federations.go ## @@ -167,3 +206,296 @@

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

rawlinp commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r340193455 ## File path: traffic_ops/traffic_ops_golang/federations/federations.go ## @@ -167,3 +206,296 @@

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

rawlinp commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r340160646 ## File path: traffic_ops/traffic_ops_golang/federations/federations.go ## @@ -167,3 +206,296 @@

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

rawlinp commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r340145359 ## File path: docs/source/api/federations.rst ## @@ -150,82 +173,122 @@ Request Structure

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

rawlinp commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r340189103 ## File path: traffic_ops/traffic_ops_golang/federations/federations.go ## @@ -167,3 +206,296 @@

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4037: Docs/influx fix

rawlinp commented on a change in pull request #4037: Docs/influx fix URL: https://github.com/apache/trafficcontrol/pull/4037#discussion_r340199081 ## File path: docs/source/admin/traffic_ops.rst ## @@ -0,0 +1,708 @@ +.. +.. +.. Licensed under the Apache License, Version

[GitHub] [trafficcontrol] asf-ci commented on issue #4015: Rewrite /federations to Go - POST/PUT/DELETE

asf-ci commented on issue #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#issuecomment-547534429 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] ocket8888 commented on issue #4038: TP, TO: server capabilities are allowed to be assigned to any servers which are not mid or edge

ocket commented on issue #4038: TP, TO: server capabilities are allowed to be assigned to any servers which are not mid or edge URL: https://github.com/apache/trafficcontrol/issues/4038#issuecomment-547479747 So this has two parts, then: • Disallow assignment of server

[GitHub] [trafficcontrol] ocket8888 commented on issue #4039: TO, TP: server should not be allowed to be deleted when it has a DS assigned to it.

ocket commented on issue #4039: TO,TP: server should not be allowed to be deleted when it has a DS assigned to it. URL: https://github.com/apache/trafficcontrol/issues/4039#issuecomment-547508787 This seems like mainly a matter of opinion. I can't really see a good reason to delete

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4037: Docs/influx fix

ocket commented on a change in pull request #4037: Docs/influx fix URL: https://github.com/apache/trafficcontrol/pull/4037#discussion_r340220705 ## File path: docs/source/admin/traffic_ops.rst ## @@ -0,0 +1,708 @@ +.. +.. +.. Licensed under the Apache License, Version

[GitHub] [trafficcontrol] rob05c commented on issue #4038: TP, TO: server capabilities are allowed to be assigned to any servers which are not mid or edge

rob05c commented on issue #4038: TP, TO: server capabilities are allowed to be assigned to any servers which are not mid or edge URL: https://github.com/apache/trafficcontrol/issues/4038#issuecomment-547481110 I'd vote we also add a Database Constraint. Multiple failsafes are always

[GitHub] [trafficcontrol] asf-ci commented on issue #4037: Docs/influx fix

asf-ci commented on issue #4037: Docs/influx fix URL: https://github.com/apache/trafficcontrol/pull/4037#issuecomment-547481124 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4661/

Jenkins build is back to normal : trafficcontrol-PR #4661

See

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r340175558 ## File path: traffic_ops/app/bin/checks/ToAutorenewCerts.pl ##

[GitHub] [trafficcontrol] mhoppa commented on issue #4038: TP, TO: server capabilities are allowed to be assigned to any servers which are not mid or edge

mhoppa commented on issue #4038: TP, TO: server capabilities are allowed to be assigned to any servers which are not mid or edge URL: https://github.com/apache/trafficcontrol/issues/4038#issuecomment-547510780 I can do this issue. I can't assign myself so wanted to post so we dont have

[GitHub] [trafficcontrol] lbathina opened a new issue #4039: TO, TP: server should not be allowed to be deleted when it has a DS assigned to it.

lbathina opened a new issue #4039: TO,TP: server should not be allowed to be deleted when it has a DS assigned to it. URL: https://github.com/apache/trafficcontrol/issues/4039 ## I'm submitting a ... - [ ] bug report - [ ] new feature / enhancement request

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

ocket commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r340198521 ## File path: docs/source/api/federations.rst ## @@ -150,82 +173,122 @@ Request Structure

[GitHub] [trafficcontrol] mhoppa opened a new pull request #4042: Foreign key err handling regex was not catching tables with _'s

mhoppa opened a new pull request #4042: Foreign key err handling regex was not catching tables with _'s URL: https://github.com/apache/trafficcontrol/pull/4042 ## What does this PR (Pull Request) do? - [x] This PR fixes #4033 ## Which Traffic Control components

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4030: Rewrite PUT /api/1.1/servers/:id/status to Go

rawlinp commented on a change in pull request #4030: Rewrite PUT /api/1.1/servers/:id/status to Go URL: https://github.com/apache/trafficcontrol/pull/4030#discussion_r340286906 ## File path: traffic_ops/testing/api/v14/serverupdatestatus_test.go ## @@ -0,0 +1,149 @@

[GitHub] [trafficcontrol] lbathina opened a new issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigned required capability

lbathina opened a new issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigned required capability URL: https://github.com/apache/trafficcontrol/issues/4043 ## I'm submitting a ... - [X] bug report - [ ] new feature /

[GitHub] [trafficcontrol] asf-ci commented on issue #4030: Rewrite PUT /api/1.1/servers/:id/status to Go

asf-ci commented on issue #4030: Rewrite PUT /api/1.1/servers/:id/status to Go URL: https://github.com/apache/trafficcontrol/pull/4030#issuecomment-547597578 Refer to this link for build results (access rights to CI server needed):

Jenkins build is back to normal : trafficcontrol-PR #4666

See

[GitHub] [trafficcontrol] mhoppa opened a new pull request #4041: Block server servercapability delete if associated ds requires it

mhoppa opened a new pull request #4041: Block server servercapability delete if associated ds requires it URL: https://github.com/apache/trafficcontrol/pull/4041 ## What does this PR (Pull Request) do? - [x] This PR is not related to any Issue This PR adds in extra

[GitHub] [trafficcontrol] asf-ci commented on issue #4041: Block server servercapability delete if associated ds requires it

asf-ci commented on issue #4041: Block server servercapability delete if associated ds requires it URL: https://github.com/apache/trafficcontrol/pull/4041#issuecomment-547602091 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: trafficcontrol-PR #4667

See Changes: [ocket] Feature/add deliveryservice required capability (#4026) [ocket] Fix query parameter name (#4031) [ocket] Correct references to traffic vault (#4040) [rawlin_peters]

[GitHub] [trafficcontrol] rob05c commented on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability

rob05c commented on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability URL: https://github.com/apache/trafficcontrol/issues/4043#issuecomment-547670913 Removing unprivileged DSes in `/deliveryservices` endpoints isn't just

Jenkins build is back to normal : trafficcontrol-PR #4668

See

[GitHub] [trafficcontrol] asf-ci commented on issue #4042: Foreign key err handling regex was not catching tables with _'s

asf-ci commented on issue #4042: Foreign key err handling regex was not catching tables with _'s URL: https://github.com/apache/trafficcontrol/pull/4042#issuecomment-547641860 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] lbathina commented on issue #4036: TO: alert message on create server should be fixed.

lbathina commented on issue #4036: TO: alert message on create server should be fixed. URL: https://github.com/apache/trafficcontrol/issues/4036#issuecomment-547644180 I think message on almost all API should be revisited to make it more meaningful and user friendly.

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4041: Block server servercapability delete if associated ds requires it

ocket commented on a change in pull request #4041: Block server servercapability delete if associated ds requires it URL: https://github.com/apache/trafficcontrol/pull/4041#discussion_r340344156 ## File path: traffic_ops/traffic_ops_golang/server/servers_server_capability.go

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4041: Block server servercapability delete if associated ds requires it

ocket commented on a change in pull request #4041: Block server servercapability delete if associated ds requires it URL: https://github.com/apache/trafficcontrol/pull/4041#discussion_r340344578 ## File path: traffic_ops/testing/api/v14/cachegroupsdeliveryservices_test.go

[GitHub] [trafficcontrol] asf-ci commented on issue #4041: Block server servercapability delete if associated ds requires it

asf-ci commented on issue #4041: Block server servercapability delete if associated ds requires it URL: https://github.com/apache/trafficcontrol/pull/4041#issuecomment-547648825 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] ocket8888 commented on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability

ocket commented on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability URL: https://github.com/apache/trafficcontrol/issues/4043#issuecomment-547649192 No, this is - at least for DELETE - correct behavior. A user without

[GitHub] [trafficcontrol] lbathina edited a comment on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability

lbathina edited a comment on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability URL: https://github.com/apache/trafficcontrol/issues/4043#issuecomment-547652483 ``` 6.5.3. 403 Forbidden The 403 (Forbidden) status

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4041: Block server servercapability delete if associated ds requires it

rob05c commented on a change in pull request #4041: Block server servercapability delete if associated ds requires it URL: https://github.com/apache/trafficcontrol/pull/4041#discussion_r340359296 ## File path: traffic_ops/traffic_ops_golang/server/servers_server_capability.go

[GitHub] [trafficcontrol] ocket8888 commented on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability

ocket commented on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability URL: https://github.com/apache/trafficcontrol/issues/4043#issuecomment-547662350 Then why bother hiding Delivery Services in the response to

[GitHub] [trafficcontrol] asf-ci commented on issue #3996: Rewrote /user/current to Go

asf-ci commented on issue #3996: Rewrote /user/current to Go URL: https://github.com/apache/trafficcontrol/pull/3996#issuecomment-547662575 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4670/

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4041: Block server servercapability delete if associated ds requires it

ocket commented on a change in pull request #4041: Block server servercapability delete if associated ds requires it URL: https://github.com/apache/trafficcontrol/pull/4041#discussion_r340364678 ## File path: traffic_ops/traffic_ops_golang/server/servers_server_capability.go

[GitHub] [trafficcontrol] ocket8888 commented on issue #4036: TO: alert message on create server should be fixed.

ocket commented on issue #4036: TO: alert message on create server should be fixed. URL: https://github.com/apache/trafficcontrol/issues/4036#issuecomment-547650631 You're preaching to the choir here. The API cannot be reworked until API v2 is released, which mainly means not until

[GitHub] [trafficcontrol] lbathina edited a comment on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability

lbathina edited a comment on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability URL: https://github.com/apache/trafficcontrol/issues/4043#issuecomment-547652483 ```6.5.3. 403 Forbidden The 403 (Forbidden) status code

[GitHub] [trafficcontrol] lbathina edited a comment on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability

lbathina edited a comment on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability URL: https://github.com/apache/trafficcontrol/issues/4043#issuecomment-547652483 ``` 6.5.3. 403 Forbidden The 403 (Forbidden) status

[GitHub] [trafficcontrol] lbathina commented on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability

lbathina commented on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability URL: https://github.com/apache/trafficcontrol/issues/4043#issuecomment-547652483 ```6.5.3. 403 Forbidden The 403 (Forbidden) status code

[GitHub] [trafficcontrol] lbathina commented on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability

lbathina commented on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability URL: https://github.com/apache/trafficcontrol/issues/4043#issuecomment-547653383 so if we don't agree to be 403, it should be 404

[GitHub] [trafficcontrol] rob05c commented on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability

rob05c commented on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability URL: https://github.com/apache/trafficcontrol/issues/4043#issuecomment-547654920 I think I agree with @lbathina that it should be a `403 Forbidden`.

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4041: Block server servercapability delete if associated ds requires it

mhoppa commented on a change in pull request #4041: Block server servercapability delete if associated ds requires it URL: https://github.com/apache/trafficcontrol/pull/4041#discussion_r340354844 ## File path: traffic_ops/traffic_ops_golang/server/servers_server_capability.go

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4041: Block server servercapability delete if associated ds requires it

ocket commented on a change in pull request #4041: Block server servercapability delete if associated ds requires it URL: https://github.com/apache/trafficcontrol/pull/4041#discussion_r340361969 ## File path: traffic_ops/traffic_ops_golang/server/servers_server_capability.go

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4041: Block server servercapability delete if associated ds requires it

mhoppa commented on a change in pull request #4041: Block server servercapability delete if associated ds requires it URL: https://github.com/apache/trafficcontrol/pull/4041#discussion_r340362079 ## File path: traffic_ops/traffic_ops_golang/server/servers_server_capability.go