[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-05 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r321331054 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,111 @@ +pac

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-05 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r321275087 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,111 @@ +pac

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r321002901 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,111 @@ +pac

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r321000462 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,111 @@ +pac

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320919332 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,97 @@ +pack

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320845597 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,97 @@ +pack

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320848632 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,97 @@ +pack

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320760370 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @@ -119,6 +119,8 @@ func Rout

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320754572 ## File path: traffic_ops/testing/api/v14/cachegroups_parameters_test.go ## @@ -0,0 +1,91 @@ +/

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320755402 ## File path: traffic_ops/testing/api/v14/cachegroups_parameters_test.go ## @@ -0,0 +1,91 @@ +/

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320753420 ## File path: traffic_ops/testing/api/v14/cachegroups_parameters_test.go ## @@ -0,0 +1,91 @@ +/

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320748367 ## File path: lib/go-tc/cachegroup_parameters.go ## @@ -0,0 +1,32 @@ +package tc + +/* + * Lice

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320754829 ## File path: traffic_ops/testing/api/v14/cachegroups_parameters_test.go ## @@ -0,0 +1,91 @@ +/

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320647870 ## File path: docs/source/api/cachegroups_id_parameters.rst ## @@ -28,6 +28,14 @@ Gets all the