[GitHub] dneuman64 commented on a change in pull request #1827: This fixes an issue in Traffic Stats with getting the last summary time

dneuman64 commented on a change in pull request #1827: This fixes an issue in Traffic Stats with getting the last summary time URL: https://github.com/apache/incubator-trafficcontrol/pull/1827#discussion_r165068764 ## File path: traffic_stats/traffic_stats.go ## @@

[GitHub] asfgit commented on issue #1828: Cleaned up golint warnings

asfgit commented on issue #1828: Cleaned up golint warnings URL: https://github.com/apache/incubator-trafficcontrol/pull/1828#issuecomment-362009635 Refer to this link for build results (access rights to CI server needed):

[GitHub] alficles commented on issue #1643: Anonymous IP TO Implementation

alficles commented on issue #1643: Anonymous IP TO Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/1643#issuecomment-361979153 I see the implementation of the UI, but where are these values consumed? Is there a plugin I'm not aware of that implements this?

[GitHub] limited commented on a change in pull request #1799: Traffic Ops API/GUI configuration of FQ Pacing plugin

limited commented on a change in pull request #1799: Traffic Ops API/GUI configuration of FQ Pacing plugin URL: https://github.com/apache/incubator-trafficcontrol/pull/1799#discussion_r165101523 ## File path: traffic_ops/app/templates/delivery_service/_form.html.ep ## @@

[GitHub] PeterRyder commented on issue #736: Anonymous IP TR Implementation

PeterRyder commented on issue #736: Anonymous IP TR Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/736#issuecomment-361989018 Yes - I figured splitting this into 2 PRs would be easier to review

[GitHub] PeterRyder commented on issue #736: Anonymous IP TR Implementation

PeterRyder commented on issue #736: Anonymous IP TR Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/736#issuecomment-361989018 Yes - I figured splitting this into 2 PRs would be easier to review

[GitHub] dewrich opened a new pull request #1828: Cleaned up golint warnings

dewrich opened a new pull request #1828: Cleaned up golint warnings URL: https://github.com/apache/incubator-trafficcontrol/pull/1828 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] alficles commented on a change in pull request #1799: Traffic Ops API/GUI configuration of FQ Pacing plugin

alficles commented on a change in pull request #1799: Traffic Ops API/GUI configuration of FQ Pacing plugin URL: https://github.com/apache/incubator-trafficcontrol/pull/1799#discussion_r165081613 ## File path: traffic_ops/app/templates/delivery_service/_form.html.ep ##

[GitHub] alficles commented on a change in pull request #1799: Traffic Ops API/GUI configuration of FQ Pacing plugin

alficles commented on a change in pull request #1799: Traffic Ops API/GUI configuration of FQ Pacing plugin URL: https://github.com/apache/incubator-trafficcontrol/pull/1799#discussion_r165078834 ## File path: traffic_ops/app/lib/Schema/Result/Deliveryservice.pm ## @@

[GitHub] limited commented on a change in pull request #1799: Traffic Ops API/GUI configuration of FQ Pacing plugin

limited commented on a change in pull request #1799: Traffic Ops API/GUI configuration of FQ Pacing plugin URL: https://github.com/apache/incubator-trafficcontrol/pull/1799#discussion_r165100989 ## File path: traffic_ops/app/lib/Schema/Result/Deliveryservice.pm ## @@

[GitHub] PeterRyder commented on issue #1643: Anonymous IP TO Implementation

PeterRyder commented on issue #1643: Anonymous IP TO Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/1643#issuecomment-361989131 Yes - I figured splitting this into 2 PRs would be easier to review

[GitHub] PeterRyder commented on issue #1643: Anonymous IP TO Implementation

PeterRyder commented on issue #1643: Anonymous IP TO Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/1643#issuecomment-361988111 When the Cr-Config gets generated in the UI::Topology file, the routers will determine if anonymous blocking is enabled or disabled.

[GitHub] asfgit commented on issue #1827: This fixes an issue in Traffic Stats with getting the last summary time

asfgit commented on issue #1827: This fixes an issue in Traffic Stats with getting the last summary time URL: https://github.com/apache/incubator-trafficcontrol/pull/1827#issuecomment-362037209 Refer to this link for build results (access rights to CI server needed):

[GitHub] alficles commented on issue #809: Automatic License Checking with Weasel

alficles commented on issue #809: Automatic License Checking with Weasel URL: https://github.com/apache/incubator-trafficcontrol/pull/809#issuecomment-362047700 I went ahead and added the PATENTS lines to the LICENSE, based on guidance from legal-discuss.

[GitHub] alficles commented on a change in pull request #1799: Traffic Ops API/GUI configuration of FQ Pacing plugin

alficles commented on a change in pull request #1799: Traffic Ops API/GUI configuration of FQ Pacing plugin URL: https://github.com/apache/incubator-trafficcontrol/pull/1799#discussion_r165101974 ## File path: traffic_ops/app/lib/Schema/Result/Deliveryservice.pm ## @@

[GitHub] alficles commented on issue #1643: Anonymous IP TO Implementation

alficles commented on issue #1643: Anonymous IP TO Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/1643#issuecomment-361988740 Aha. I see now. this one depends on #736 . This is an automated

[GitHub] mitchell852 opened a new issue #1830: "Portal" role should have a higher priv level than the "read only" role

mitchell852 opened a new issue #1830: "Portal" role should have a higher priv level than the "read only" role URL: https://github.com/apache/incubator-trafficcontrol/issues/1830 Currently, the portal role has a priv level of 2 whereas the read-only role has a priv level of 10. This is

[GitHub] nir-sopher opened a new pull request #1832: traffic router re-authentication on unauthorized

nir-sopher opened a new pull request #1832: traffic router re-authentication on unauthorized URL: https://github.com/apache/incubator-trafficcontrol/pull/1832 Traffic router pulls the steering and federation cfg directly for traffic-ops. Every time it pulls the cfg, it tests if the

[GitHub] elsloo closed pull request #1824: adds the option to disable proxy usage at runtime

elsloo closed pull request #1824: adds the option to disable proxy usage at runtime URL: https://github.com/apache/incubator-trafficcontrol/pull/1824 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mitchell852 opened a new issue #1829: GET /api/1.3/cdns returns wrong response code and response format when unauthorized or forbidden

mitchell852 opened a new issue #1829: GET /api/1.3/cdns returns wrong response code and response format when unauthorized or forbidden URL: https://github.com/apache/incubator-trafficcontrol/issues/1829 If you try to access GET /api/1.3/cdns without being logged in (i.e. no valid cookie)

[GitHub] limited commented on a change in pull request #1825: updated docs to add some missing data

limited commented on a change in pull request #1825: updated docs to add some missing data URL: https://github.com/apache/incubator-trafficcontrol/pull/1825#discussion_r165144482 ## File path: docs/source/admin/traffic_ops/using.rst ## @@ -293,135 +293,136 @@ The fields

[GitHub] limited commented on a change in pull request #1825: updated docs to add some missing data

limited commented on a change in pull request #1825: updated docs to add some missing data URL: https://github.com/apache/incubator-trafficcontrol/pull/1825#discussion_r165144572 ## File path: docs/source/admin/traffic_ops/using.rst ## @@ -293,135 +293,136 @@ The fields

[GitHub] asfgit commented on issue #809: Automatic License Checking with Weasel

asfgit commented on issue #809: Automatic License Checking with Weasel URL: https://github.com/apache/incubator-trafficcontrol/pull/809#issuecomment-362061181 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 closed pull request #1811: Traffic Ops: remove unused get_type call that makes extra sql queries

mitchell852 closed pull request #1811: Traffic Ops: remove unused get_type call that makes extra sql queries URL: https://github.com/apache/incubator-trafficcontrol/pull/1811 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] mitchell852 commented on issue #1832: traffic router re-authentication on unauthorized

mitchell852 commented on issue #1832: traffic router re-authentication on unauthorized URL: https://github.com/apache/incubator-trafficcontrol/pull/1832#issuecomment-362062977 @nir-sopher - can you slap some labels on this? As a committer, you should be able to. thanks!

[GitHub] dneuman64 closed pull request #1834: Updated Traffic Server Admin Docs

dneuman64 closed pull request #1834: Updated Traffic Server Admin Docs URL: https://github.com/apache/incubator-trafficcontrol/pull/1834 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] dneuman64 commented on issue #1834: Updated Traffic Server Admin Docs

dneuman64 commented on issue #1834: Updated Traffic Server Admin Docs URL: https://github.com/apache/incubator-trafficcontrol/pull/1834#issuecomment-362068383 This fixes #1135 This is an automated message from the Apache Git

[GitHub] dneuman64 commented on issue #1135: Traffic Server administration docs are out of date

dneuman64 commented on issue #1135: Traffic Server administration docs are out of date URL: https://github.com/apache/incubator-trafficcontrol/issues/1135#issuecomment-362068727 This is closed by #1834 This is an automated

[GitHub] asfgit commented on issue #1824: adds the option to disable proxy usage at runtime

asfgit commented on issue #1824: adds the option to disable proxy usage at runtime URL: https://github.com/apache/incubator-trafficcontrol/pull/1824#issuecomment-362071102 Refer to this link for build results (access rights to CI server needed):

Jenkins build is back to normal : incubator-trafficcontrol-PR #961

See

[GitHub] asfgit commented on issue #1832: traffic router re-authentication on unauthorized

asfgit commented on issue #1832: traffic router re-authentication on unauthorized URL: https://github.com/apache/incubator-trafficcontrol/pull/1832#issuecomment-362075728 Refer to this link for build results (access rights to CI server needed):

Jenkins build is back to normal : incubator-trafficcontrol-rat #497

See

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #393

See Changes: [neuman] making a change in branch [neuman] updated ts admin docs [dewrich] increases portal priv level to above R/O role to better reflect what the

[GitHub] dewrich closed pull request #1833: [Issue-1830] - increases portal priv level to above R/O role to better reflect what ?

dewrich closed pull request #1833: [Issue-1830] - increases portal priv level to above R/O role to better reflect what ? URL: https://github.com/apache/incubator-trafficcontrol/pull/1833 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] mitchell852 opened a new pull request #1833: [Issue-1830] - increases portal priv level to above R/O role to better reflect what ?

mitchell852 opened a new pull request #1833: [Issue-1830] - increases portal priv level to above R/O role to better reflect what ? URL: https://github.com/apache/incubator-trafficcontrol/pull/1833 ?the portal role can actually do. but it is still below the privlevel of operations and

Build failed in Jenkins: incubator-trafficcontrol-PR #959

See Changes: [alficles] Add weasel to the docker build. [alficles] Update LICENSE and a few headers to fix weasel complaints. [alficles] Adding bin/docker-compose to .gitignore so it is properly

[GitHub] limited commented on issue #159: Should use "dest_ip" instead of "dest_domain" in "parent.config" and ?

limited commented on issue #159: Should use "dest_ip" instead of "dest_domain" in "parent.config" and ? URL: https://github.com/apache/incubator-trafficcontrol/pull/159#issuecomment-362065729 @jifyang Hey Jifeng- Can you please make same changes to ApacheTrafficServer.pm Also

Build failed in Jenkins: incubator-trafficcontrol-rat #496

See -- Started by upstream project "incubator-trafficcontrol-master-build" build number 538 originally caused by: Started by an SCM change Started by an SCM change

[GitHub] asfgit commented on issue #1833: [Issue-1830] - increases portal priv level to above R/O role to better reflect what ?

asfgit commented on issue #1833: [Issue-1830] - increases portal priv level to above R/O role to better reflect what ? URL: https://github.com/apache/incubator-trafficcontrol/pull/1833#issuecomment-362092680 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 commented on issue #1815: [issue 1814] Add fields to the reponse of POST/PUT steering target APIs

mitchell852 commented on issue #1815: [issue 1814] Add fields to the reponse of POST/PUT steering target APIs URL: https://github.com/apache/incubator-trafficcontrol/pull/1815#issuecomment-362062494 @jifyang - can you update the documentation too?

[GitHub] asfgit commented on issue #1824: adds the option to disable proxy usage at runtime

asfgit commented on issue #1824: adds the option to disable proxy usage at runtime URL: https://github.com/apache/incubator-trafficcontrol/pull/1824#issuecomment-362066847 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: incubator-trafficcontrol-PR #960

See -- GitHub pull request #1824 of commit ce41c9ece875335c51b8a6aaa3b56a945cdb63ce, no merge conflicts. [EnvInject] - Loading node environment variables. Building remotely

[GitHub] dneuman64 closed issue #1135: Traffic Server administration docs are out of date

dneuman64 closed issue #1135: Traffic Server administration docs are out of date URL: https://github.com/apache/incubator-trafficcontrol/issues/1135 This is an automated message from the Apache Git Service. To respond to the

[GitHub] dewrich closed issue #1830: "Portal" role should have a higher priv level than the "read only" role

dewrich closed issue #1830: "Portal" role should have a higher priv level than the "read only" role URL: https://github.com/apache/incubator-trafficcontrol/issues/1830 This is an automated message from the Apache Git

[GitHub] DylanVolz opened a new pull request #1835: fix authorization handling to use alerts and handle forbidden properly

DylanVolz opened a new pull request #1835: fix authorization handling to use alerts and handle forbidden properly URL: https://github.com/apache/incubator-trafficcontrol/pull/1835 fixes #1829 This is an automated message

[GitHub] ashish-timilsina opened a new pull request #1834: Updated Traffic Server Admin Docs

ashish-timilsina opened a new pull request #1834: Updated Traffic Server Admin Docs URL: https://github.com/apache/incubator-trafficcontrol/pull/1834 @dneuman64 This is an automated message from the Apache Git Service. To

[GitHub] ashish-timilsina commented on issue #1135: Traffic Server administration docs are out of date

ashish-timilsina commented on issue #1135: Traffic Server administration docs are out of date URL: https://github.com/apache/incubator-trafficcontrol/issues/1135#issuecomment-362068155 #1834 This is an automated message

[GitHub] alficles commented on issue #809: Automatic License Checking with Weasel

alficles commented on issue #809: Automatic License Checking with Weasel URL: https://github.com/apache/incubator-trafficcontrol/pull/809#issuecomment-362073836 @dangogh Looks like that build failed with an "out of disk space" error.

Build failed in Jenkins: incubator-trafficcontrol-PR #965

See -- GitHub pull request #1835 of commit 645f7305404e42361780c7dd0822689ace43f025, no merge conflicts. Setting status of 645f7305404e42361780c7dd0822689ace43f025 to PENDING

[GitHub] asfgit commented on issue #1835: fix authorization handling to use alerts and handle forbidden properly

asfgit commented on issue #1835: fix authorization handling to use alerts and handle forbidden properly URL: https://github.com/apache/incubator-trafficcontrol/pull/1835#issuecomment-362126807 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #1835: fix authorization handling to use alerts and handle forbidden properly

asfgit commented on issue #1835: fix authorization handling to use alerts and handle forbidden properly URL: https://github.com/apache/incubator-trafficcontrol/pull/1835#issuecomment-362135266 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: incubator-trafficcontrol-PR #966

See -- GitHub pull request #1835 of commit 051bc1041796e2b30edbeb862340c9bfbe68e324, no merge conflicts. Setting status of 051bc1041796e2b30edbeb862340c9bfbe68e324 to PENDING

[GitHub] asfgit commented on issue #1834: Updated Traffic Server Admin Docs

asfgit commented on issue #1834: Updated Traffic Server Admin Docs URL: https://github.com/apache/incubator-trafficcontrol/pull/1834#issuecomment-362111304 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh commented on a change in pull request #1804: prepared transactions from within a handler create a connections leak to postgres

dangogh commented on a change in pull request #1804: prepared transactions from within a handler create a connections leak to postgres URL: https://github.com/apache/incubator-trafficcontrol/pull/1804#discussion_r165229708 ## File path:

[GitHub] limited commented on a change in pull request #1825: updated docs to add some missing data

limited commented on a change in pull request #1825: updated docs to add some missing data URL: https://github.com/apache/incubator-trafficcontrol/pull/1825#discussion_r165163540 ## File path: docs/source/admin/traffic_ops/using.rst ## @@ -293,135 +293,136 @@ The fields

[GitHub] rawlinp opened a new issue #1831: Traffic Monitor shouldn't serve stale Delivery Services data in /publish/CrStates

rawlinp opened a new issue #1831: Traffic Monitor shouldn't serve stale Delivery Services data in /publish/CrStates URL: https://github.com/apache/incubator-trafficcontrol/issues/1831 When a Delivery Service is deleted from Traffic Ops and a snapshot is taken, Traffic Monitor should check

Build failed in Jenkins: incubator-trafficcontrol-PR #967

See -- GitHub pull request #1835 of commit 2cc7450e869090f0cc1f74be7541968468560370, no merge conflicts. Setting status of 2cc7450e869090f0cc1f74be7541968468560370 to PENDING

[GitHub] asfgit commented on issue #1835: fix authorization handling to use alerts and handle forbidden properly

asfgit commented on issue #1835: fix authorization handling to use alerts and handle forbidden properly URL: https://github.com/apache/incubator-trafficcontrol/pull/1835#issuecomment-362140339 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #283

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 966 originally caused by: GitHub pull request #1835 of commit

[GitHub] asfgit commented on issue #1835: fix authorization handling to use alerts and handle forbidden properly

asfgit commented on issue #1835: fix authorization handling to use alerts and handle forbidden properly URL: https://github.com/apache/incubator-trafficcontrol/pull/1835#issuecomment-362143311 Refer to this link for build results (access rights to CI server needed):

Jenkins build is back to normal : incubator-trafficcontrol-PR #968

See

[GitHub] RSK14 commented on issue #1783: AWS Traffic Sever

RSK14 commented on issue #1783: AWS Traffic Sever URL: https://github.com/apache/incubator-trafficcontrol/issues/1783#issuecomment-362157623 I had doubt if possible can use MySQL DB inside of PostgreSQL Traffic OPS DB? if you have any documents could you please share me thanks

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #284

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 968 originally caused by: GitHub pull request #1835 of commit

[GitHub] RSK14 commented on issue #1783: AWS Traffic Sever

RSK14 commented on issue #1783: AWS Traffic Sever URL: https://github.com/apache/incubator-trafficcontrol/issues/1783#issuecomment-362157623 I had doubt if possible can use MySQL DB inside of PostgreSQL Traffic OPS DB? if you have any documents could you please share me thanks