[GitHub] dangogh commented on a change in pull request #2010: Go login

2018-04-09 Thread GitBox
dangogh commented on a change in pull request #2010: Go login URL: https://github.com/apache/incubator-trafficcontrol/pull/2010#discussion_r180205545 ## File path: traffic_ops/traffic_ops_golang/auth/login.go ## @@ -0,0 +1,130 @@ +package auth + +/* + * Licensed to the Apa

[GitHub] dangogh commented on a change in pull request #2010: Go login

2018-04-04 Thread GitBox
dangogh commented on a change in pull request #2010: Go login URL: https://github.com/apache/incubator-trafficcontrol/pull/2010#discussion_r179322637 ## File path: traffic_ops/install/bin/_postinstall ## @@ -262,13 +262,15 @@ sub generateLdapConf { } } -

[GitHub] dangogh commented on a change in pull request #2010: Go login

2018-03-15 Thread GitBox
dangogh commented on a change in pull request #2010: Go login URL: https://github.com/apache/incubator-trafficcontrol/pull/2010#discussion_r174836451 ## File path: traffic_ops/traffic_ops_golang/auth/login.go ## @@ -0,0 +1,111 @@ +package auth Review comment: Needs t

[GitHub] dangogh commented on a change in pull request #2010: Go login

2018-03-15 Thread GitBox
dangogh commented on a change in pull request #2010: Go login URL: https://github.com/apache/incubator-trafficcontrol/pull/2010#discussion_r174836394 ## File path: traffic_ops/traffic_ops_golang/auth/ldap.go ## @@ -0,0 +1,101 @@ +package auth Review comment: Needs th