Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/947
Looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/947
An update to summarize updates from today:
After looking into it the core issue with the crash I was seeing is that
the read/write side of the VIOs where being called regardless of w
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/982/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1090/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/981/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1089/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/979/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1087/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/947
After doing some testing with this patch, I see crashes where write_to_net
is being called with a null vc lock.
```
(gdb) list
416 }
417 while ((vc = write_ready_list
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/957/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1065/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/947
@zwoop ping again :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/947
@zwoop ping :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/717/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/821/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/947
Sure, I ran it in a test env for a few days with no issues, I also have a
test case for the RST behavior which is passing as well.
Probably worth running on docs just to see if there
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/947
@jacksontj @zwoop Can we please run this on docs for a few days?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/814/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/710/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/947
I'm worried by the number of changes here. Has this been tested? What is
the risk of regression? Is this known to work on any platform other than Linux?
Can we add comments to describe why this
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/947
looks good to me. @jpeach, Can you review the finial code ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/622/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/726/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/607/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/711/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/606/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/587/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/691/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/947
That all sounds reasonable :) I just pushed a new commit here which does
effectively what you are suggesting-- just both on the read and write side (as
well as the few other little changes t
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/947
comments for codes:
```
if (get_ev_events(pd, x) & (EVENTIO_READ | EVENTIO_ERROR)) {
// ** set read.triggered if a epoll event of net has EVENTIO_READ
or EVENTIO_ERROR b
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/947
according your description, the HttpTunnel transfers the data from server
session to client session, ATS received a RST from client and the connection
between ATS and origin server is still aliv
Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/947
The behavior I see on master (without this patch) is that ATS doesn't close
the session when getting the RST. From digging that UnixNetHandler gets an
EPOLLERR -- which attempts to add it to
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/947
The InactivityCop will handle those netvc that read or write disabled.
InactivityCop will send TIMEOUT to SM or call close_UnixNetVConnection() to
close netvc directly depend on the last call
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/947
EVENTIO_ERROR means EPOLLHUP | EPOLLERR | EPOLLPRI.
EPOLLPRI means OOB or TCP URG is set. You will always receive EPOLLPRI with
EPOLLIN.
To EPOLLPRI, we need handle READ first and i
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/947
I don't think this is the right approach.
First, ``read_signal_error`` and ``write_signal_error`` don't need to be
made non-static since you already have
``UnixNetVConnection::readSign
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/947
/cc @oknet
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/947
Seems reasonable. I can't think why the errors shouldn't bubble up. We may
need to be a bit careful on handling them though.
---
If your project is set up for it, you can reply to thi
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/556/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/661/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/554/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/659/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/551/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/656/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/547/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/652/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/546/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/651/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/650/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/947
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/545/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
49 matches
Mail list logo
