[GitHub] trafficserver pull request #1623: Delete dead code

[zwoop]

Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1623


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1623: Delete dead code

[SolidWallOfCode]

Github user SolidWallOfCode commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1623#discussion_r109226190
  
--- Diff: proxy/logging/LogBuffer.cc ---
@@ -112,14 +112,6 @@ LogBufferHeader::log_filename()
   return addr;
 }
 
-/*-
-  LogBuffer::LogBuffer
--- End diff --

I talked with @danobi about this and my view is a local comment should be 
minimal and the real meat in the Architecture section of the documentation. 
This commentary has obviously not been maintained and I don't see it being any 
different in the future. At least in the normal documentation there's some hope 
of it being updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1623: Delete dead code

[danobi]

Github user danobi commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1623#discussion_r109180096
  
--- Diff: proxy/logging/LogBuffer.cc ---
@@ -112,14 +112,6 @@ LogBufferHeader::log_filename()
   return addr;
 }
 
-/*-
-  LogBuffer::LogBuffer
--- End diff --

IMO it wasn't saying anything informative or useful now that AbstractBuffer 
is gone. If I had to add a comment it would be about what LogBuffer does and I 
would prefer to do that in LogBuffer.h. 

I'm deep into the weeds of the logging system right now. Afterwards, I'll 
fix up and add more documentation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1623: Delete dead code

[zwoop]

Github user zwoop commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1623#discussion_r109090078
  
--- Diff: proxy/logging/LogBuffer.cc ---
@@ -112,14 +112,6 @@ LogBufferHeader::log_filename()
   return addr;
 }
 
-/*-
-  LogBuffer::LogBuffer
--- End diff --

I don't think you should nuke the entire comment, just clean it up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1623: Delete dead code

[danobi]

GitHub user danobi opened a pull request:

https://github.com/apache/trafficserver/pull/1623

Delete dead code

None of this code was being called or used elsewhere. Most likely some
point before git history someone migrated off the abstract base class
and never bothered to delete this stuff.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danobi/trafficserver delete_abstract_buffer

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1623.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1623


commit 7241221cf3a73729786540c04fcb3fe7805d05ea
Author: Daniel Xu 
Date:   2017-03-30T22:28:34Z

Delete dead code

None of this code was being called or used elsewhere. Most likely some
point before git history someone migrated off the abstract base class
and never bothered to delete this stuff.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---