[jira] [Work logged] (TS-4979) clang-analyzer error in HttpTransact.cc
[
https://issues.apache.org/jira/browse/TS-4979?focusedWorklogId=30813&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30813
]
ASF GitHub Bot logged work on TS-4979:
--
Author: ASF GitHub Bot
Created on: 18/Oct/16 17:05
Start Date: 18/Oct/16 17:05
Worklog Time Spent: 10m
Work Description: Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/1116
Issue Time Tracking
---
Worklog Id: (was: 30813)
Time Spent: 1h 10m (was: 1h)
> clang-analyzer error in HttpTransact.cc
> ---
>
> Key: TS-4979
> URL: https://issues.apache.org/jira/browse/TS-4979
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Reporter: Leif Hedstrom
>Assignee: Alan M. Carroll
> Fix For: 7.1.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {code}
> if (mimefield_value_equal(host_field, *host_val, host_val_len) == false) {
> 7
> ←
> Passing null pointer value via 2nd parameter 'value'
> →
> 8
> ←
> Calling 'mimefield_value_equal'
> →
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4979) clang-analyzer error in HttpTransact.cc
[
https://issues.apache.org/jira/browse/TS-4979?focusedWorklogId=30812&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30812
]
ASF GitHub Bot logged work on TS-4979:
--
Author: ASF GitHub Bot
Created on: 18/Oct/16 17:05
Start Date: 18/Oct/16 17:05
Worklog Time Spent: 10m
Work Description: Github user SolidWallOfCode commented on a diff in the
pull request:
https://github.com/apache/trafficserver/pull/1116#discussion_r83902560
--- Diff: proxy/http/HttpTransact.cc ---
@@ -1075,6 +1073,8 @@ HttpTransact::ModifyRequest(State *s)
if (!request.is_target_in_url()) {
s->hdr_info.client_req_is_server_style = true;
}
+ // Make Coverity happy. hostname is non-null iff
request.is_target_in_url().
--- End diff --
It's just who we are.
Issue Time Tracking
---
Worklog Id: (was: 30812)
Time Spent: 1h (was: 50m)
> clang-analyzer error in HttpTransact.cc
> ---
>
> Key: TS-4979
> URL: https://issues.apache.org/jira/browse/TS-4979
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Reporter: Leif Hedstrom
>Assignee: Alan M. Carroll
> Fix For: 7.1.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {code}
> if (mimefield_value_equal(host_field, *host_val, host_val_len) == false) {
> 7
> ←
> Passing null pointer value via 2nd parameter 'value'
> →
> 8
> ←
> Calling 'mimefield_value_equal'
> →
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4979) clang-analyzer error in HttpTransact.cc
[
https://issues.apache.org/jira/browse/TS-4979?focusedWorklogId=30808&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30808
]
ASF GitHub Bot logged work on TS-4979:
--
Author: ASF GitHub Bot
Created on: 18/Oct/16 16:16
Start Date: 18/Oct/16 16:16
Worklog Time Spent: 10m
Work Description: Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1116
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1039/ for details.
Issue Time Tracking
---
Worklog Id: (was: 30808)
Time Spent: 0.5h (was: 20m)
> clang-analyzer error in HttpTransact.cc
> ---
>
> Key: TS-4979
> URL: https://issues.apache.org/jira/browse/TS-4979
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Reporter: Leif Hedstrom
>Assignee: Alan M. Carroll
> Fix For: 7.1.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {code}
> if (mimefield_value_equal(host_field, *host_val, host_val_len) == false) {
> 7
> ←
> Passing null pointer value via 2nd parameter 'value'
> →
> 8
> ←
> Calling 'mimefield_value_equal'
> →
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4979) clang-analyzer error in HttpTransact.cc
[
https://issues.apache.org/jira/browse/TS-4979?focusedWorklogId=30810&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30810
]
ASF GitHub Bot logged work on TS-4979:
--
Author: ASF GitHub Bot
Created on: 18/Oct/16 16:22
Start Date: 18/Oct/16 16:22
Worklog Time Spent: 10m
Work Description: Github user zwoop commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1116#discussion_r83893797
--- Diff: proxy/http/HttpTransact.cc ---
@@ -1075,6 +1073,8 @@ HttpTransact::ModifyRequest(State *s)
if (!request.is_target_in_url()) {
s->hdr_info.client_req_is_server_style = true;
}
+ // Make Coverity happy. hostname is non-null iff
request.is_target_in_url().
--- End diff --
Since we're bike shedding, this probably should have said "clang-analyzer".
;-)
Issue Time Tracking
---
Worklog Id: (was: 30810)
Time Spent: 50m (was: 40m)
> clang-analyzer error in HttpTransact.cc
> ---
>
> Key: TS-4979
> URL: https://issues.apache.org/jira/browse/TS-4979
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Reporter: Leif Hedstrom
>Assignee: Alan M. Carroll
> Fix For: 7.1.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {code}
> if (mimefield_value_equal(host_field, *host_val, host_val_len) == false) {
> 7
> ←
> Passing null pointer value via 2nd parameter 'value'
> →
> 8
> ←
> Calling 'mimefield_value_equal'
> →
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4979) clang-analyzer error in HttpTransact.cc
[
https://issues.apache.org/jira/browse/TS-4979?focusedWorklogId=30809&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30809
]
ASF GitHub Bot logged work on TS-4979:
--
Author: ASF GitHub Bot
Created on: 18/Oct/16 16:19
Start Date: 18/Oct/16 16:19
Worklog Time Spent: 10m
Work Description: Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1116
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/931/ for details.
Issue Time Tracking
---
Worklog Id: (was: 30809)
Time Spent: 40m (was: 0.5h)
> clang-analyzer error in HttpTransact.cc
> ---
>
> Key: TS-4979
> URL: https://issues.apache.org/jira/browse/TS-4979
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Reporter: Leif Hedstrom
>Assignee: Alan M. Carroll
> Fix For: 7.1.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {code}
> if (mimefield_value_equal(host_field, *host_val, host_val_len) == false) {
> 7
> ←
> Passing null pointer value via 2nd parameter 'value'
> →
> 8
> ←
> Calling 'mimefield_value_equal'
> →
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4979) clang-analyzer error in HttpTransact.cc
[
https://issues.apache.org/jira/browse/TS-4979?focusedWorklogId=30807&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30807
]
ASF GitHub Bot logged work on TS-4979:
--
Author: ASF GitHub Bot
Created on: 18/Oct/16 16:03
Start Date: 18/Oct/16 16:03
Worklog Time Spent: 10m
Work Description: Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1116
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/930/ for details.
Issue Time Tracking
---
Worklog Id: (was: 30807)
Time Spent: 20m (was: 10m)
> clang-analyzer error in HttpTransact.cc
> ---
>
> Key: TS-4979
> URL: https://issues.apache.org/jira/browse/TS-4979
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Reporter: Leif Hedstrom
>Assignee: Alan M. Carroll
> Fix For: 7.1.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {code}
> if (mimefield_value_equal(host_field, *host_val, host_val_len) == false) {
> 7
> ←
> Passing null pointer value via 2nd parameter 'value'
> →
> 8
> ←
> Calling 'mimefield_value_equal'
> →
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4979) clang-analyzer error in HttpTransact.cc
[
https://issues.apache.org/jira/browse/TS-4979?focusedWorklogId=30806&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30806
]
ASF GitHub Bot logged work on TS-4979:
--
Author: ASF GitHub Bot
Created on: 18/Oct/16 16:01
Start Date: 18/Oct/16 16:01
Worklog Time Spent: 10m
Work Description: GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/1116
TS-4979: Fix coverity complaint about potential null pointer.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver ts-4979
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1116
commit ea965643027e96a22016b3c916ecbeb7ee2fa0ee
Author: Alan M. Carroll
Date: 2016-10-18T16:00:07Z
TS-4979: Fix coverity complaint about potential null pointer.
Issue Time Tracking
---
Worklog Id: (was: 30806)
Time Spent: 10m
Remaining Estimate: 0h
> clang-analyzer error in HttpTransact.cc
> ---
>
> Key: TS-4979
> URL: https://issues.apache.org/jira/browse/TS-4979
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Reporter: Leif Hedstrom
>Assignee: Alan M. Carroll
> Fix For: 7.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code}
> if (mimefield_value_equal(host_field, *host_val, host_val_len) == false) {
> 7
> ←
> Passing null pointer value via 2nd parameter 'value'
> →
> 8
> ←
> Calling 'mimefield_value_equal'
> →
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
