Re: [PATCH] drv_imap: linearize code

2013-01-04 Thread Oswald Buddenhagen
On Mon, Dec 31, 2012 at 02:17:38PM +0100, Nikola Pajkovsky wrote: > this change makes code more readable > that's subjective. i'd consider either variant if this was new code, but i'm not going to make such changes to existing code, unless the structure changes as a precondition of a "real" change

Re: [PATCH] use proper name for array size

2013-01-04 Thread Oswald Buddenhagen
hi, On Mon, Dec 31, 2012 at 02:06:19PM +0100, Nikola Pajkovsky wrote: > using 'as' as name for array size is confusing a lot. Better name is > ARRAY_SIZE. > i'll think about that. when i wrote the code, i wasn't using an IDE with auto-completion yet, and now i'm kind of used to this shortcut. ^^