[commit] 1.3: fix simultaneously connecting to multiple hosts in non-IPv6 builds

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 813ad67c5664019d198b5c0832c10142a20f2793 Author: Oswald Buddenhagen Date: Mon Jul 27 22:48:41 2020 +0200 fix simultaneously connecting to multiple hosts in non-IPv6 builds we need to deep-copy the struct hostent data, as otherwise the concurrent connects will overwrite e

[commit] 1.3: bump version

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit c97e650c241536b5fafcccd138428d1c7a22cdd7 Author: Oswald Buddenhagen Date: Tue Aug 4 14:44:17 2020 +0200 bump version configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ca3ee33..188d712 100644 --- a/configure.ac +++ b/c

[commit] 1.3: fix re-using server connections for new stores

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 542e38dd49b4ac0ecf96637be289b6e71ac84990 Author: Oswald Buddenhagen Date: Tue Aug 4 10:10:47 2020 +0200 fix re-using server connections for new stores we failed to reset the box list pointer after freeing it, which would lead to a crash. we also failed to reset the l

[commit] 1.3: don't crash in proxy_invoke_bad_callback()

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit c82397cf6e6c3c89b3b5bce6836bf17208abae70 Author: Oswald Buddenhagen Date: Mon Aug 3 12:39:33 2020 +0200 don't crash in proxy_invoke_bad_callback() we need to hold a ref to the proxy store, as after the bad_callback() it's otherwise likely gone. src/drv_proxy.c | 4 +++-

[commit] 1.3: increase PassCmd output buffer even more

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 3651c30296cbe8995b8a9c1c839088fa03778540 Author: Oswald Buddenhagen Date: Tue Jul 28 00:28:11 2020 +0200 increase PassCmd output buffer even more apparently, some XOAUTH2 tokens are at 2.4K already, so make it 8K to be *really* safe for a while. REFMAIL: <202007

[commit] 1.3: fix version comparison in LibreSSL conditional

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 30261fe6f17b24bd57008ffde9650cd1a13d9cbd Author: Oswald Buddenhagen Date: Tue Aug 4 11:17:56 2020 +0200 fix version comparison in LibreSSL conditional the operator was exactly inverted. that means that it actually wouldn't compile with both older versions (that needed th

[commit] 1.3: unbreak CertificateFile documentation

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 09540b5648aecd1bd2e29db0b6201ca71381a058 Author: Oswald Buddenhagen Date: Sun Aug 2 20:05:42 2020 +0200 unbreak CertificateFile documentation the file may in fact contain CA certs. amends 7d9d3e15. src/mbsync.1 | 32 +--- 1 file changed

[commit] master: Merge branch '1.3'

2020-08-04 Thread Oswald Buddenhagen via isync-devel
Skipped 7 existing revision(s) on branch 'master'. commit 5fee222f8408d5dd82b40d53c663b8ceffa13914 Merge: cab1460 c97e650 Author: Oswald Buddenhagen Date: Tue Aug 4 14:48:58 2020 +0200 Merge branch '1.3' src/drv_imap.c | 17 ++-- src/drv_proxy.c | 4 +++- src/mbsync.1|

[commit] tag 'v1.3.3' created

2020-08-04 Thread Oswald Buddenhagen via isync-devel
The tag 'v1.3.3' has been created at c97e650. ___ isync-devel mailing list isync-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/isync-devel

[commit] master: autotest: fix prototype of ckbox()

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit d59392e9010714ca3aaf8ac21840f14ba712c384 Author: Oswald Buddenhagen Date: Sun Dec 29 11:59:47 2019 +0100 autotest: fix prototype of ckbox() src/run-tests.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/run-tests.pl b/src/run-tests.pl index 3618db5..5a

[commit] master: get rid of maildir_find_new_msgs() stub

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit c84235b068220a02800aad01ad244fe215f05734 Author: Oswald Buddenhagen Date: Tue Jul 21 17:16:24 2020 +0200 get rid of maildir_find_new_msgs() stub a failed assertion isn't any better than a clean segfault with an obvious backtrace. src/drv_maildir.c | 9 + 1 file

[commit] master: don't use reserved identifier pattern in stringify()

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit b885e0e03abf8f126154dbce89a06068e6f7ed3a Author: Oswald Buddenhagen Date: Sun Jul 28 22:31:41 2019 +0200 don't use reserved identifier pattern in stringify() src/common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/common.h b/src/common.h index d4592

[commit] master: autotest: re-organize mailbox storage by UID

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit f3629c69e1b098cc0ef475dbc915e9f958df90cf Author: Oswald Buddenhagen Date: Fri Apr 3 12:18:26 2020 +0200 autotest: re-organize mailbox storage by UID an effect of 7ce658d is that we can index messages by UID rather than content (or more specifically, subject). apart from

[commit] master: autotest: use symbolic message subjects

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 406931bc45d1260cd4ea68ac26e1729e1649f8f8 Author: Oswald Buddenhagen Date: Thu Apr 2 20:39:07 2020 +0200 autotest: use symbolic message subjects ... instead of numbers. otherwise there is too much confusion with UIDs. src/run-tests.pl | 73 +-

[commit] master: don't leak box list from the command line

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 09d11245cde07fa7711cdb78b695a44e14f0fa38 Author: Oswald Buddenhagen Date: Mon Nov 11 22:32:21 2019 +0100 don't leak box list from the command line we also free the box list obtained from IMAP, so there isn't a real reason not to do that for one from the command line.

[commit] master: autotest: assume that each message has a UID

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit b59ee239a4b7caa956c3912f2514318d4be333b8 Author: Oswald Buddenhagen Date: Fri Apr 3 11:21:09 2020 +0200 autotest: assume that each message has a UID followup to 7ce658d14. src/run-tests.pl | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/run-

[commit] master: autotest: re-order mailbox contents according to UIDs

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 6734b9ce7dbebb441bde80c1bd8ec43cc7973c1a Author: Oswald Buddenhagen Date: Fri Apr 3 10:43:19 2020 +0200 autotest: re-order mailbox contents according to UIDs ... instead of subjects, because that's way more natural and thus less confusing. src/run-tests.pl | 12 ++-

[commit] master: de-noise initialization of sync records

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 841f07efd006bbbd5855037eb95f63e18f303e07 Author: Oswald Buddenhagen Date: Tue Dec 3 13:06:12 2019 +0100 de-noise initialization of sync records use calloc() instead of malloc(). src/sync.c | 25 - 1 file changed, 4 insertions(+), 21 deletions(-) di

[commit] master: actually implement maildir_get_uidnext()

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 83adb9a39ba36660a6643799550e3e3f61436100 Author: Oswald Buddenhagen Date: Wed Jul 22 14:18:14 2020 +0200 actually implement maildir_get_uidnext() the assumption was that this wouldn't be needed, as maildir_store_msg() reliably delivers a UID. however, if we crash right b

[commit] master: autotest: show the right state file after idempotence test failure

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 50eab085091b06ce948a837206ee8a368738a97c Author: Oswald Buddenhagen Date: Sun Dec 29 12:06:44 2019 +0100 autotest: show the right state file after idempotence test failure amends efd72b85. src/run-tests.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[commit] master: de-noise msg_copied() and flags_set() somewhat

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit b677bfe7e530da38e135fab0c6e4309a9e0de201 Author: Oswald Buddenhagen Date: Sun Dec 29 12:31:10 2019 +0100 de-noise msg_copied() and flags_set() somewhat assign temporary srec object instead of always spelling out the indirection. src/sync.c | 16 +--- 1 file

[commit] master: re-nest conditions in socket_fd_cb()

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 8a03651dd8a40afd0ac520fc3e6dcd228db24ca3 Author: Oswald Buddenhagen Date: Sat Nov 16 14:17:06 2019 +0100 re-nest conditions in socket_fd_cb() conn->state == SCK_STARTTLS implies conn->ssl != NULL. src/socket.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[commit] master: de-noise -Dd output somewhat

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit c5d3565db5dd846dd33c380df0f62069f618db54 Author: Oswald Buddenhagen Date: Fri Nov 22 20:10:15 2019 +0100 de-noise -Dd output somewhat drop commas and left-align fields in message lists. src/drv_proxy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[commit] master: don't leak the channel list after all

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 85688d1c1a6053041e49b959350ed585f8209b4a Author: Oswald Buddenhagen Date: Mon Nov 11 22:42:42 2019 +0100 don't leak the channel list after all unlike the actual configuration data, it's not kept in global variables, so it shows up in memcheck. amends 1de3ecd88.

[commit] master: kill TODO item about killing INBOX

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 100475665918e5e8c5f58db76d918eba13a0bb02 Author: Oswald Buddenhagen Date: Mon Sep 9 20:08:28 2019 +0200 kill TODO item about killing INBOX while it's correct that mbsync doesn't strictly need to support both Inbox and Path in a single Channel due to being able to Group C

[commit] master: autotest: create the temp dir in $TEMP

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit ef2caa074edfa0f6124aecead56e8253f047819c Author: Oswald Buddenhagen Date: Sun Dec 29 11:59:05 2019 +0100 autotest: create the temp dir in $TEMP on modern systems, this makes it likely to end up on tmpfs, which is a lot faster and ssd-friendlier. the symlink is n

[commit] master: Maildir: fix setting flags on messages without ":2, " part

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 38e7b4db2243e2bff7a6ae6ce2834acb0ba60286 Author: Oswald Buddenhagen Date: Sun Jun 14 13:16:07 2020 +0200 Maildir: fix setting flags on messages without ":2," part this is mostly hypothetical, as all messages i've encountered actually have it even if no flags are set on t

[commit] master: centralize "const cast" in make_key()

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 01348f6f7c7df2da04fe2b890a1c708bd1aab7a1 Author: Oswald Buddenhagen Date: Fri Nov 15 20:04:26 2019 +0100 centralize "const cast" in make_key() src/drv_maildir.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/drv_maildir.c b/src/drv_maildir.c index 3

[commit] master: give the coverity build result archive a more descriptive name

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 30e166aa180cdfec3b9db91736b9ab9cda577fa7 Author: Oswald Buddenhagen Date: Sun Nov 24 10:54:02 2019 +0100 give the coverity build result archive a more descriptive name Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 24

[commit] master: atomize & document conditions in load() exception list construction

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit abdca388f6f0200120e244220539803b1461df28 Author: Oswald Buddenhagen Date: Tue Jul 7 21:14:59 2020 +0200 atomize & document conditions in load() exception list construction src/sync.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/sync.c

[commit] master: make find_uint_array() never create negative indices

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit e334eb3580923fc01451732ba9a3601036e9537c Author: Oswald Buddenhagen Date: Fri Nov 22 21:02:50 2019 +0100 make find_uint_array() never create negative indices src/util.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util.c b/src/util.c index 2a96389..

[commit] master: constness fixes

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit def22db09679c1570e82eeb9e6ad75f8bfcfeb53 Author: Oswald Buddenhagen Date: Sun Jul 28 21:13:28 2019 +0200 constness fixes add missing const qualifications, and add "const cast" suppressions where unavoidable. src/drv_maildir.c | 5 - src/main.c| 8

[commit] master: consistently use NULL for null pointers

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 64e5f07ad3371fa5e10fc0ad715a68205f4effb7 Author: Oswald Buddenhagen Date: Sun Jul 28 20:50:31 2019 +0200 consistently use NULL for null pointers makes the code noisier, but also somewhat more expressive. src/common.h | 4 +- src/config.c | 28 ++---

[commit] master: modernize list of gcc warning flags somewhat

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit a6bb26091a575756cb8554d3376feb52f0300f92 Author: Oswald Buddenhagen Date: Fri Nov 15 20:21:50 2019 +0100 modernize list of gcc warning flags somewhat configure.ac | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index a4c00

[commit] master: remove support for SSLv3

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 234becf5309cf84f21f1ac069ba731f578c54346 Author: Oswald Buddenhagen Date: Tue Nov 26 16:18:58 2019 +0100 remove support for SSLv3 it's insecure and default builds of openssl don't include it any more. NEWS | 1 + src/drv_imap.c | 11 +-- src/socket.c |

[commit] master: purge handling of pending sync entries from state file

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit b514d9ddbc065deab8d5122e02398fd20e0ffe97 Author: Oswald Buddenhagen Date: Sat Jul 4 16:13:50 2020 +0200 purge handling of pending sync entries from state file these cannot actually end up in the committed state. amends bd5fb6ff. src/sync.c | 13 ++--- 1 fi

[commit] master: fix strftime() format string warning properly

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 27a1935361f90a72bbb9a625fb6a8e8895d92b13 Author: Oswald Buddenhagen Date: Sun Jul 28 20:42:04 2019 +0200 fix strftime() format string warning properly the workaround for -Wformat triggered -Wformat-nonliteral in turn. so instead go back to using pragmas and add a proper

[commit] master: add option to get password from macOS Keychain

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 198ca65b6ea1d46e6ce8b9e9c2d4e10033c5247b Author: Oswald Buddenhagen Date: Wed Nov 27 17:13:44 2019 +0100 add option to get password from macOS Keychain this is better than using PassCmd, as it allows the keychain manager to identify the calling process and therefore use

[commit] master: fix signedness issues surrounding UIDs

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 2f3cb5f4815d0024042bfb8387163b210acf3a6f Author: Oswald Buddenhagen Date: Wed Jul 8 13:45:06 2020 +0200 fix signedness issues surrounding UIDs amends bb632d1c. src/driver.h | 4 ++-- src/drv_imap.c| 10 +- src/drv_maildir.c | 6 +++--- src/drv_proxy.c

[commit] master: make more objects static

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 5c2e8d3e147ad4550fbdb66585a93b1a03e1f756 Author: Oswald Buddenhagen Date: Sun Jul 28 20:54:01 2019 +0200 make more objects static src/config.c | 2 +- src/drv_imap.c | 2 +- src/main.c | 4 ++-- src/sync.c | 8 4 files changed, 8 insertions(+), 8 deletions(-) di

[commit] master: wrap jFprintf()+debug() into a macro

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit d93726067dc298a33f65800d73a3fe1e35c46afc Author: Oswald Buddenhagen Date: Wed Jul 8 22:16:47 2020 +0200 wrap jFprintf()+debug() into a macro this ensures that everything that is logged to the journal also appears in the debug output, and it makes the code less noisy. s

[commit] master: fix loading of some messages' sizes in some partial sync scenarios

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 395f8025003c080203ecb8680e9d84d0d8bb2f1b Author: Oswald Buddenhagen Date: Sun Dec 29 11:52:26 2019 +0100 fix loading of some messages' sizes in some partial sync scenarios we need to pass a different "boundary" UID to driver_t::load_box() for every OPEN_* flag that queri

[commit] master: handle bogus IMAP FETCH responses more robustly

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 67ea5bea7f84a9a58e05a4f28d787ff3322a3029 Author: Oswald Buddenhagen Date: Mon Nov 11 17:24:38 2019 +0100 handle bogus IMAP FETCH responses more robustly don't use assert()s when the error condition can stem not only from errors in mbsync's logic, but also from the IMAP s

[commit] master: turn maildir_again() into a proper varargs function

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit df22514ced8e6a62e6456496b645609af0b07930 Author: Oswald Buddenhagen Date: Tue Aug 4 16:54:28 2020 +0200 turn maildir_again() into a proper varargs function this is mostly to work around the fact that both gcc and clang won't accept the format string declaration (i.e., wi

[commit] master: extract parse_fetched_flags() from parse_fetch_rsp()

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 81c4bfeefad7a62947ae29359bcb07924a6154d1 Author: Oswald Buddenhagen Date: Mon Nov 11 16:32:32 2019 +0100 extract parse_fetched_flags() from parse_fetch_rsp() src/drv_imap.c | 62 -- 1 file changed, 35 insertions(+), 27 deletions(-) d

[commit] master: shrink some data at the source to avoid subsequent narrowing

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 4d7e169e5722babc0b78c71ed33f68030aaffd13 Author: Oswald Buddenhagen Date: Sun Jul 28 21:24:17 2019 +0200 shrink some data at the source to avoid subsequent narrowing src/common.h | 5 +++-- src/config.c | 2 +- src/config.h | 2 +- src/sync.c | 8 src/util.c | 2 +- 5

[commit] master: fix lots of sign conversion warnings

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit e2d3b4d55b36b252d19d0c8b77e2ea59db7e4cd3 Author: Oswald Buddenhagen Date: Wed Jul 8 17:27:37 2020 +0200 fix lots of sign conversion warnings ... by making a lot of objects unsigned, and some signed. casts which lose precision and change the sign in one go (ssize_t and

[commit] master: de-duplicate updating of uid in sync records

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit fd7b5659ab3e50782ce19f3011916949cc6628e0 Author: Oswald Buddenhagen Date: Sun Dec 29 14:41:45 2019 +0100 de-duplicate updating of uid in sync records src/sync.c | 42 -- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/src/sync

[commit] master: make expiration loops solely far-side-driven

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit de6dc699c91e18bd3705fd253141e9ca1fb8ebcf Author: Oswald Buddenhagen Date: Thu Jul 16 14:47:30 2020 +0200 make expiration loops solely far-side-driven we can do that, as unpaired near-side messages are ignored anyway. this mildly changes expiration order, as near-sid

[commit] master: sanitize error handling in IMAP FETCH response processing

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit a5a8783ea3de982dfd7c3926646033919bbf6af3 Author: Oswald Buddenhagen Date: Mon Nov 11 14:29:42 2019 +0100 sanitize error handling in IMAP FETCH response processing abort on actual error conditions (protocol errors) and downgrade the rest to warnings. REFMAIL: 201

[commit] master: rename socket_expect_read() => socket_expect_activity()

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit e7bc402d09bba365b7ef34bf223a39155b5d8dab Author: Oswald Buddenhagen Date: Sat Nov 16 17:14:57 2019 +0100 rename socket_expect_read() => socket_expect_activity() ... to better reflect its (mostly new) function. src/drv_imap.c | 16 src/socket.c | 10 +

[commit] master: set sync record's flags only after propagating new message

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 25b1c2b9e730cd5a61581c6379e4c6a1900f38eb Author: Oswald Buddenhagen Date: Sun Dec 29 12:34:36 2019 +0100 set sync record's flags only after propagating new message this is semantically cleaner, and fixes storing the flags in the rare case that flags are not being synced

[commit] master: move state assignment to a more natural place

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 21179458385aa576da53cce7a0d88b9eaefddd91 Author: Oswald Buddenhagen Date: Sun Jul 28 13:36:15 2019 +0200 move state assignment to a more natural place ... so it's right next to the related callback assignment. src/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[commit] master: Add support for specifying cipher string used for ssl connection

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 07cb422cbb552744ac7cd13507fa4933de98ab15 Author: Jaroslav Suchanek AuthorDate: Sat Nov 9 19:47:55 2019 +0100 Commit: Oswald Buddenhagen CommitDate: Tue Aug 4 14:49:58 2020 +0200 Add support for specifying cipher string used for ssl connection Some distributions (e.g.

[commit] master: don't store 'shared' and 'other' namespaces

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 6fd4e8de24a2f8f520bde43a3d0fd0f5f4f1f3cc Author: Oswald Buddenhagen Date: Sun Nov 10 17:13:41 2019 +0100 don't store 'shared' and 'other' namespaces they are never used anyway, and aren't going to be (because configuring that would be more annoying than just specifying P

[commit] master: IMAP: reject unqualified non-uppercased INBOX spellings

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit e9407cc1f724315daa47d617a0ebbd36a2415129 Author: Oswald Buddenhagen Date: Thu Jun 2 19:41:03 2011 +0200 IMAP: reject unqualified non-uppercased INBOX spellings otherwise the server would interpret it as INBOX contrary to our expectations, which might lead to moderately s

[commit] master: add ability to script IMAP user query

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 03b15dbdd341375e2f3350bdfe0d957b64c4edde Author: Oswald Buddenhagen Date: Tue Nov 26 12:17:33 2019 +0100 add ability to script IMAP user query It was already possible to retrieve passwords from arbitrary commands. But this goes only half the way to allowing automated der

[commit] master: don't forget to skip dead messages on far side during expiration

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit ca72383fe947d70950ddfe110d033a158ac9a183 Author: Oswald Buddenhagen Date: Thu Jul 16 13:08:29 2020 +0200 don't forget to skip dead messages on far side during expiration this is mostly theoretical, as at this point no updates to the message list can have actually happene

[commit] master: drop redundant conn->writing member

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit c391b06b07ec6310fbce1759c4a2d85bb0027c98 Author: Oswald Buddenhagen Date: Sat Nov 16 16:00:06 2019 +0100 drop redundant conn->writing member this information is already encoded in the socket notifier's config. src/common.h | 1 + src/socket.c | 4 +--- src/socket.h | 1

[commit] master: rewrite nonsensical struct packing magic

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 6010fe104ef2a3e91335fdb7e686939d6af82a46 Author: Oswald Buddenhagen Date: Fri Nov 15 20:20:45 2019 +0100 rewrite nonsensical struct packing magic this couldn't have possibly worked - the alignment also determines the sizeof, thus defeating the intent of the packing. sr

[commit] master: de-duplicate FETCH response data item traversal somewhat

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 503478533ce4221c88c9614d515479d78837c595 Author: Oswald Buddenhagen Date: Fri Nov 22 17:50:01 2019 +0100 de-duplicate FETCH response data item traversal somewhat src/drv_imap.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/drv_imap.c

[commit] master: add support for (disabling) TLS v1.3

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit d09f988c70e6598a7deb8de5a5c6496c32ab88d9 Author: Oswald Buddenhagen Date: Tue Nov 26 16:05:46 2019 +0100 add support for (disabling) TLS v1.3 this is actually potentially counterproductive, as people who have set SSLVersions and fail to adjust it will _lose_ tls 1.3 supp

[commit] master: make some narrowing of integers explicit

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit cc176df2c3b46d2becb6dd7c8ccc441471c468cb Author: Oswald Buddenhagen Date: Sun Jul 28 22:10:21 2019 +0200 make some narrowing of integers explicit this does specifically *not* cover about a bazillion warnings about size_t being shrunk to uint - these make no sense given t

[commit] master: do away with newmaxuid

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit e9efc49b6c1747da7256d0c276b97689f337f871 Author: Oswald Buddenhagen Date: Mon Jul 20 20:53:21 2020 +0200 do away with newmaxuid now that expiration order is determined by a single loop ordered by far-side UIDs, it is no longer necessary to accurately track the highest

[commit] master: fully decompose NAMESPACE response early on

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 7af7354dbc07cba5a97ba9d87f2c0ca5b5ec6c64 Author: Oswald Buddenhagen Date: Mon Nov 11 13:41:32 2019 +0100 fully decompose NAMESPACE response early on that way the code becomes clearer, and we don't keep useless nodes in memory. src/drv_imap.c | 65 ++

[commit] master: streamline counting of currently pushed messages wrt. expiration

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 5d6741a9a8ba71ae94ae15f9bd79f34d8d785ea4 Author: Oswald Buddenhagen Date: Sun Jul 12 17:21:15 2020 +0200 streamline counting of currently pushed messages wrt. expiration don't count them as alive just to ignore them in the next step. src/sync.c | 14 +- 1 file

[commit] master: re-nest conditions for syncing new messages

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 8df1f5dd646d165a9a8fb90f57c3a8872ab3ce7a Author: Oswald Buddenhagen Date: Wed Jul 8 14:37:57 2020 +0200 re-nest conditions for syncing new messages this makes the logic easier to follow and document in place. also, make the comments actually match reality. src/sync.c |

[commit] master: extract parse_fetched_header() from parse_fetch_rsp()

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit d4ead05a0203d6dc959e565510f06998c3aabaa1 Author: Oswald Buddenhagen Date: Mon Nov 11 16:18:40 2019 +0100 extract parse_fetched_header() from parse_fetch_rsp() src/drv_imap.c | 79 +++--- 1 file changed, 43 insertions(+), 36 deletions(-)

[commit] master: Add option to use IMAP LSUB instead of LIST

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 990cc112f1d6807adfe07a550bedd179177d5949 Author: Oswald Buddenhagen Date: Tue Nov 26 15:49:19 2019 +0100 Add option to use IMAP LSUB instead of LIST Based on patch by Cedric Ware NEWS | 2 ++ src/drv_imap.c | 10 +++--- src/mbsync.1 | 8 3 files

[commit] master: remove redundant condition

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 4aaada18e9a32ca06cedc96da4ea30c8f3669b73 Author: Oswald Buddenhagen Date: Sat Jul 11 16:21:20 2020 +0200 remove redundant condition the 'pending' and 'skipped' sync record states are mutually exclusive with having a complementary message, so there is no point in testing

[commit] master: de-duplicate exit paths of imap_alloc_store()

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit b148fd9e446e30b889764a4d0d96098842684270 Author: Oswald Buddenhagen Date: Tue Aug 4 09:08:17 2020 +0200 de-duplicate exit paths of imap_alloc_store() src/drv_imap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/drv_imap.c b/src/drv_imap.c index 75b44cd

[commit] master: centralize disposal of parsed IMAP lists

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit b91dd5b3bccfed97d5e479d2b18007c6fd819836 Author: Oswald Buddenhagen Date: Mon Nov 11 13:51:14 2019 +0100 centralize disposal of parsed IMAP lists makes the code less cluttered, and it's harder to introduce leaks. this has the hypothetical disadvantage that due to fr

[commit] master: re-nest parse_fetch_rsp()

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 47b477b3fb67f285b36e034a79d9e174bdf96ab3 Author: Oswald Buddenhagen Date: Fri Nov 22 16:54:31 2019 +0100 re-nest parse_fetch_rsp() prefer early exits over else branches, which is easier to follow. src/drv_imap.c | 112 - 1 fi

[commit] master: use more appropriate return value in driver_t::select_box()

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 8457225a50d21d4b663af80c4a60202bb165a054 Author: Oswald Buddenhagen Date: Tue Aug 4 00:23:33 2020 +0200 use more appropriate return value in driver_t::select_box() don't say DRV_CANCELED when it's really DRV_STORE_BAD, as apart from being just wrong, it lead to the confu

[commit] master: handle messages which are newly doomed after an interruption

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit ceb09fcd44246ab7dad1a352b29854b6b86c3ddf Author: Oswald Buddenhagen Date: Tue Jul 21 16:10:28 2020 +0200 handle messages which are newly doomed after an interruption we already didn't propagate messages which would be instantly expunged from the target, but failed to can

[commit] master: don't rewrite state gratuitously

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 68a412115a75223fb9561f0a467970d2a4af65bf Author: Oswald Buddenhagen Date: Mon Nov 25 20:55:41 2019 +0100 don't rewrite state gratuitously delay the creation of the new state and journal until there is actually something interesting to write. this saves some cpu cycles an

[commit] master: complain about malformed item names in FETCH responses

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 8acf56b3113f6b6a31bf841edfb2fe36c6206026 Author: Oswald Buddenhagen Date: Fri Nov 22 17:49:04 2019 +0100 complain about malformed item names in FETCH responses src/drv_imap.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/drv_imap.c b/src/drv_imap.c i

[commit] master: create placeholders for messages over MaxSize

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 70bad661298017c07d996294928f6cd7421b6792 Author: Oswald Buddenhagen Date: Sun Dec 29 14:37:53 2019 +0100 create placeholders for messages over MaxSize this is vastly more useful than just omitting the messages with no indication at all. NEWS | 2 + TODO

[commit] master: add some ATTR_* (mostly)

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 71d7d3e6dfd29517268c1848c3348ad0eb7fae13 Author: Oswald Buddenhagen Date: Sun Jul 28 19:52:41 2019 +0200 add some ATTR_* (mostly) mostly ATTR_PRINTFLIKE(*, 0) for functions with a va_list argument. also, one ATTR_NORETURN and one ATTR_UNUSED, both on functions.

[commit] master: add/fix/de-duplicate comments

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 0e5046e14afbaee599387cbbdc997c9669b8879c Author: Oswald Buddenhagen Date: Sun Nov 17 19:45:00 2019 +0100 add/fix/de-duplicate comments src/driver.h | 17 ++--- src/drv_imap.c | 1 + src/run-tests.pl | 1 + src/sync.c | 8 src/sync.h | 1 +

[commit] master: deprecate master/slave terminology

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit c8f402e43f9c6a3c685fe0f716ffda741beeac13 Author: Oswald Buddenhagen Date: Wed Jul 22 19:44:26 2020 +0200 deprecate master/slave terminology the underlying metaphor refers to an inhumane practice, so using it casually is rightfully offensive to many people. it isn't even

[commit] master: actually implement imap_commit_cmds()

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit cfaa4848dd7c72e628fcc81a4c4532c9be226144 Author: Oswald Buddenhagen Date: Tue Jul 28 16:14:00 2020 +0200 actually implement imap_commit_cmds() delay reporting success of STORE FLAGS until a subsequent CHECK succeeds. this fixes (inverse flag change propagation)

[commit] master: handle CertificateFile more cleanly

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit 481c12a8b31c6dd7eba048e8f42d0b9653110621 Author: Oswald Buddenhagen Date: Wed Jul 29 20:23:54 2020 +0200 handle CertificateFile more cleanly properly distribute the certificates between the SSL context's trust store and our host cert list. as a drive-by, clean u

[commit] master: don't unnecessarily re-initialize some members of imap_store

2020-08-04 Thread Oswald Buddenhagen via isync-devel
commit c83330ffe8af72b3dea381c0e43562d572d0ad85 Author: Oswald Buddenhagen Date: Tue Aug 4 09:06:41 2020 +0200 don't unnecessarily re-initialize some members of imap_store ... when recycling server connections. src/drv_imap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[commit] branch 'wip/master-next' reset

2020-08-04 Thread Oswald Buddenhagen via isync-devel
The branch 'wip/master-next', previously at 447829c, has been rewound by 70 revision(s) and subsequently fast-forwarded by 83 revision(s) to b148fd9. ___ isync-devel mailing list isync-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/list

[commit] branch 'wip/placeholders' deleted

2020-08-04 Thread Oswald Buddenhagen via isync-devel
The branch 'wip/placeholders', previously at 8d09ea4, has been deleted. ___ isync-devel mailing list isync-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/isync-devel

beta testing for 1.4 release; short-term roadmap

2020-08-04 Thread Oswald Buddenhagen
hello community, after *finally* having pushed my work branch to master (this time even intentionally, heh), i'm about to release 1.4.0 in a few days. please give the branch some good hammering. going forward, i intend to do some more hacking before the project mostly hibernates again for an

[PATCH] add support for built-in oauthbearer auth mechanism

2020-08-04 Thread MichaƂ Winiarski
this can be combined with an external tool (PassCmd) to generate access tokens used for authentication For more information, see: https://tools.ietf.org/html/rfc7628 --- src/drv_imap.c | 123 - src/mbsync.1 | 2 +- 2 files changed, 102 insertion

Re: [PATCH] add support for built-in oauthbearer auth mechanism

2020-08-04 Thread Oswald Buddenhagen
what is the fundamental advantage over using a SASL plugin like https://github.com/tarickb/sasl-xoauth2 ? ___ isync-devel mailing list isync-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/isync-devel