CVS commit by ossi:
wrap message storing into transactions. nice side effect: drivers don't
need to deal with line end conversion any move.
M +0 -7 TODO 1.20
M +30 -85src/drv_imap.c 1.15
M +39 -8 src/drv_maildir.c 1.10
M +12 -4 src/isync.h 1.53
M +268 -58
CVS commit by ossi:
include run-tests.pl in distribution
M +1 -1 Makefile.am 1.3
--- isync/src/Makefile.am #1.2:1.3
@@ -14,3 +14,3 @@
man_MANS = mbsync.1 mdconvert.1
-EXTRA_DIST = mbsyncrc.sample $(man_MANS)
+EXTRA_DIST = run-tests.pl mbsyncrc.sample $(man_MANS)
CVS commit by ossi:
unbelieveable, but close() can actually fail
M +11 -2 sync.c 1.73
--- isync/src/sync.c #1.72:1.73
@@ -37,4 +37,13 @@ static const char *str_ms[] = { master
void
+Fclose( FILE *f )
+{
+ if (fclose( f ) == EOF) {
+ perror( cannot close file
CVS commit by ossi:
don't barf at directories with none of {tmp,new,cur}/ and turn them
into maildirs instead. see next commit.
M +11 -6 drv_maildir.c 1.12
--- isync/src/drv_maildir.c #1.11:1.12
@@ -213,5 +213,5 @@ maildir_validate( const char *prefix, co
struct dirent
CVS commit by ossi:
lock the sync state open the journal before opening the master. this is
a bit ugly for the SyncState * case, as we have to create a directory
without making it a maildir right away. however, this makes the code
quite a bit simpler to understand and simpler to parallelize.
CVS commit by ossi:
factor out box selection from sync_boxes to avoid code dupe
M +37 -58sync.c 1.76
--- isync/src/sync.c #1.75:1.76
@@ -108,12 +108,35 @@ typedef struct sync_rec {
static int
-findmsgs( sync_rec_t *srecs, store_t *ctx[], int t, FILE *jfp )
+select_box( sync_rec_t
CVS commit by ossi:
make config parsing more robust against bogus input and report errors
more clearly.
M +38 -28drv_imap.c 1.17
--- isync/src/drv_imap.c #1.16:1.17
@@ -255,9 +255,7 @@ init_ssl_ctx( imap_store_t *ctx )
fprintf( stderr, Error, CertificateFile not
CVS commit by ossi:
fprintf( stderr, = error(. new functions debugn() and infon()
for messages with missing newline; warn() and error() act upon this.
M +26 -29config.c 1.30
M +56 -60drv_imap.c 1.18
M +20 -20drv_maildir.c 1.13
M +4 -1 isync.h 1.55
M +8 -7
CVS commit by ossi:
merge imap_t into imap_store_t - there is really no point in having them
separated.
M +109 -134 drv_imap.c 1.19
--- isync/src/drv_imap.c #1.18:1.19
@@ -108,5 +108,8 @@ struct imap_cmd;
#define max_in_progress 50 /* make this configurable? */
-typedef struct imap
CVS commit by ossi:
whitespace and code verbosity
M +3 -4 drv_imap.c 1.20
--- isync/src/drv_imap.c #1.19:1.20
@@ -235,6 +235,5 @@ static int
init_ssl_ctx( imap_store_t *ctx )
{
- imap_store_conf_t *conf = (imap_store_conf_t *)ctx-gen.conf;
- imap_server_conf_t *srvc =
CVS commit by ossi:
do not repeatedly get namespace from server.
M +6 -2 drv_imap.c 1.25
--- isync/src/drv_imap.c #1.24:1.25
@@ -113,4 +113,5 @@ typedef struct imap_store {
unsigned /*currentnc:1,*/ trashnc:1;
int uidnext; /* from SELECT responses */
+
CVS commit by ossi:
unscrew lf=crlf conversion and tuid insertion
M +3 -3 sync.c 1.83
--- isync/src/sync.c #1.82:1.83
@@ -240,5 +240,5 @@ copy_msg( store_t *ctx[], int t, message
crd = -1;
else if (scr tcr)
- crd = 1;
+
CVS commit by ossi:
no/empty mailbox name means INBOX
M +6 -2 main.c 1.62
--- isync/src/main.c #1.61:1.62
@@ -485,4 +485,6 @@ static void done_sync_dyn( int sts, void
static void done_sync( int sts, void *aux );
+#define nz(a,b) ((a)?(a):(b))
+
static void
sync_chans(
CVS commit by ossi:
be *slightly* more explicit about which options Tunnel makes
superfluous.
M +2 -1 mbsync.1 1.5
--- isync/src/mbsync.1 #1.4:1.5
@@ -234,5 +234,6 @@
Specify a command to run to establish a connection rather than opening a TCP
socket. This allows you to run an
CVS commit by ossi:
glibc seems to be *really* fucked up.
M +4 -5 drv_maildir.c 1.20
--- isync/src/drv_maildir.c #1.19:1.20
@@ -660,9 +660,8 @@ maildir_scan( maildir_store_t *ctx, msgl
else
u = ru = strchr(
CVS commit by ossi:
memmove for overlapping mem copies.
M +1 -1 drv_imap.c 1.30
--- isync/src/drv_imap.c #1.29:1.30
@@ -370,5 +370,5 @@ buffer_gets( buffer_t * b, char **s )
if (n)
- memcpy( b-buf, b-buf +
On Fri, Aug 11, 2006 at 02:24:36PM +0200, Daniel Danner wrote:
On Thursday 10 August 2006 22:42, Oswald Buddenhagen wrote:
the output of mbsync -V -D, .mbsyncrc and the state file should be a
good start.
Allright. Which state file exactly?
For the folder that return the error message
On Thu, 9 Nov 2006 00:11:01 +010, Nicolas Boullis wrote:
I just tried 1.0.3 (at last) and to be honnest I am slightly
disappointed. I found a few behavioral differences:
1) when User was not specified, 0.9.2 used the name of the user
running isync; 1.0.3 fails;
indeed, will fix.
CVS commit by ossi:
make compat wrapper default to current user for imap login
M +6 -0 main.c 1.8
--- isync/src/compat/main.c #1.7:1.8
@@ -23,4 +23,5 @@
#include sys/types.h
#include sys/stat.h
+#include sys/param.h
#include stdlib.h
#include unistd.h
@@ -168,4 +169,9 @@ main(
CVS commit by ossi:
reverse-map Inbox to INBOX when encountered during listing.
usually this will be a no-op (when putting INBOX in Path, people
generally call it INBOX), but better safe than sorry.
M +5 -2 drv_maildir.c 1.22
--- isync/src/drv_maildir.c #1.21:1.22
@@ -175,4 +175,6
On Wed, Nov 29, 2006 at 10:42:31PM +0100, Elmar W. Tischhauser wrote:
2. copy these messages to the destination mailbox via IMAP,
3. obtain the new UIDs of these messages within the destination mailbox,
you can abstract things a bit: talk about master and slave, not imap
maildir. also,
On Tue, Apr 08, 2008 at 11:04:38PM -0500, [EMAIL PROTECTED] wrote:
http://wonko.com/post/ruby_script_to_sync_email_from_any_imap_server_to_gmail
ok, the key seems to be explicitly setting the internaldate attribute.
have to investigate that ...
--
Hi! I'm a .signature virus! Copy me into your
CVS commit by ossi:
ignore system flag extensions (\X-...)
M +3 -1 drv_imap.c 1.34
--- isync/src/drv_imap.c #1.33:1.34
@@ -2,5 +2,5 @@
* mbsync - mailbox synchronizer
* Copyright (C) 2000-2002 Michael R. Elkins [EMAIL PROTECTED]
- * Copyright (C) 2002-2006 Oswald Buddenhagen
On Fri, Aug 22, 2008 at 12:21:59AM +0100, Daniel Skinner wrote:
Selecting slave INBOX... IMAP error: malformed UIDVALIDITY status
please re-run with the -V option and send me the output.
--
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Confusion, chaos, panic - my work
CVS commit by ossi:
backport: deal with UIDVALIDITY of 0 properly.
CCMAIL: [EMAIL PROTECTED]
M +6 -3 drv_imap.c 1.10.2.9
M +6 -5 sync.c 1.43.2.4
--- isync/src/drv_imap.c #1.10.2.8:1.10.2.9
@@ -818,5 +818,5 @@ parse_response_code( imap_store_t *ctx,
{
imap_t *imap
CVS commit by ossi:
handle failure to store message. this helps with invalid messages like
0-byte files after crashes.
M +1 -0 drv_imap.c 1.10.2.10
M +14 -0 sync.c 1.43.2.5
--- isync/src/drv_imap.c #1.10.2.9:1.10.2.10
@@ -1587,4 +1587,5 @@ imap_store_msg( store_t *gctx,
On Mon, Jul 13, 2009 at 01:35:09PM +0200, Antoine Reilles wrote:
The attached patch does fix this segfault, and dit let isync work again
for me.
- bl = nfsnprintf( base, sizeof(base), %ld.%d_%d.%s, time( 0 ), Pid,
++MaildirCount, Hostname );
+ bl = nfsnprintf( base,
CVS commit by ossi:
isync switched to git - this repository is DEAD.
the repo itself will be disabled within a few weeks, so make your diffs
now if you have any local changes.
no, this doesn't mean that i will have more time for it now.
but that way i can more cleanly maintain the copies of
commit 94a2c13cbf17a5f126e1da1657d6818e6f4174ec
Author: Oswald Buddenhagen o...@kde.org
Date: Sat Feb 6 09:31:35 2010 +0100
add fully async operation, take 1 *** WIP ***
this is a dead branch and it is progressively canibalized by the
proper async branch.
configure.in
commit 4cf90cedca8823aa7c2a49431c7681518e7dc7ba
Author: Oswald Buddenhagen o...@kde.org
Date: Sat Feb 6 10:25:49 2010 +0100
fully aync operation, take 2 *** WIP ***
second attempt, starting from the other end.
this branch will be subject to forced pushes.
TODO
commit 5a056f615fdd08111687d6b388fa3f3698be1c22
Author: Oswald Buddenhagen o...@kde.org
Date: Sat Feb 6 10:32:10 2010 +0100
some more error reporting relating malformed messages
src/sync.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/sync.c b/src
commit 29fe45911e4318255c1cebfce22f79960850a991
Author: Oswald Buddenhagen o...@kde.org
Date: Sat Feb 6 11:27:55 2010 +0100
compile (with newer BDB?)
src/maildir.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/maildir.c b/src/maildir.c
index 19cef25
The branch 'master', previously at 6e2098c, has been rewound by 1
revision(s) to 3599542.
--
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best
commit ffb6e178ff8d17ffca3810dd33e66996dfb970ca
Author: Oswald Buddenhagen o...@kde.org
Date: Sat Feb 6 10:48:11 2010 +0100
more to do
TODO | 41 -
1 files changed, 40 insertions(+), 1 deletions(-)
diff --git a/TODO b/TODO
index dd2aafc..3a53844
commit 8f172d9c5b364bb69a48abb23ebe473681e41217
Author: Oswald Buddenhagen o...@kde.org
Date: Sat Feb 6 16:30:22 2010 +0100
cvsignore = gitignore
.cvsignore = .gitignore |6 ++
src/{.cvsignore = .gitignore}|1 +
src/compat/{.cvsignore = .gitignore} |1
commit 6f38c350a09609a3f16ea58054f6a6161aecdb49
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Feb 7 17:36:38 2010 +0100
add -P option to isync wrapper
not really a backwards compat option, but whatever ...
submitted long ago by
CCMAIL: Jaeho Shin n...@users.sf.net
The branch 'master', previously at 6f38c35, has been rewound by 1
revision(s) to c7f1af5.
--
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best
The branch 'master', previously at 84cc8b5, has been rewound by 4
revision(s) to 016e0b8.
--
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best
commit e4e030421cd9c8c6174a4ed5e0c45047d4d4b835
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Feb 7 17:36:38 2010 +0100
add -P option to isync wrapper
not really a backwards compat option, but whatever ...
based on a patch submitted long ago by nobody.
BUG: 1433532
commit 0832ef8ba7044ec872a8a354cafed109b8060ae3
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Feb 7 12:23:56 2010 +0100
adjust ChangeLog generation to git
now that log generation is cheap, don't store it in the SCM any more.
ChangeLog | 1445
commit 3c97ccabff0b3270273b22a041a1f26e7d9dd1a5
Author: Oswald Buddenhagen o...@kde.org
Date: Thu Sep 23 09:56:20 2010 +0200
link to the list's info page instead of giving a blank address
index.html |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/index.html b
commit 26a79a3056bfc46d90bcc4875d6a4ce07d7a995d
Author: Oswald Buddenhagen o...@kde.org
Date: Thu Sep 23 09:56:59 2010 +0200
use the stable branch for manual generation
Makefile |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 53b5eb8
commit 1bed73f61ff5d8e3c63ae2b3a6b05fb149663091
Author: Oswald Buddenhagen o...@kde.org
Date: Thu Sep 23 10:04:15 2010 +0200
adjust upload location
Makefile |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 69f8a17..d0eee3b 100644
The branch 'ssl-fprint' has been created at 608a286.
--
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
commit 802e8004356e6928b0a918f33fc735aa54a01a07
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Sep 26 15:24:22 2010 +0200
add support for ssl server certificate fingerprint checking
based on a patch by Ben Kibbey, sourceforge tracker item 3073733.
src/drv_imap.c | 43
commit be07bbb4a1bbdab9ebd1e9ae526c5d1ddd83a447
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Oct 3 11:53:18 2010 +0200
don't hang after failed start_tls()
we'd send a LOGOUT command in plain text while the server was already
expecting an encrypted command, which would
commit e71bfc6d06bf3fc06ad76e94457e6f04a2f89004
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Feb 28 22:23:20 2010 +0100
remove mail addresses from man pages
apparently, some people don't see the maintained by bits, so make them
look harder for explicit contact information
commit 7f1315d591575f671ad3711a3337f01f4354c63e
Author: Oswald Buddenhagen o...@kde.org
Date: Mon Apr 5 13:08:17 2010 +0200
beautify error messages
don't print the error number - we print the error string anyway, so it
adds no value.
add some whitespace to the messages
commit 7fadb989acb05ecab12566b701b22459f0cb2a11
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Oct 3 14:25:59 2010 +0200
fix UIDNEXT handling
UIDNEXT *can* be legally zero, so deal with it.
src/drv_imap.c |6 --
1 files changed, 4 insertions(+), 2 deletions
On Thu, Jan 13, 2011 at 09:37:10PM +0200, Felipe Contreras wrote:
On Thu, Jan 13, 2011 at 9:34 PM, Oswald Buddenhagen o...@kde.org wrote:
On Thu, Jan 13, 2011 at 09:04:56PM +0200, Felipe Contreras wrote:
I started to have server-side filters (MS Exchance) to put mail into
directories
The branch 'async', previously at 405d19e, has been rewound by 2
revision(s) to 1d0c484.
--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the
commit 003fd6474fa9abc5354d0dca9dcc9aad58e1d2e8
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 6 23:04:46 2011 +0100
don't leak SSL objects
src/drv_imap.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/drv_imap.c b/src/drv_imap.c
index d8acc4f
commit 9e778c5450e32bf39382c6ebbe40c46d43b9e827
Author: Oswald Buddenhagen o...@kde.org
Date: Mon Nov 15 10:30:24 2010 +0100
purge imap_store_t::currentnc vestiges
we always actually open the mailbox before appending to it, so we
obviously know that it exists - that's why
commit 93c5595d4baa2e183c77d1cd5a8e934eb78e15ed
Author: Oswald Buddenhagen o...@kde.org
Date: Mon Nov 15 10:38:50 2010 +0100
do away with the dreaded rcaps hack
don't pretend that the server has no literal+ for the time of the
first relevant command's synchronous execution
commit fc5da2fd0a11bf5f26eda1f5ade443bac1f2addd
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Dec 19 23:33:29 2010 +0100
don't hang if store cannot be opened asynchronously
src/main.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/main.c b/src/main.c
commit 8b3bb9ade881d203b54f7495feb2c9530dcbf5be
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 13 11:34:04 2011 +0100
make imap_exec() result reporting callback-based
this makes the IMAP command submission interface asynchronous.
the imap context is now refcounted
commit 56c5a4d2467428c22e35bf447f05570a42caa3c0
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 13 15:51:09 2011 +0100
make drv-cancel callback have no status code
this function is not going to actually execute any commands, so it
makes no sense for it to return a status
commit eaa44a9a7e37547ca6eb8ac9b5f133612eb9b3c7
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 13 15:53:23 2011 +0100
replace DRV_STORE_BAD with a separate bad_callback()
that way we don't have to piggy-back (possibly asynchronous) fatal
errors to particular commands
commit b6940b482c8ef744c74cabba410c27c515170aae
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Nov 14 23:16:32 2010 +0100
docs
- insert separator comments between driver entry points
- document driver API
- fix one comment
src/drv_imap.c | 36
commit b817c3afd10f73ebfff251b1dd1bbc455aae9031
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 13 12:06:49 2011 +0100
move greeting response handling into get_cmd_result()
the primary purpose of this is getting rid of the free-standing
buffer_gets() call.
src
commit 9bc99080de718a07986f23ecfb8b4c7fb2bffa61
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Jan 23 14:06:03 2011 +0100
Socket_t + buffer_t = conn_t
remove the layering, in favor of a buffered connection abstraction.
src/drv_imap.c | 44
commit a025359c8a08fbe07294d732e7efc8b0f3d55cc6
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 6 22:30:44 2011 +0100
make IMAP pipeline depth configurable
currently, this affects only clustered message listings and
flag stores.
src/drv_imap.c | 11 +--
src
commit 918f97c8c509762a389732efc05fe87ebc047d0a
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 13 13:40:39 2011 +0100
change socket_write() return code semantics
instead of returning a write()-like result, return only a binary status
code - write errors are handled
commit 66b041882ca1b61b9e383b522a6bfcbafa262aa4
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 13 14:12:54 2011 +0100
make socket_write() capable of taking ownership of the buffer
that way the user code doesn't have to free it any more.
src/drv_imap.c | 36
commit 4032aa94f43f1cdf535b2011c0b5a03f64214351
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 13 14:24:15 2011 +0100
centralize imap_cmd disposal
src/drv_imap.c | 43 +++
1 files changed, 23 insertions(+), 20 deletions(-)
diff --git a/src
commit c938ebdd227d429ee375231c5462d299b33ac036
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 13 15:03:59 2011 +0100
compile with -ansi -pedantic on gcc
greatly helps portability ...
configure.in|3 ++-
src/drv_imap.c | 12 ++--
src/mdconvert.c |2
commit 7de87234370f1ac74f3d70a0d7264720c90d5f63
Author: Oswald Buddenhagen o...@kde.org
Date: Sat Mar 12 16:20:48 2011 +0100
less bizarre code
we know that there is only one command in progress, so there
is no need to employ tricks to access the last command.
src/drv_imap.c
commit a960dec7e3242ff887bcf4278cd07c321645ff68
Author: Oswald Buddenhagen o...@kde.org
Date: Sat Mar 12 16:16:42 2011 +0100
get rid of redundant literal_pending state flag
src/drv_imap.c | 15 +++
1 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/src/drv_imap.c
commit 7cb85c1c551ef1d044a59767ef20dc8cf5153d4b
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 13 14:44:49 2011 +0100
*** full async
configure.in |2 +-
src/drv_imap.c | 475 +++--
src/isync.h| 54 +-
src/mbsync.1 |4
On Sun, Mar 13, 2011 at 03:41:43PM +, Oswald Buddenhagen wrote:
commit 7cb85c1c551ef1d044a59767ef20dc8cf5153d4b
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 13 14:44:49 2011 +0100
*** full async
fwiw, this is mostly ready, except that i'll still try to split up
On Mon, Mar 21, 2011 at 06:51:05PM +, Bartosz Szatkowski wrote:
Maybe iam doing something wrong?
can't see anything obviously wrong.
please re-run with the -V option. and just the -v option, too - for
completeness.
commit f9f3391757f195d77ddc903aa083ad77037647b8
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 27 10:52:47 2011 +0200
fix (another) out-of-bounds access in CRLF conversion
if the header contained no CRs but the body (or the post-TUID part of
the header) did, the TUID
commit 2c2026d5ada176f8d01f84484962fc5703d8f6c6
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 27 11:01:22 2011 +0200
add CR after TUID during LF = CRLF conversion
src/sync.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/sync.c b/src/sync.c
index
commit e96898fe67ad6faca639e843a5d496a3c2952fe3
Author: Oswald Buddenhagen o...@kde.org
Date: Sat Mar 12 16:20:48 2011 +0100
less bizarre code
we know that there is only one command in progress, so there
is no need to employ tricks to access the last command.
src/drv_imap.c
The branch 'async', previously at a960dec, has been rewound by 27
revision(s) to 1d0c484.
--
Xperia(TM) PLAY
It's a major breakthrough. An authentic gaming
smartphone on the nation's most reliable network.
And it wants
Skipped 8 existing revision(s) on branch 'async'.
commit 575e0fd846cf6452ac984a74a53cad4c47598675
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Apr 10 09:58:41 2011 +0200
de-duplicate error paths
makes the code more compact. yay for gotos.
src/sync.c | 63
commit ef0b920f35d3916d55052fd3934770fcf2fe2266
Author: Oswald Buddenhagen o...@kde.org
Date: Mon Nov 15 10:38:50 2010 +0100
do away with the dreaded rcaps hack
don't pretend that the server has no literal+ for the time of the
first relevant command's synchronous execution
commit cd4ab34d1637b37c9cac5b7b8a13112c555aa763
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 20 16:27:51 2011 +0100
use return values from correct set in get_cmd_result()
DRV_OK == RESP_OK, so this worked by accident
src/drv_imap.c |4 ++--
1 files changed, 2
commit 90e9c3e458bd2ef0557ba5c56cd48be1fdaf4786
Author: Oswald Buddenhagen o...@kde.org
Date: Sat Nov 20 10:17:41 2010 +0100
after [TRYCREATE], just resend the same command instead of cloning it
src/drv_imap.c | 18 +++---
1 files changed, 7 insertions(+), 11 deletions
commit 49285ad070018798154b8eea7443855bff3429ce
Author: Oswald Buddenhagen o...@kde.org
Date: Sat Nov 20 23:48:23 2010 +0100
DRV_SERVER_BAD is and will probably stay unused = trash
src/isync.h |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/isync.h b/src
commit d230b0e7acc4142251a93c5cda35d7a6735657fa
Author: Oswald Buddenhagen o...@kde.org
Date: Wed Dec 15 19:01:27 2010 +0100
remove redundant use_ssl variables
just use the presence of an SSL object as an indicator. if something
goes wrong during the ssl handshake
commit 957a0f090669a60c8261476051c15e468547d26e
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Dec 5 16:49:11 2010 +0100
make response code parse failure of untagged OK/NO/BYE/BAD non-fatal
as such, it does not disrupt the data stream
src/drv_imap.c |3 +--
1 files changed
commit f06b6bb3227fe840b1609dbe3307c3bfc958346d
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Apr 3 16:29:18 2011 +0200
don't call cancel() repeatedly on a store
erroring command replies will trickle in even after canceling
src/sync.c |7 +--
1 files changed, 5
commit ec17733b326833527338ca5b66cba4a0bcc6915a
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 20 13:45:42 2011 +0100
always use return value from get_cmd_result()
once we have callback-based error reporting, this will ensure that we
don't operate on invalidated data
commit 076f45686c9c14af3c504867a9a27d2ad9d8aad7
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Apr 10 01:17:31 2011 +0200
use -1 instead of 1 as error indicator
that's more intuitive as it reflects POSIX file i/o.
src/sync.c | 46
commit 8162ad4872e2fd9927e71a12c6018b57cd3028eb
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Apr 10 00:52:21 2011 +0200
add synchronous return values to more functions
everything which *may* require the cancellation of a main loop needs a
return value.
this excludes
commit c97da9a988def7ae236adbe2d177e10b173f3b59
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 27 15:55:25 2011 +0200
replace DRV_STORE_BAD with a separate bad_callback()
that way we don't have to piggy-back (possibly asynchronous) fatal
errors to particular commands
commit fb0d21d15a0840647d84cf45e546f6baad1a
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Apr 3 18:15:36 2011 +0200
make imap_exec() result reporting callback-based
this makes the IMAP command submission interface asynchronous.
the functions still have synchronous
commit 946a8b53df1ed75145b0e5e46a6c0a26ece49dad
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Apr 3 18:21:46 2011 +0200
docs related fixes
- insert separator comments between driver entry points
- document driver API
- use cont()'s return code according to doc
commit 18e1aeb01d4cb44105ad309654d733a33ea2edfd
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 13 12:06:49 2011 +0100
move greeting response handling into get_cmd_result()
the primary purpose of this is getting rid of the free-standing
buffer_gets() call.
src
commit 5109c044f8108944a7ea14038db2f9ae87693208
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Jan 23 13:43:00 2011 +0100
move socket code to a separate file
this makes the layering more obvious
src/Makefile.am |2 +-
src/drv_imap.c | 541
commit 1b9b79d24ea2ff18043b1f6c2dccead2bf5bdd01
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Apr 10 13:28:48 2011 +0200
security fix: failure to load the certificate file is *not* OK ...
src/socket.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src
commit 28bfcdb94751e38ef96008d6a806c21fe00061df
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Jan 23 14:06:03 2011 +0100
Socket_t + buffer_t = conn_t
remove the layering, in favor of a buffered connection abstraction.
src/drv_imap.c | 42
commit eb14ff37f1f811b5866a4d9584153a52d53bf31e
Author: Oswald Buddenhagen o...@kde.org
Date: Sat Mar 19 22:12:55 2011 +0100
cancel submitted commands when canceling store
we already have some minimal asynchronicity, so there might be commands
in flight when a fatal error comes
commit 702ccb993dee55486ca5712f0b2b9808b587b627
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 27 16:58:23 2011 +0200
make IMAP pipeline depth configurable
currently, this affects only clustered message listings and
flag stores.
src/drv_imap.c | 11 +--
src
commit 1c036ce72dc6f55a2c46f4f5675026c02b8aed86
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 13 13:40:39 2011 +0100
change socket_write() return code semantics
instead of returning a write()-like result, return only a binary status
code - write errors are handled
commit f657ab584c92a3b15b956f2c3552a3075ee81e38
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 27 12:34:25 2011 +0200
centralize imap_cmd disposal
src/drv_imap.c | 31 ++-
1 files changed, 14 insertions(+), 17 deletions(-)
diff --git a/src/drv_imap.c
commit 65ff9ee6981de43290ad37826173fa49e766b379
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Apr 3 18:47:37 2011 +0200
decouple the filling of the read buffer from consuming it
this prepares the code for being called from a callback.
notably, this makes the imap list
commit 0dd0cf34e373503f9b9c61edbcc8c23826db7c62
Author: Oswald Buddenhagen o...@kde.org
Date: Sun Mar 27 16:50:32 2011 +0200
make socket read/write error reporting callback-based
the functions still have synchronous return codes as well -
this enables early error returns
commit 58851cddee16bcccfcae5f91b9472ffa1298a26f
Author: Oswald Buddenhagen o...@kde.org
Date: Sat Mar 19 19:40:50 2011 +0100
move responsibility for closing sockets on error to user
src/drv_imap.c |1 +
src/socket.c |4
2 files changed, 1 insertions(+), 4 deletions(-)
diff
1 - 100 of 1931 matches
Mail list logo
