Re: [java code coverage] Re: Instrumenting error caused by: java.lang.ArrayIndexOutOfBoundsException: -1

2018-04-05 Thread Evgeny Mandrikov
On Thursday, March 29, 2018 at 4:52:36 AM UTC+2, Tool Ply wrote: > > > So the conclusion is jacoco has a little bug with handling frame right? > > I notice that jacoco could exclude some classes in execution analysis >

Re: [java code coverage] Re: Instrumenting error caused by: java.lang.ArrayIndexOutOfBoundsException: -1

2018-03-29 Thread Evgeny Mandrikov
On Thu, Mar 29, 2018 at 6:58 PM Marc Hoffmann wrote: > Here is a proposed fix: > > https://github.com/jacoco/jacoco/pull/667 > > I didn't yet expand it to other validation tests as they depend on the > toolchain JDK. > > Not sure I understand what do you mean by

Re: [java code coverage] Re: Instrumenting error caused by: java.lang.ArrayIndexOutOfBoundsException: -1

2018-03-29 Thread Marc Hoffmann
Here is a proposed fix: https://github.com/jacoco/jacoco/pull/667 I didn't yet expand it to other validation tests as they depend on the toolchain JDK. Cheers, -marc On 2018-03-29 12:54, Evgeny Mandrikov wrote: > On Thu, Mar 29, 2018 at 7:30 AM Marc Hoffmann

Re: [java code coverage] Re: Instrumenting error caused by: java.lang.ArrayIndexOutOfBoundsException: -1

2018-03-29 Thread Evgeny Mandrikov
On Thu, Mar 29, 2018 at 7:30 AM Marc Hoffmann wrote: > Hi Evgeny, > > I was as bit confused at the beginning as we have ClassFileVersionsTest > which tests for existence of frames. > > But after a closer look I realized that this test only checks whether our >

Re: [java code coverage] Re: Instrumenting error caused by: java.lang.ArrayIndexOutOfBoundsException: -1

2018-03-29 Thread Marc Hoffmann
> Marc, how you execute CheckClassAdapter ? I did it completely wrong: Created a small Java main() but accedentially used SKIP_CODE for the accept method(). Sorry for the noise... I'll now try to improve ClassFileVersionsTest to demonstrate the problem. Regards, -marc On 2018-03-28

Re: [java code coverage] Re: Instrumenting error caused by: java.lang.ArrayIndexOutOfBoundsException: -1

2018-03-28 Thread Tool Ply
Thank you very much. Evgeny and Marc I am supposed to add some details to perfect jacoco. the first two classes, abap.classs and aaqc.class, are created by dex2jar 2.x , while the last one, UiApiPlugin.class, was created by enjarify

Re: [java code coverage] Re: Instrumenting error caused by: java.lang.ArrayIndexOutOfBoundsException: -1

2018-03-28 Thread Evgeny Mandrikov
Marc, how you execute CheckClassAdapter ? My attempt shows a lot of "ClassNotFoundException" because of missing classes that this class depends on, but no "Execution can fall off end of the code". Also looking at "" in output of "javap -v -p UiApiPlugin.class", I don't see how it can fall off

[java code coverage] Re: Instrumenting error caused by: java.lang.ArrayIndexOutOfBoundsException: -1

2018-03-26 Thread Tool Ply
Ok,thank you 在 2018年3月23日星期五 UTC+8上午1:21:33,Evgeny Mandrikov写道: > > $ javap -v -p aaqc.class | grep "major version" > major version: 50 > > i.e. contains Java 1.6 bytecode. > > http://www.jacoco.org/jacoco/trunk/doc/faq.html clearly states : class > files version 1.6 and above have to contain

[java code coverage] Re: Instrumenting error caused by: java.lang.ArrayIndexOutOfBoundsException: -1

2018-03-22 Thread Evgeny Mandrikov
$ javap -v -p aaqc.class | grep "major version" major version: 50 i.e. contains Java 1.6 bytecode. http://www.jacoco.org/jacoco/trunk/doc/faq.html clearly states : class files version 1.6 and above have to contain valid stackmap frames $ javap -v -p aaqc.class | grep StackMapTable | wc -l 0

[java code coverage] Re: Instrumenting error caused by: java.lang.ArrayIndexOutOfBoundsException: -1

2018-03-21 Thread Tool Ply
在 2018年3月22日星期四 UTC+8上午1:56:59,Evgeny Mandrikov写道: > > Please provide "abap.class". > > On Wednesday, March 21, 2018 at 6:03:53 PM UTC+1, Tool Ply wrote: >> >> I tried to instrument a jar which was translated from an apk by using >> dex2jar. Then the error arised. >> >> There are some details

[java code coverage] Re: Instrumenting error caused by: java.lang.ArrayIndexOutOfBoundsException: -1

2018-03-21 Thread Evgeny Mandrikov
Please provide "abap.class". On Wednesday, March 21, 2018 at 6:03:53 PM UTC+1, Tool Ply wrote: > > I tried to instrument a jar which was translated from an apk by using > dex2jar. Then the error arised. > > There are some details about command and exception. > > *java -jar >