Re: [PATCH 13/38] core: ivshmem: Use device ID from config

2020-01-14 Thread Ralf Ramsauer
On 1/6/20 1:17 PM, Jan Kiszka wrote: > From: Jan Kiszka > > Convert the creation order based ID assignment to the one now provided > by the cell configuration. > > Signed-off-by: Jan Kiszka > --- > hypervisor/include/jailhouse/ivshmem.h | 1 - > hypervisor/ivshmem.c | 13

Re: [PATCH 23/38] configs: Factor out ivshmem memory region macro for network devices

2020-01-14 Thread Ralf Ramsauer
[...] On 1/6/20 1:18 PM, Jan Kiszka wrote: > diff --git a/include/jailhouse/cell-config.h b/include/jailhouse/cell-config.h > index a62fa1ee..f82bbe8d 100644 > --- a/include/jailhouse/cell-config.h > +++ b/include/jailhouse/cell-config.h > @@ -129,6 +129,15 @@ struct jailhouse_memory { > __u

Re: [PATCH 24/38] configs: Move ivshmem memory regions at array start

2020-01-14 Thread Ralf Ramsauer
On 1/6/20 1:18 PM, Jan Kiszka wrote: > From: Jan Kiszka > > Simplifies index calculation and reduces risk of errors. The only > downside is that regions are no longer ordered according to their > physical addresses. We have 64 bit for flags. Instead of moving those memory regions to the top,

Re: [PATCH 13/38] core: ivshmem: Use device ID from config

2020-01-14 Thread Jan Kiszka
On 14.01.20 15:25, Ralf Ramsauer wrote: On 1/6/20 1:17 PM, Jan Kiszka wrote: From: Jan Kiszka Convert the creation order based ID assignment to the one now provided by the cell configuration. Signed-off-by: Jan Kiszka --- hypervisor/include/jailhouse/ivshmem.h | 1 - hypervisor/ivshmem

Re: [PATCH 24/38] configs: Move ivshmem memory regions at array start

2020-01-14 Thread Jan Kiszka
On 14.01.20 15:27, Ralf Ramsauer wrote: On 1/6/20 1:18 PM, Jan Kiszka wrote: From: Jan Kiszka Simplifies index calculation and reduces risk of errors. The only downside is that regions are no longer ordered according to their physical addresses. We have 64 bit for flags. Instead of moving

Re: [PATCH 23/38] configs: Factor out ivshmem memory region macro for network devices

2020-01-14 Thread Jan Kiszka
On 14.01.20 15:26, Ralf Ramsauer wrote: [...] On 1/6/20 1:18 PM, Jan Kiszka wrote: diff --git a/include/jailhouse/cell-config.h b/include/jailhouse/cell-config.h index a62fa1ee..f82bbe8d 100644 --- a/include/jailhouse/cell-config.h +++ b/include/jailhouse/cell-config.h @@ -129,6 +129,15 @@ stru

Re: [PATCH 23/38] configs: Factor out ivshmem memory region macro for network devices

2020-01-14 Thread Ralf Ramsauer
On 1/14/20 3:37 PM, Jan Kiszka wrote: > On 14.01.20 15:26, Ralf Ramsauer wrote: >> [...] >> >> On 1/6/20 1:18 PM, Jan Kiszka wrote: >>> diff --git a/include/jailhouse/cell-config.h >>> b/include/jailhouse/cell-config.h >>> index a62fa1ee..f82bbe8d 100644 >>> --- a/include/jailhouse/cell-config.h

Re: [PATCH 23/38] configs: Factor out ivshmem memory region macro for network devices

2020-01-14 Thread Jan Kiszka
On 14.01.20 15:59, Ralf Ramsauer wrote: On 1/14/20 3:37 PM, Jan Kiszka wrote: On 14.01.20 15:26, Ralf Ramsauer wrote: [...] On 1/6/20 1:18 PM, Jan Kiszka wrote: diff --git a/include/jailhouse/cell-config.h b/include/jailhouse/cell-config.h index a62fa1ee..f82bbe8d 100644 --- a/include/jailh

[siemens/jailhouse] 9eb860: core: ivshmem: Unconditionally check ID range

2020-01-14 Thread Jan Kiszka
Branch: refs/heads/next Home: https://github.com/siemens/jailhouse Commit: 9eb8608a209b0ab7aa6032fe8dfb38d043d4c1e2 https://github.com/siemens/jailhouse/commit/9eb8608a209b0ab7aa6032fe8dfb38d043d4c1e2 Author: Jan Kiszka Date: 2020-01-14 (Tue, 14 Jan 2020) Changed paths:

[PATCH] core: ivshmem: Unconditionally check ID range

2020-01-14 Thread Jan Kiszka
From: Jan Kiszka This check should not depend on whether we are adding a peer to link or starting a new one. Reported-by: Ralf Ramsauer Signed-off-by: Jan Kiszka --- hypervisor/ivshmem.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hypervisor/ivshmem.c b/hypervisor