Re: [RFC PATCH 0/3] x86 code split and x86-64 emitters

2009-05-25 Thread Pekka Enberg
Eduard - Gabriel Munteanu wrote: > Yes, we can, but I thought we unnecessarily end up with global symbols > that we don't use in any other file. Apart from that, we need to create > either a header file or declare prototypes in both emit-code_32.c and > emit-code_64.c. Another option is to make em

Re: [RFC PATCH 0/3] x86 code split and x86-64 emitters

2009-05-25 Thread Eduard - Gabriel Munteanu
On Mon, May 25, 2009 at 10:26:10PM +0300, Pekka Enberg wrote: > Eduard - Gabriel Munteanu wrote: >> You can merge the first patch right away. > > Will do. > > Eduard - Gabriel Munteanu wrote: >> On the others I'd like your opinion. Are you okay with that >> '#include "emit-code.c"' stuff? > > Not r

Re: [RFC PATCH 0/3] x86 code split and x86-64 emitters

2009-05-25 Thread Pekka Enberg
Eduard - Gabriel Munteanu wrote: > You can merge the first patch right away. Will do. Eduard - Gabriel Munteanu wrote: > On the others I'd like your opinion. Are you okay with that > '#include "emit-code.c"' stuff? Not really :-). Can't we just make the functions in emit-code.c non-static and u