robertlazarski commented on PR #842:
URL:
https://github.com/apache/axis-axis2-java-core/pull/842#issuecomment-2877225759
This looks great. Thanks @cortlepp for sticking with this and coming up with
a code good enough to merge.
--
This is an automated message from the Apache Git Servi
robertlazarski merged PR #842:
URL: https://github.com/apache/axis-axis2-java-core/pull/842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: java-dev-uns
cortlepp commented on PR #842:
URL:
https://github.com/apache/axis-axis2-java-core/pull/842#issuecomment-2809030190
@robertlazarski I thought a bit more about this decided that my special case
for IPv6 unique local addresses might not be correct, so I removed it. I also
implemented that by
cortlepp commented on PR #842:
URL:
https://github.com/apache/axis-axis2-java-core/pull/842#issuecomment-2697769029
> That last IP should be returned in the List from this new method as one of
the IP's, correct?
Well, yes, but actually no (I think). The current implementation was
so
robertlazarski commented on PR #842:
URL:
https://github.com/apache/axis-axis2-java-core/pull/842#issuecomment-2659379241
@cortlepp this Linux command below shows a localhost ipv6 address and an
ipv6 address assigned from a router.
ip a | grep inet6
inet6 ::1/128 scope host
cortlepp commented on PR #842:
URL:
https://github.com/apache/axis-axis2-java-core/pull/842#issuecomment-2658623528
@robertlazarski I'm not quite sure if I understand what you're saying: does
the new `getLocalHostLANAddresses()` function not return your IPv6, or do we
just not select the "
robertlazarski commented on PR #842:
URL:
https://github.com/apache/axis-axis2-java-core/pull/842#issuecomment-2658118230
@cortlepp upon further review this code finds my default ipv6 address on my
local Ubuntu machine but doesn't return it - only ipv4.
See this print statement that
cortlepp commented on PR #842:
URL:
https://github.com/apache/axis-axis2-java-core/pull/842#issuecomment-2620876725
@robertlazarski Thanks so much for looking into this! Do you perhaps have
any idea how/where I can add a good test for this?
--
This is an automated message from the Apache
robertlazarski commented on PR #842:
URL:
https://github.com/apache/axis-axis2-java-core/pull/842#issuecomment-2619580608
@cortlepp I reviewed the builds and code, with a conclusion that
map(InetAddress::getHostAddress) instead of map(InetAddress::toString) in
getIpAddress() will fix the i
cortlepp commented on PR #842:
URL:
https://github.com/apache/axis-axis2-java-core/pull/842#issuecomment-2615366505
There seems to be a problem in the `TCPEchoRawXMLTest`, for some hard to
debug reason the TCP server keeps shutting down soon after or as soon as we try
to connect to it. Unf
cortlepp commented on PR #842:
URL:
https://github.com/apache/axis-axis2-java-core/pull/842#issuecomment-2586691011
If possible I'd like to also add tests for this, but I'm unsure where/how.
If someone has an idea that would be great.
--
This is an automated message from the Apache Git S
cortlepp commented on PR #842:
URL:
https://github.com/apache/axis-axis2-java-core/pull/842#issuecomment-2586653586
@robertlazarski can you restart the build? From the stacktrace it seems like
this to just be some dns resolution failure, but I don't see how I can restart
the build.
--
T
cortlepp opened a new pull request, #842:
URL: https://github.com/apache/axis-axis2-java-core/pull/842
See discussion in [Jira](https://issues.apache.org/jira/browse/AXIS2-5858).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
13 matches
Mail list logo
