Again - random opinion from left field - I've used guice and I like it
a lot. Really cool stuff and I actually prefer it to Spring for
injection. But still for some reason I'd hate to see Lucene start
resembling anything in Guice.
I'm not even taking the time to make arguments, so I don't e
On Oct 2, 2009, at 10:18 PM, Earwin Burrfoot wrote:
Call me old fashioned, but I like how the non constructor params
are set
now.
And what happens when you index some docs, change these params, index
more docs, change params, commit? Let's throw in some threads?
You either end up writing
> Call me old fashioned, but I like how the non constructor params are set
> now.
And what happens when you index some docs, change these params, index
more docs, change params, commit? Let's throw in some threads?
You either end up writing really hairy state control code, or just
leave it broken,
> Though what about required settings? EG IW's builder must have
> Directory, Analyzer. Would we pass these as up-front args to the
> initial builder?
I'd try to keep required settings at minimum. The only one absolutely
required, imho, is a Directory, and it's best to specify it in
create() meth
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761785#action_12761785
]
Mark Miller edited comment on LUCENE-1257 at 10/2/09 5:30 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761785#action_12761785
]
Mark Miller edited comment on LUCENE-1257 at 10/2/09 5:28 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761785#action_12761785
]
Mark Miller commented on LUCENE-1257:
-
{quote}Actually I patched the Snowball stemmer
Call me old fashioned, but I like how the non constructor params are set
now.
And for some reason I like a config object over a builder pattern for
the required constructor params.
Thats just me though.
Michael McCandless wrote:
> OK, I agree, using the builder approach looks compelling!
>
> Tho
OK, I agree, using the builder approach looks compelling!
Though what about required settings? EG IW's builder must have
Directory, Analyzer. Would we pass these as up-front args to the
initial builder?
And shouldn't we still specify the version up-front so we can improve
defaults over time wit
I already started with removing deprecations in o.a.l.store and make FSDir
abstract. This package is finished, now I have to remove all these
open()/ctors using getDirectory().
Will post a patch tomorrow! Good night!
Uwe
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaph
On Sat, Oct 3, 2009 at 03:29, Uwe Schindler wrote:
>> It is also probably a good idea to move various settings methods from
>> IW to that builder and have IW immutable in regards to configuration.
>> I'm speaking of the likes of setWriteLockTimeout, setRAMBufferSizeMB,
>> setMergePolicy, setMergeS
> I like Earwin's version more. A builder is very flexible, because you can
> concat all your properties (like StringBuilder works with its append
> method
> returning itself) and create the instance at the end.
This is a really cool example of this builder pattern:
http://google-collections.goog
I like Earwin's version more. A builder is very flexible, because you can
concat all your properties (like StringBuilder works with its append method
returning itself) and create the instance at the end.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@th
I think this would make sense... though, it'd be a shame if the
"simple case" becomes overbearing. Maybe we can keep good defaults,
but use Version to allow us to change them. So eg:
new IndexWriter(new IndexWriter.Config(dir, analyzer, Version.LUCENE_29));
would be the "simple" case.
Mike
Sigh. The introduction of new but deprecated methods is silly. Is
there some simple automated way to catch/prevent these?
The proliferation of ctors/factory methods is a nightmare.
Part of the story with IndexReader.open is the switch to readOnly
IndexReaders. After the long back-compat discus
> It is also probably a good idea to move various settings methods from
> IW to that builder and have IW immutable in regards to configuration.
> I'm speaking of the likes of setWriteLockTimeout, setRAMBufferSizeMB,
> setMergePolicy, setMergeScheduler, setSimilarity.
>
> IndexWriter.Builder iwb =
It is also probably a good idea to move various settings methods from
IW to that builder and have IW immutable in regards to configuration.
I'm speaking of the likes of setWriteLockTimeout, setRAMBufferSizeMB,
setMergePolicy, setMergeScheduler, setSimilarity.
IndexWriter.Builder iwb = IndexWriter.
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761774#action_12761774
]
Uwe Schindler edited comment on LUCENE-1257 at 10/2/09 4:22 PM:
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1257:
--
Attachment: LUCENE-1257-Document.patch
Generification of Document. It makes now clear what get
I was thinking lately about the large quantity of IndexWriter
constructors and IndexReader open methods. I'm not sure if this has been
proposed before, but what if we introduced new objects, e.g.
IndexWriterConfig and IndexReaderConfig. They would contain
getter/setter methods for all the diffe
When looking for press articles about the release of Lucene 2.9, I found the
following one from Bernd Fondermann
@ http://it-republik.de/jaxenter/artikel/Apache-Lucene-2.9-2594.html
Translation with Google Translate:
Depr
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761754#action_12761754
]
Uwe Schindler commented on LUCENE-1257:
---
I already committed tha non-public-API chan
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761755#action_12761755
]
Karl Wettin commented on LUCENE-1257:
-
bq. I vote to move to StringBuilder anyway if i
[
https://issues.apache.org/jira/browse/LUCENE-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761756#action_12761756
]
Robert Muir commented on LUCENE-1833:
-
Uwe, I agree with what Mark said.
my previous
[
https://issues.apache.org/jira/browse/LUCENE-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761752#action_12761752
]
Mark Miller commented on LUCENE-1833:
-
bq. I hope, nobody has problems with merging ca
[
https://issues.apache.org/jira/browse/LUCENE-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-1833.
---
Resolution: Fixed
Committed revision: 821186
I hope, nobody has problems with merging cause
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761748#action_12761748
]
Mark Miller commented on LUCENE-1257:
-
bq. There are still some special cases in contr
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761747#action_12761747
]
Uwe Schindler edited comment on LUCENE-1257 at 10/2/09 3:12 PM:
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761747#action_12761747
]
Uwe Schindler commented on LUCENE-1257:
---
StringBuffer changes committed revision: 82
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1257:
--
Attachment: LUCENE-1257-StringBuffer.patch
Small fix in highlighter public API.
> Port to Jav
[
https://issues.apache.org/jira/browse/LUCENE-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hasan Diwan updated LUCENE-1942:
Attachment: lucene.pat
Patch fixes the compile bugs outlined in the summary.
> NUM_THREADS is a s
[
https://issues.apache.org/jira/browse/LUCENE-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1257:
--
Attachment: LUCENE-1257-StringBuffer.patch
Updated patch. It removes some replacements in snow
[
https://issues.apache.org/jira/browse/LUCENE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir reassigned LUCENE-1943:
---
Assignee: Robert Muir
> ChineseFilter is inefficient
>
>
>
[
https://issues.apache.org/jira/browse/LUCENE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-1943:
Attachment: LUCENE-1943.patch
> ChineseFilter is inefficient
>
>
>
ChineseFilter is inefficient
Key: LUCENE-1943
URL: https://issues.apache.org/jira/browse/LUCENE-1943
Project: Lucene - Java
Issue Type: Improvement
Components: contrib/analyzers
Reporter: Ro
[
https://issues.apache.org/jira/browse/LUCENE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761726#action_12761726
]
Uwe Schindler commented on LUCENE-1939:
---
Yes you are right, I updated/fixed ShingleF
[
https://issues.apache.org/jira/browse/LUCENE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761724#action_12761724
]
Robert Muir commented on LUCENE-1939:
-
bq. Michael Busch and me updated it It is now
[
https://issues.apache.org/jira/browse/LUCENE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761720#action_12761720
]
Uwe Schindler edited comment on LUCENE-1939 at 10/2/09 2:07 PM:
[
https://issues.apache.org/jira/browse/LUCENE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761720#action_12761720
]
Uwe Schindler commented on LUCENE-1939:
---
Michael Busch and me updated it :-) It is n
[
https://issues.apache.org/jira/browse/LUCENE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761712#action_12761712
]
Karl Wettin commented on LUCENE-1939:
-
bq. I also think so, because the above stack du
[
https://issues.apache.org/jira/browse/LUCENE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761708#action_12761708
]
Uwe Schindler commented on LUCENE-1939:
---
I also think so, because the above stack du
[
https://issues.apache.org/jira/browse/LUCENE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761706#action_12761706
]
Karl Wettin commented on LUCENE-1939:
-
bq. Is this caused by the rewrite because of th
NUM_THREADS is a static member of RunAddIndexesThreads and should be accessed
in a static way
-
Key: LUCENE-1942
URL: https://issues.apache.org/jira/browse/LUCENE-1942
[
https://issues.apache.org/jira/browse/LUCENE-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1833:
--
Attachment: LUCENE-1833.patch
This patch changes all "new Number(" code parts with "Number.val
[
https://issues.apache.org/jira/browse/LUCENE-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler reassigned LUCENE-1833:
-
Assignee: Uwe Schindler
> When we move to java 1.5 in 3.0 we should replace all Interger
[
https://issues.apache.org/jira/browse/LUCENE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761679#action_12761679
]
Paul Elschot commented on LUCENE-1940:
--
Uwe, thanks for opening this issue.
I'll col
MinPayloadFunction returns 0 when only one payload is present
-
Key: LUCENE-1941
URL: https://issues.apache.org/jira/browse/LUCENE-1941
Project: Lucene - Java
Issue Type: Bug
[
https://issues.apache.org/jira/browse/LUCENE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1940:
--
Summary: Refactor ScorerDocQueue that it subclasses
PriorityQueue (was: Recaftor ScorerDocQue
[
https://issues.apache.org/jira/browse/LUCENE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761653#action_12761653
]
Uwe Schindler commented on LUCENE-1935:
---
Hi Paul Elschot: I opened LUCENE-1940 for t
Recaftor ScorerDocQueue that it subclasses PriorityQueue
-
Key: LUCENE-1940
URL: https://issues.apache.org/jira/browse/LUCENE-1940
Project: Lucene - Java
Issue Type: Tas
[
https://issues.apache.org/jira/browse/LUCENE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-1935.
---
Resolution: Fixed
Committed revision: 821104
> Generify PriorityQueue
> ---
[
https://issues.apache.org/jira/browse/LUCENE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761576#action_12761576
]
Uwe Schindler commented on LUCENE-1939:
---
Is this caused by the rewrite because of th
[
https://issues.apache.org/jira/browse/LUCENE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Wettin reassigned LUCENE-1939:
---
Assignee: Karl Wettin
> IndexOutOfBoundsException at ShingleMatrixFilter's Iterator#hasNext
[
https://issues.apache.org/jira/browse/LUCENE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Jungermann updated LUCENE-1939:
---
Attachment: ShingleMatrixFilter_IndexOutOfBoundsException.patch
patch
> IndexOutOfB
IndexOutOfBoundsException at ShingleMatrixFilter's Iterator#hasNext method
--
Key: LUCENE-1939
URL: https://issues.apache.org/jira/browse/LUCENE-1939
Project: Lucene - Java
[
https://issues.apache.org/jira/browse/LUCENE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761492#action_12761492
]
Paul Elschot commented on LUCENE-1935:
--
> Do you want to provide a patch for ScorerDo
56 matches
Mail list logo
