[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834824#action_12834824
]
Shai Erera commented on LUCENE-1720:
bq. I have commit rights
Oh, sorry, I didn't kno
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834819#action_12834819
]
Mark Harwood commented on LUCENE-1720:
--
bq. How do we proceed from here? Is there a c
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834801#action_12834801
]
Shai Erera commented on LUCENE-1720:
How do we proceed from here? Is there a committer
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833902#action_12833902
]
Mark Harwood commented on LUCENE-1720:
--
bq. Mark, the only thing that remains is to c
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833867#action_12833867
]
Shai Erera commented on LUCENE-1720:
bq. Would that be abstract? ...
I've actually w
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833863#action_12833863
]
Mark Harwood commented on LUCENE-1720:
--
bq. BTW found and fixed a bug in TimeLimiting
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833845#action_12833845
]
Shai Erera commented on LUCENE-1720:
bq. most reader-wrappers would use this as a base
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833838#action_12833838
]
Shai Erera commented on LUCENE-1720:
Hmm ... I've added the method above, and it solve
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833833#action_12833833
]
Mark Harwood commented on LUCENE-1720:
--
bq. Anyway, I'm putting that aside for now, a
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833827#action_12833827
]
Shai Erera commented on LUCENE-1720:
Ok, it looks like ConcurrentHashMap cannot be use
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833013#action_12833013
]
Mark Harwood commented on LUCENE-1720:
--
bq. I think we should add some search timeout
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833009#action_12833009
]
Shai Erera commented on LUCENE-1720:
Hit the submit button too soon.
I forgot to add
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833007#action_12833007
]
Shai Erera commented on LUCENE-1720:
Hey Mark, I'm working on the patch also (experime
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832987#action_12832987
]
Mark Harwood commented on LUCENE-1720:
--
bq. I also want to add a TestTimeLimitedIndex
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832858#action_12832858
]
Shai Erera commented on LUCENE-1720:
Thanks Mark. I will take a look at the patch a bi
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832721#action_12832721
]
Mark Harwood commented on LUCENE-1720:
--
bq. When's this ready to test with Solr?
I t
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832638#action_12832638
]
Jason Rutherglen commented on LUCENE-1720:
--
When's this ready to test with Solr?
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832501#action_12832501
]
Shai Erera commented on LUCENE-1720:
BTW, perhaps to allow even finer granularity and
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832500#action_12832500
]
Mark Harwood commented on LUCENE-1720:
--
I'll pick this up
> TimeLimitedIndexReader a
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832491#action_12832491
]
Shai Erera commented on LUCENE-1720:
bq. We can always provide a convenience wrapper m
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832483#action_12832483
]
Mark Harwood commented on LUCENE-1720:
--
Agreed, might be useful to provide boolean re
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832480#action_12832480
]
Shai Erera commented on LUCENE-1720:
Liked the formatting. Didn't know you can do that
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832470#action_12832470
]
Mark Harwood commented on LUCENE-1720:
--
The change to ATM isn't that big - as you say
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832461#action_12832461
]
Shai Erera commented on LUCENE-1720:
I like the idea of adding the projected activity
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832444#action_12832444
]
Mark Harwood commented on LUCENE-1720:
--
Thanks for the updates, Shai.
Agreed on remo
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832427#action_12832427
]
Shai Erera commented on LUCENE-1720:
BTW Mark, if we assume the number of threads that
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742915#action_12742915
]
Jason Rutherglen commented on LUCENE-1720:
--
I've been using TimeLimitingCollector
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742902#action_12742902
]
Shai Erera commented on LUCENE-1720:
We still haven't coded in the items on the commen
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742138#action_12742138
]
Jason Rutherglen commented on LUCENE-1720:
--
I am interested in using this code, i
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734176#action_12734176
]
Mark Harwood commented on LUCENE-1720:
--
bq. Hey Mark. Have you made any progress with
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734156#action_12734156
]
Shai Erera commented on LUCENE-1720:
Hey Mark. Have you made any progress with that? W
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726382#action_12726382
]
Shai Erera commented on LUCENE-1720:
bq. Stop() removes a thread from 1) or 2)
Minor
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726128#action_12726128
]
Mark Harwood commented on LUCENE-1720:
--
Maybe we should start by debugging some guidi
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726086#action_12726086
]
Shai Erera commented on LUCENE-1720:
bq. TimeoutThread should call the existing "reset
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726064#action_12726064
]
Mark Harwood commented on LUCENE-1720:
--
re points 1,2,3 - yep, will change.
re the
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726037#action_12726037
]
Shai Erera commented on LUCENE-1720:
# Can we move to call Thread.currentThread() only
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725741#action_12725741
]
Mark Harwood commented on LUCENE-1720:
--
bq. Ah, so we're assuming most actions don't
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725729#action_12725729
]
Jason Rutherglen commented on LUCENE-1720:
--
{quote}This lookup only happens when
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725500#action_12725500
]
Mark Harwood commented on LUCENE-1720:
--
bq. Maybe we can benchmark this approach
See
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725386#action_12725386
]
Jason Rutherglen commented on LUCENE-1720:
--
Maybe we can benchmark this approach
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725200#action_12725200
]
Shai Erera commented on LUCENE-1720:
bq. I'm not familiar with the proposal to pass ar
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725197#action_12725197
]
Mark Harwood commented on LUCENE-1720:
--
bq. any custom Scorer which does a lot of wor
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725183#action_12725183
]
Shai Erera commented on LUCENE-1720:
bq. With only a boolean it could be hard to know
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725182#action_12725182
]
Eks Dev commented on LUCENE-1720:
-
Sure, I just wanted to "sharpen definition" what is Luc
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725176#action_12725176
]
Mark Harwood commented on LUCENE-1720:
--
bq. Oh, I did not mean to skip this check.
B
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725172#action_12725172
]
Shai Erera commented on LUCENE-1720:
bq. ... quickly testing a single volatile boolean
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725168#action_12725168
]
Eks Dev commented on LUCENE-1720:
-
it's been late for this issue, but maybe worth thinking
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725164#action_12725164
]
Mark Harwood commented on LUCENE-1720:
--
Currently the class hinges on a "fast fail" m
[
https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725144#action_12725144
]
Shai Erera commented on LUCENE-1720:
In stop(), shouldn't the 'else' part be reached o
49 matches
Mail list logo
