RE: CustomScoreQuery Explanation

2009-11-19 Thread Michael Garski
NP, sounds good. Michael -Original Message- From: Mark Miller [mailto:markrmil...@gmail.com] Sent: Thursday, November 19, 2009 5:02 PM To: java-dev@lucene.apache.org Subject: Re: CustomScoreQuery Explanation No worries - I think its a bit overkill for the change - I can just pop it in

Re: CustomScoreQuery Explanation

2009-11-19 Thread Mark Miller
ber 19, 2009 4:47 PM > *To:* java-dev@lucene.apache.org > *Subject:* Re: CustomScoreQuery Explanation > > > > I don't see any reason why doExplain should be called twice. Can you > create an issue in jira please? > > Simon > > On Nov 20, 2009 1:30 AM, &q

RE: CustomScoreQuery Explanation

2009-11-19 Thread Michael Garski
Will do, along with a patch. Michael From: Simon Willnauer [mailto:simon.willna...@googlemail.com] Sent: Thursday, November 19, 2009 4:47 PM To: java-dev@lucene.apache.org Subject: Re: CustomScoreQuery Explanation I don't see any reason why doExplain should be called twice. Ca

Re: CustomScoreQuery Explanation

2009-11-19 Thread Simon Willnauer
I don't see any reason why doExplain should be called twice. Can you create an issue in jira please? Simon On Nov 20, 2009 1:30 AM, "Michael Garski" wrote: Hi there – I’m helping out with the Lucene.Net port of 2.9, and when rooting around in CustomScoreQuery.CustomWeight, I noticed what ap

CustomScoreQuery Explanation

2009-11-19 Thread Michael Garski
Hi there - I'm helping out with the Lucene.Net port of 2.9, and when rooting around in CustomScoreQuery.CustomWeight, I noticed what appears to be an unnecessary call to doExplain in the explain method. Current method in trunk: public Explanation explain(IndexReader reader, int doc