Re: Seeking feedback on LUCENE-557

2006-06-19 Thread Chris Hostetter
: > > Should This HACK be commited, or is it better to leave explanations for : > > SpanNear queries broken untill someone has the confidence to fix LUCENE-569? : > I think it would be all right as long as you make a note of it on the : > 569 issue and in the code so that people know why the cha

Re: Seeking feedback on LUCENE-557

2006-06-19 Thread Paul Elschot
On Monday 19 June 2006 21:07, Grant Ingersoll wrote: > > Chris Hostetter wrote: > > 2) SpanScorer.explain HACK fix > > > > NearSpans.skipTo is broken (see LUCENE-569). This apparently doesn't > > affect too many people (or if it does, they haven't been filing bugs about > > it) but it does make

Re: Seeking feedback on LUCENE-557

2006-06-19 Thread Grant Ingersoll
Chris Hostetter wrote: 2) SpanScorer.explain HACK fix NearSpans.skipTo is broken (see LUCENE-569). This apparently doesn't affect too many people (or if it does, they haven't been filing bugs about it) but it does make SpanScorer.explain lie. I don't understand SpanQueries enough to feel co

Re: Seeking feedback on LUCENE-557

2006-06-15 Thread Yonik Seeley
On 6/15/06, Chris Hostetter <[EMAIL PROTECTED]> wrote: 1) Modifying existing search tests to implicitly check explain LUCENE-557-modify-existing-tests.patch modifies (almost) every core test I could find that used an IndexSearcher to use a modified IndexSearcher that implicitly tests explanation

Seeking feedback on LUCENE-557

2006-06-15 Thread Chris Hostetter
Regarding "search vs explain - score discrepancies"... http://issues.apache.org/jira/browse/LUCENE-557 ...I got sidetracked by a pesky anoyance called "work" for a little while, but I'm looking at this again, and I'd like to commit some varient of the patches I added to that bug -- the notabl