Re: index reopen question

2008-04-11 Thread Michael Busch
Chris Hostetter wrote: : 1) looking at the code: : : if (this.hasChanges || this.isCurrent()) { : // the index hasn't changed - nothing to do here : return this; : } :Shouldn't it be !this.hasChanges? ...that's from DirectoryIndexReader, and it sure looks like a bug t

Re: index reopen question

2008-04-11 Thread Chris Hostetter
: 1) looking at the code: : : if (this.hasChanges || this.isCurrent()) { : // the index hasn't changed - nothing to do here : return this; : } :Shouldn't it be !this.hasChanges? ...that's from DirectoryIndexReader, and it sure looks like a bug to me. : 2) FilterIndexRe

index reopen question

2008-04-09 Thread John Wang
Hi: Have been reading the 2.3.1 release code and have a few questions regarding indexReader reopen: 1) looking at the code: if (this.hasChanges || this.isCurrent()) { // the index hasn't changed - nothing to do here return this; } Shouldn't it be !this.hasChanges?