[jira] Updated: (LUCENE-1084) increase default maxFieldLength?

2008-01-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-1084: --- Fix Version/s: (was: 2.4) 3.0 > increase default maxFieldLeng

[jira] Commented: (LUCENE-1084) increase default maxFieldLength?

2008-01-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559887#action_12559887 ] Michael McCandless commented on LUCENE-1084: {quote} This kind of limit is com

[jira] Commented: (LUCENE-1136) add ability to not count sub-task doLogic increment to contri/benchmark

2008-01-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559888#action_12559888 ] Michael McCandless commented on LUCENE-1136: It works like a charm! And, all

[jira] Updated: (LUCENE-1136) add ability to not count sub-task doLogic increment to contri/benchmark

2008-01-17 Thread Doron Cohen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doron Cohen updated LUCENE-1136: Attachment: lucene-1136.patch Good catch! This patch fixes that - printing the '-' for tasks with

[jira] Reopened: (LUCENE-1050) SimpleFSLockFactory ignores error on deleting the lock file

2008-01-17 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Ingersoll reopened LUCENE-1050: - Assignee: Grant Ingersoll (was: Michael McCandless) Lucene Fields: (was: [New

[jira] Commented: (LUCENE-1050) SimpleFSLockFactory ignores error on deleting the lock file

2008-01-17 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559908#action_12559908 ] Grant Ingersoll commented on LUCENE-1050: - I agree, it can be fixed by the SpellCh

Back Compatibility

2008-01-17 Thread Grant Ingersoll
I have been thinking for a while that is time we revisit our back- compatibility "policy" (http://wiki.apache.org/lucene-java/BackwardsCompatibility ) in terms of maybe becoming a little leaner and also in terms of addressing some issues that come up from time to time in relation to bug fixes

[jira] Assigned: (LUCENE-1138) SpellChecker.clearIndex calls unlock inappropriately

2008-01-17 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Ingersoll reassigned LUCENE-1138: --- Assignee: Grant Ingersoll > SpellChecker.clearIndex calls unlock inappropriately > -

[jira] Updated: (LUCENE-1050) SimpleFSLockFactory ignores error on deleting the lock file

2008-01-17 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Ingersoll updated LUCENE-1050: Comment: was deleted > SimpleFSLockFactory ignores error on deleting the lock file > -

[jira] Updated: (LUCENE-1050) SimpleFSLockFactory ignores error on deleting the lock file

2008-01-17 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Ingersoll updated LUCENE-1050: Attachment: (was: LUCENE-1050-2.patch) > SimpleFSLockFactory ignores error on deleting

[jira] Updated: (LUCENE-1050) SimpleFSLockFactory ignores error on deleting the lock file

2008-01-17 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Ingersoll updated LUCENE-1050: Attachment: LUCENE-1050-2.patch Patch for SimpleLock > SimpleFSLockFactory ignores error

[jira] Commented: (LUCENE-1050) SimpleFSLockFactory ignores error on deleting the lock file

2008-01-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559919#action_12559919 ] Michael McCandless commented on LUCENE-1050: I agree, we should fix it so that

[jira] Commented: (LUCENE-1050) SimpleFSLockFactory ignores error on deleting the lock file

2008-01-17 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559916#action_12559916 ] Grant Ingersoll commented on LUCENE-1050: - Hmm, it seems putting in lockFile.exist

[jira] Updated: (LUCENE-1138) SpellChecker.clearIndex calls unlock inappropriately

2008-01-17 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Ingersoll updated LUCENE-1138: Attachment: LUCENE-1138.patch Here's the fix for the spellchecker. I confirmed this fixes

[jira] Commented: (LUCENE-1050) SimpleFSLockFactory ignores error on deleting the lock file

2008-01-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559927#action_12559927 ] Michael McCandless commented on LUCENE-1050: {quote} Grant, you just have to c

[jira] Commented: (LUCENE-1138) SpellChecker.clearIndex calls unlock inappropriately

2008-01-17 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559932#action_12559932 ] Grant Ingersoll commented on LUCENE-1138: - I will commit around 12 EST today. > S

[jira] Updated: (LUCENE-1050) SimpleFSLockFactory ignores error on deleting the lock file

2008-01-17 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Ingersoll updated LUCENE-1050: Attachment: LUCENE-1050-2.patch OK, this patch works and passes the test. I will commit t

Going to Java 5. Was: Re: A bit of planning

2008-01-17 Thread DM Smith
On Jan 17, 2008, at 1:38 AM, Chris Hostetter wrote: : If I remember right, the file format changed in 2.1, such that 2.0 could not : read a 2.1 index. that is totally within the bounds of the compatibility statement... http://wiki.apache.org/lucene-java/BackwardsCompatibility Note that ol

Build failed in Hudson: Lucene-Nightly #340

2008-01-17 Thread hudson
See http://lucene.zones.apache.org:8080/hudson/job/Lucene-Nightly/340/changes -- started ERROR: svn: PROPFIND request failed on '/repos/asf/lucene/java/trunk' svn: Connection timed out org.tmatesoft.svn.core.SVNException: svn: PROPFIND request failed on '/r

[jira] Updated: (LUCENE-1084) increase default maxFieldLength?

2008-01-17 Thread Steven Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Rowe updated LUCENE-1084: Lucene Fields: [New, Patch Available] (was: [New]) > increase default maxFieldLength? > -

[jira] Updated: (LUCENE-1084) increase default maxFieldLength?

2008-01-17 Thread Steven Rowe (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Rowe updated LUCENE-1084: Attachment: LUCENE-1084.patch Attaching a patch implementing my suggestion to add an explicit maxi

[jira] Resolved: (LUCENE-1002) Nightly Builds

2008-01-17 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Ingersoll resolved LUCENE-1002. - Resolution: Fixed Lucene Fields: (was: [New]) > Nightly Builds > --

[jira] Resolved: (LUCENE-1138) SpellChecker.clearIndex calls unlock inappropriately

2008-01-17 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Ingersoll resolved LUCENE-1138. - Resolution: Fixed Lucene Fields: (was: [New]) Committed on 612869 and 612868 (b

[jira] Resolved: (LUCENE-1050) SimpleFSLockFactory ignores error on deleting the lock file

2008-01-17 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Ingersoll resolved LUCENE-1050. - Resolution: Fixed Committed on 612869 and 612868 (branch and trunk) > SimpleFSLockFacto

Re: svn commit: r612869 - in /lucene/java/branches/lucene_2_3: contrib/spellchecker/src/java/org/apache/lucene/search/spell/SpellChecker.java src/java/org/apache/lucene/store/SimpleFSLockFactory.java

2008-01-17 Thread Michael Busch
Hi Grant, do you think we need another RC today so that people can test this. Otherwise I'll create a (hopefully) final RC end of tomorrow and call a release vote. -Michael [EMAIL PROTECTED] wrote: > Author: gsingers > Date: Thu Jan 17 09:01:01 2008 > New Revision: 612869 > > URL: http://svn.

Re: svn commit: r612869 - in /lucene/java/branches/lucene_2_3: contrib/spellchecker/src/java/org/apache/lucene/search/spell/SpellChecker.java src/java/org/apache/lucene/store/SimpleFSLockFactory.java

2008-01-17 Thread Grant Ingersoll
Hmmm. The functionality that caused the problem was introduced in 2.3, so 2.2 users would not be aware of it. I'm pretty confident it is right, but... I am definitely fine w/ the SpellChecker change, as it should have been checking isLocked in the first place. The Lock stuff, I will ha

Re: svn commit: r612869 - in /lucene/java/branches/lucene_2_3: contrib/spellchecker/src/java/org/apache/lucene/search/spell/SpellChecker.java src/java/org/apache/lucene/store/SimpleFSLockFactory.java

2008-01-17 Thread Michael Busch
Grant Ingersoll wrote: > > What do others think? > > I think I will say +1 to going ahead w/ the release. > I agree. The patch seems low-risk to me. -Michael - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands

Re: Back Compatibility

2008-01-17 Thread Bill Janssen
> Examples of the former issue include things like removing > deprecations sooner and the ability to add new methods to interfaces > (both of these are not to be done ad-hoc) What would be the difference between ad-hoc and non-ad-hoc? Bill

Re: Back Compatibility

2008-01-17 Thread Grant Ingersoll
On Jan 17, 2008, at 2:42 PM, Bill Janssen wrote: Examples of the former issue include things like removing deprecations sooner and the ability to add new methods to interfaces (both of these are not to be done ad-hoc) What would be the difference between ad-hoc and non-ad-hoc? Maybe bad ch

Re: Back Compatibility

2008-01-17 Thread Doug Cutting
Grant Ingersoll wrote: 1. We add a new section to CHANGES for each release, at the top where we can declare what deprecations will be removed in the _next_ release (major or minor) and also any interface API changes 2. When deprecating, the @deprecate tag should declare what version it will be

Re: Back Compatibility

2008-01-17 Thread Grant Ingersoll
On Jan 17, 2008, at 4:14 PM, Doug Cutting wrote: Grant Ingersoll wrote: 1. We add a new section to CHANGES for each release, at the top where we can declare what deprecations will be removed in the _next_ release (major or minor) and also any interface API changes 2. When deprecating, the

RE: Back Compatibility

2008-01-17 Thread Steven A Rowe
Hi Grant, On 01/17/2008 at 7:51 AM, Grant Ingersoll wrote: > Our minor release cycles are currently in the 3-6 months range > and our major release cycles are in the 1-1.5 year range. Since 2.0.0, including 2.3.0 - assuming it will be released in the next week or so - the minor release intervals

Re: Back Compatibility

2008-01-17 Thread DM Smith
Grant Ingersoll wrote: My reasoning for this solution: Our minor release cycles are currently in the 3-6 months range and our major release cycles are in the 1-1.5 year range. I think giving someone 4-8 (or whatever) months is more than enough time to prepare for API changes. I am not sur

Re: Back Compatibility

2008-01-17 Thread robert engels
If they are " no longer actively developing the portion of the code that's broken, aren't seeking the new feature, etc", and they stay back on old versions... isn't that exactly what we want? They can stay on the old version, and new application development uses the newer version. It woul

Re: Back Compatibility

2008-01-17 Thread DM Smith
On Jan 17, 2008, at 7:57 PM, robert engels wrote: If they are " no longer actively developing the portion of the code that's broken, aren't seeking the new feature, etc", and they stay back on old versions... isn't that exactly what we want? They can stay on the old version, and new applic

Re: Back Compatibility

2008-01-17 Thread Grant Ingersoll
I guess I am suggesting that instead of maintaining the whole major/ minor thing (not including file format) that we relax a bit and say that any give feature we choose to remove or add has to go through two release cycles, which according to your averages, would equal just over 1 year's tim

Re: Back Compatibility

2008-01-17 Thread Grant Ingersoll
On Jan 17, 2008, at 9:30 PM, DM Smith wrote: On Jan 17, 2008, at 7:57 PM, robert engels wrote: If they are " no longer actively developing the portion of the code that's broken, aren't seeking the new feature, etc", and they stay back on old versions... isn't that exactly what we want? Th

Final RC build tomorrow 01/18/08 at 3pm PST

2008-01-17 Thread Michael Busch
Hi Team, great job - there are no severe issues in Jira with "Fix Version" 2.3. As announced I will therefore build another Release Candidate tomorrow (01/18/08) around 3pm PST and call a release vote if no blocking issues will come up by then and if nobody objects. So in case you want to check-i

Re: (another) generate-maven-artifacts build failure

2008-01-17 Thread Michael Busch
Steven A Rowe wrote: > Hi Michael, > > On 01/15/2008 at 10:04 PM, Michael Busch wrote: >> which version of the maven-ant-tasks are you using? > > 2.0.8 > > Steve > Hi Steve, it's a bit weird. I actually just had the same problem with 2.0.8. Then I switched back to 2.0.7 and 'ant generate-mave

Hudson build is back to normal: Lucene-Nightly #341

2008-01-17 Thread hudson
See http://lucene.zones.apache.org:8080/hudson/job/Lucene-Nightly/341/changes - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Back Compatibility

2008-01-17 Thread Karl Wettin
18 jan 2008 kl. 03.39 skrev Grant Ingersoll: Does anyone have experience w/ how other open source projects deal with this? Would be a pain to implement, but it could be done as libcompat. lucene-2.4-compat-core-3.0.jar -- karl -

Re: Back Compatibility

2008-01-17 Thread robert engels
That brings us back to an earlier discussion: "if majority want to break compatibility, then we should do so, and the minority can back- port the changes to a previous release if they feel it is warranted." I don't understand why that isn't a viable approach. I agree that maintaining interfac

Re: Back Compatibility

2008-01-17 Thread Karl Wettin
18 jan 2008 kl. 07.41 skrev robert engels: Look at similar problems and how they handled in the JDK. The Date class has been notorious since its inception. The Calendar class is almost no better, now they are developing JSR-310 to replace both. Existing code can still use the Date or Calen

Re: Back Compatibility

2008-01-17 Thread robert engels
That wasn't what I was thinking. They would use lucene23.jar if they wanted the 2.3 API. Newer code uses the lucene30.jar for the 3.0 API. The others could continue to back-port 3.0 features to 2.3.X if they wished (and could do so without changing the API - private changes only). I thin