RFR: JDK-8242649 : improve the CSS class names used for summary and details tables

2020-04-14 Thread Jonathan Gibbons
Please review a moderately simple change to clean up the CSS class names and other minor details in the Table builder class. Originally, the Table builder "just" built elements.  As part of the work to better support ARIA, it was changed to create a element that encloses the , and (when nece

Re: RFR: 8241982: Make TestSearchScript.java run with GraalJS

2020-04-14 Thread Hannes Wallnoefer
Thanks Jon, I wasn’t aware of jtreg.SkippedException. I pushed the change unmodified and filed a bug for using SkippedException: https://bugs.openjdk.java.net/browse/JDK-8242652 Hannes > Am 14.04.2020 um 18:48 schrieb Jonathan Gibbons : > > L

Re: RFR: 8241982: Make TestSearchScript.java run with GraalJS

2020-04-14 Thread Jonathan Gibbons
Looks good to me. As a minor enhancement, either now or later, note that jtreg recognizes the use of an exception named 'jtreg.SkippedException` such as the one declared here: test/lib/jtreg/SkippedException.java This is used to help indicate when a test was skipped for any reason. -- Jon