> 8267329: Modernize Javadoc code to use instanceof with pattern matching
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Typos
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/4105/files
- new: https://git.open
8267329: Modernize Javadoc code to use instanceof with pattern matching
-
Commit messages:
- Updating javadoc to use instanceof patterns
Changes: https://git.openjdk.java.net/jdk/pull/4105/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4105&range=00
Issue: https://bu
> Please review a trivial fix to avoid creating an unnecessary `BufferedWriter`.
>
> `noreg-trivial` (or `noreg-cleanup` : take your pick). Either way, no test.
Jonathan Gibbons has updated the pull request incrementally with one additional
commit since the last revision:
address review feedb
On Tue, 18 May 2021 11:00:19 GMT, Pavel Rappo wrote:
>> Please review a trivial fix to avoid creating an unnecessary
>> `BufferedWriter`.
>>
>> `noreg-trivial` (or `noreg-cleanup` : take your pick). Either way, no test.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util
On Tue, 18 May 2021 17:57:59 GMT, Pavel Rappo wrote:
> I wonder if we could teach JavaDoc types that model HTML that void elements
> do not require end tags. Before this change, WBR required an end tag despite
> being void:
> https://github.com/jonathan-gibbons/jdk/blob/8a96c703771224990504cd2
On Tue, 18 May 2021 11:39:45 GMT, Pavel Rappo wrote:
> I have two high-level questions: (1) Why would Doclet API expose standard
> streams given that it already has `jdk.javadoc.doclet.Reporter`? (2) Is
> `PrintStream` the most appropriate abstraction for a standard stream? (For
> example, the
On Tue, 18 May 2021 17:36:44 GMT, Vicente Romero wrote:
>> Please review a simple fix to treat `war` as a void element.
>
> test/langtools/tools/doclint/html/HtmlVersionTagsAttrsTest.java line 154:
>
>> 152: *
>> 153: * Test current time is 10:00 at night
>> 154: * Testtext
>
>
On Tue, 18 May 2021 17:15:56 GMT, Jonathan Gibbons wrote:
> Please review a simple fix to treat `war` as a void element.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4098
> Please review the test changes for [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> With JEP 411 and the default value of `-Djava.security.manager` becoming
> `disallow`, tests calling `System.setSecurityManager()` need
> `-Djava.security.manager=allow` when launched. This PR covers such
On Wed, 12 May 2021 12:43:48 GMT, Hannes Wallnöfer wrote:
> This changes the parameter type for the tab label from `String` to `Content`
> in the `formats.html.Table` `addTab` and `setDefaultTab` methods. The change
> is straightforward because the tab name was converted to `Content` anyway,
>
> Please review a change for JavaDoc, for the Standard Doclet to copy legal
> header files into the generated docs from a default or designated directory.
Jonathan Gibbons has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelate
On Tue, 18 May 2021 17:15:56 GMT, Jonathan Gibbons wrote:
> Please review a simple fix to treat `war` as a void element.
I wonder if we could teach JavaDoc types that model HTML that void elements do
not require end tags. Before this change, WBR required an end tag despite being
void:
https:/
On Mon, 17 May 2021 17:51:36 GMT, Weijun Wang wrote:
> Please review the test changes for [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> With JEP 411 and the default value of `-Djava.security.manager` becoming
> `disallow`, tests calling `System.setSecurityManager()` need
> `-Djava.secu
On Tue, 18 May 2021 17:15:56 GMT, Jonathan Gibbons wrote:
> Please review a simple fix to treat `war` as a void element.
test/langtools/tools/doclint/html/HtmlVersionTagsAttrsTest.java line 154:
> 152: *
> 153: * Test current time is 10:00 at night
> 154: * Testtext
this is a p
Please review a simple fix to treat `war` as a void element.
-
Commit messages:
- Merge remote-tracking branch 'upstream/master' into wbr
- JDK-8266856: Make element void
Changes: https://git.openjdk.java.net/jdk/pull/4098/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&
On Tue, 18 May 2021 16:22:56 GMT, liach
wrote:
> For this change, in fact, you can pretty much discard all previous change;
> the current commit is not related to the previous commit contents, as the way
> of approach and the test both got rewritten.
Yet, it is preferable to have preceding co
On Tue, 18 May 2021 13:52:25 GMT, Jonathan Gibbons wrote:
>> liach has refreshed the contents of this pull request, and previous commits
>> have been removed. The incremental views will show differences compared to
>> the previous content of the PR.
>
> As a matter of style, these days we avoid
On Tue, 18 May 2021 15:44:31 GMT, Pavel Rappo wrote:
>
>
> Meta: I would appreciate it if next time you could update your PR normally
> rather than forcefully. Pushing forcefully makes it harder to follow the
> progression of a PR.
For this change, in fact, you can pretty much discard all pr
On Tue, 18 May 2021 15:36:26 GMT, liach
wrote:
>> This change fixes when a method body has only inline tags that produce no
>> output, the method summary will get eaten.
>>
>> This change allows `{@inheritDoc}` from empty parents to go through the code
>> path used by `-nocomment` and properl
> This change fixes when a method body has only inline tags that produce no
> output, the method summary will get eaten.
>
> This change allows `{@inheritDoc}` from empty parents to go through the code
> path used by `-nocomment` and properly generate tables.
>
> All `jtreg:test/langtools/jdk/j
On Tue, 18 May 2021 13:52:25 GMT, Jonathan Gibbons wrote:
>> liach has refreshed the contents of this pull request, and previous commits
>> have been removed. The incremental views will show differences compared to
>> the previous content of the PR.
>
> As a matter of style, these days we avoid
On Mon, 17 May 2021 20:40:18 GMT, Jonathan Gibbons wrote:
>> Please review a change to overhaul the javadoc support for diagnostics to
>> better leverage the support available in javac. This includes the ability
>> for all javadoc diagnostics to show a "source line and caret" to indicate
>> th
On Mon, 17 May 2021 17:39:19 GMT, liach
wrote:
>> This change fixes when a method body has only inline tags that produce no
>> output, the method summary will get eaten.
>>
>> This change allows `{@inheritDoc}` from empty parents to go through the code
>> path used by `-nocomment` and properl
On Tue, 18 May 2021 05:48:56 GMT, Alan Bateman wrote:
> The changes look okay but a bit inconsistent on where -Djava...=allow is
> inserted for tests that already set other system properties or other
> parameters. Not a correctness issue, just looks odd in several places, e.g.
>
> test/jdk/jav
On Tue, 18 May 2021 11:12:00 GMT, Daniel Fuchs wrote:
>> Please review the test changes for [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> With JEP 411 and the default value of `-Djava.security.manager` becoming
>> `disallow`, tests calling `System.setSecurityManager()` need
>> `-Dja
On Mon, 17 May 2021 17:39:19 GMT, liach
wrote:
>> This change fixes when a method body has only inline tags that produce no
>> output, the method summary will get eaten.
>>
>> This change allows `{@inheritDoc}` from empty parents to go through the code
>> path used by `-nocomment` and properl
On Mon, 17 May 2021 17:39:19 GMT, liach
wrote:
>> This change fixes when a method body has only inline tags that produce no
>> output, the method summary will get eaten.
>>
>> This change allows `{@inheritDoc}` from empty parents to go through the code
>> path used by `-nocomment` and properl
On Tue, 18 May 2021 00:38:40 GMT, Jonathan Gibbons wrote:
> Please review a relatively simple update to expose the 1 or 2 streams
> available within javadoc for writing expected or diagnostic output.
>
> The change at this time is just to _expose_ the streams; followup work may
> change how we
On Mon, 17 May 2021 17:51:36 GMT, Weijun Wang wrote:
> Please review the test changes for [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> With JEP 411 and the default value of `-Djava.security.manager` becoming
> `disallow`, tests calling `System.setSecurityManager()` need
> `-Djava.secu
On Tue, 18 May 2021 04:33:52 GMT, Jonathan Gibbons wrote:
> Please review a trivial fix to avoid creating an unnecessary `BufferedWriter`.
>
> `noreg-trivial` (or `noreg-cleanup` : take your pick). Either way, no test.
Changes requested by prappo (Reviewer).
src/jdk.javadoc/share/classes/jdk/j
On Tue, 18 May 2021 01:42:57 GMT, liach
wrote:
> if an empty content stays empty, it's handled like htmltree.empty in a
> special case (just like what happens to nocomment) and included in table
> output. if it's wrapped in a div class=block, the check will not be triggered
> as it's not empt
> This is a preview of a patch implementing JEP 406: Pattern Matching for
> switch (Preview):
> https://bugs.openjdk.java.net/browse/JDK-8213076
>
> The current draft of the specification is here:
> http://cr.openjdk.java.net/~gbierman/jep406/jep406-20210430/specs/patterns-switch-jls.html
>
> A
On Tue, 18 May 2021 06:56:51 GMT, Hannes Wallnöfer wrote:
> Yes, you can look at it both ways, either there is a closing parenthesis
> where it shouldn't be, or there is text following a correctly placed closing
> parenthesis. We tend to see one or the other depending on whether the text up
>
On Tue, 18 May 2021 06:56:51 GMT, Hannes Wallnöfer wrote:
> I still like the more specific message. We can use a more generic "unexpected
> text" message, but I think it is less useful.
Maybe something like "unexpected text after parenthesis"?
-
PR: https://git.openjdk.java.net/jd
On Mon, 17 May 2021 16:54:07 GMT, Hannes Wallnöfer wrote:
> The primary problem was that key `compiler.err.dc.ref.bad.parens` had the
> wrong message "')' missing in reference". That error message is not used when
> the right parenthesis is missing, but when it occurs before the end of the
> s
35 matches
Mail list logo
