Re: RFR: JDK-8269401: Merge "Exceptions" and "Errors" into "Exception Classes" [v2]

2021-10-25 Thread Jonathan Gibbons
On Thu, 21 Oct 2021 12:30:42 GMT, Hannes Wallnöfer wrote: >> This is a conceptually simple change to merge the "Exception" and "Error" >> classes into a single "Exception Class" group. >> >> The only change that is not strictly related to the merge is the removal of >> unused type subsets and

Re: RFR: JDK-8269401: Merge "Exceptions" and "Errors" into "Exception Classes" [v2]

2021-10-25 Thread Jonathan Gibbons
On Thu, 21 Oct 2021 11:38:12 GMT, Hannes Wallnöfer wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java >> line 518: >> >>> 516: } >>> 517: return typeUtils.isSubtype(te.asType(), getExceptionType()) >>> 518: || typeUtils.isSub

Re: RFR: JDK-8269401: Merge "Exceptions" and "Errors" into "Exception Classes" [v2]

2021-10-25 Thread Jonathan Gibbons
On Tue, 26 Oct 2021 00:05:03 GMT, Jonathan Gibbons wrote: >> Interesting: We have property `doclet.Annotation_Types` (with underscore) >> defined in `standard.properties` and `doclet.AnnotationTypes` (without >> underscore) in `doclets.properties. Both properties have the same value. >> Smells

Re: RFR: JDK-8269401: Merge "Exceptions" and "Errors" into "Exception Classes" [v2]

2021-10-25 Thread Jonathan Gibbons
On Thu, 21 Oct 2021 13:06:47 GMT, Hannes Wallnöfer wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SummaryListWriter.java >> line 66: >> >>> 64: case ENUM -> "doclet.Enums"; >>> 65: case EXCEPTION_CLASS -> "doclet.ExceptionClasses"; >>>

JEP 413 Questions

2021-10-25 Thread Gunnar Morling
Hi all, Over the weekend, I've been playing a bit with JEP 413, and the first impression is really great! Thanks a lot for improving the tooling here. I've written a quick blog post about this, which you can find at [1]. Based on that, I've had a few questions about things which were not quite cle

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows [v4]

2021-10-25 Thread Ichiroh Takiguchi
On Mon, 25 Oct 2021 14:20:52 GMT, Ichiroh Takiguchi wrote: >> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13. >> After JDK18-b13, javac and some other langtool command's usage were garbled >> on Japanese Windows. >> These commands use PrintWriter instead of standard out/err with PrintStream

Re: RFR: 8274544: Langtools command's usage were garbled on Japanese Windows [v4]

2021-10-25 Thread Ichiroh Takiguchi
> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13. > After JDK18-b13, javac and some other langtool command's usage were garbled > on Japanese Windows. > These commands use PrintWriter instead of standard out/err with PrintStream. Ichiroh Takiguchi has updated the pull request with a new targe