Re: RFR: JDK-8286101: Support formatting in @value tag [v3]

2022-05-17 Thread Jonathan Gibbons
> This PR is for an update to the doc comment `{@value}` tag to permit an > optional [format > string](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Formatter.html#syntax) > after the name of the tag. > > {@value optional-format-string optional-reference} > > If

Re: RFR: JDK-8286101: Support formatting in @value tag [v2]

2022-05-17 Thread Jonathan Gibbons
On Mon, 16 May 2022 09:57:14 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request incrementally with one >> additional commit since the last revision: >> >> address review feedback > > src/jdk.compiler/share/classes/com/sun/source/doctree/ValueTree.java line 55: > >> 53:

Re: RFR: JDK-8286101: Support formatting in @value tag [v2]

2022-05-17 Thread Jonathan Gibbons
> This PR is for an update to the doc comment `{@value}` tag to permit an > optional [format > string](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Formatter.html#syntax) > after the name of the tag. > > {@value optional-format-string optional-reference} > > If

Re: RFR: JDK-8286101: Support formatting in @value tag

2022-05-17 Thread Jonathan Gibbons
On Mon, 16 May 2022 10:07:18 GMT, Pavel Rappo wrote: > So far the idea looks okay. My feedback is purely on its implementation. > > I'm concerned about backward compatibility. If we believe that it is unlikely > that javadoc can be configured to use a custom implentation of >

Re: RFR: JDK-8286101: Support formatting in @value tag

2022-05-17 Thread Pavel Rappo
On Thu, 5 May 2022 23:39:46 GMT, Jonathan Gibbons wrote: > This PR is for an update to the doc comment `{@value}` tag to permit an > optional [format > string](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Formatter.html#syntax) > after the name of the tag. > >

RFR: JDK-8286101: Support formatting in @value tag

2022-05-17 Thread Jonathan Gibbons
This PR is for an update to the doc comment `{@value}` tag to permit an optional [format string](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Formatter.html#syntax) after the name of the tag. {@value optional-format-string optional-reference} If given, the format

Integrated: JDK-8286338: suppress warnings about bad @author tags when author info is not generated.

2022-05-17 Thread Jonathan Gibbons
On Fri, 6 May 2022 22:06:17 GMT, Jonathan Gibbons wrote: > Please review a simple small change to `TagletManager`, to not report > warnings about bad use of tags (such as `@author` and `@version`) when > command-line options have not been given to enable the use of the tags in the > output

RFR: JDK-8286887: Remove logging from search.js

2022-05-17 Thread Hannes Wallnöfer
This is a trivial change to remove a logging statement in search.js that sneaked in with JDK-8248863. - Commit messages: - JDK-8286887: Remove logging from search.js Changes: https://git.openjdk.java.net/jdk/pull/8752/files Webrev:

RFR: JDK-8286832: JavaDoc pages call browser history API too often

2022-05-17 Thread Hannes Wallnöfer
This is a small but important fix in our browser script that ensures that the `history.replaceState()` function is not called repeatedly during scrolling. The existing code makes sure the function is called no more often then every 100 milliseconds, but that is still unnecessarily often and

Integrated: JDK-8268335: Find better way to exclude empty HTML elements

2022-05-17 Thread Hannes Wallnöfer
On Thu, 20 Jan 2022 15:26:21 GMT, Hannes Wallnöfer wrote: > Please review a change to straighten out the mechanism to avoid generating > empty HTML elements in javadoc. > > Currently this is implemented using the `Content.isValid()` method in > `HtmlTree.add(Content)` to check whether the

Re: RFR: JDK-8268335: Find better way to exclude empty HTML elements [v8]

2022-05-17 Thread Hannes Wallnöfer
> Please review a change to straighten out the mechanism to avoid generating > empty HTML elements in javadoc. > > Currently this is implemented using the `Content.isValid()` method in > `HtmlTree.add(Content)` to check whether the the content argument should be > added or dropped. This seems

Integrated: JDK-8284367: JQuery UI upgrade from 1.12.1 to 1.13.1

2022-05-17 Thread Hannes Wallnöfer
On Fri, 13 May 2022 13:49:21 GMT, Hannes Wallnöfer wrote: > This updates jQuery UI (which is used for the javadoc in-age search feature) > to version 1.13.1. > > Rendered documentation is available here: > http://cr.openjdk.java.net/~hannesw/8284367/api.00/ > > I noticed that we are carrying

Re: RFR: JDK-8268422: Find a better way to select releases in "New API" page

2022-05-17 Thread Hannes Wallnöfer
On Tue, 17 May 2022 03:19:39 GMT, Jonathan Gibbons wrote: >> This is a conceptually simple change, but it has a few ramifications that >> make it at least look a bit bigger than it is. >> >> At the core, this adds a new method to the `Table` class that allows to >> generate tables with