Re: RFR: 8241982: Make TestSearchScript.java run with GraalJS

Thanks Jon, I wasn’t aware of jtreg.SkippedException. I pushed the change unmodified and filed a bug for using SkippedException: https://bugs.openjdk.java.net/browse/JDK-8242652 Hannes > Am 14.04.2020 um 18:48 schrieb Jonathan Gibbons : > > L

Re: RFR: 8241982: Make TestSearchScript.java run with GraalJS

Looks good to me. As a minor enhancement, either now or later, note that jtreg recognizes the use of an exception named 'jtreg.SkippedException` such as the one declared here: test/lib/jtreg/SkippedException.java This is used to help indicate when a test was skipped for any reason. -- Jon

Re: RFR: 8241982: Make TestSearchScript.java run with GraalJS

Looks good to me. -Sundar On 02/04/20 8:27 pm, Hannes Wallnoefer wrote: Please review: JBS: https://bugs.openjdk.java.net/browse/JDK-8241982 Webrev: http://cr.openjdk.java.net/~hannesw/8241982/webrev.00/ This makes TestSearchScript.java run with GraalJS in addition to Nashorn, and potentiall

RFR: 8241982: Make TestSearchScript.java run with GraalJS

Please review: JBS: https://bugs.openjdk.java.net/browse/JDK-8241982 Webrev: http://cr.openjdk.java.net/~hannesw/8241982/webrev.00/ This makes TestSearchScript.java run with GraalJS in ad