Re: RFR: 241518: Member signature parameter span contains closing but not opening parens

Thanks, Pavel! > Am 29.07.2020 um 16:42 schrieb Pavel Rappo : > > Thanks for doing this. > > It seems possible for an empty list of parameters "()" to be of one style, > while a non-empty list to be of another: AbstractMemberWriter.java:689:694 That empty parameters are not wrapped in a parame

RFR: 8250779: Anchor is ignored when reloading a page in Chrome

Please review: JBS: https://bugs.openjdk.java.net/browse/JDK-8250779 Webrev: http://cr.openjdk.java.net/~hannesw/8250779/webrev.00/ The fix consists in not calling history.replaceState at the end of the patch when the current URL has a fragment identifier. The rest of the patch consists in co

Re: RFR: 241518: Member signature parameter span contains closing but not opening parens

Hannes, Differences between HTML representations of "()" and "(...)" are an inconsistency. I agree that it's a separate issue and I think we should fix it. On a related note, it's impressive to see how a trivial change like that ripples through the tests that use string comparison. Although str

Re: RFR: 8250779: Anchor is ignored when reloading a page in Chrome

Hannes, I verified that your links worked on macOS versions of Chrome, Firefox, and Edge. Looks good to me. -Pavel > On 30 Jul 2020, at 12:07, Hannes Wallnoefer > wrote: > > Please review: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8250779 > Webrev: http://cr.openjdk.java.net/~hann