On Wed, 1 Jun 2022 05:20:22 GMT, Jonathan Gibbons wrote:
> Please review a trivial fix to remove unnecessary hyphens from compound words
> in comments,
> as suggested in an earlier review.
Looks okay; thanks.
This PR changes hyphenated forms to closed forms. Consider also changing open
forms
On Thu, 2 Jun 2022 14:43:20 GMT, Pavel Rappo wrote:
>> Please review a trivial fix to remove unnecessary hyphens from compound
>> words in comments,
>> as suggested in an earlier review.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/AbstractMemberBuilder.java
>
On Wed, 1 Jun 2022 05:20:22 GMT, Jonathan Gibbons wrote:
> Please review a trivial fix to remove unnecessary hyphens from compound words
> in comments,
> as suggested in an earlier review.
This pull request has now been integrated.
Changeset: c78392db
Author:Jonathan Gibbons
URL:
h
On Tue, 31 May 2022 23:43:34 GMT, Jonathan Gibbons wrote:
>> Please review a simple change for `SnippetUtils` to throw a checked
>> exception if a snippet cannot be found.
>
> Jonathan Gibbons has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webr
Please review a moderate change to enable (most) doclet warnings even if
doclint is enabled.
Since the introduction of doclint, there was some (small) overlap between the
small set of warnings generated by the doclet and the new larger set of
diagnostics that could be generated by doclint. The
On Thu, 2 Jun 2022 20:59:26 GMT, Jonathan Gibbons wrote:
> Please review a moderate change to enable (most) doclet warnings even if
> doclint is enabled.
>
> Since the introduction of doclint, there was some (small) overlap between the
> small set of warnings generated by the doclet and the ne
This is a spelling and terminology PR, not a code PR. Rationale for some of the
changes are as follows:
* "Subsignature" is mentioned in JLS 8.4.2 Method Signature.
* lower- and upper- bounded wrt `super` and `extends` are mentioned in JLS
4.10.5 Type Projections.
* For "super super class" I use
On Wed, 25 May 2022 19:38:13 GMT, Jonathan Gibbons wrote:
> Please review a simple change for `SnippetUtils` to throw a checked exception
> if a snippet cannot be found.
This pull request has now been integrated.
Changeset: deb06539
Author:Jonathan Gibbons
URL:
https://git.openjdk.
