Re: RFR: JDK-8316972: Add javadoc support for restricted methods [v4]

2024-02-05 Thread Hannes Wallnöfer
On Mon, 5 Feb 2024 02:11:56 GMT, Luca Kellermann wrote: >> This change seems to result in a wrong `sealed` modifier being added to all >> restricted methods >> ([example](https://cr.openjdk.org/~hannesw/8316972/api.00/java.base/java/lang/foreign/AddressLayout.html#withTargetLayout(java.lang.for

Re: RFR: JDK-8316972: Add javadoc support for restricted methods [v4]

2024-02-04 Thread Luca Kellermann
On Sun, 4 Feb 2024 23:10:11 GMT, Luca Kellermann wrote: > My guess to why this is happening is that `com.sun.tools.javac.code.Flags` > has the same value for both `SEALED` and `RESTRICTED`. If this is the reason, then https://github.com/openjdk/jdk/pull/15964 is probably the real cause. `Flags

Re: RFR: JDK-8316972: Add javadoc support for restricted methods [v4]

2024-02-04 Thread Luca Kellermann
On Tue, 17 Oct 2023 09:35:59 GMT, Hannes Wallnöfer wrote: >> Please review a change to add support for restricted methods to JavaDoc. The >> bulk of this patch was contributed by @mcimadamore. It adds a warning note >> to the summary and details of restricted methods and a superscript to links

Re: RFR: JDK-8316972: Add javadoc support for restricted methods [v4]

2023-10-18 Thread Hannes Wallnöfer
On Tue, 17 Oct 2023 09:32:33 GMT, Hannes Wallnöfer wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WorkArounds.java >> line 432: >> >>> 430: } >>> 431: >>> 432: public boolean isRestrictedAPI(Element el) { >> >> It would be good to file a JBS issue, reques

Re: RFR: JDK-8316972: Add javadoc support for restricted methods [v4]

2023-10-17 Thread Jonathan Gibbons
On Tue, 17 Oct 2023 09:35:59 GMT, Hannes Wallnöfer wrote: >> Please review a change to add support for restricted methods to JavaDoc. The >> bulk of this patch was contributed by @mcimadamore. It adds a warning note >> to the summary and details of restricted methods and a superscript to links

Re: RFR: JDK-8316972: Add javadoc support for restricted methods [v4]

2023-10-17 Thread Hannes Wallnöfer
On Tue, 17 Oct 2023 09:35:59 GMT, Hannes Wallnöfer wrote: >> Please review a change to add support for restricted methods to JavaDoc. The >> bulk of this patch was contributed by @mcimadamore. It adds a warning note >> to the summary and details of restricted methods and a superscript to links

Re: RFR: JDK-8316972: Add javadoc support for restricted methods

2023-10-17 Thread Hannes Wallnöfer
On Mon, 16 Oct 2023 13:26:36 GMT, Maurizio Cimadamore wrote: > Question: we have this section on restricted method in the java/lang/foreign > javadoc: > https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/foreign/package-summary.html#restricted > > Should the text that java

Re: RFR: JDK-8316972: Add javadoc support for restricted methods [v4]

2023-10-17 Thread Hannes Wallnöfer
On Mon, 16 Oct 2023 22:51:26 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Rename local variable > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WorkArounds.java >

Re: RFR: JDK-8316972: Add javadoc support for restricted methods [v4]

2023-10-17 Thread Hannes Wallnöfer
> Please review a change to add support for restricted methods to JavaDoc. The > bulk of this patch was contributed by @mcimadamore. It adds a warning note to > the summary and details of restricted methods and a superscript to links to > restricted methods, similar to what we already do with el

Re: RFR: JDK-8316972: Add javadoc support for restricted methods [v3]

2023-10-17 Thread Hannes Wallnöfer
> Please review a change to add support for restricted methods to JavaDoc. The > bulk of this patch was contributed by @mcimadamore. It adds a warning note to > the summary and details of restricted methods and a superscript to links to > restricted methods, similar to what we already do with el

Re: RFR: JDK-8316972: Add javadoc support for restricted methods [v2]

2023-10-17 Thread Hannes Wallnöfer
> Please review a change to add support for restricted methods to JavaDoc. The > bulk of this patch was contributed by @mcimadamore. It adds a warning note to > the summary and details of restricted methods and a superscript to links to > restricted methods, similar to what we already do with el

Re: RFR: JDK-8316972: Add javadoc support for restricted methods

2023-10-16 Thread Jonathan Gibbons
On Fri, 13 Oct 2023 16:21:48 GMT, Hannes Wallnöfer wrote: > Please review a change to add support for restricted methods to JavaDoc. The > bulk of this patch was contributed by @mcimadamore. It adds a warning note to > the summary and details of restricted methods and a superscript to links to

Re: RFR: JDK-8316972: Add javadoc support for restricted methods

2023-10-16 Thread Maurizio Cimadamore
On Fri, 13 Oct 2023 16:21:48 GMT, Hannes Wallnöfer wrote: > Please review a change to add support for restricted methods to JavaDoc. The > bulk of this patch was contributed by @mcimadamore. It adds a warning note to > the summary and details of restricted methods and a superscript to links to

Re: RFR: JDK-8316972: Add javadoc support for restricted methods

2023-10-16 Thread Maurizio Cimadamore
On Fri, 13 Oct 2023 16:21:48 GMT, Hannes Wallnöfer wrote: > Please review a change to add support for restricted methods to JavaDoc. The > bulk of this patch was contributed by @mcimadamore. It adds a warning note to > the summary and details of restricted methods and a superscript to links to

Re: RFR: JDK-8316972: Add javadoc support for restricted methods

2023-10-13 Thread Hannes Wallnöfer
On Fri, 13 Oct 2023 17:27:01 GMT, Maurizio Cimadamore wrote: >> Please review a change to add support for restricted methods to JavaDoc. The >> bulk of this patch was contributed by @mcimadamore. It adds a warning note >> to the summary and details of restricted methods and a superscript to li

Re: RFR: JDK-8316972: Add javadoc support for restricted methods

2023-10-13 Thread Maurizio Cimadamore
On Fri, 13 Oct 2023 16:21:48 GMT, Hannes Wallnöfer wrote: > Please review a change to add support for restricted methods to JavaDoc. The > bulk of this patch was contributed by @mcimadamore. It adds a warning note to > the summary and details of restricted methods and a superscript to links to

RFR: JDK-8316972: Add javadoc support for restricted methods

2023-10-13 Thread Hannes Wallnöfer
Please review a change to add support for restricted methods to JavaDoc. The bulk of this patch was contributed by @mcimadamore. It adds a warning note to the summary and details of restricted methods and a superscript to links to restricted methods, similar to what we already do with elements b