Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v9]

2024-08-02 Thread Hannes Wallnöfer
On Fri, 2 Aug 2024 17:26:48 GMT, Jonathan Gibbons wrote: >> Please review a change to reorganize the internal low-level support for HTML >> in the jdk.javadoc module. >> >> Hitherto, there are two separate sets of classes for low-level support for >> HTML in the `jdk.javadoc` module: one, in d

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v9]

2024-08-02 Thread Jonathan Gibbons
> Please review a change to reorganize the internal low-level support for HTML > in the jdk.javadoc module. > > Hitherto, there are two separate sets of classes for low-level support for > HTML in the `jdk.javadoc` module: one, in doclint, focused on reading and > checking classes, the other, i

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v8]

2024-08-01 Thread Jonathan Gibbons
> Please review a change to reorganize the internal low-level support for HTML > in the jdk.javadoc module. > > Hitherto, there are two separate sets of classes for low-level support for > HTML in the `jdk.javadoc` module: one, in doclint, focused on reading and > checking classes, the other, i

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v7]

2024-08-01 Thread Jonathan Gibbons
On Thu, 1 Aug 2024 11:53:29 GMT, Hannes Wallnöfer wrote: >> Jonathan Gibbons has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 12 commits: >> >> - Merge with upstream master; >>add reference in HtmlTag to a related RFE >> - Up

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v7]

2024-08-01 Thread Hannes Wallnöfer
On Wed, 31 Jul 2024 18:00:11 GMT, Jonathan Gibbons wrote: >> Please review a change to reorganize the internal low-level support for HTML >> in the jdk.javadoc module. >> >> Hitherto, there are two separate sets of classes for low-level support for >> HTML in the `jdk.javadoc` module: one, in

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v7]

2024-07-31 Thread Jonathan Gibbons
> Please review a change to reorganize the internal low-level support for HTML > in the jdk.javadoc module. > > Hitherto, there are two separate sets of classes for low-level support for > HTML in the `jdk.javadoc` module: one, in doclint, focused on reading and > checking classes, the other, i

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v6]

2024-07-30 Thread Jonathan Gibbons
> Please review a change to reorganize the internal low-level support for HTML > in the jdk.javadoc module. > > Hitherto, there are two separate sets of classes for low-level support for > HTML in the `jdk.javadoc` module: one, in doclint, focused on reading and > checking classes, the other, i

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v4]

2024-07-30 Thread Jonathan Gibbons
On Tue, 30 Jul 2024 18:02:32 GMT, Jonathan Gibbons wrote: >> I'll look to upgrade these. In the original impl of DocLint, it was >> something of a conscious decision to avoid supporting input elements. >> >> I'm surprised LINK is phrasing content: I thought it could only appear in >> HEAD elem

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v4]

2024-07-30 Thread Jonathan Gibbons
On Tue, 30 Jul 2024 17:50:43 GMT, Jonathan Gibbons wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/html/HtmlTag.java line 87: >> >>> 85: attrs(AttrKind.HTML4, CLEAR)), >>> 86: >>> 87: BUTTON(BlockType.OTHER, EndKind.REQUIRED, >> >> Several tag constants that use `B

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v5]

2024-07-30 Thread Jonathan Gibbons
> Please review a change to reorganize the internal low-level support for HTML > in the jdk.javadoc module. > > Hitherto, there are two separate sets of classes for low-level support for > HTML in the `jdk.javadoc` module: one, in doclint, focused on reading and > checking classes, the other, i

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v4]

2024-07-30 Thread Jonathan Gibbons
On Fri, 26 Jul 2024 10:52:22 GMT, Hannes Wallnöfer wrote: >> Jonathan Gibbons has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Cleanup use of HtmlStyle and HtmlStyles > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/html/HtmlTag.jav

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v4]

2024-07-26 Thread Hannes Wallnöfer
On Wed, 24 Jul 2024 22:09:46 GMT, Jonathan Gibbons wrote: >> Please review a change to reorganize the internal low-level support for HTML >> in the jdk.javadoc module. >> >> Hitherto, there are two separate sets of classes for low-level support for >> HTML in the `jdk.javadoc` module: one, in

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v4]

2024-07-25 Thread Hannes Wallnöfer
On Wed, 24 Jul 2024 22:09:46 GMT, Jonathan Gibbons wrote: >> Please review a change to reorganize the internal low-level support for HTML >> in the jdk.javadoc module. >> >> Hitherto, there are two separate sets of classes for low-level support for >> HTML in the `jdk.javadoc` module: one, in

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v4]

2024-07-25 Thread Hannes Wallnöfer
On Wed, 24 Jul 2024 22:09:46 GMT, Jonathan Gibbons wrote: >> Please review a change to reorganize the internal low-level support for HTML >> in the jdk.javadoc module. >> >> Hitherto, there are two separate sets of classes for low-level support for >> HTML in the `jdk.javadoc` module: one, in

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v4]

2024-07-24 Thread Jonathan Gibbons
> Please review a change to reorganize the internal low-level support for HTML > in the jdk.javadoc module. > > Hitherto, there are two separate sets of classes for low-level support for > HTML in the `jdk.javadoc` module: one, in doclint, focused on reading and > checking classes, the other, i

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v3]

2024-07-24 Thread Jonathan Gibbons
> Please review a change to reorganize the internal low-level support for HTML > in the jdk.javadoc module. > > Hitherto, there are two separate sets of classes for low-level support for > HTML in the `jdk.javadoc` module: one, in doclint, focused on reading and > checking classes, the other, i

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v2]

2024-07-09 Thread Andrey Turbanov
On Mon, 8 Jul 2024 19:18:21 GMT, Jonathan Gibbons wrote: >> Please review a change to reorganize the internal low-level support for HTML >> in the jdk.javadoc module. >> >> Hitherto, there are two separate sets of classes for low-level support for >> HTML in the `jdk.javadoc` module: one, in d

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v2]

2024-07-08 Thread Jonathan Gibbons
> Please review a change to reorganize the internal low-level support for HTML > in the jdk.javadoc module. > > Hitherto, there are two separate sets of classes for low-level support for > HTML in the `jdk.javadoc` module: one, in doclint, focused on reading and > checking classes, the other, i

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc

2024-07-08 Thread Jonathan Gibbons
On Fri, 28 Jun 2024 13:36:47 GMT, Hannes Wallnöfer wrote: > I'm not sure if this is intentional (it makes changes easier to review), but > I notice that imports of classes in the new package are generally mixed with > classes remaining in the old package, and therefore not in alphabetic order.

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc

2024-07-08 Thread Hannes Wallnöfer
On Wed, 26 Jun 2024 23:00:27 GMT, Jonathan Gibbons wrote: > Please review a change to reorganize the internal low-level support for HTML > in the jdk.javadoc module. > > Hitherto, there are two separate sets of classes for low-level support for > HTML in the `jdk.javadoc` module: one, in docli