Re: RFR: 8308753: Class-File API transition to Preview [v13]

2023-10-04 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v14]

2023-10-04 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8306980: Generated docs should contain correct GPLv2 Legal Documents [v6]

2023-10-04 Thread Mandy Chung
On Tue, 20 Jun 2023 05:07:34 GMT, KIRIYAMA Takuya wrote: >> I modified the location from which javadoc copies some legal files to the >> generated documentation. If --legal-notices option is set to default or >> nothing is specified,, GPLv2 Legal Documents are copied from >> legal/java.base/

Re: RFR: 8308753: Class-File API transition to Preview [v14]

2023-10-04 Thread Mandy Chung
On Wed, 4 Oct 2023 09:30:16 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v14]

2023-10-04 Thread Vicente Romero
On Wed, 4 Oct 2023 09:30:16 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8306980: Generated docs should contain correct GPLv2 Legal Documents [v6]

2023-10-04 Thread Jaikiran Pai
On Tue, 20 Jun 2023 05:07:34 GMT, KIRIYAMA Takuya wrote: >> I modified the location from which javadoc copies some legal files to the >> generated documentation. If --legal-notices option is set to default or >> nothing is specified,, GPLv2 Legal Documents are copied from >> legal/java.base/

Re: RFR: 8306980: Generated docs should contain correct GPLv2 Legal Documents [v6]

2023-10-04 Thread Mandy Chung
On Tue, 20 Jun 2023 05:07:34 GMT, KIRIYAMA Takuya wrote: >> I modified the location from which javadoc copies some legal files to the >> generated documentation. If --legal-notices option is set to default or >> nothing is specified,, GPLv2 Legal Documents are copied from >> legal/java.base/

Re: RFR: 8306980: Generated docs should contain correct GPLv2 Legal Documents [v6]

2023-10-04 Thread Jaikiran Pai
On Tue, 20 Jun 2023 05:07:34 GMT, KIRIYAMA Takuya wrote: >> I modified the location from which javadoc copies some legal files to the >> generated documentation. If --legal-notices option is set to default or >> nothing is specified,, GPLv2 Legal Documents are copied from >> legal/java.base/

Re: RFR: 8308753: Class-File API transition to Preview [v14]

2023-10-04 Thread Adam Sotona
On Wed, 4 Oct 2023 09:30:16 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a