Re: RFR: 8336754: Remodel TypeAnnotation to "has" instead of "be" an Annotation [v8]

2024-08-02 Thread Adam Sotona
On Fri, 2 Aug 2024 00:04:48 GMT, Chen Liang wrote: >> `TypeAnnotation` is not an annotation, as it should not be used in places >> like `AnnotationValue.ofAnnotation`. Thus it's remodeled to contain an >> annotation at a given location instead of to be an annotation. >> >> Depends on #20205. >

Re: RFR: 8336754: Remodel TypeAnnotation to "has" instead of "be" an Annotation [v8]

2024-08-02 Thread Alex Buckley
In the annotation `@Foo(a=1)`, the left hand side `a` is an _element_ (as declared in the annotation interface Foo) and the right hand side `1` is an _element value_ (per the first line of JLS 9.7.1). Syntactically the `a` is an identifier but that's almost never relevant what discussing eleme

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v9]

2024-08-02 Thread Jonathan Gibbons
> Please review a change to reorganize the internal low-level support for HTML > in the jdk.javadoc module. > > Hitherto, there are two separate sets of classes for low-level support for > HTML in the `jdk.javadoc` module: one, in doclint, focused on reading and > checking classes, the other, i

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v9]

2024-08-02 Thread Hannes Wallnöfer
On Fri, 2 Aug 2024 17:26:48 GMT, Jonathan Gibbons wrote: >> Please review a change to reorganize the internal low-level support for HTML >> in the jdk.javadoc module. >> >> Hitherto, there are two separate sets of classes for low-level support for >> HTML in the `jdk.javadoc` module: one, in d

Re: [External] : Re: Missing element-list for https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec

2024-08-02 Thread Osipov, Michael (IN IT IN)
On 2024-06-07 01:11, Jonathan Gibbons wrote: On 6/5/24 2:51 AM, Osipov, Michael wrote: On 2024-05-31 21:38, Jonathan Gibbons wrote: Michael, There is no `element-list` file for any version of JDK before JDK 9. Before JDK 9, the appropriate information was in the `package-list` file. In JDK 9,

Re: RFR: 8336754: Remodel TypeAnnotation to "has" instead of "be" an Annotation [v8]

2024-08-02 Thread Chen Liang
One specification question for Alex: we call an annotation interface's element "element". What about the element-value pair that binds a value to an interface element in an annotation? Can we call this element-value pair an "element", or is there any other more proper name that is still concise?

Integrated: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc

2024-08-02 Thread Jonathan Gibbons
On Wed, 26 Jun 2024 23:00:27 GMT, Jonathan Gibbons wrote: > Please review a change to reorganize the internal low-level support for HTML > in the jdk.javadoc module. > > Hitherto, there are two separate sets of classes for low-level support for > HTML in the `jdk.javadoc` module: one, in docli

RFR: 8337054: JDK 23 RDP2 L10n resource files update

2024-08-02 Thread Damon Nguyen
Clean forward-port from JDK23 of RDP2 L10N. - Commit messages: - Clean forwardport Changes: https://git.openjdk.org/jdk/pull/20444/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20444&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337054 Stats: 28 lines in 7 file

Re: RFR: 8337054: JDK 23 RDP2 L10n resource files update

2024-08-02 Thread Naoto Sato
On Fri, 2 Aug 2024 18:20:40 GMT, Damon Nguyen wrote: > Forwardport for JDK-8337054 from JDK23 of RDP2 L10N, fix applied cleanly. > > Forward-porting to add translated files from JDK23 RDP2 into mainline and > prevent re-translating these files in the next L10N drop. Marked as reviewed by naoto

Re: RFR: 8337054: JDK 23 RDP2 L10n resource files update

2024-08-02 Thread Justin Lu
On Fri, 2 Aug 2024 18:20:40 GMT, Damon Nguyen wrote: > Forwardport for JDK-8337054 from JDK23 of RDP2 L10N, fix applied cleanly. > > Forward-porting to add translated files from JDK23 RDP2 into mainline and > prevent re-translating these files in the next L10N drop. Marked as reviewed by jlu (