Re: [JBoss-dev] sources for hsqldb (LEAK FOUND)

2002-09-25 Thread viktor
onsdagen den 25 september 2002 kl 23.02 skrev Jason Dillon: > Do we still need the hacked version with the latest release of HSQLDB? > If not lets drop the hacked version and just integrate what they > release. > > If not, then lets get a fix into the HSQLDB sources so they are more > embeddable

RE: [JBoss-dev] sources for hsqldb (LEAK FOUND)

2002-09-25 Thread Jason Dillon
TECTED] [mailto:jboss- > [EMAIL PROTECTED]] On Behalf Of Michael Bartmann > Sent: Wednesday, September 25, 2002 1:18 PM > To: [EMAIL PROTECTED] > Subject: Re: [JBoss-dev] sources for hsqldb (LEAK FOUND) > > viktor wrote: > > > > onsdagen den 25 september 2002 kl 20.43 skre

Re: [JBoss-dev] sources for hsqldb (LEAK FOUND)

2002-09-25 Thread viktor
onsdagen den 25 september 2002 kl 22.17 skrev Michael Bartmann: > A possible answer might be: > > 0) test... > 1) post patch to hsqldb (as source) > 2) build the modified jar in your garage (as binary) > 3) commit the jar to Branch_X of jboss cvs "Just Do IT"(TM) comes to mind ... ---

Re: [JBoss-dev] sources for hsqldb (LEAK FOUND)

2002-09-25 Thread Michael Bartmann
viktor wrote: > > onsdagen den 25 september 2002 kl 20.43 skrev Michael Bartmann: > >> What is the best way to change the codebase? Another >> patch for hsqldb? >> > > Commit something that works optimised ... is the "best way"... > > After running the testsuit that is ... > > :-) ... > > /p

Re: [JBoss-dev] sources for hsqldb (LEAK FOUND)

2002-09-25 Thread viktor
onsdagen den 25 september 2002 kl 20.43 skrev Michael Bartmann: > What is the best way to change the codebase? Another > patch for hsqldb? > Commit something that works optimised ... is the "best way"... After running the testsuit that is ... :-) ... /peter_f PS: test and debug hsqldb 1.7.0

Re: [JBoss-dev] sources for hsqldb (LEAK FOUND)

2002-09-25 Thread Michael Bartmann
Wow, now i see the leak! Embedded_ServerConnection extends Thread == but you do: Socket s = serverSocket.accept(); Embedded_ServerConnection c = new Embedded_ServerConnection(s, this); ==