Re: CFV: New OpenJDK 7 Committer: Andrew Dinn

On 13/09/2018 23:50, mark.reinh...@oracle.com wrote: 2018/9/12 20:30:40 -0700, Andrew Hughes : I hereby nominate Andrew Dinn (adinn) [0] to OpenJDK 7 Committer. Andrew co-wrote the original AArch64 port [1] and is the the author of 32 patches in the OpenJDK sources [2]. He is already a revie

Re: [RFR] JDK-8207151: JVM 7u181 crash with SIGSEGV when Tomcat 7 starts

Is this issue also applicable to later JDK family version releases ? Is so, do you intend to fix there ? If not, can you add 8-na label to the bug record ? Thanks, Sean. On 15/08/18 16:11, Andrew Hughes wrote: On 23 July 2018 at 08:56, Andrew Haley wrote: On 07/12/2018 02:34 AM, Martin Bal

Re: Java DirectByteBuffer and OOM

Biju, Why don't you pull the patch into your own forest and build a local copy ? I could be a few weeks/months before this fix becomes public in an Oracle JDK release. Oracle jdk7u releases are no longer public. Last public one was 7u80. Regards, Sean. On 18/08/2015 00:21, Biju G.S Nair wro

Re: DirectByteBuffer change proposal

Biju, These lists are often not suitable for JDK component specific issues. You should discuss your issue on the nio-dev specific mailing list : http://mail.openjdk.java.net/mailman/listinfo/nio-dev Regards, Sean. On 11/08/2015 15:11, Biju G.S Nair wrote: Hello All, While the patch https

Re: Backporting sun.security.ssl.ClientHandshaker change to jdk7u?

John, the change you're referring to seems to be https://bugs.openjdk.java.net/browse/JDK-8075750 It's fixed for 7u85 which is an upcoming JDK release. Regards, Sean. On 19/05/2015 22:31, john.e.gr...@wellsfargo.com wrote: Hi all, On April 10 a change was committed to jdk8u that I'd like t

Re: Reminder [7u-dev] Request for Approval and Review: 8057008: [TEST_BUG] Test java/awt/Focus/SortingFPT/JDK8048887.java fails with compilation error

java/awt/Focus/SortingFPT/JDK8048887.java fails with compilation error Hi all Please help me in reviewing the fix for the issue -Thanks Srinivasan Raghavan On 9/1/2014 10:18 PM, Seán Coffey wrote: Looks good to me Srinivasan but you'll have to get an official 7u reviewer. You could appe

Re: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

Thanks all - Agreed changes pushed to 7u85 and I'll make a request to see if we can include this in 7u80 code base. regards, Sean. On 30/01/2015 16:00, Alan Bateman wrote: On 30/01/2015 12:18, Seán Coffey wrote: Alan, hadn't spotted the race issue. I guess we could del

Re: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

is version unless I hear objections. regards, Sean. On 29/01/2015 17:31, Alan Bateman wrote: On 26/01/2015 13:48, Seán Coffey wrote: Valeriy, those changes look fine to me and I've verified that they run through testing fine also. webrev here for reference : http://cr.openjdk.java.net/

Re: [7u] Review Request: JDK-8064454 Fix type in langtools for tools/javac/innerClassFile/Driver.sh

Hi Pooja, I think we're good to push your fix as it stands. Since we're past RDP2 for 7u80, I'll work with you off list in resolving this one. regards, Sean. On 29/01/2015 17:40, pooja chopra wrote: Hi , Can the change mentioned in my webrev be submitted or we should wait for one more revi

Re: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

r you? Best regards, Valeriy Kopylov, Software Engineer, Akvelon, Skype: Valeriy.Kopylov *From:*Martin Sawicki (MS OPEN TECH) *Sent:* Saturday, January 24, 2015 03:21 *To:* Seán Coffey; Valery Kopylov (Akvelon); jdk7u-dev@openjdk.java.net *Cc:* Kirk Shoop (MS OPEN TECH); OpenJDK Network Dev

Re: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

y in http://cr.openjdk.java.net/~coffeys/webrev.8060170.7u.v2/webrev/src/windows/native/sun/nio/ch/Net.c.cdiff.html Good to push ? I'll try and get this into 7u80 but can't guarantee that now given that we've entered the rampdown/stabilization phase. regards, Sean. On 15/01/15 12:09, Seán Coffey

Re: [7u] Review Request: JDK-8064454 Fix type in langtools for tools/javac/innerClassFile/Driver.sh

Pooja, your test case fix looks fine to me but I'm not a jdk7u reviewer. Can we get a jdk7u reviewer to review this simple change please ? regards, Sean. On 12/01/2015 07:04, pooja chopra wrote: Hi All, Please review below fix . 8064454 [TEST_BUG] Test tools/javac/innerClassFile/Driver.sh f

Re: DSA with keylength > 1024 no longer accepted (jdk7u-dev Digest, Vol 43, Issue 8)

Peter, the issue you reference isn't a problem in jdk7u. - for the Oracle JDK at least. The code snippet your refer to is from jdk8 source code. The key length restriction was initially introduced as a side effect of this fix in JDK 8 https://bugs.openjdk.java.net/browse/JDK-7044060 That sai

Re: [7u-dev] Request for approval: 8020829: NMT tests fail on platforms if NMT detail is not supported

Approved. regards, Sean. On 15/01/2015 17:25, Paul Nauman wrote: Would like to push this trivial backport to correct test failures. Bug: 8020829 (Confidential) - NMT tests fail on platforms if NMT detail is not supported. hs25 changeset: http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/5fd8e

Re: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

diff" command in jdk folder? Best regards, Valeriy Kopylov -Original Message- From: Seán Coffey [mailto:sean.cof...@oracle.com] Sent: Tuesday, January 13, 2015 22:31 To: Martin Sawicki (MS OPEN TECH); jdk7u-dev@openjdk.java.net Cc: Valery Kopylov (Akvelon); Kirk Shoop (MS OPEN TECH);

Re: DSA with keylength > 1024 no longer accepted

Hi Peter, security-dev is best mailing list to discuss this issue, I'm cc'ing that list and bcc'ing off jdk7u-dev. Are you hitting this issue with JDK 8 and later ? (I'll assume so) - You've hit https://bugs.openjdk.java.net/browse/JDK-8039921 To aid compatibility, it's been decided to relax

Re: [7u-dev] Request for approval for 8042235: redefining method used by multiple MethodHandles crashes VM

Approved. regards, Sean. On 14/01/2015 22:32, Kevin Walls wrote: Hi, This is a backport approval request for 8042235 into 7u. The 7u change is a little different from 8 onwards, some discussion below that led to the final webrev. bug https://bugs.openjdk.java.net/browse/JDK-8042235 webre

Re: [7u-dev] request for approval: 8048050: Agent NullPointerException when rmi.port in use

ready and waiting for approval as well. http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-January/013682.html Vladimir. On 14.01.2015 20:19, Seán Coffey wrote: Vladimir, What are your plans for fixing in jdk8u ? (rule 1 : http://openjdk.java.net/projects/jdk7u/groundrules.htm

Re: [7u-dev] request for approval: 8048050: Agent NullPointerException when rmi.port in use

Vladimir, What are your plans for fixing in jdk8u ? (rule 1 : http://openjdk.java.net/projects/jdk7u/groundrules.html) Please create a backport record for 8u60 so that this isn't forgotten. Approved on the condition that you'll also port to 8u shortly. regards, Sean. On 14/01/15 16:20, Vladi

Re: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

the update and your assistance. Looking forward. -Original Message----- From: Seán Coffey [mailto:sean.cof...@oracle.com] Sent: Friday, January 09, 2015 8:24 AM To: Martin Sawicki (MS OPEN TECH); jdk7u-dev@openjdk.java.net Cc: Valery Kopylov (Akvelon); Kirk Shoop (MS OPEN TECH) Subject: Re: Backp

[7u-dev] Request for approval : 8066612 Add a test that will call getDeclaredFields() on all classes and try to set them accessible.

Seeking to backport this new testcase to jdk7u-dev. Should be a useful stress test for future releases. review thread : http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-January/030678.html webrev : http://cr.openjdk.java.net/~coffeys/webrev.8066612.jdk7u/webrev/ bug ID : https://bugs.

Re: [7u-dev] Request for backport approval: 8016834 (Underlines and strikethrough not rendering correctly)

Approved. regards, Sean. On 12/01/15 16:22, Anton Nashatyrev wrote: Hello, please approve the fix backport from jdk8 to jdk7u-dev. The patch is simple and was applied without any modifications. Alexander, could you please review the backport? Bug: https://bugs.openjdk.java.net/bro

Re: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

Hey Martin, I can help in getting this enhancement ported to jdk7u-dev. I'm just waiting on approval for use of new system property in jdk7u release. Once I have that, I can get this in. regards, Sean. On 08/01/15 20:01, Martin Sawicki (MS OPEN TECH) wrote: Hello again, We'd like to propose

[7u80] Request for approval: 8015780: java/lang/reflect/Method/GenericStringTest.java failing

This testcase fix should have been ported to jdk7u-dev after JDK-6695379 was fixed. The JDK 8 test changes apply cleanly. The ProblemList.txt file does not need to be edited since java/lang/reflect/Method/GenericStringTest.java test is not excluded in 7u-dev jdk8 changeset : http://hg.openjdk

[7u-dev] Request for approval : 8064407, 8068507 : (fc) FileChannel transferTo should use TransmitFile on Windows

Looking to backport these fixes to jdk7u-dev. https://bugs.openjdk.java.net/browse/JDK-8064407 https://bugs.openjdk.java.net/browse/JDK-8068507 review thread : http://mail.openjdk.java.net/pipermail/nio-dev/2015-January/002975.html JDK-8068507 is also in process of being backported to JDK 8u.

Re: Request for approval to backport JDK-8068639: Make certain annotation classfile warnings opt-in

Normal process is that we port from 9 -> 8u -> 7u. This is approved for 7u on the condition that 8u is followed up on shortly. I'll create a backport record for 8u so that it's not forgotten. regards, Sean. On 08/01/2015 02:17, Joseph D. Darcy wrote: Hello, Please approve the backport from

Re: Backporting the FileChannel.transferTo (Windows) improvement to OpenJDK v7

Martin, This patch should apply easily enough to the jdk7u-dev codebase. Some minor edits may be necessary. I'll work off the jdk8u changeset : http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/c5d9397d4d41 The new system property was approved for use with 8u and later only. I'll work with Alan

Re: [7u-dev] Request for approval for 8066103: C2's range check smearing allows out of bound array accesses

As per the 8048170 request, please get a peer review before pushing to jdk7u-dev. Approved. regards, Sean. On 22/12/14 14:51, Roland Westrelin wrote: Backport to 7u request. Changes were pushed to jdk9 2 weeks ago and to 8u a bit less than 2 weeks ago. Nightly testing is fine. Changes apply

Re: [7u-dev] Request for approval for 8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed

Roland, Please get a peer review before pushing the jdk7u changes. Approved. regards, Sean. On 22/12/14 14:46, Roland Westrelin wrote: Backport to 7u request. Changes were pushed to jdk9 a bit more than 2 weeks ago and to 8u a bit less than 2 weeks ago. Nightly testing is fine. The change d

Re: [7u-dev] Request for Review + Request for Approval to Backport: 8064846: Lazy-init thread safety problems in core reflection

Approved for jdk7u-dev. regards, Sean. On 19/12/14 17:09, Martin Buchholz wrote: Looks good! On Fri, Dec 19, 2014 at 7:55 AM, Ivan Gerasimov wrote: Hello! This is a request to approve the partial backport of the fix JDK-8064846. The backport is very similar to the one for jdk8u. I only had

Re: [7u-dev] request for approval: 8065552: setAccessible(true) on fields of Class may throw a SecurityException

Approved. regards, Sean. On 18/12/2014 09:28, cheleswer sahu wrote: Hi! May I please have approval to backport this fix from JDK8 to JDK7. I have built the JDK7 and tested already. JDK8 fix applies cleanly to JDK7 source. As I do not have account for OpenJDK, David Buck will push the fix in

Re: [7u-dev] Request for Approval for Backport: JDK-8013849: Awt assert on Hashtable.cpp:124

Approved. I'm assuming it's a straight backport. If it's not, please get a peer review before pushing. regards, Sean. On 15/12/2014 07:49, mikhail cherkasov wrote: Hi there, Please approve the backport of JDK-8013849 from 8 repo to 7. webrev: http://cr.openjdk.java.net/~mcherkas/8013849/webr

Re: [7u-dev] Request for Approval for Backport: JDK-6695379: Copy method annotations and parameter annotations to synthetic bridge methods

Hi Vicente, Approved. I can help push this change to jdk7u-dev for you. regards, Sean. On 10/12/2014 21:45, Vicente-Arturo Romero-Zaldivar wrote: Hi, Please approve the backport of JDK-6695379 from 9 repo to JDK7u-dev. Public webrev: http://cr.openjdk.java.net/~vromero/work/6695379/webrev.0

Re: [7u80] Request for approval for 8066756: Test test/sun/awt/dnd/8024061/bug8024061.java fails

Approved. regards, Sean. On 10/12/14 10:16, Alexey Ivanov wrote: Hello, Could you please approve the following backport of the fix to 7u80? JBS bug: https://bugs.openjdk.java.net/browse/JDK-8066756 Webrev: http://cr.openjdk.java.net/~aivanov/8066756/jdk9/webrev.00/ Review: http://mail.openjd

Re: [7u-dev] Request for approval for 8065098: JColorChooser no longer supports drag and drop between two JVM instances

Approved with the condition that this gets a peer code review. regards, Sean. On 04/12/2014 13:55, Alexey Ivanov wrote: Hello, Could you please approve the following backport of the fix to jdk7u-dev? The patch doesn't apply cleanly automatically, code in DataTransferer.java differs. Yet the

Re: [7u-dev] request for approval: 8035893: JVM_GetVersionInfo fails to zero structure

Please add a noreg- label to the bug report : http://openjdk.java.net/guide/changePlanning.html#noreg Approved. regards, Sean. On 04/12/2014 09:42, cheleswer sahu wrote: Hi! May I please have approval to backport this fix from JDK8 to JDK7. I have built the JDK7 hotspot and tested already.

Re: [7u-dev] Request for Approval to Backport: 8065765: Missing space in output message from -XX:+CheckEndorsedAndExtDirs

Looks good. Hopefully Mandy can give the thumbs up before you push. Approved. regards, Sean. On 04/12/2014 07:29, Ivan Gerasimov wrote: On 04.12.2014 2:44, Mandy Chung wrote: On 12/3/2014 1:00 PM, Ivan Gerasimov wrote: WEBREV: http://cr.openjdk.java.net/~igerasim/8065765/0/webrev/ Anoth

Re: [7u-dev] Request for approval for 8031765: [TEST] Child process error stream is not empty!

Approved. regards, Sean. On 03/12/14 17:28, Alexey Ivanov wrote: Hello, Could you please approve the following direct backport of the fix to jdk7u-dev? JBS bug: https://bugs.openjdk.java.net/browse/JDK-8031765 Webrev: http://cr.openjdk.java.net/~pchelko/9/8031765/webrev/ Review: http://mai

Re: [7u-dev] Request for Review + Request for Approval to Backport: 8064391: More thread safety problems in core reflection

Looks fine to me Ivan. Please get jdk7u reviewer to review. Approved. regards, Sean. On 28/11/2014 13:37, Ivan Gerasimov wrote: Hello! Would you please approve the backport from jdk 8u to 7u? The patch didn't apply cleanly due to generics in these two files: src/share/classes/sun/reflect/Boo

Re: [7u-dev] Request for Approval: 8001579: Cleanup warnings in security native code

Approved. regards, Sean. On 27/11/2014 12:45, Ivan Gerasimov wrote: Hello! Would you please give me an approval to backport the fix for JDK-8001579? I have a strong belief this will fix an 'access violation' bug JDK-8049839 that was reported several times for jdk7. The patch applies cleanl

Re: [7u-dev] Request for Review + Request for Approval to Backport: 8064391: More thread safety problems in core reflection

Thanks for handling this Ivan. Looks good to me. Hopefully you can get another reviewer. Approved. regards, Sean. On 26/11/14 11:36, Ivan Gerasimov wrote: Hello! Would you please approve the (almost) direct backport from jdk 8u to 7u? The difference, comparing to 8u changeset, is due to cha

Re: [7u-dev] Request for approval: 8064560: (tz) Support tzdata2014j

Approved. regards, Sean. On 25/11/2014 12:11, Aleksej Efimov wrote: Hello, Please, approve a backport of tzdata2014j related changes to jdk7u-dev. The JDK8 fix applies cleanly with unshuffled path to tz data storage (make/data/tzdata->make/sun/javazic/tzdata). Testing: JPRT and JTREG [1] tes

Re: RFR: 8061785: [TEST_BUG] serviceability/sa/jmap-hashcode/Test8028623.java has utf8 character corrupted by earlier merge

I wasn't sure if this was a review or approval request Kevin. Change looks fine to me in any case. Approved. regards, Sean. On 24/11/14 11:43, KEVIN WALLS wrote: Hi, I'd like to request approval to push this small proactive change to a test into http://hg.openjdk.java.net/jdk7u/jdk7u-dev/

Re: [7u80] Request for Approval : JDK-8026865 : [TESTBUG] 'compiler/print/PrintInlining.java' should specify -XX:+UnlockDiagnosticVMOptions

Approved. regards, Sean. On 24/11/14 12:34, shobhit gupta wrote: Please approve backport ofJDK-8026865 to 7u80. Bug: https://bugs.openjdk.java.net/browse/JDK-8026865 Webrev:http://cr.openjdk.java.net/~kshefov/8026865/webrev.00/ Review thread

Re: [7u-dev] Request for approval: 8001633: Wrong alt processing during switching between windows.

Thanks for following up with the approval request. Approved. regards, Sean. On 24/11/14 09:59, mikhail cherkasov wrote: Hello all, I would like to request for an approval to push a backport of the fix from JDK 8 to JDK 7. The backport was changed, the original testcase was replaced with a n

[7u-dev] Request for approval : 8047340 - (process) Runtime.exec() fails in Turkish locale

I'd like to push this fix to jdk7u-dev. It's already addressed in JDK 8 via JDK-8000975 webrev : http://cr.openjdk.java.net/~coffeys/webrev.8047340.7u/webrev/ bug report : https://bugs.openjdk.java.net/browse/JDK-8047340 review thread : http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-

Re: [7u-dev] request for approval: 8059327: XML parser returns corrupt attribute value

Approved. On a side note, I notice that alot of new incoming testng tests don't use the "@bug" label convention. QA and other teams use that tag for metrics. Something to keep an eye on. regards, Sean. On 12/11/14 10:24, Aleksej Efimov wrote: Hi! May I please have approval to backport 8059

Re: [7u-dev] request for approval: 8064516: BCEL still corrupts generic methods if bytecode offsets are modified

Approved. Please add a noreg- label to master bug record. regards, Sean. On 11/11/2014 09:35, david buck wrote: Hi! May I please have approval to backport this fix from JDK8 to JDK7? Fix applies cleanly. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8064516 JDK8 changeset: http://hg.op

Re: [7u-dev] Request for approval for CR 8020675 - invalid jar file in the bootclasspath could lead to jvm fatal error

Missed that. Apologies. I thought the links referred to the JDK 8 review. You're good to push then. regards, Sean. On 10/11/14 13:41, Andreas Eriksson wrote: As I mentioned in the mail, the backport has been reviewed by Calvin Cheung, is that not enough? - Andreas On 2014-11-10 14:38,

Re: [7u-dev] Request for approval for CR 8020675 - invalid jar file in the bootclasspath could lead to jvm fatal error

Approved. I'm assuming this patch applies cleanly. If not, please obtain a peer review before pushing. regards, Sean. On 10/11/14 13:04, Andreas Eriksson wrote: Hi, I'd like approval for backporting JDK-8020675 - invalid jar file in the boo

Re: [7u-dev] request for approval: 8062608: BCEL corrupts debug data of methods that use generics

Approved. regards, Sean. On 07/11/14 10:37, david buck wrote: Hi! Please approve this backport from jdk8 to jdk7u-dev bug url: https://bugs.openjdk.java.net/browse/JDK-8062608 JDK8 changeset: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jaxp/rev/02d2df45bda8 review thread : http://mail.openjd

Re: [7u-dev] Request for approval: 8062021: NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146

Approved. regards, Sean. On 06/11/2014 18:55, mikhail cherkasov wrote: Hi there, I would like to backport this fix from jdk8: bug: https://bugs.openjdk.java.net/browse/JDK-8062021 review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2014-October/008617.html jdk8 changeset: http://h

Re: [7u-dev] Request for approval: 8059216: Make PrintGCApplicationStoppedTime print information about stopping threads

Master bug needs a noreg- label. Approved. regards, Sean. On 06/11/2014 14:30, Vladimir Kempik wrote: The webrev - http://cr.openjdk.java.net/~vkempik/8059216/jdk7/8059216/webrev.00/ On 06.11.2014 17:29, Vladimir Kempik wrote: Hello, please approve this backport of the fix to jdk7u-dev. Th

Re: [7u-dev] Request for approval: 8058715: stability issues when being launched as an embedded JVM via JNI

I thought it was another case of colleague attacks/hugs! [1] Review thread : http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-November/013056.html Approved. regards, Sean. [1] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2014-November/002370.html On 06/11/2014 12:46, dav

Re: Resend: [7u-dev] Request for approval for 8046289: compiler/6340864/TestLongVect.java timeout with

You might want to add a noreg- label to the bug report. The testbug label should be removed also since this affects product code. Approved. regards, Sean. On 06/11/2014 01:48, Vladimir Kozlov wrote: Please, ignore previous mail. I messed up links. Backport to 7u request. Changes were pushed

Re: [7u-dev] Request for approval: 8062744 jdk.net.Sockets.setOption/getOption does not support IP_TOS

Thanks Rob - I got the bug ID wrong in the subject field. Correcting that here for records purposes... regards, Sean. On 04/11/2014 22:06, Rob McKenna wrote: Approved. -Rob On 04/11/14 21:18, Seán Coffey wrote: I'd like to backport this fix to jdk7u-dev. The 8u change applies cl

Re: [7u-dev] Request for approval : JDK-8046275 : Fastdebug build failing on jdk9/hs/ control jobs after pulling some hs-comp changes

Approved. regards, Sean. On 05/11/2014 00:43, Poonam Bajaj wrote: Please approve this backport for jdk7u-dev: JDK-8046275 : Fastdebug build failing on jdk9/hs/ control jobs after pulling some hs-comp changes Review thread: http://mail.openj

[7u-dev] Request for approval: 8082744 jdk.net.Sockets.setOption/getOption does not support IP_TOS

I'd like to backport this fix to jdk7u-dev. The 8u change applies cleanly to jdk7u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8062744 JDK 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/30c2d576a1be Review thread: http://mail.openjdk.java.net/pipermail/net-dev/2014-November/008

Re: [7u-dev] Request for approval : 8056026 Debug security logging should print Provider used for each crypto operation

With the correct webrev link... http://cr.openjdk.java.net/~coffeys/webrev.8056026.7u/webrev/ regards, Sean. On 04/11/2014 16:51, Seán Coffey wrote: I'd like to backport this enhancement to jdk7u-dev. The fix from jdk8u applies cleanly with the exception of copyright years that

[jdk7u-dev] Request for approval : 6458027: Disabling IPv6 on a specific network interface causes problems

I'd like to backport this to jdk7u. The patch from JDK 8 applies cleanly and I'm currently running tests on the change. bug ID : https://bugs.openjdk.java.net/browse/JDK-6458027 JDK 8 changeset : http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/db0fc2b71298 review thread : http://mail.openjdk.java.

[7u-dev] Request for approval : 8056026 Debug security logging should print Provider used for each crypto operation

I'd like to backport this enhancement to jdk7u-dev. The fix from jdk8u applies cleanly with the exception of copyright years that had a conflict. webrev : http://t4.ie.oracle.com/home/sean/jdk7u-dev/jdk/webrev.8056026.7u/webrev/ review thread : http://mail.openjdk.java.net/pipermail/security-d

Re: [7u-dev] Request for approval: 8059206: (tz) Support tzdata2014i

Approved pending a peer review of the JDK7u changes. regards, Sean. On 01/11/2014 22:19, Aleksej Efimov wrote: Hello, Please, approve a JDK 7u-dev backport of tzdata2014i integration fix. The fix is almost identical to JDK8 with one difference: there is no generic names in JDK7 and changes r

Re: [7u76] 8051614: smartcardio TCK tests fail due to lack of 'reset' permission

jdk7u-dev is gathering fixes for 7u80. Approved. regards, Sean. On 28/10/2014 04:27, Ivan Gerasimov wrote: Hello! I'm looking for an approval to backport the fix into 7u-dev repository. The fix applies cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8051614 (marked confidential due to

Re: [7u-dev] Request for approval 8058927: ATG throws ClassNotFoundException

Approved. regards, Sean. On 15/10/14 09:56, Kevin Walls wrote: Hi, I'd like to get a approval for this backport into 7u. It's a change from the original fix, approval below from original author. webrev http://cr.openjdk.java.net/~kevinw/8058927/webrev.00/ bug https://bugs.openjdk.java.net/

Re: [7u-dev] Request for approval 8030976: Untaken paths should be more vigorously pruned at highest optimization level

Please add a suitable noreg- label to master bug report. This is not a direct backport from 8u either so please obtain a 7u review. Approved. regards, Sean. On 15/10/2014 07:09, Sergey Gabdurakhmanov wrote: Hello, Could you please approve the back-port of the fix for 8030976 to jdk7u-dev?

Re: [7u-dev] Request for approval 8058120: Rendering / caret errors with HTMLDocument

Approved. regards, Sean. On 10/10/14 10:48, dmitry markov wrote: Hello, Could you approve the straight back-port of the fix for 8058120 to jdk7u-dev (jdk7u80), please? The bug: https://bugs.openjdk.java.net/browse/JDK-8058120 The webrev: http://cr.openjdk.java.net/~dmarkov/8058120/jdk7u/web

Re: [7u-dev] Request for approval : 8014254, 7145454, 7156459

Approved. regards, Sean. On 08/10/14 13:23, Rob McKenna wrote: Hi folks, looking for approval for these backports. (all of which apply cleanly) 8014254: Selector in HttpServer introduces a 1000 ms delay when using KeepAlive bug: https://bugs.openjdk.java.net/browse/JDK-8043528 changeset: h

[7u-dev] Request for approval : 8004488 wrong permissions checked in krb5

Looking to port this to jdk7u. bug : https://bugs.openjdk.java.net/browse/JDK-8004488 webrev : http://cr.openjdk.java.net/~coffeys/webrev.8004488.7u/webrev/ review thread : http://mail.openjdk.java.net/pipermail/security-dev/2014-October/011314.html regards, Sean.

Re: [7u-dev] Request for approval: 8038966: JAX-WS handles wrongly xsd:any arguments for Web services

Looks fine Aleksej. Approved. regards, Sean. On 08/10/14 09:45, Aleksej Efimov wrote: Hello, Could you, please, approve a backport of 8038966 bug to JDK7u-dev. The source code changes is identical to JDK8. The only one difference is in how test application converts the WS response to String

[7u-dev] Request for approval : 8052406: SSLv2Hello protocol may be filtered out unexpectedly

-Rob On 30/09/14 18:46, Seán Coffey wrote: Looking to backport this change from JDK 8u. JDK 8u changeset applies cleanly. bug report : https://bugs.openjdk.java.net/browse/JDK-8052406 changeset : http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/ddba61b06470 regards, Sean.

[7u-dev] Request for approval : 7017962 : Obsolete link is used in URL class level spec

Been asked to backport this to 7u code line in case anyone needs to re-build javadoc. Straight port for JDK 8 : bug : https://bugs.openjdk.java.net/browse/JDK-7017962 changeset : http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/77bde15bc6a9 review link : http://mail.openjdk.java.net/pipermail/net-d

[7u-dev] request for approval : 8046588 8047187

Following bugs need to be backported to jdk7u-dev to correct issues where SO_FLOW_SLA availability might not be available or where sufficient permissions are not in place. https://jbs.oracle.com/bugs/browse/JDK-8046588 8u changeset : http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/be862163bb8d

[7u-dev] Request for approval : 7180038 8031566

I'd like to backport some test stabilization fixes for the following testcase : test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/SSLEngineBadBufferArrayAccess.java Both patches apply cleanly. Tests are green. https://bugs.openjdk.java.net/browse/JDK-7180038 jdk8u changeset : ht

Re: PING: [7u80] Request for review for CR 4963723: Implement SHA-224

Valerie Peng (original author) is probably best suited to reviewing this but I think she's out of the office the moment and back next week. Let's hope we can get an update/review then. regards, Sean. On 01/10/2014 16:11, Andrew Hughes wrote: - Original Message - - Original Messa

Re: [7u-dev] Request for approval 8008328: [partfait] Null pointer defererence in hotspot/src/cpu/x86/vm/frame_x86.inline.hpp

I'm not sure why developers persist with the same exception message across different native functions. It can be real useful for post mortem debugging to know exactly which method generated the message. (just from exception message) "bad register save location" is used across saved_oop_result

[7u-dev] Request for approval: JDK-8058932 - java/net/InetAddress/IPv4Formats.java failed because hello.foo.bar does exist

Seeking to push Mark's fix to jdk7u-dev also. https://bugs.openjdk.java.net/browse/JDK-8058932 http://mail.openjdk.java.net/pipermail/net-dev/2014-October/008711.html Simple patch will apply cleanly. regards, Sean.

[7u-dev] Request for approval : 8052406: SSLv2Hello protocol may be filtered out unexpectedly

Looking to backport this change from JDK 8u. JDK 8u changeset applies cleanly. bug report : https://bugs.openjdk.java.net/browse/JDK-8052406 changeset : http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/ddba61b06470 regards, Sean.

Re: [7u-dev] Backport request: 8056914: Right Click Menu for Paste not showing after upgrading to java 7

Approved. regards, Sean. On 30/09/2014 12:55, Anton Nashatyrev wrote: Hello, please approve the fix backport from jdk8 to jdk7u-dev. The patch was applied clearly with the exception of one change which has failed due to lines shifting, this change has been applied by hands. Bug: https:

[7u-dev] Request for approval : 7085757 7195759 8021121 8055222 8006748 7077119 7028073 6931564 8027695

Looking to port some currency data and minor Locale updates to jdk7u-dev. All have already been fixed in JDK 8. 7085757: Currency Data: ISO 4217 Amendment 152 7195759: ISO 4217 Amendment 154 8021121: ISO 4217 Amendment Number 156 8055222: Currency update needed for ISO 4217 Amendment #159 800674

Re: [8u-dev][7u-dev] Backport request for 8058473: "Comparison method violates its general contract" when using Clipboard

Approved for 8u-dev and 7u-dev. regards, Sean. On 26/09/2014 11:28, Anton Nashatyrev wrote: Hello, please approve the backport to 8u-dev and 7u-dev (the patch is absolutely the same for 8u-dev and 7u-dev) JBS: https://bugs.openjdk.java.net/browse/JDK-8058473 JDK9 changeset: http://hg.o

Re: [7u-dev] Request for approval for 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check

On 25/09/2014 20:06, Vladimir Kozlov wrote: On 9/25/14 11:49 AM, Seán Coffey wrote: Vladimir, this needs to be pushed to the jdk8u code line first. http://openjdk.java.net/projects/jdk7u/groundrules.html : Rule 1 Yes, I also sent the request to hotspot-dev (since it is Hotspot changes

Re: [7u-dev] Request for approval for 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check

Vladimir, this needs to be pushed to the jdk8u code line first. http://openjdk.java.net/projects/jdk7u/groundrules.html : Rule 1 regards, Sean. On 25/09/2014 19:42, Vladimir Kozlov wrote: Backport request. Changes was pushed into jdk9 week ago. Nighties are fine. Changes are applied cleanly.

Re: [7u-dev] Request for approval for 8058936 hotspot/test/Makefile should use jtreg script from $JT_HOME/bin/jreg (instead of $JT_HOME/win32/bin/jtreg)

Approved. Please add a noreg- label. regards, Sean. On 24/09/14 11:48, Staffan Larsen wrote: Please approve this backport from 9 and 8u. The fix applies cleanly. bug: https://bugs.openjdk.java.net/browse/JDK-8058936 jdk9 changeset: http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/01961999c58a

Re: [7u-dev] Request for approval 8057564: JVM hangs at getAgentProperties after attaching to VM with lower integrity

Sergey, can you make the bug report public ? Please add the information from the code review thread into the description of the bug. Can you also create an 8u40 backport record so that it's not forgotten. Approved. regards, Sean. On 23/09/2014 08:14, Sergey Gabdurakhmanov wrote: Hello, Coul

[7u-dev] Request for approval : 8057813: Alterations to jdk_security3 test target

Looking to push this test clean up to jdk7u-dev. webrev : http://cr.openjdk.java.net/~coffeys/webrev.7u.8057813/webrev/ bug report : https://bugs.openjdk.java.net/browse/JDK-8057813 review thread : http://mail.openjdk.java.net/pipermail/security-dev/2014-September/011229.html regards, Sean.

Re: [7u-dev] Request for approval 8028280, 8038274: ParkEvent leak when running modified runThese which only loads classes

1st prize goes to the hotspot team for failing to use noreg- labels! Please add them. Approved for jdk7u-dev but subject to peer code review. regards, Sean. On 17/09/14 11:49, Sergey Gabdurakhmanov wrote: Hello, Could you please approve the back-port of the fix for 8028280 and 8038274 to jd

Re: [7u-dev] Request for approval 8051359: [headless] JPopupMenu creation in headless mode with JDK9b23 causes NPE

Approved. regards, Sean. On 17/09/2014 09:05, dmitry markov wrote: Hello, Could you approve the straight back-port of the fix for 8051359 to jdk7u-dev (jdk7u80), please? The bug: https://bugs.openjdk.java.net/browse/JDK-8051359 The webrev: http://cr.openjdk.java.net/~dmarkov/8051359/webrev.

Re: [7u-dev] RFA: 8049343: (tz) Support tzdata2014g

Please get a reviewer to review the JDK7u changes. Approved but subject to review. regards, Sean. On 12/09/14 15:42, Aleksej Efimov wrote: Hello, Could you, please, approve a backport of tz2014g related changes to JDK7. The backport is not straight-forward one, there is no generic time zone

Re: [7u-dev] Request for approval 8015586: [macosx] Test closed/java/awt/print/PrinterJob/PrintToDir.java fails on MacOSX

Approved. regards, Sean. On 12/09/14 13:13, dmitry markov wrote: Hello, Could you approve the back-port of the fix for 8015586 to jdk7u-dev (7u80), please? I could not find the review thread for the original fix, but the changes apply cleanly. The bug: https://bugs.openjdk.java.net/browse/

Re: [7u-dev] Request for approval 8048110: Using tables in JTextPane leads to infinite loop in FlowLayout.layoutRow

Approved. regards, Sean. On 12/09/14 12:37, dmitry markov wrote: Hello, Could you approve the straight back-port of the fix for 8048110 to jdk7u-dev (jdk7u80), please? The bug: https://bugs.openjdk.java.net/browse/JDK-8048110 The webrev: http://cr.openjdk.java.net/~dmarkov/8048110/jdk7u/web

Re: [7u-dev] Request for approval: 6642881: Improve performance of Class.getClassLoader()

Approved. Please add the noreg-perf label to the master bug report. regards, Sean. On 12/09/2014 09:33, Kevin Walls wrote: Hi, Please approve this backport into 7u of changes to speed up access to the classloader. There are hotspot and JDK components. Changes have been in jdk9 for nearly 2

Re: [7u-dev] Request for approval: 8049684: pstack crashes on java core dump

Approved. regards, Sean. On 10/09/14 14:46, Kevin Walls wrote: Hi, Please approve a simple backport of this hotspot fix that's in 9 and 8u. bug: https://bugs.openjdk.java.net/browse/JDK-8049684 7u webrev: http://cr.openjdk.java.net/~kevinw/8049684/7u/ The 8u changeset imports cleanly into 7

Re: [7u-dev] Request for approval 8028484: [TEST_BUG][macosx] closed/java/awt/MouseInfo/JContainerMousePositionTest fails

Approved but subject to code review. regards, Sean. On 10/09/14 13:16, dmitry markov wrote: Hello, Could you approve the back-port of the fix for 8028484 to jdk7u-dev (7u80), please? The original fix and the back-port are slightly different. There are trivial changes in the regression test (

[7u-dev] Request for approval : 8044725 :Bug in zlib 1.2.5 prevents inflation of some gzipped files (zlib 1.2.8 port)

I'd like to backport the zlib v1.2.8 libraries to JDK 7u. bug report : https://bugs.openjdk.java.net/browse/JDK-8044725 webrev : http://cr.openjdk.java.net/~coffeys/webrev.8044725.7u/webrev/ review thread : http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-September/028482.html regards

Re: [7u-dev] Request for approval: 8057184 JCK8's api/javax_swing/JDesktopPane/descriptions.html#getset failed with GTKLookAndFeel on Linux and Solaris run v.s. JDK8+

Approved. regards, Sean. On 08/09/14 11:00, Alexander Scherbatiy wrote: Hello, Could you approve the direct backport of the fix to JDK 7u-dev. The bug: https://bugs.openjdk.java.net/browse/JDK-8057184 The webrev: http://cr.openjdk.java.net/~alexsch/8057184/webrev.01/ The review thread: http

Re: [7u-dev] Request for approval 8025644: java/util/stream/test/org/openjdk/tests/java/util/stream/ToArrayOpTest.java fails with TestData$OfRef): failure java.lang.AssertionError: expected [true] but

Approved. regards, Sean. On 05/09/2014 09:20, Sergey Gabdurakhmanov wrote: Hello, Could you please approve the back-port of the fix for 8025644 to jdk7u-dev? The bug: https://bugs.openjdk.java.net/browse/JDK-8025644 The webrev: http://cr.openjdk.java.net/~sgabdura/8025644/webrev.00/ The rev

Re: [7u-dev] Request for approval 8046233: VerifyError on backward branch

Thanks for following up Harold. Good to have the detail also. Approved. regards, Sean. On 04/09/2014 14:14, harold seigel wrote: Hi, Please approve this small fix for bug 8046233 for JDK7u-dev. Section 4.10.2.4 o

Re: hg: jdk7u/jdk7u-dev/hotspot: 8046233: VerifyError on backward branch

Coleen, Harold, I didn't see an approval request for this one. Could you log one for records purposes ? http://openjdk.java.net/projects/jdk7u/groundrules.html regards, Sean. On 03/09/2014 19:00, coleen.phillim...@oracle.com wrote: Changeset: aad3fc05d972 Author:hseigel Date: 2014-0

Re: [7u-dev] Request for approval 8029190: VM_Version::determine_features() asserts on Fujitsu Sparc64 CPUs

Approved. Looks like the bug report needs a noreg- label. regards, Sean. On 03/09/14 13:06, Sergey Gabdurakhmanov wrote: Hello, Could you please approve the back-port of the fix for 8029190 to jdk7u-dev? The bug: https://bugs.openjdk.java.net/browse/JDK-8029190 The webrev: http://cr.openjdk

Re: [7u-dev] Request for approval 8022229: Intermittent test failures in sun/tools/jstatd

Good to have these tests fixed up. Approved. regards, Sean. On 03/09/14 11:36, Sergey Gabdurakhmanov wrote: Hello, Could you please approve the back-port of the fix for 809 to jdk7u-dev? Files from test/lib/testlibrary/jdk/testlibrary/ have been backported in bug 8036786 "Update jdk7 tes

  1   2   3   4   5   6   7   8   9   10   >