Hello Serge,
I see several issues with this patch:
sun/security/ec/ECPrivateKeyImpl.java
- ECUtil class is not referenced in the ECPrivateKeyImpl class. Import can be
removed
org/jcp/xml/dsig/internal/dom/DOMKeyValue.java
- DomKeyValue class should be updated to instantiate ECParameters and
Na
Hello Alexey,
Thanks for pointing this out. I updated the webrev here:
http://cr.openjdk.java.net/~alexsch/sercher/8035166.7u/webrev.01/
Thank you.
On 11.12.2020 13:17, Alexey Bakhtin wrote:
> Hello Serge,
>
> I see several issues with this patch:
>
> sun/security/ec/ECPrivateKeyImpl.java
> -
Looks good to me now.
Thank you
Alexey
> On 11 Dec 2020, at 17:12, Sergey Chernyshev
> wrote:
>
> Hello Alexey,
>
> Thanks for pointing this out. I updated the webrev here:
>
> http://cr.openjdk.java.net/~alexsch/sercher/8035166.7u/webrev.01/
>
> Thank you.
>
>
> On 11.12.2020 13:17, Alex
Hello,
Alexey, thank you for the review.
Sergey, thank you for contributing the fix. Before you push this change
in 7u, could you please clarify the purpose of this backport? Do you
plan to backport any followup fixes into 7u? Do you have any assessment
whether any third-party software could be
Hello Andrew,
The main goal is to backport JDK-8233228 to 7u, which depends on this issue.
The same fix was pushed earlier this week to 8u:
http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/b8ad41e9571f
I am not aware of any 3rd party software that can be affected by the
change. This seems unli
