Re: [7u6] request for approval, 7166687: InetAddress.getLocalHost().getHostName() returns FQDN

2012-05-10 Thread Chris Hegarty
On 10/05/2012 06:29, David Holmes wrote: Is this going to be a push of the exact same changeset as 7u5, or a new changeset with the same content? I'd like to see the '--exact' same changeset being imported into 7u6. We've done this before between 7u-dev and 7ux(stabilization) repositories and

Re: CFV: New jdk7u Committer: Kurchi Subhra Hazra

2012-05-10 Thread Chris Hegarty
Vote: yes. -Chris.

[7u6] Request for approval: 7176784: Windows authentication not working on some computers

2012-06-25 Thread Chris Hegarty
Requesting approval to push CR 7176784 to 7u6. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7176784 Webrev: http://cr.openjdk.java.net/~chegar/7176784/webrev.00/webrev/ This fix has been pushed into jdk8 [1], and it ultra conservative. Thanks, -Chris. [1] http://hg.openjdk.java.net/j

hg: jdk7u/jdk7u-dev/jdk: 2 new changesets

2012-06-25 Thread chris . hegarty
Changeset: 71cb21ac8481 Author:chegar Date: 2012-06-25 14:19 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/71cb21ac8481 7176784: Windows authentication not working on some computers Reviewed-by: michaelm ! src/windows/native/sun/net/www/protocol/http/ntlm/NTLMAuthSe

Re: Code Review Request: 6953455 CookieStore.add() cannot handle null URI parameter, contrary to the API specification

2012-07-04 Thread Chris Hegarty
Seems like a reasonable candidate for a backport. Are you encountering it in 7? -Chris On 4 Jul 2012, at 15:19, Neil Richards wrote: > On Fri, 2011-09-30 at 10:08 -0700, Kurchi Hazra wrote: >> >> >> Hi, >> >>The CookieStore.add() method throws a Null Pointer Exception when >> null is pas

Re: Crash due to missing synchronization on 'gconf_client' in 'jdk/src/solaris/native/sun/net/spi/DefaultProxySelector.c'

2012-08-02 Thread Chris Hegarty
Thanks for the cross post David. Yes, net-dev is the best place to discuss this issue ( bcc'ing off jdk7u-dev ). Thanks for reporting this issue Christian. I haven't looked at the proposed patch yet, but I agree we may want to simplify this if possible ( handling the synchronization at the Jav

[7u8] Request for Approval for CR 7188755: Crash due to missing synchronization on gconf_client in DefaultProxySelector.c

2012-08-28 Thread Chris Hegarty
Hi, This is a request for approval to backport the fix for 7188755 from JDK8 to 7u8. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7188755 7188755: Crash due to missing synchronization on gconf_client in DefaultProxySelector.c JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/j

hg: jdk7u/jdk7u-dev/jdk: 7188755: Crash due to missing synchronization on gconf_client in DefaultProxySelector.c

2012-08-29 Thread chris . hegarty
Changeset: aa5a30249beb Author:chegar Date: 2012-08-12 22:56 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/aa5a30249beb 7188755: Crash due to missing synchronization on gconf_client in DefaultProxySelector.c Reviewed-by: chegar Contributed-by: Christian Schulte !

Re: Request for approval: 7023713: HttpCookie.domainMatches("hostname.local", "hostname") should return true

2012-09-14 Thread Chris Hegarty
Sean, Are you encountering this bug in Java 7, in the real world, or is this a proactive backport? My initial reaction to this request is that we should not backport, unless someone is actually running into it. Otherwise we are making a behavior change, and taking a risk, unnecessarily. -Chr

Re: Request for approval: 7023713: HttpCookie.domainMatches("hostname.local", "hostname") should return true

2012-09-14 Thread Chris Hegarty
t you are ok with that. I appreciate your co-operation here. Thank you, -Chris. On Fri, Sep 14, 2012 at 4:37 PM, Chris Hegarty mailto:chris.hega...@oracle.com>> wrote: Sean, Are you encountering this bug in Java 7, in the real world, or is this a proactive backport? My initi

Re: [7u10] Request for approval: 7112670: Inet4AddressImpl should use getaddrinfo/getnameinfo

2012-09-17 Thread Chris Hegarty
On 17/09/2012 10:06, Alan Bateman wrote: For the record, I have concerns about back-porting this to 7u. The reason is that switching to getnameinfo and getaddrinfo can result in subtle behavioral changes that cause problems for applications and developers. A recent one in this area was: http://

Re: [7u-dev] Request for approval: 8001124: jdk7u ProblemList.txt updates (10/2012)

2012-10-18 Thread Chris Hegarty
Looks fine Alan. It will make working on 7u a little easier! -Chris On 18 Oct 2012, at 15:06, Alan Bateman wrote: > > I don't work in jdk7u-dev too often but today I had to build it and I'm > seeing a lot of test failures. The test are failures are mostly because the > exclude list (jdk/test

Re: Request for approval: 7014860: Socket.getInputStream().available() not clear for shutdown input

2012-10-24 Thread Chris Hegarty
Hmm.. there is a spec clarification here, I'm not sure that it can done in a 7 Update. -Chris. On 24/10/2012 10:27, Sean Chou wrote: Hello, This is request for approval to push the fix of 7014860 to jdk7u, please take a look. Link to the bug: http://bugs.sun.com/bugdatabase/view_bug.do?

Re: Request for approval: 7025938: Add bitmap mime type to content-types.properties

2012-10-24 Thread Chris Hegarty
Yes, there is a small change in behavior here. getContent is not all that widely used, and I'm not sure if this change in behavior should surprise anyone. Sean, could you write a simple test that demonstrates this change in behavior? I'd like to get a better feel for what how this would impact

Re: Request for approval: 7025938: Add bitmap mime type to content-types.properties

2012-11-07 Thread Chris Hegarty
System.out.println(conn3.getContentType()); System.out.println(conn4.getContentType()); } } /// results /// /modified-j2sdk-image/bin/java TestBMP text/plain image/png image/png image/bmp /jdk1.7.0_05/bin/java TestBMP text/plain image/png image/png cont

Re: Approval request for 7201156: jar tool fails to convert file separation characters for list and extract

2012-12-12 Thread Chris Hegarty
I'm not an official approver for 7u-dev, but as far as the changes are concerned I think they should be fine for 7u-dev. -Chris. On 12/12/2012 06:04, Sean Chou wrote: Hi , I would like to get approval for back-porting the fix for 7201156 to JDK 7u . The patch is same as JDK 8 . JDK 8 change

Re: a socket impl question?

2013-01-13 Thread Chris Hegarty
On 12/01/2013 23:20, Sand Stone wrote: Hi, JDK devs. Is there a reason the impl not there below? This is a bug, fixed in jdk8, 7107020: "java.net.PlainSocketImpl.socketSetOption() calls itself" This bug did not create a much of a problem since setOption() is usually called for setting sock

Re: Review Request for bug# 8006395

2013-02-06 Thread Chris Hegarty
The changes look good to me. -Chris. On 06/02/2013 11:21, mala bankal wrote: HI, Request reviews for backport of bug# 8006395 to jdk7u : http://cr.openjdk.java.net/~mbankal/8006395/webrev.00/ Brief Description : Race in the socket asynchronous close mechanism on Linux which can lead to blocki

[7u-next] Request for approval for CR 8006669 - sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh fails on mac

2013-02-08 Thread Chris Hegarty
This is a request for approval to backport a test stabilization change from JDK8 to 7u-dev. http://bugs.sun.com/view_bug.do?bug_id=8006669 JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf2a14ebb6e9 JDK8 review thread: http://mail.openjdk.java.net/pipermail/security-dev/2013-Jan

hg: jdk7u/jdk7u-dev/jdk: 8006669: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh fails on mac

2013-02-08 Thread chris . hegarty
Changeset: 47a55dc371a5 Author:chegar Date: 2013-01-23 14:45 + URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/47a55dc371a5 8006669: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh fails on mac Reviewed-by: alanb ! test/sun/security/ss

[7u-next] Request for approval for CR 7032247 - java/net/InetAddress/GetLocalHostWithSM.java fails if hostname resolves, to loopback address

2013-02-12 Thread Chris Hegarty
This is a request for approval to backport a test stabilization change from JDK8 to 7u-dev. http://bugs.sun.com/view_bug.do?bug_id=7032247 JDK8 changeset: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d5d24c08f0dc JDK8 review thread: http://mail.openjdk.java.net/pipermail/net-dev/2012-Sept

[7u-next] Request for approval for CR 6963841 - java/util/concurrent/Phaser/Basic.java fails intermittently

2013-02-12 Thread Chris Hegarty
This is a request for approval to backport a test stabilization change from JDK8 to 7u-dev. http://bugs.sun.com/view_bug.do?bug_id=6963841 JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/85b7fcf14249 JDK8 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-Ap

[7u-next] Request for approval for CR 6776144 - java/lang/ThreadGroup/NullThreadName.java fails with Thread group is no,t destroyed ,fastdebug LINUX

2013-02-12 Thread Chris Hegarty
This is a request for approval to backport a test stabilization change from JDK8 to 7u-dev. http://bugs.sun.com/view_bug.do?bug_id=6776144 JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7eb0debca9b3 JDK8 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-No

[7u-next] Request for approval for CR 7044870 - java/nio/channels/DatagramChannel/SelectWhenRefused.java failed on SUSE Linux 10

2013-02-12 Thread Chris Hegarty
This is a request for approval to backport a test stabilization change from JDK8 to 7u-dev. http://bugs.sun.com/view_bug.do?bug_id=7044870 JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9e78769c0da JDK8 review thread: http://mail.openjdk.java.net/pipermail/nio-dev/2011-August/

[7u-next] Request for approval for CR 7073295 - TEST_BUG: test/java/lang/instrument/ManifestTest.sh causing havoc (win)

2013-02-12 Thread Chris Hegarty
This is a request for approval to backport a test stabilization change from JDK8 to 7u-dev. http://bugs.sun.com/view_bug.do?bug_id=7073295 JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/26fe74aa48ef JDK8 review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/20

[7u-next] Request for approval for CR 7076756 - TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in Cygwin

2013-02-12 Thread Chris Hegarty
This is a request for approval to backport a test stabilization change from JDK8 to 7u-dev. http://bugs.sun.com/view_bug.do?bug_id=7076756 JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf203f293b4e JDK8 review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/20

hg: jdk7u/jdk7u-dev/jdk: 6 new changesets

2013-02-12 Thread chris . hegarty
Changeset: 10eae5966c2d Author:chegar Date: 2012-09-07 14:00 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/10eae5966c2d 7032247: java/net/InetAddress/GetLocalHostWithSM.java fails if hostname resolves to loopback address Summary: TESTBUG Reviewed-by: chegar, alanb C

Request for Bulk Approval - backport test stabilization change from JDK8

2013-02-12 Thread Chris Hegarty
This is a bulk request for approval to backport some test stabilization change from JDK8 to 7u-dev. There are many more, this is just a start! All changes are in JDK8, and all changesets are identical. 7076756: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in Cygwin http://hg

Re: Request for Bulk Approval - backport test stabilization change from JDK8

2013-02-12 Thread Chris Hegarty
Thank you Sean. -Chris. On 02/12/2013 12:24 PM, Seán Coffey wrote: Looks good Chris! Approved for jdk7u-dev. regards, Sean. On 12/02/2013 11:46, Chris Hegarty wrote: This is a bulk request for approval to backport some test stabilization change from JDK8 to 7u-dev. There are many more

hg: jdk7u/jdk7u-dev/jdk: 11 new changesets

2013-02-12 Thread chris . hegarty
Changeset: d0d5986f25ef Author:chegar Date: 2011-08-09 16:59 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/d0d5986f25ef 7076756: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in Cygwin Reviewed-by: alanb, dcubed ! test/com/sun/jdi/ShellScaffold.sh

FAILS: test/sun/management/jdp/JdpTest.sh: test: argument expected

2013-02-12 Thread Chris Hegarty
Dmitry, This test is now failing on several platforms, on jdk8 and 7u-dev --- result: Passed. Compilation successful #section:shell --messages:(3/154)-- command: shell JdpTest.sh [--jtreg, --no-compile] reason: User specified action: run shell JdpTest.sh --jtreg --no-compil

Re: FAILS: test/sun/management/jdp/JdpTest.sh: test: argument expected

2013-02-13 Thread Chris Hegarty
}/policy.tpl | \ -Chris. On 12/02/2013 22:19, Dmitry Samersoff wrote: Chris, I'm not able to reproduce it locally. Do you have a link to jprt job you see this failure? -Dmitry On 2013-02-12 21:38, Chris Hegarty wrote: Dmitry, This test is now failing on several platforms, on jdk8 and 7

Re: RR(S): 8008095.JDP-TEST3 (was Re: FAILS: test/sun/management/jdp/JdpTest.sh: test: argument expected)

2013-02-13 Thread Chris Hegarty
and hope this time the problem with this test is gone. I'm ready to push it right after your response. -Dmitry On 2013-02-13 14:53, Chris Hegarty wrote: Dmitry, I have a trivial patch that resolves this issue. I would like to push it to jdk8/tl today before we freeze for M7, and have this fa

[7u-next] Request for approval for CR 8008223: java/net/BindException/Test.java fails rarely

2013-02-18 Thread Chris Hegarty
This is a request for approval to backport a test stabilization change from JDK8 to 7u-dev. http://bugs.sun.com/view_bug.do?bug_id=8008223 JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/048637b40787 JDK8 review thread: http://mail.openjdk.java.net/pipermail/net-dev/2013-Februar

hg: jdk7u/jdk7u-dev/jdk: 8008223: java/net/BindException/Test.java fails rarely

2013-02-18 Thread chris . hegarty
Changeset: 56103be763c1 Author:chegar Date: 2013-02-15 11:06 + URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/56103be763c1 8008223: java/net/BindException/Test.java fails rarely Reviewed-by: khazra, alanb ! test/java/net/BindException/Test.java

Request for Bulk Approval - backport tools test stabilization changes from JDK8

2013-02-18 Thread Chris Hegarty
This is a bulk request for approval to backport several tools test stabilization changes from JDK8 to 7u-dev. Original authors and reviewers cc'ed. These changes address several constant and persistent failures, on all platforms, in the tools area. Specifically the jdk_tools target: FAILED

hg: jdk7u/jdk7u-dev/jdk: 4 new changesets

2013-02-19 Thread chris . hegarty
Changeset: 99d24631a93a Author:fparain Date: 2012-02-15 09:29 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/99d24631a93a 7144833: sun/tools/jcmd/jcmd-Defaults.sh failing intermittently Reviewed-by: alanb ! test/sun/tools/jcmd/jcmd_Output1.awk Changeset: 6bc173d4265

[7u-next] Request for approval for CR 7021010 - (thread) TEST_BUG java/lang/Thread/ThreadStateTest.java fails intermittently

2013-03-01 Thread Chris Hegarty
This is a request for approval to backport a test stabilization change from JDK8 to 7u-dev. [original reviewers cc'ed] http://bugs.sun.com/view_bug.do?bug_id=7021010 JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae7211979179 JDK8 review thread: http://mail.openjdk.java.net/pip

[7u-next] Request for approval for CR 7081476 - test/java/net/InetSocketAddress/B6469803.java failing intermittently

2013-03-01 Thread Chris Hegarty
This is a request for approval to backport a test stabilization change from JDK8 to 7u-dev. http://bugs.sun.com/view_bug.do?bug_id=7081476 JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c2e4ecc8f7e JDK8 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-Ju

hg: jdk7u/jdk7u-dev/jdk: 3 new changesets

2013-03-01 Thread chris . hegarty
Changeset: 494f23e3dac8 Author:chegar Date: 2011-06-23 13:15 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/494f23e3dac8 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently Reviewed-by: dholmes, alanb, mchung ! test/ProblemList.txt ! test/java/lang/Th

[7u-next] Request for approval for CR 7078386 - NetworkInterface.getNetworkInterfaces() may return corrupted results on linux

2013-03-06 Thread Chris Hegarty
http://bugs.sun.com/view_bug.do?bug_id=7078386 JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b1814b3ea6d3 JDK8 review thread: http://mail.openjdk.java.net/pipermail/net-dev/2011-December/003878.html Identical changeset to that of JDK8. -Chris.

hg: jdk7u/jdk7u-dev/jdk: 7078386: NetworkInterface.getNetworkInterfaces() may return corrupted results on linux

2013-03-06 Thread chris . hegarty
Changeset: 2578df0c85f1 Author:michaelm Date: 2011-12-21 10:06 + URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/2578df0c85f1 7078386: NetworkInterface.getNetworkInterfaces() may return corrupted results on linux Reviewed-by: michaelm, alanb, chegar Contributed-by: bran

[7u-next] Request for approval for CR 8010282: sun.net.www.protocol.jar.JarFileFactory.close(JarFile) should be thread-safe

2013-03-22 Thread Chris Hegarty
This is a request for approval to backport a product fix that eliminates a race on, and visibility issues, on url jar file caching. http://bugs.sun.com/view_bug.do?bug_id=8010282 JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3070b7363853 JDK8 review thread: http://mail.openjdk

hg: jdk7u/jdk7u-dev/jdk: 8010282: sun.net.www.protocol.jar.JarFileFactory.close(JarFile) should be thread-safe

2013-03-23 Thread chris . hegarty
Changeset: 5bb351598308 Author:chegar Date: 2013-03-20 14:39 + URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/5bb351598308 8010282: sun.net.www.protocol.jar.JarFileFactory.close(JarFile) should be thread-safe Reviewed-by: khazra, alanb ! src/share/classes/sun/net/www/

Re: [7u-dev] Request for approval and review request for 8012572: Exclude sun/tools/jmap/Basic.sh for short term

2013-04-18 Thread Chris Hegarty
Makes sense to me. Consider the changes reviewed. -Chris. On 18/04/2013 10:51, Seán Coffey wrote: The sun/tools/jmap/Basic.sh test is failing since recent bulk hsx integration into 7u-dev. http://bugs.sun.com/view_bug.do?bug_id=8012474 was logged to track that issue. in the meantime we should

Re: [7u-dev] Request for approval for CR 7132378: Race in FutureTask if used with explicit set and get ( not Runnable )

2013-06-06 Thread Chris Hegarty
I am not aware of any specific issues that would prevent this change from being backported. The snipped you sited is for private implementation, and as Aleksey said, is a corner case and should be ok. -Chris On 06/06/2013 02:39 PM, Seán Coffey wrote: Aleksey, The code comments indicate that

Re: [7u40] Review request for CR 8014925: Disable sun.reflect.Reflection.getCallerClass(int) with a temporary switch to re-enable it

2013-06-19 Thread Chris Hegarty
FWIW, the changes look ok to me. -Chris. On 19/06/2013 06:58, Mandy Chung wrote: Alan, Chris, Can you review the fix for [1] 8014925: Disable sun.reflect.Reflection.getCallerClass(int) with a temporary switch to re-enable it [2] 8016814: sun.reflect.Reflection.getCallerClass returns the wrong

[7u40] Request for phase 2 approval for CR 8012156 - tools/javac/file/zip/T6865530.java fails for win32/64

2013-06-26 Thread Chris Hegarty
This is a fix for a regression from a recent change. URLClassLoader may hold an open stream to a resource in some circumstances. The solution is to close the stream in these circumstances. The changes for 7u are identical to JDK8. JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a4

hg: jdk7u/jdk7u40-dev/jdk: 8012156: tools/javac/file/zip/T6865530.java fails for win32/64

2013-06-27 Thread chris . hegarty
Changeset: 70b91714c76e Author:chegar Date: 2013-06-14 16:38 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jdk/rev/70b91714c76e 8012156: tools/javac/file/zip/T6865530.java fails for win32/64 Reviewed-by: alanb ! src/share/classes/sun/misc/URLClassPath.java

Re: [7u40] Request for phase 2 approval for CR 8017566

2013-07-15 Thread Chris Hegarty
You can count me as a reviewer for the backport. -Chris On 15 Jul 2013, at 23:07, Seán Coffey wrote: > I'd like to port this fix to the 7u40 release. This fix (backout of 8000450) > was already pushed to jdk8. The change is identical for 7u. Reviewed by > Mandy. I'd welcome a 2nd reviewer for

Re: CFV: New JDK 7 Updates Committer: Jaroslav Bachorik

2013-07-22 Thread Chris Hegarty
Vote: Yes. -Chris.

hg: jdk7u/jdk7u40-dev/jdk: 8020498: Crash when both libnet.so and libmawt.so are loaded

2013-07-22 Thread chris . hegarty
Changeset: fe948b47f3c0 Author:khazra Date: 2013-07-22 21:51 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jdk/rev/fe948b47f3c0 8020498: Crash when both libnet.so and libmawt.so are loaded Reviewed-by: chegar, dsamersoff ! src/share/native/java/net/net_util.c

Re: [7u40] Request for phase 2 approval for 8021946: Disabling sun.reflect.Reflection.getCallerCaller(int) by default breaks several frameworks and libraries

2013-07-31 Thread Chris Hegarty
On 31/07/2013 21:44, Alan Bateman wrote: A few weeks ago we pushed a change that "disables" the JDK private method sun.reflect.Reflection.getCallerClass(int). Those that have been following the effort to check the usages of caller sensitive methods in the JDK will be familiar with the background

Re: Request for approval 8021820: Number of opened files used in select() is limited to 1024 [macosx]

2013-08-20 Thread Chris Hegarty
On 08/20/2013 01:38 PM, Aleksej Efimov wrote: Hi, This is a request to backport a JDK 8 fix for bug 8021820 to JDK 7u-dev. The changes little differs from JDK 8 but identical to it by nature: The compilation flag for [.c|.cpp] files were added just to another place: jdk/make/common/Defs-macosx.

Re: update N repos where N > 6

2013-08-21 Thread Chris Hegarty
hg clone -r -Chris On 21 Aug 2013, at 05:25, Ivan Krylov wrote: > Turned out that "hg clone source dest -u " is the same as "hg clone > "+"hg update ". > See attached log. > I guess that even after clone -u tag the cloned repo still contains ALL tags > and changesets and any accidental "hg

Re: [7u40] Request for approval for CR JDK-8025713 - Syncing indendation/comment/copyright year differences with upstream projects

2013-10-03 Thread Chris Hegarty
On 10/03/2013 10:07 AM, Miroslav Kos wrote: Hi, see inline. On 10/2/13 5:55 PM, Seán Coffey wrote: Miran, Jeff, Looks like webrev doesn't show up the indentation changes. You'll see them in the patch link from webrev. This seems to be a review request and an approval request. 7u40 has shipped

[7u60] Request for approval for 7171591 - getDefaultScopeID() in src/solaris/native/java/net/net_util_md.c should return a value

2013-10-07 Thread Chris Hegarty
bug: https://bugs.openjdk.java.net/browse/JDK-7171591 jdk8 review: http://mail.openjdk.java.net/pipermail/net-dev/2012-May/004404.html jdk8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eb441933f6fe The JDK8 changeset applied cleanly, modulo a formatting/indentation change. Thanks, -C

hg: jdk7u/jdk7u-dev/jdk: 7171591: getDefaultScopeID() in src/solaris/native/java/net/net_util_md.c should return a value

2013-10-07 Thread chris . hegarty
Changeset: 1744fc1a2228 Author:khazra Date: 2012-05-29 13:16 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/1744fc1a2228 7171591: getDefaultScopeID() in src/solaris/native/java/net/net_util_md.c should return a value Summary: Use CHECK_NULL_RETURN instead of CHECK_NU

Re: [7u-dev] Request for approval : 8016271: wsimport -clientjar does not create portable jars on windows due to hardcoded backslash

2013-10-09 Thread Chris Hegarty
a.net/pipermail/core-libs-dev/2013-October/021471.html Chris Hegarty reviewed but did request that the 8016271 changeset be separated out from the 8025054 changeset. Hope that clears up matters. The review thread was a little noisy, and the outcome maybe non-obvious. I can confirm that I have reviewe

Re: CFV: New JDK7u Committer: Mikhail Cherkasov

2013-10-14 Thread Chris Hegarty
On 14/10/2013 12:20, Alan Bateman wrote: Vote: Veto +1 -Chris. The guidelines suggest at least 8 significant contributions but some of the changes cited in the nomination don't appear (at least on the surface) to be significant. For example, one of the changes is a one-line fix, another is a

Re: [7u] problem with jdk test java/nio/channels/DatagramChannel/SendToUnresolved.java

2013-10-28 Thread Chris Hegarty
I'm not sure why this domain name resolves, to that address. You should try to determine what authoritative name server is giving you that answer, or if you have some kind of configuration issue. To the best of my knowledge, I have never seen this test fail before. -Chris > On 28 Oct 2013, at

Re: [7u60] - Request for approval : 8017779, 8003253, 8003285, 8003895

2014-01-23 Thread Chris Hegarty
The changes to B4769350.java look fine to me. -Chris. On 22 Jan 2014, at 17:49, Seán Coffey wrote: > Looking for approval for these test stabilization fixes. > > These are backports from JDK 8. The > java/nio/channels/AsynchronousChannelGroup/Unbounded.java changes came back > smoothly with

Re: [7u-dev] Request for approval : 8035897, 8036584

2014-03-11 Thread Chris Hegarty
Thanks for taking this Sean. The changes look good to me. -Chris. > On 11 Mar 2014, at 19:45, Seán Coffey wrote: > > Requesting approval to push Chris's recent fix to jdk7u-dev. > > Bug IDs : > https://bugs.openjdk.java.net/browse/JDK-8035897 > https://bugs.openjdk.java.net/browse/JDK-8036584

Re: CFV: New JDK 7u Committer: Ivan Gerasimov

2014-04-10 Thread Chris Hegarty
Vote: YES. -Chris. On 10 Apr 2014, at 19:45, Seán Coffey wrote: > I hereby nominate Ivan Gerasimov (igerasim) to JDK 7u Committer. > > Ivan is a member of the Java SE Sustaining team and works on all issues > connected to the JDK core libraries. He's already a committer in the JDK 9 > Projec

hg: jdk7u/jdk7u-dev/jaxws: 8033113: wsimport fails on WSDL:header parameter name customization

2014-04-22 Thread chris . hegarty
Changeset: a6458f65144e Author:mkos Date: 2014-04-22 13:45 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxws/rev/a6458f65144e 8033113: wsimport fails on WSDL:header parameter name customization Reviewed-by: chegar ! src/share/jaxws_classes/com/sun/tools/internal/ws/proces

hg: jdk7u/jdk7u-dev/jdk: 2 new changesets

2014-04-22 Thread chris . hegarty
Changeset: 0ec0d97d6966 Author:mkos Date: 2014-04-08 11:25 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/0ec0d97d6966 8033113: wsimport fails on WSDL:header parameter name customization Reviewed-by: chegar + test/javax/xml/ws/8033113/Organization_List.wsdl + test/ja

[7u80] Request for approval for CR 8025710: Proxied HTTPS connections reused by HttpClient can send CONNECT to the server

2014-04-25 Thread Chris Hegarty
Hi 7u Maintainers, I would like to request approval for 8025710 for inclusion in 7u80 ( to be pushed to 7u-dev ). The 7u changes identical to the JDK 9/8 changes. 8025710: Proxied HTTPS connections reused by HttpClient can send CONNECT to the server https://bugs.openjdk.java.net/browse/J

[7u80] Request for approval for CR 8041931: test/sun/net/www/http/HttpClient/B8025710.java fails with cannot find keystore

2014-04-28 Thread Chris Hegarty
Hi 7u Maintainers, I would like to request approval for 8041931 for inclusion in 7u80 ( to be pushed to 7u-dev ). The 7u changes identical to the JDK 8 changes. To keep things straight and simple from a bug tracking perspective, 8025710 ( already approved to 7u-dev ) contains a test with a ba

hg: jdk7u/jdk7u-dev/jdk: 2 new changesets

2014-04-28 Thread chris . hegarty
Changeset: 3ff34a436d61 Author:chegar Date: 2014-04-23 13:19 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/3ff34a436d61 8025710: Proxied HTTPS connections reused by HttpClient can send CONNECT to the server Reviewed-by: chegar Contributed-by: Steven Lawrance , Andre

Re: [7u-dev] Request for approval: 7158636: InterfaceAddress.getBroadcast() returns invalid broadcast address on WLAN

2014-08-28 Thread Chris Hegarty
On 28 Aug 2014, at 17:16, Seán Coffey wrote: > Approved. The conflict does indeed look trivial. Good if Chris can confirm. Ok for me. -Chris. > regards, > Sean. > > On 28/08/2014 15:45, Rob McKenna wrote: >> Hi folks, >> >> Looking to backport this change to 7u. >> >> There is a trivial con

Re: RFR [9] 8059101: unshuffle_patch.sh should be able to deal with stdin/stdout

2014-09-25 Thread Chris Hegarty
On 25 Sep 2014, at 03:12, Ivan Gerasimov wrote: > Thank you Daniel for the comments! > > On 25.09.2014 13:49, Daniel Fuchs wrote: >> Hi Ivan, >> >> When setting output & input, I wonder if it would be simpler >> to use an 'if else if' construct in order to avoid the '-a' >> in the 'if' that fo

Re: RFR [9] 8059101: unshuffle_patch.sh should be able to deal with stdin/stdout

2014-09-25 Thread Chris Hegarty
On 25 Sep 2014, at 00:42, Ivan Gerasimov wrote: > Hello! > > This is a proposal to enhance the unshuffle_patch.sh script so that it will > be able to read from stdin and write to stdout. > This would let us use the script in a pipe chain. > > For example, the following line could be used to a

Request for approval for CR 7051516 - ThreadLocalRandom seed is never initialized so all instances generate the same sequence

2011-08-31 Thread Chris Hegarty
This is a request for approval to backport the fix for 7051516 to jdk7u-dev/jdk: 7051516 - ThreadLocalRandom seed is never initialized so all instances generate the same sequence http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7051516 Changeset in jdk8 (and see [1] for the discussi

Request for Approval for CR 7058828 - test/java/util/concurrent/Phaser/Arrive.java fails intermittently

2011-08-31 Thread Chris Hegarty
This is a request for approval to backport the fix for 7058828 to jdk7u-dev/jdk: 7058828 - test/java/util/concurrent/Phaser/Arrive.java fails intermittently http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058828 Changeset in jdk8: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5

Re: Request for approval for CR 7051516 - ThreadLocalRandom seed is never initialized so all instances generate the same sequence

2011-09-01 Thread Chris Hegarty
On 09/ 1/11 12:44 PM, Dalibor Topic wrote: On 8/31/11 11:01 PM, Chris Hegarty wrote: This is a request for approval to backport the fix for 7051516 to jdk7u-dev/jdk: 7051516 - ThreadLocalRandom seed is never initialized so all instances generate the same sequence http://bugs.sun.com

hg: jdk7u/jdk7u-dev/jdk: 7051516: ThreadLocalRandom seed is never initialized so all instances generate the same sequence

2011-09-01 Thread chris . hegarty
Changeset: 791e94e7b64f Author:chegar Date: 2011-09-01 13:05 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/791e94e7b64f 7051516: ThreadLocalRandom seed is never initialized so all instances generate the same sequence Reviewed-by: chegar, dholmes, mduigou ! src/shar

hg: jdk7u/jdk7u-dev/jdk: 7058828: test/java/util/concurrent/Phaser/Arrive.java fails intermittently

2011-09-01 Thread chris . hegarty
Changeset: 1c0190388b70 Author:dl Date: 2011-09-01 13:08 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/1c0190388b70 7058828: test/java/util/concurrent/Phaser/Arrive.java fails intermittently Reviewed-by: chegar ! test/java/util/concurrent/Phaser/Arrive.java

Re: Interaction with the CCC Process - Draft

2011-09-01 Thread Chris Hegarty
Also, I'm not sure it necessarily needs to be the tech lead for that area. Surely any internal Oracle employee should be able to run with it. Typically, the change and CCC will already have been done for JDK8, possibly leaving it open the original dev engineer? -Chris. On 09/ 1/11 02:36 PM, S

Request for Approval for CR 7041800 - URI.equals may incorrectly return true with escaped octets

2011-09-01 Thread Chris Hegarty
This is a request for approval to backport the fix for 7041800 to jdk7u-dev/jdk: 7041800 - URI.equals may incorrectly return true with escaped octets http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7041800 Changeset in jdk8: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fcb33500b3

hg: jdk7u/jdk7u-dev/jdk: 7041800: URI.equals may incorrectly return true with escaped octets

2011-09-02 Thread chris . hegarty
Changeset: d7044475a604 Author:chegar Date: 2011-09-01 13:53 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/d7044475a604 7041800: URI.equals may incorrectly return true with escaped octets Reviewed-by: alanb, michaelm ! src/share/classes/java/net/URI.java ! test/java

Re: URGENT: Request for approval for CR #7049963 -, DISTINGUISHED NAMES FOR CERT ARE ESCAPED IN JROCKIT 1.6(NOT COMPATIBLE, WITH JROC

2011-09-15 Thread Chris Hegarty
On 09/15/11 10:00 AM, Dalibor Topic wrote: Unfortunately, not quite - there is a change in the copyright block in your webrev, that's not present in the changeset that was pushed into jdk8. So I have to ask Sean From time to time the issue of who should update the year ranges in the co

Request for phase 2 approval for CR 7091369 - DatagramSocket/Limit.java failing on 8 and 7u2

2011-10-07 Thread Chris Hegarty
7091369: DatagramSocket/Limit.java failing on 8 and 7u2 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7091369 Identical changeset to JDK 8: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e3d78fe803d4 Reviewers: Michael McMahon, Alan Bateman Thanks, -Chris.

Request for phase 2 approval for CR 7098719- -Dsun.net.maxDatagramSockets and Socket constructor does not work correctly with System.gc()

2011-10-10 Thread Chris Hegarty
7098719: -Dsun.net.maxDatagramSockets and Socket constructor does not work correctly with System.gc() http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7098719 Identical changeset to JDK 8: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1e89a13d9d8f Reviewers: Michael McMahon, Sean Coffey T

hg: jdk7u/jdk7u2-dev/jdk: 7091369: DatagramSocket/Limit.java failing on 8 and 7u2

2011-10-10 Thread chris . hegarty
Changeset: 1ffe9f7251e3 Author:chegar Date: 2011-10-10 14:34 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u2-dev/jdk/rev/1ffe9f7251e3 7091369: DatagramSocket/Limit.java failing on 8 and 7u2 Reviewed-by: michaelm, alanb ! src/windows/classes/java/net/TwoStacksPlainDatagramSocketI

Request for phase 2 approval for CR 7099488 - TwoStacksPlainSocketImpl should invoke super.create(stream), typo in fix for 7098719

2011-10-13 Thread Chris Hegarty
7099488: TwoStacksPlainSocketImpl should invoke super.create(stream), typo in fix for 7098719 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7099488 Identical changeset to JDK 8: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bfe2de1157b Reviewers: Michael McMahon, Sean Coffey This is a

Request for approval for CR 7057935 - com/sun/nio/sctp tests should be moved out of jdk_nio and into their own target, jdk_sctp

2011-10-27 Thread Chris Hegarty
Hi, CR 7057935 - com/sun/nio/sctp tests should be moved out of jdk_nio and into their own target, jdk_sctp http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7057935 Identical changes to JDK8 http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6b2c14dfe9b9 The com/sun/nio/sctp tests are r

hg: jdk7u/jdk7u-dev/jdk: 7057935: com/sun/nio/sctp tests should be moved out of jdk_nio and into their own target, jdk_sctp

2011-10-27 Thread chris . hegarty
Changeset: ee50c18ede0d Author:chegar Date: 2011-06-23 13:00 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/ee50c18ede0d 7057935: com/sun/nio/sctp tests should be moved out of jdk_nio and into their own target, jdk_sctp Reviewed-by: alanb ! test/Makefile ! test/Prob

Request for approval for CR 7079012 - test/java/net/NetworkInterface/NetParamsTest.java fails with SocketException getting mac address

2011-10-27 Thread Chris Hegarty
Hi, CR 7079012 - test/java/net/NetworkInterface/NetParamsTest.java fails with SocketException getting mac address http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7079012 Identical *source* changes to JDK8 http://hg.openjdk.java.net/jdk8/tl/jdk/rev/61a8c602cace The changeset for JDK8 co

jdk7u-dev OPENJDK build fails

2011-10-27 Thread Chris Hegarty
The latest jdk7u-dev OPENJDK build fails due to CR 7099017. This CR has been fixed in 7u2-dev but not yet integrated into 7u-dev. I wonder what is the process around when 7u2-dev merges into the jdk7u-dev main development forest? We are also seeing a networking regression test that has been f

Request for approval for CR 7076523 - TEST_BUG: test/java/net/NetworkInterface/NetParamsTest.java can fail with NPE

2011-10-27 Thread Chris Hegarty
CR 7076523 - TEST_BUG: test/java/net/NetworkInterface/NetParamsTest.java can fail with NPE http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7076523 Identical changes to JDK8 http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af15e902cf08 This is a simple change to resolve a testcase bug. Thank

Re: jdk7u-dev OPENJDK build fails

2011-10-27 Thread chris hegarty
e problem. We just need to flag these type of issues and have the integrator/project owner aware of them so they can be fixed, both repo and process. -Chris. -ChrisG On 10/27/2011 9:13 AM, Chris Hegarty wrote: The latest jdk7u-dev OPENJDK build fails due to CR 7099017. This CR has be

hg: jdk7u/jdk7u-dev/jdk: 7079012: test/java/net/NetworkInterface/NetParamsTest.java fails with SocketException getting mac address

2011-10-27 Thread chris . hegarty
Changeset: 07abe3cc996f Author:chegar Date: 2011-10-27 15:44 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/07abe3cc996f 7079012: test/java/net/NetworkInterface/NetParamsTest.java fails with SocketException getting mac address Reviewed-by: michaelm ! src/solaris/nat

Re: jdk7u-dev OPENJDK build fails

2011-10-28 Thread Chris Hegarty
On 28/10/2011 08:43, Edvard Wendelin wrote: The plan was to sync the repos when we built the stabilisation area, but clearly this is something we need to revisit. Right, but it just seems wrong to have the main jdk7u-dev repository unbuildable for so long. Developers cannot build or test.

Re: jdk7u-dev OPENJDK build fails

2011-10-28 Thread Chris Hegarty
On 28/10/2011 10:10, Florian Weimer wrote: This seems to be a bit backwards to me. If hardly anyone notices that the forest doesn't build, it suggests that nobody is used it for development. Perhaps it would be possible to work with a single forest and freeze it periodically when it's bei

hg: jdk7u/jdk7u-dev/jdk: 7076523: TEST_BUG: test/java/net/NetworkInterface/NetParamsTest.java can fail with NPE

2011-10-29 Thread chris . hegarty
Changeset: f880242cb9c9 Author:chegar Date: 2011-08-10 12:30 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/f880242cb9c9 7076523: TEST_BUG: test/java/net/NetworkInterface/NetParamsTest.java can fail with NPE Reviewed-by: alanb ! test/java/net/NetworkInterface/NetPar

Re: Proposal on how we should handle syncing between stabilisation forests and always open 7u

2011-11-04 Thread Chris Hegarty
On 04/11/2011 09:58, Alan Bateman wrote: On 03/11/2011 16:02, Edvard Wendelin wrote: . If you have any feedback, please let me know before Monday. Edvard - what does this mean for the history? Just thinking of someone with a clone of jdk7u/jdk7u, they will no longer be able to do a "hg upd

[7u4] Request for approval for CR 7095980: Ensure HttpURLConnection (and supporting APIs) don't expose HttpOnly cookies

2012-01-10 Thread Chris Hegarty
Hi, This is a request to backport a JDK 8 fix into JDK 7u4: 7095980: Ensure HttpURLConnection (and supporting APIs) don't expose HttpOnly cookies http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7095980 The fix has already been pushed to JDK 8: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/33

[7u4] Request for approval for CR 7128648: HttpURLConnection.getHeaderFields should return an unmodifiable Map

2012-01-11 Thread Chris Hegarty
Hi, This is a request to backport a JDK 8 fix into JDK 7u4: 7128648: HttpURLConnection.getHeaderFields should return an unmodifiable Map http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7128648 The fix has already been pushed to JDK 8: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31a1fc60a895

hg: jdk7u/jdk7u-dev/jdk: 2 new changesets

2012-01-12 Thread chris . hegarty
Changeset: d7450b1e436d Author:chegar Date: 2012-01-12 09:29 + URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/d7450b1e436d 7095980: Ensure HttpURLConnection (and supporting APIs) don't expose HttpOnly cookies Reviewed-by: michaelm ! src/share/classes/java/net/HttpCook

[7u4] Request for approval for CR 7129083: CookieManager does not store cookies if url is read before setting cookie manager

2012-01-17 Thread Chris Hegarty
Hi, This is a request to backport a JDK 8 fix into JDK 7u4: 7129083: CookieManager does not store cookies if url is read before setting cookie manager http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129083 The fix has already been pushed to JDK 8: http://hg.openjdk.java.net/jdk8/tl/jdk/

  1   2   >