Re: CFV: New jdk7u Committer: Alejandro Murillo

2012-09-20 Thread Christian Thalinger
Vote: yes On Sep 19, 2012, at 10:30 AM, John Coomes wrote: > I hereby nominate Alejandro Murillo to jdk7u Committer. > > Alejandro is a performance engineer and also the HotSpot gatekeeper. > In the latter role he's responsible for delivering HotSpot sources > into jdk7 updates and other jdk re

[7u12] Request for approval for CR 8000999: backport of JSR 292 to 7u

2012-10-18 Thread Christian Thalinger
Webrev: http://cr.openjdk.java.net/~twisti/8000999/ 8000999: backport of JSR 292 to 7u This is an umbrella bug for these changes (which are backported in one changeset): 6983728: JSR 292 remove argument count limitations 7128512: Javadoc typo in java.lang.invoke.MethodHandle 7117167: Misc warn

Re: [7u12] Request for approval for CR 8000999: backport of JSR 292 to 7u

2012-10-18 Thread Christian Thalinger
On Oct 18, 2012, at 12:00 PM, mark.reinh...@oracle.com wrote: > 2012/10/18 11:54 -0700, christian.thalin...@oracle.com: >> Webrev: http://cr.openjdk.java.net/~twisti/8000999/ >> 8000999: backport of JSR 292 to 7u >> >> This is an umbrella bug for these changes (which are backported in one >> cha

Re: [7u12] Request for approval for CR 8000999: backport of JSR 292 to 7u

2012-10-18 Thread Christian Thalinger
On Oct 18, 2012, at 12:17 PM, Christian Thalinger wrote: > > On Oct 18, 2012, at 12:00 PM, mark.reinh...@oracle.com wrote: > >> 2012/10/18 11:54 -0700, christian.thalin...@oracle.com: >>> Webrev: http://cr.openjdk.java.net/~twisti/8000999/ >>> 8000999: backpo

Re: [7u12] Request for approval for CR 8000999: backport of JSR 292 to 7u

2012-10-19 Thread Christian Thalinger
IT I can bring the original changesets over. And if that means no reviews and quick approvals then it might be worth it. -- Chris > > I understand some more PIT testing is going to be run - Let's see how test > results look before proceeding. > > regards, > Sean. > &g

Re: [7u12] Request for approval for CR 8000999: backport of JSR 292 to 7u

2012-10-19 Thread Christian Thalinger
On Oct 19, 2012, at 11:26 AM, Christian Thalinger wrote: > > On Oct 18, 2012, at 6:48 PM, Seán Coffey wrote: > >> Christian, >> >> It is quite a big code change for 7u, one worthy of more testing before >> integration perhaps. Doesn't this cod

Re: [7u12] Request for approval for CR 8000999: backport of JSR 292 to 7u

2012-10-19 Thread Christian Thalinger
On Oct 19, 2012, at 1:39 AM, Dalibor Topic wrote: > On 10/18/12 9:22 PM, Christian Thalinger wrote: >> diff --git a/src/share/classes/sun/misc/Unsafe.java >> b/src/share/classes/sun/misc/Unsafe.java >> --- a/src/share/classes/sun/misc/Unsafe.java >> +++ b/src/share/c

Re: [7u12] Request for approval for CR 8000999: backport of JSR 292 to 7u

2012-10-22 Thread Christian Thalinger
On Oct 22, 2012, at 11:39 AM, mark.reinh...@oracle.com wrote: > 2012/10/18 12:17 -0700, christian.thalin...@oracle.com: >> On Oct 18, 2012, at 12:00 PM, mark.reinh...@oracle.com wrote: >>> Um, isn't this an awfully big change for what's supposed to be a low-risk >>> update release? >> >> It's bi

Re: HotSpot Changes in 7u

2013-01-11 Thread Christian Thalinger
On Jan 11, 2013, at 11:08 AM, Chris Phillips @ T O wrote: > Hi > > On 11/01/13 12:29 PM, Andrew Hughes wrote: >> - Original Message - >>> On 21/12/2012 9:51 AM, Coleen Phillimore wrote: I am checking these changes into hsx24 now. >>> Thanks Coleen. >>> >> Yes, thanks Coleen for ta

Re: HotSpot Changes in 7u (8000780: make Zero build run with JDK8)

2013-01-14 Thread Christian Thalinger
d this and the patch I reviewed was for 7u. -- Chris > > Vladimir > > On 1/12/13 4:53 AM, Alejandro E Murillo wrote: >> >> On 1/11/2013 4:17 PM, Christian Thalinger wrote: >>> On Jan 11, 2013, at 11:08 AM, Chris Phillips @ T O >>> wrote: >

Re: Bad licensing header on testcase in HotSpot repositories

2013-02-14 Thread Christian Thalinger
On Feb 14, 2013, at 7:53 AM, Andrew Hughes wrote: > - Original Message - >> On 2/11/13 8:29 PM, Andrew Hughes wrote: >>> The file: >>> >>> http://hg.openjdk.java.net/jdk8/jdk8/hotspot/file/fe4a4ea5bed9/test/runtime/7158804/Test7158804.sh >>> >>> has a bad copyright header with just: >>

Re: [7u40] Review request for CR 8014925: Disable sun.reflect.Reflection.getCallerClass(int) with a temporary switch to re-enable it

2013-06-24 Thread Christian Thalinger
Looks good. -- Chris On Jun 19, 2013, at 8:31 AM, Mandy Chung wrote: > Thanks. I have revised the exception message and the test: > http://cr.openjdk.java.net/~mchung/jdk7u/8014925/webrev.01/ > > Mandy > > On 6/19/2013 4:36 AM, Alan Bateman wrote: >> On 19/06/2013 06:58, Mandy Chung wrote:

Re: New jdk7u maintainer : Christian Thalinger

2013-07-22 Thread Christian Thalinger
On Jul 19, 2013, at 2:26 PM, Dalibor Topic wrote: > I'm delegating the maintainer authority for jdk7u to Christian Thalinger. > Christian will be helping Sean and myself with jdk7u maintainer duties. > > Welcome, Christian! Thanks! -- Chris > > I'd also like

Re: [7u40] Request for phase 2 approval: 8020371 [macosx] applets with Drag and Drop fail with IllegalArgumentException

2013-07-24 Thread Christian Thalinger
Approved for jdk7u40-dev. -- Chris On Jul 24, 2013, at 12:52 PM, Petr Pchelko wrote: > Hello > > This is a request for phase 2 approval to push the fix for 8020371 into the > jdk7u40 repository. > > 7u40-critical-request justification: this is a regression in 7u40 which makes > all applets

Re: [7u40] Request for phase 2 approval: 8020319: Update Japanese man pages for 7u40

2013-07-24 Thread Christian Thalinger
I hope all the quirks have been resolved. Approved for jdk7u40-dev. -- Chris On Jul 24, 2013, at 4:19 PM, Michael Fang wrote: > Hello, > > This is a request for phase 2 approval to push the fix for 8020319 into > jdk7u40 repository. > > Bug: http://bugs.sun.com/view_bug.do?bug_id=8020319 >

Re: [7u40] Request for phase 2 approval for CR 8014850: 3rd Party License README update for 7u40

2013-07-25 Thread Christian Thalinger
Approved for jdk7u40-dev. -- Chris On Jul 25, 2013, at 12:13 PM, Jeff Dinkins wrote: > > Note: this is not a backport of the JDK8 Third Party README, so there's no > link to a JDK8 changeset included. > > BugID: 8014850 > Synopsis: 7u40 THIRDPARTY License Readme Update > > JDK 7 webrev: htt

Re: [7u40] Request for phase 2 approval (JAXP): 8021148 : Regression in SAXParserImpl in 7u40 b34 (NPE)

2013-07-25 Thread Christian Thalinger
Approved for jdk7u40-dev. -- Chris On Jul 25, 2013, at 1:25 PM, huizhe wang wrote: > Hi, > > I'd like to request approval to backport the following fix to jdk7u40. This > is to allow applications such as NetBeans to continue using the internal JAXP > parser. > > The bug: > http://bugs.sun.c

Re: New jdk7u maintainer : Rob McKenna

2013-10-11 Thread Christian Thalinger
On Oct 11, 2013, at 9:40 AM, Dalibor Topic wrote: > With 7u40 being out of the door, it's time to update the jdk7u maintainer > team again. > > I'd like to start by thanking Christian for his very welcome contributions as > a jdk7u > maintainer in the 7u40 endgame. As he is now back to being

hg: jdk7u/jdk7u-dev/hotspot: 8026502: java/lang/invoke/MethodHandleConstants.java fails on all platforms

2013-12-03 Thread christian . thalinger
Changeset: 271f0c186798 Author:twisti Date: 2013-10-23 15:44 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/271f0c186798 8026502: java/lang/invoke/MethodHandleConstants.java fails on all platforms Reviewed-by: iveresov, jrose ! src/share/vm/classfile/systemDictio

Re: hg: jdk7u/jdk7u-dev/hotspot: 8026502: java/lang/invoke/MethodHandleConstants.java fails on all platforms

2013-12-03 Thread Christian Thalinger
On Dec 3, 2013, at 12:21 PM, Dalibor Topic wrote: > On 12/3/13 7:47 PM, christian.thalin...@oracle.com wrote: >> Changeset: 271f0c186798 >> Author:twisti >> Date: 2013-10-23 15:44 -0700 >> URL: >> http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/271f0c186798 >> >> 8026502:

[7u-dev] Request for approval: 8026502: java/lang/invoke/MethodHandleConstants.java fails on all platforms

2013-12-11 Thread Christian Thalinger
https://bugs.openjdk.java.net/browse/JDK-8026502 8026502: java/lang/invoke/MethodHandleConstants.java fails on all platforms The HotSpot part of the fix was missing. This is a retroactive approval request because it was pushed already accidentally: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/ho

[7u60] Request for approval: 8030059: ShouldNotReachHere error when creating an array with component type of void

2013-12-20 Thread Christian Thalinger
https://bugs.openjdk.java.net/browse/JDK-8030059 The bug was originally filed against 7u40 but turned out that we have the same problem in 8 so we pushed to 8 first: https://bugs.openjdk.java.net/browse/JDK-8029366 http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/b87211e33ebb This is the reques

Re: [7u60] Request for approval: 8030059: ShouldNotReachHere error when creating an array with component type of void

2013-12-23 Thread Christian Thalinger
Right. Thanks for clarifying, Alejandro. I just didn’t want to do another push without the required approvals :-) On Dec 23, 2013, at 6:40 AM, Alejandro E Murillo wrote: > > On 12/20/2013 12:14 PM, Christian Thalinger wrote: >> https://bugs.openjdk.java.net/browse/JDK-803005

[7u60] Request for approval: 8019184: MethodHandles.catchException() fails when methods have 8 args + varargs

2014-02-12 Thread Christian Thalinger
This change was intended to end up in 7u40 but for some reason we missed it. The original bug which went into 8 is: https://bugs.openjdk.java.net/browse/JDK-8019184 and the pushed changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/bd6949f9dbb2 This is the new 7u60 backport with approval:

Re: [7u60] Request for approval: 8019184: MethodHandles.catchException() fails when methods have 8 args + varargs

2014-02-12 Thread Christian Thalinger
-dev/2013-July/010118.html > > thanks, > > -jeff > > On Feb 12, 2014, at 1:53 PM, Christian Thalinger > wrote: > >> This change was intended to end up in 7u40 but for some reason we missed it. >> The original bug which went into 8 is: >> >> ht

Re: [7u60] Request for approval: 8019184: MethodHandles.catchException() fails when methods have 8 args + varargs

2014-02-12 Thread Christian Thalinger
uld be 2014? It was pushed in 2013: author twisti Wed Jul 03 11:35:06 2013 -0700 (7 months ago) and the file wasn’t touched in 2014 so it’s fine. > > -jeff > > > On Feb 12, 2014, at 4:14 PM, Christian Thalinger > wrote: >> On Feb 12, 2014, at 1:06 PM, Jeff Dinkins

hg: jdk7u/jdk7u-dev/jdk: 8019184: MethodHandles.catchException() fails when methods have 8 args + varargs

2014-02-12 Thread christian . thalinger
Changeset: 3edb49b50486 Author:twisti Date: 2013-07-03 11:35 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/3edb49b50486 8019184: MethodHandles.catchException() fails when methods have 8 args + varargs Reviewed-by: jrose ! src/share/classes/java/lang/invoke/MethodHan

[7u-dev] Request for approval: 8001105: findVirtual of Object[].clone produces internal error

2014-03-03 Thread Christian Thalinger
https://bugs.openjdk.java.net/browse/JDK-8001105 I would like to backport this fix to 7u (preferably 7u60). The bug was filed to affect versions 7 and 8 was pushed to 8 only. Here is the changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/97d5cc1e7586 and the original review thread with a

Re: [7u-dev] Request for approval: 8001105: findVirtual of Object[].clone produces internal error

2014-03-03 Thread Christian Thalinger
e's the background mail: > http://mail.openjdk.java.net/pipermail/jdk7u-dev/2014-January/008315.html ) > > This is approved for 7u80. Thanks, Rob. Let me update the backport bug to 7u80 for now. > >-Rob > > On 03/03/14 20:12, Christian Thalinger wrote: &g

Re: [7u-dev] Request for approval: 8001105: findVirtual of Object[].clone produces internal error

2014-03-18 Thread Christian Thalinger
esponding VM changes. The Object.clone hack is in the VM for a very long time already. > > -Rob > > On 04/03/14 00:13, Christian Thalinger wrote: >> On Mar 3, 2014, at 1:04 PM, Rob McKenna wrote: >> >>> Hi Christian, >>> >>> If you want

hg: jdk7u/jdk7u-dev/hotspot: 2 new changesets

2014-05-28 Thread christian . thalinger
Changeset: f290ac92cb22 Author:mikael Date: 2014-04-29 22:04 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/f290ac92cb22 8022070: Compilation error in stubGenerator_sparc.cpp with some compilers Reviewed-by: twisti, kvn ! src/cpu/sparc/vm/stubGenerator_sparc.cpp

hg: jdk7u/jdk7u-dev/hotspot: 2 new changesets

2014-05-30 Thread christian . thalinger
Changeset: b60f95bce6c2 Author:mikael Date: 2014-05-29 12:40 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/b60f95bce6c2 8043205: Incorrect system traps.h include path Reviewed-by: kvn, dholmes ! src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp Changeset: 5a8

Request for approval for CR 7085860

2011-09-22 Thread Christian Thalinger
CR:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7085860 Webrev:http://cr.openjdk.java.net/~twisti/7085860/ Review: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2011-September/006287.html Changeset: http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/rev/b0efc

[7u4] Request for approval for CR 7109063 - JSR 292: fix for 7085860 is incomplete

2012-01-12 Thread Christian Thalinger
7109063: JSR 292: fix for 7085860 is incomplete http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7109063 The change is in JDK 8 since 11/2011: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/5c34ed65176e This is a follow-up fix for 7085860. -- Chris

[7u4] Request for approval for CR 7085860 - JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods

2012-01-12 Thread Christian Thalinger
7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7085860 The change is in JDK 8 since 11/2011: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/2a147f854257 The required HotSpot changes are already in j

hg: jdk7u/jdk7u-dev/jdk: 2 new changesets

2012-01-16 Thread christian . thalinger
Changeset: b5074ea960b9 Author:twisti Date: 2012-01-16 01:47 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/b5074ea960b9 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods Reviewed-by: jrose, never ! src/share/classes/java/l

Re: [7u4] Request for approval for CR 7109063 - JSR 292: fix for 7085860 is incomplete

2012-01-16 Thread Christian Thalinger
Thanks. -- Chris On Jan 12, 2012, at 1:08 PM, Edvard Wendelin wrote: > Approved. > > On 01/12/2012 12:26 PM, Christian Thalinger wrote: >> 7109063: JSR 292: fix for 7085860 is incomplete >> >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7109063 >> &

Re: [7u4] Request for approval for CR 7085860 - JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods

2012-01-16 Thread Christian Thalinger
Thanks. -- Chris On Jan 12, 2012, at 1:07 PM, Edvard Wendelin wrote: > approved. > > On 01/12/2012 12:26 PM, Christian Thalinger wrote: >> 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile >> as native methods: >> >> http://bugs.sun.c

7090802: segfault in GraphBuilder [Was: Re: JVM segfault]

2012-02-14 Thread Christian Thalinger
[Forwarding to hotspot-compiler-dev, BBC'ing jdk7u-dev] On Feb 14, 2012, at 4:25 PM, Alan Stange wrote: > All, > > I've been able to make the JVM segfault fairly reliably when using > TieredCompilation. I reported this as bugid 7090802. > > # Problematic frame: > # V [libjvm.so+0x1aa058]